Re: [EGIT PATCH] Fix invalid menubar and toolbar entries in plugin.xml

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Robin Rosenberg <robin.rosenberg.lists@...>, <git@...>
Date: Thursday, August 14, 2008 - 3:13 pm

Robin Rosenberg wrote:

Ah, I see. It appears the menu was used, but because it had the wrong
path ('org.spearce.egit.ui.gitmenu' instead of 'additions') the four 
entries did not show up in 3.4. 

Either way I suggest the patch is still valid, because it removes
the Git menu from the menu bar. This is consistent with what other 
platform plugins do, ie. not populating the main menu bar with plugin
specific entries, but instead using sub menus, context menus and views.

In the long run we should probably also move the global toolbar entries
to the synchronize view, when I get the chance to look at implementing 
that. 

Tor Arne
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Fix invalid menubar and toolbar entries in plugin.xml, Tor Arne Vestbø, (Wed Aug 13, 3:07 pm)
Re: [EGIT PATCH] Fix invalid menubar and toolbar entries in ..., Tor Arne Vestbø, (Thu Aug 14, 3:13 pm)