Andreas Ericsson wrote:
quoted text
>I'd do it like this instead:

quoted text
>daemon: auth_user = dlsym(dlopen("auth-module.so", RTLD_NOW), 
>"authenticat");

quoted text
>This approach has several nifty benefits:
>* The otherwise duplicated code (for different auth schemes) is
> done only once (in the git daemon).

I'd prefer that to be in a separate program, instead of git-daemon
proper.

quoted text
>* If the git daemon has no authentication module loaded, we might
> as well not bother sending any challenge and just pretend we do
> not know about the authentication scheme.

Loading modules is highly fragile across different OSes, so it's not
really recommended at all.

quoted text
>* Modules is a great way for newcomers to get started contributing to
> git so it's a nice way of getting more contributors/sub-maintainers.

If by "modules" you mean dynamically loaded libraries, then I
wholeheartedly disagree.
-- 
Sincerely,
           Stephen R. van den Berg.

"Hold still, while I inject you with SQL."
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html