Re: git help broken

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Christian Couder
Date: Thursday, July 31, 2008 - 9:28 pm

Le jeudi 31 juillet 2008, Miklos Vajna a écrit :
<Johannes.Schindelin@gmx.de> wrote:

Yeah, and it seems that "git help help" doesn't work any more since my patch 
that does that:

2dce956e397be8a769624e8693565b8a30056060 help: check early if we have a 
command, if not try a documentation topic

I didn't realize that the function "is_git_command" would not work 
for "help".

Perhaps there should be another function like is_git_command that could work 
using the "struct cmd_struct commands" defined in "handle_internal_command" 
in "git.c". That may be faster and more accurate.

Unfortunately I won't have time to work on this as I will leave for vacation 
in a few hours. Sorry to leave this behind.

Best regards,
Christian.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
git help broken, Kevin Ballard, (Wed Jul 30, 1:52 pm)
Re: git help broken, Johannes Schindelin, (Wed Jul 30, 4:42 pm)
Re: git help broken, Johannes Schindelin, (Wed Jul 30, 4:44 pm)
Re: git help broken, Kevin Ballard, (Wed Jul 30, 4:45 pm)
Re: git help broken, Miklos Vajna, (Wed Jul 30, 5:04 pm)
Re: git help broken, Christian Couder, (Thu Jul 31, 9:28 pm)
Re: git help broken, Miklos Vajna, (Fri Aug 1, 7:41 am)
[PATCH] Builtin git-help., Miklos Vajna, (Sat Aug 2, 1:08 am)
Re: git help broken, Christian Couder, (Wed Aug 20, 7:51 pm)
[PATCH] Fix 'git help help', Miklos Vajna, (Thu Aug 21, 7:21 am)
Re: [PATCH] Fix 'git help help', Christian Couder, (Thu Aug 21, 9:40 pm)