login
Header Space

 
 

git mailing list

FromSubjectsort iconDate
Jakub Narebski
[PATCH] gitweb: Describe projects_index format in more detail
Update and extend information about $projects_list file format in gitweb/README and in gitweb/INSTALL. Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- This was part of "gitweb: Extend project_index file format by project description" patch send to git mailing list (but not applied). I thought that updating documentation can be done independently, so here it is (minus of course information about optional repository description field). gitweb/INSTALL | 6 ++++++ gitweb/README ...
Jul 7, 6:07 pm 2008
Jean-Luc Herren
Cloning marks pack for .keep
After cloning a local repository with "git clone file://...", the resulting repo had one big pack file, as expected, but also a matching ".keep" file. Certainly this is a bug, isn't it? The same happens if I clone git.git. I used git 1.5.6.1 but observed the same with the current master. I bisected this behavior to commit fa740529 by Shawn O. Pearce (CC'ing him). Since this dates back to 2007, I wonder if maybe only I am seeing this, but I cannot think of any reason for it. (I already mention...
Jul 7, 5:27 pm 2008
Eric Raible
[PATCH] completion: add branch options --contains --merged -...
Signed-off-by: Eric Raible <raible@gmail.com> --- contrib/completion/git-completion.bash | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 0eb8df0..22e109d 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -546,7 +546,7 @@ _git_branch () --*) __gitcomp " --color --no-color --verbose --abbrev= --no-abbrev - --track --no...
Jul 7, 4:41 pm 2008
Mike Hommey
[PATCH] Avoid apache complaining about lack of server's FQDN
On some setups, apache will say: apache2: Could not reliably determine the server's fully qualified domain name, using $(IP_address) for ServerName Avoid this message polluting tests output by setting a ServerName in apache configuration. --- t/lib-httpd/apache.conf | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf index a447346..4717c2d 100644 --- a/t/lib-httpd/apache.conf +++ b/t/lib-httpd/apache.conf @@ -1,3 +1,4 @@ ...
Jul 7, 4:22 pm 2008
Mike Hommey
Re: [PATCH] Avoid apache complaining about lack of server's ...
Signed-off-by: Mike Hommey <mh@glandium.org> for the 3 patches I sent today, obviously... Mike --
Jul 7, 4:48 pm 2008
Mike Hommey
[PATCH] Skip t5540-http-push test when USE_CURL_MULTI is und...
When USE_CURL_MULTI is undefined, git http-push doesn't work, so it's useless to test it. --- I wasted too much time wondering why the 3rd and 4th tests were failing before realizing I was building against an ancient libcurl, thus having a non working git http-push. This would avoid other people to do the same. t/t5540-http-push.sh | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/t/t5540-http-push.sh b/t/t5540-http-push.sh index 6cd8b45..147ff98 100755 --- a/...
Jul 7, 3:02 pm 2008
Mike Hommey
[PATCH] Fix http-push test
http-push test has been broken by 4a7aaccd adding a space character in the place where the test is being run. --- Note that the 4th test doesn't pass because of the new git clone, that creates the clone with packed-refs instead of refs/heads/master that push is requiring. But this also means push was already broken with repositories with packed-refs. t/lib-httpd.sh | 18 ++++++++++-------- t/t5540-http-push.sh | 2 +- 2 files changed, 11 insertions(+), 9 deletions(-) diff --g...
Jul 7, 3:02 pm 2008
Mike Hommey
Re: [PATCH] Fix http-push test
Actually, the 3rd is failing too, but fails to report an error because git push returns no error code in cases where it says: No refs in common and none specified; doing nothing. Mike --
Jul 7, 3:08 pm 2008
Junio C Hamano
Re: [PATCH] Fix http-push test
Ok, when you are done checking, care to send in a replacement patch with failing one marked with test_expect_failure? You do not have to hurry, I am currently at day job and already deep in today's integration cycle during the lunchtime, and won't be able to queue new fixes for several hours from now, so your patch will be part of tomorrow's or tonight's cycle anyway. --
Jul 7, 3:54 pm 2008
Mike Hommey
[PATCH] Catch failures from t5540-http-push
git http-push doesn't handle packed-refs, and now the new builtin-clone created packed refs, the http-push test fails. Mark the current failure as such, and also catch third test's failure that went unreported because git push doesn't return an error code when it says: No refs in common and none specified; doing nothing. Which it does when http-push can't get a list of refs recursively from $URL/refs/. Signed-off-by: Mike Hommey <mh@glandium.org> --- Feel free to squash this in the p...
Jul 7, 5:06 pm 2008
Mike Hommey
Re: [PATCH] Fix http-push test
Shouldn't that be two different patches ? One to fix the spaces problem and one to handle the fact that builtin-clone broke the tests ? Mike --
Jul 7, 4:17 pm 2008
Junio C Hamano
Re: [PATCH] better git-submodule status output
Not very easily, and that is very deliberate. The objects fetched will become dangling if you allowed such a mode of operation, and will immediately become subject to gc. As Avery said, when the user asks "what's the status" in the superproject, "the superproject binds a commit you do not have locally at these paths" is a perfectly valid answer, and as Dscho argues, it is not good to avoid giving that answer by running fetch behind the user's back. And the thing is, if you do the "without upda...
Jul 7, 2:20 pm 2008
Avery Pennarun
Re: [PATCH] better git-submodule status output
Is this really desirable? I could imagine dropping an entry (or several entries, or whatever) into the reflog after each fetch, to prevent such fetched objects from being deleted right away. Avery --
Jul 7, 2:29 pm 2008
Junio C Hamano
Re: [PATCH] better git-submodule status output
Yes. After "git fetch $random_place master && git log ..FETCH_HEAD" to inspect what the other guy is up to, if you do not like what you see, you do want the objects that are only reachable from FETCH_HEAD to go away (note that it is not counted as the root of fsck traversal for this exact reason). --
Jul 7, 3:51 pm 2008
Jon Smirl
stgit error on status command
jonsmirl@terra:~$ stg --version Stacked GIT 0.14.3.163.g06f9 git version 1.5.6.1 Python version 2.5.2 (r252:60911, Apr 21 2008, 11:17:30) [GCC 4.2.3 (Ubuntu 4.2.3-2ubuntu7)] jonsmirl@terra:~$ jonsmirl@terra:~/fs$ stg status Error: Unhandled exception: Traceback (most recent call last): File "/usr/local/lib/python2.5/site-packages/stgit/main.py", line 278, in main ret = command.func(parser, options, args) File "/usr/local/lib/python2.5/site-packages/stgit/commands/status.py", line 119, ...
Jul 7, 11:10 am 2008
Jonathon Mah
BUG: make install with FileVault on Mac OS X
Hi, (I don't subscribe to this list, so please copy me in on replies) Mac OS X 10.5.4, Git 1.5.6.2 I use FileVault for my home directory: my files are stored on an encrypted disk image which is mounted on my home (/Users/jonathon). When I run "sudo make install", perllocal.pod gets written to: /Users/jonathon/System/Library/Perl/5.8.8/darwin-thread-multi-2level/ perllocal.pod under my home directory instead of at the root of the drive. Presumably this is because it's writing to /Syst...
Jul 7, 10:01 am 2008
Johannes Schindelin
[PATCH] run_command(): respect GIT_TRACE
When GIT_TRACE is set, the user is most likely wanting to see an external command that is about to be executed. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- run-command.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/run-command.c b/run-command.c index 2ce8c2b..6e29fdf 100644 --- a/run-command.c +++ b/run-command.c @@ -65,6 +65,8 @@ int start_command(struct child_process *cmd) cmd->err = fderr[0]; } + trace_argv_printf(cm...
Jul 7, 9:41 am 2008
Junio C Hamano
Re: [PATCH] run_command(): respect GIT_TRACE
I haven't checked to see if none of the callers of start_command() assumes the current behaviour and is printing this information itself instead, but other than that, your justification feels very sensible. --
Jul 7, 4:00 pm 2008
Olivier Marin
[PATCH] builtin-rerere: fix conflict markers parsing
From: Olivier Marin <dkr@freesurf.fr> When a conflicting file contains a line that begin with "=======", rerere failed to parse conflict markers. This result to a wrong preimage file and an unexpected error for the user. This patch enforce parsing rules so that markers match in the right order and update tests to match the above fix. Signed-off-by: Olivier Marin <dkr@freesurf.fr> --- This happend to me with a conflict in Documentation/git-remote.txt. The bug seems to have al...
Jul 7, 8:42 am 2008
Johannes Schindelin
Re: [PATCH] builtin-rerere: fix conflict markers parsing
Hi, So what about <<<<<<< This hunk contains ===== anythin ======= Hello ======= somethin else >>>>>>> problem! If you fix it, I think you should do it properly, and analyze the index. Ciao, Dscho --
Jul 7, 9:02 am 2008
Junio C Hamano
Re: [PATCH] builtin-rerere: fix conflict markers parsing
I do not know offhand if analyzing the index is the right solution, but your point is very valid. You need to know which ====== is the real one to be able to properly flip sides of the conflict. I however think detecting that we have this ambiguous hunk is easy, and punting gracefully and not re-resolving in such a case is million times better than producing random results that the users need to be worried about. --
Jul 7, 1:39 pm 2008
Olivier Marin
Re: [PATCH] builtin-rerere: fix conflict markers parsing
If I read the code correctly, this case is not a problem at all because what is important is the content between <<< and >>> : even if you match the wrong === marker, you will match the first one only, then parsing will success and preimage file will be OK. Also because we always match in the same order the sha1 will be the same. Anyway, I do not know how to match the right === marker. Olivier. --
Jul 7, 9:55 am 2008
Johannes Schindelin
Re: [PATCH] builtin-rerere: fix conflict markers parsing
Hi, On Mon, 7 Jul 2008, Olivier Marin wrote: > Johannes Schindelin a
Jul 7, 10:06 am 2008
Olivier Marin
Re: [PATCH] builtin-rerere: fix conflict markers parsing
If you have a better fix send a patch or at least give me some clues. Olivier. --
Jul 7, 10:44 am 2008
Johannes Schindelin
Re: [PATCH] builtin-rerere: fix conflict markers parsing
Hi, On Mon, 7 Jul 2008, Olivier Marin wrote: > Johannes Schindelin a
Jul 7, 11:29 am 2008
Rob Shearman
[PATCH 3/3] imap-send.c: Clean up coding style to better mat...
--- imap-send.c | 631 ++++++++++++++++++++++++++++------------------------------- 1 files changed, 301 insertions(+), 330 deletions(-) diff --git a/imap-send.c b/imap-send.c index d138726..59ef4eb 100644 --- a/imap-send.c +++ b/imap-send.c @@ -102,14 +102,14 @@ typedef struct { static int Verbose, Quiet; -static void imap_info( const char *, ... ); -static void imap_warn( const char *, ... ); +static void imap_info(const char *, ...); +static void imap_warn(const char *, ...); -stat...
Jul 7, 4:05 am 2008
Junio C Hamano
Re: [PATCH 3/3] imap-send.c: Clean up coding style to better...
These patches seem to have been linewrapped severely. I _could_ fix them up and apply, but the last one being about whitespace and style fixes, I'd rather not. --
Jul 7, 4:49 am 2008
Rob Shearman
Re: [PATCH 3/3] imap-send.c: Clean up coding style to better...
How do you propose I fix this? I attached the patch last time to avoid the problem of line wrapping. -- Rob Shearman --
Jul 7, 8:17 am 2008
Jakub Narebski
Re: [PATCH 3/3] imap-send.c: Clean up coding style to better...
If possible to turn of linewrapping, or use either git-send-email (I think you can send patches also via Gmail) or git-imap-send, then preferred solution is to have patch inline. If it is not possible, then attach the patch, but preferrably 1) with text/plain mimetype (.txt extension instead of .patch or .diff could be required for that) 2) 8bit (preferred) or quoted-printable (if 8bit is not possible) transfer encoding (base64 is terrible waste of space); text/plain should chose...
Jul 7, 8:40 am 2008
Rob Shearman
[PATCH 2/3] git-imap-send: Add support for SSL.
Allow SSL to be used when a imaps:// URL is used for the host name. Also, automatically use TLS when not using imaps:// by using the IMAP STARTTLS command, if the server supports it. Tested with Courier and Gimap IMAP servers. --- Documentation/git-imap-send.txt | 5 +- Makefile | 4 +- imap-send.c | 166 +++++++++++++++++++++++++++++++++++---- 3 files changed, 157 insertions(+), 18 deletions(-) diff --git a/Documentation/git-imap-send.txt b/...
Jul 7, 4:05 am 2008
Rob Shearman
[PATCH 1/3] git-imap-send: Allow the program to be run from ...
Call setup_git_directory_gently to allow git-imap-send to be used from subdirectories of a git tree. --- imap-send.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/imap-send.c b/imap-send.c index 1ec1310..89a1532 100644 --- a/imap-send.c +++ b/imap-send.c @@ -1296,6 +1296,7 @@ main(int argc, char **argv) /* init the random number generator */ arc4_init(); + setup_git_directory_gently( NULL ); git_config(git_imap_config, NULL); if (!imap_folder) { -- 1...
Jul 7, 4:05 am 2008
Junio C Hamano
Re* [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
Hmm, it makes "rebase -i" different, too. Luckily, I haven't pushed anything out, so I can rewind and all I lose is just a few dozens of minutes. The one from Brian has another serious issue. That patch does not allow you to refer to ORIG_HEAD during conflict resolution, which is quite different from how "merge" lets you use ORIG_HEAD. We need to set ORIG_HEAD upfront if we want to tell user that ORIG_HEAD can be reliably used across workflows the same way to name where we were before. When...
Jul 7, 3:16 am 2008
Brian Gernhardt
Re: Re* [FIXED PATCH] Make rebase save ORIG_HEAD if changing...
Ah, I missed the exit in the $do_merge conditional. Bah. I had considered rebase--interactive a completely different beast and didn't consider it at all. We've moved a little beyond my goal of "always get git-pull to set ORIG_HEAD." However, consistency is a higher goal. :-) I originally only set ORIG_HEAD if rebase was operating on the current HEAD. Now we're setting it to the original state of the branch rebase is operating on. Thinking about it, I'm not certain this is wha...
Jul 7, 10:36 am 2008
Junio C Hamano
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
Yeah, I was scratching my head about the discrepancy between the revision comment and the patch in the previous one. Having said that, thanks to updates to git-rebase, rebased_branch@{1} has useful information these days, so I do not see much practical upside, even though I _will_ apply this patch, just for the sake of consistency. We would make it _appear_ rebase and merge are interchangeable even more. But the thing is, I am not convinced if promoting that appearance is necessarily a good thi...
Jul 7, 12:43 am 2008
Nanako Shiraishi
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
Are you really aiming for consistency, Junio? Doesn't this make the behavior of the command inconsistent between "git-rebase" and "git-rebase -m"? -- Nanako Shiraishi http://ivory.ap.teacup.com/nanako3/ --
Jul 7, 2:14 am 2008
Mike Hommey
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
And in both cases, you could use HEAD@{1} instead of ORIG_HEAD. Mike --
Jul 7, 1:41 am 2008
Mike Hommey
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
Forget it, I just woke up, I'm writing crap. Mike --
Jul 7, 1:48 am 2008
Junio C Hamano
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
No you cannot. Read what I wrote again. I never said HEAD@{1} ;-) --
Jul 7, 1:46 am 2008
Brian Gernhardt
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
I've been running rebase a lot over the last few days, and my impression was that git-rebase adds an entry to ther eflog for each patch it runs over. While this has its uses, it makes HEAD@{1} not terribly useful after a "pull --rebase". Of course, it took me three tries to get a one-line patch out this weekend, so my judgement is obviously not that great at the moment. I do appreciate that you'll apply it though. As useful as I find rebasing pull useful, I dislike maintaining pa...
Jul 7, 1:16 am 2008
Junio C Hamano
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
The idea behind ORIG_HEAD is to have an anchoring point before an operation that moves your HEAD in a drastic way. Think if it as a poor-man's reflog -- in fact it predates reflog. That is why reset saves away the HEAD before it does its thing, so that you can easily say "Oops, I did not mean it -- reset ORIG_HEAD" to flip back to the previous state. Both a fast-forward merge and a real merge can be undone by resetting back to ORIG_HEAD. So in that sense: (1) ORIG_HEAD is not strictly nec...
Jul 7, 2:28 am 2008
Junio C Hamano
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
I've also seen people complain (quite rightfully) that these FOO_HEAD pseudo refs are not documented in a central place. How about doing this? It should make it clear what ORIG_HEAD is meant to record, while describing others. And to answer your "git rebase --onto this from that-branch" question, I think ORIG_HEAD should record the tip of that-branch before rebase takes place, not the commit you happened to be at before running it. Switching branch to that-branch is not the drastic and unfors...
Jul 7, 5:58 pm 2008
Jakub Narebski
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
I'm not sure if the last part is improvement, and it wouldn't be better to say rather than r1..r2 / ^r1 r2 are "commits that are reachable from r2, excluding those commits which are reachable from r1" (which translates into set difference / subtracting set of commits. -- Jakub Narebski Poland ShadeHawk on #git --
Jul 7, 6:14 pm 2008
Junio C Hamano
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
I tried to make it easier to understand by people without having to know what a set difference is, and that was the reason I did not use "subtract" nor "difference", as I saw somebody was quoting the above part in #git was wondering what it was talking about. --
Jul 7, 6:33 pm 2008
Jakub Narebski
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
I understand, and the replacement you proposed is better, as it does not require understanding of [mathematical] set operations. I just think that "commits that are reachable from r2, excluding those commits which are reachable from r1" could be better than "commits that are reachable from r2 but not from r1". -- Jakub Narebski Poland --
Jul 7, 6:58 pm 2008
Theodore Tso
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
True, but (and please correct me if I'm wrong) ORIG_HEAD will always be pointing out HEAD before the user typed pretty much any git porcelein command (which saves HEAD into ORIG_HEAD), but with reflogs, it you have to paw through multiple HEAD@{n} to find the 'n' which corresponds to state before executing the git plumbing command, since multiple git plumbing commands could have updated the HEAD's reflog, right? One of the things that's been on my 'twoud be nice list is having an option to "git ...
Jul 7, 7:18 am 2008
Junio C Hamano
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
You can inspect HEAD's reflog for individual steps, or the branch's reflog for the aggregated moves (try rebasing a few patches on 'test' branch and $ git log -g HEAD@{now} $ git log -g test@{now} Please don't complain that interface to specify timestamp output is dirty to me -- I share the same feeling, and it was not my invention. But at least it works ;-) --
Jul 7, 2:04 pm 2008
Brian Gernhardt
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
This is _exactly_ why I wanted `pull --rebase` to set ORIG_HEAD. Reflogs are great in their own way, but having ORIG_HEAD regularly being available for a quick way to set it back or refer to the original state is just too useful. ~~ Brian --
Jul 7, 10:36 am 2008
Jakub Narebski
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
You can always use _branch_ reflog, either in the <branch>@{1} form, or in @{1} shortcut form. @{1} should be equovalent to ORIG_HEAD even for rebase. -- Jakub Narebski Poland ShadeHawk on #git --
Jul 7, 7:42 am 2008
Brian Gernhardt
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
I personally expected @{1} to be identical to HEAD@{1}. Since omitting a ref usually refers to HEAD, why shouldn't omitting it when referring to the reflogs mean the HEAD log? The definition of @{1} is useful since there's no other easy way to get "current branch's reflog", but I think it's non-obvious. (Since HEAD@{1} is something completely different, I think the only other way to refer to @{1} is $ (git symbolic-ref)@{1}.) Also, your statement is only true if ORIG_HEAD was on t...
Jul 7, 11:03 am 2008
Junio C Hamano
Re: [FIXED PATCH] Make rebase save ORIG_HEAD if changing cur...
Perhaps something like this for "git am" (only minimally tested). -- >8 -- am: record ORIG_HEAD so that we can quickly undo a large series This teaches "git-am" to record the commit before it starts its work in ORIG_HEAD, so that application of a large series can be undone by resetting to it. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- git-am.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/git-am.sh b/git-am.sh index 2c517ed..818b4e5 100755...
Jul 7, 2:48 am 2008
previous daytodaynext day
July 6, 2008July 7, 2008July 8, 2008
speck-geostationary