Re: [RFC/PATCH 1/4] Add git-sequencer shell prototype

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jakub Narebski
Date: Thursday, July 3, 2008 - 6:10 am

Stephan Beyer <s-beyer@gmx.net> writes:


First, let's not perpetuate _convenience_ calling convention of "A..B"
of git-diff* family, but use "A B" to set _endpoints_.

Second, with "A B" convention you can fairly easy deal with root
commit, changing the code to the fragment below:

+# Generate message, patch and author script files
+make_patch () {
+	parent_sha1=$(git rev-parse --verify "$1"^) ||
+		echo '--root'
+	git diff-tree -p "$parent_sha1" "$1" >"$PATCH"


BTW. what is best way of checking if given revision is parent-less?
-- 
Jakub Narebski
Poland
ShadeHawk on #git
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
git sequencer prototype, Stephan Beyer, (Mon Jun 30, 7:38 pm)
[RFC/PATCH 1/4] Add git-sequencer shell prototype, Stephan Beyer, (Mon Jun 30, 7:38 pm)
[RFC/PATCH 2/4] Add git-sequencer prototype documentation, Stephan Beyer, (Mon Jun 30, 7:38 pm)
[RFC/PATCH 3/4] Add git-sequencer test suite (t3350), Stephan Beyer, (Mon Jun 30, 7:38 pm)
[RFC/PATCH 4/4] Migrate git-am to use git-sequencer, Stephan Beyer, (Mon Jun 30, 7:38 pm)
git-rebase-i migration to sequencer, Stephan Beyer, (Mon Jun 30, 7:39 pm)
[PATCH 1/2] Make rebase--interactive use OPTIONS_SPEC, Stephan Beyer, (Mon Jun 30, 7:39 pm)
Re: git sequencer prototype, Junio C Hamano, (Tue Jul 1, 1:51 am)
Re: git sequencer prototype, Stephan Beyer, (Tue Jul 1, 7:53 am)
Re: [RFC/PATCH 1/4] Add git-sequencer shell prototype, Jakub Narebski, (Thu Jul 3, 6:10 am)
Re: [RFC/PATCH 1/4] Add git-sequencer shell prototype, Stephan Beyer, (Thu Jul 3, 2:12 pm)
Re: git sequencer prototype, Alex Riesen, (Fri Jul 4, 2:00 pm)
Re: git sequencer prototype, Junio C Hamano, (Fri Jul 4, 3:09 pm)
Re: git sequencer prototype, Stephan Beyer, (Fri Jul 4, 3:23 pm)
Re: git sequencer prototype, Alex Riesen, (Sat Jul 5, 1:13 am)
Re: git sequencer prototype, Thomas Adam, (Sat Jul 5, 3:12 am)
Re: git sequencer prototype, Johannes Schindelin, (Sat Jul 5, 3:13 am)
[PATCH v2 1/4] Add git-sequencer shell prototype, Stephan Beyer, (Sat Jul 5, 9:58 am)
[PATCH v2 2/4] Add git-sequencer prototype documentation, Stephan Beyer, (Sat Jul 5, 10:00 am)
Re: [RFC/PATCH 3/4] Add git-sequencer test suite (t3350), Stephan Beyer, (Sat Jul 5, 10:31 am)
Re: [RFC/PATCH 3/4] Add git-sequencer test suite (t3350), Junio C Hamano, (Sat Jul 5, 11:16 am)