Re: [PATCH] index-pack: correctly initialize appended objects

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Junio C Hamano <gitster@...>

Cc: Johannes Schindelin <Johannes.Schindelin@...>, Nicolas Pitre <nico@...>, <spearce@...>, <git@...>

Subject: Re: [PATCH] index-pack: correctly initialize appended objects

Date: Friday, July 25, 2008 - 7:55 am

On 2008.07.24 22:21:14 -0700, Junio C Hamano wrote:
quoted text> Reading get_data_from_pack(), it does rely on hdr_size, idx.offset and
> idx.offset of the next entry to be set correctly.  The function does not
> seem to use type (which the patch is also setting) nor real_type (which
> the patch does not set).

type is used in get_base_data().

quoted text> However, the code checks objects[nth].real_type all over the place in the
> code.  Doesn't the lack of real_type assignment in append_obj_to_pack()
> affect them in  any way?

I had thought that resolve_delta() would set that, but it seems that we
never call that function like that. Hm...

Björn
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] index-pack: correctly initialize appended objects, Johannes Schindelin, (Thu Jul 24, 1:32 pm)

Re: [PATCH] index-pack: correctly initialize appended objects, Nicolas Pitre, (Fri Jul 25, 7:48 am)

Re: [PATCH] index-pack: correctly initialize appended objects, Junio C Hamano, (Fri Jul 25, 1:21 am)

Re: [PATCH] index-pack: correctly initialize appended objects, Björn, (Fri Jul 25, 7:55 am)

Re: [PATCH] index-pack: correctly initialize appended objects, Johannes Schindelin, (Fri Jul 25, 9:15 am)

[PATCH] index-pack: correctly initialize appended objects, Björn, (Fri Jul 25, 1:13 pm)

Re: [PATCH] index-pack: correctly initialize appended objects, Johannes Schindelin, (Fri Jul 25, 11:04 pm)

Re: [PATCH] index-pack: correctly initialize appended objects, Shawn O. Pearce, (Fri Jul 25, 1:20 pm)

Re: [PATCH] index-pack: correctly initialize appended objects, Shawn O. Pearce, (Fri Jul 25, 12:42 pm)

Re: [PATCH] index-pack: correctly initialize appended objects, Johannes Schindelin, (Fri Jul 25, 6:24 am)

Re: [PATCH] index-pack: correctly initialize appended objects, Nicolas Pitre, (Fri Jul 25, 7:54 am)

Re: [PATCH] index-pack: correctly initialize appended objects, Junio C Hamano, (Fri Jul 25, 2:15 pm)

Re: [PATCH] index-pack: correctly initialize appended objects, Björn, (Fri Jul 25, 8:01 am)

Re: [PATCH] index-pack: correctly initialize appended objects, Nicolas Pitre, (Fri Jul 25, 8:24 am)

Re: [PATCH] index-pack: correctly initialize appended objects, Björn, (Thu Jul 24, 2:07 pm)


linux-kernel:
Davide Libenzi	Re: [patch 7/8] fdmap v2 - implement sys_socket2
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
Greg Kroah-Hartman	[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Mariusz Kozlowski	[KJ PATCHES] mostly kmalloc + memset conversion to k[cz]alloc
git:

linux-netdev:
KOSAKI Motohiro	[bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"
Stefan Richter	Re: [GIT]: Networking
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 0/37] dccp: Feature negotiation - last call for comments
git-commits-head:

Re: [PATCH] index-pack: correctly initialize appended objects

Online users