Re: git status in clean working dir

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Monday, July 21, 2008 - 7:40 pm

Junio C Hamano <gitster@pobox.com> writes:


Actually, the situation is now even worse than I originally thought
especially with Jeff's pager.<cmd> patch on 'master' recently.  For
example, you can screw yourself quite badly by forcing diff-files used in
the scripts you run to page, defeating --exit-code option.  Which means

 (1) It hurts?  Don't do it then; but

 (2) Then why are we even allowing to configure the plumbing to page?

Should we maintain a table of commands that we allow paging to be
customized, and ignore pager.<cmd> for commands that are not in the list?

Which codepath should issue error messages when the user tries to break
the system by saying "pager.diff-files = true"?

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
git status in clean working dir, David Bremner, (Mon Jul 21, 4:13 pm)
Re: git status in clean working dir, Junio C Hamano, (Mon Jul 21, 7:30 pm)
Re: git status in clean working dir, Abhijit Menon-Sen, (Mon Jul 21, 7:36 pm)
Re: git status in clean working dir, Junio C Hamano, (Mon Jul 21, 7:40 pm)
Re: git status in clean working dir, Junio C Hamano, (Mon Jul 21, 7:48 pm)
Re: git status in clean working dir, Jeff King, (Mon Jul 21, 9:41 pm)
Re: git status in clean working dir, Jeff King, (Mon Jul 21, 9:44 pm)
Re: git status in clean working dir, Jeff King, (Mon Jul 21, 9:52 pm)
Re: git status in clean working dir, Mike Hommey, (Mon Jul 21, 10:39 pm)
Re: git status in clean working dir, Jeff King, (Mon Jul 21, 11:06 pm)
Re: git status in clean working dir, Mike Hommey, (Mon Jul 21, 11:18 pm)
Re: git status in clean working dir, Jeff King, (Mon Jul 21, 11:46 pm)
Re: git status in clean working dir, Jeff King, (Tue Jul 22, 12:10 am)
[PATCH 1/2] run-command: add pre-exec callback, Jeff King, (Tue Jul 22, 12:12 am)
[PATCH 2/2] spawn pager via run_command interface, Jeff King, (Tue Jul 22, 12:14 am)
Re: [PATCH 2/2] spawn pager via run_command interface, Pierre Habouzit, (Tue Jul 22, 12:31 am)
Re: git status in clean working dir, Johannes Sixt, (Tue Jul 22, 12:34 am)
Re: git status in clean working dir, Jeff King, (Tue Jul 22, 12:46 am)
Re: [PATCH 2/2] spawn pager via run_command interface, Johannes Sixt, (Tue Jul 22, 12:48 am)
Re: git status in clean working dir, Johannes Sixt, (Tue Jul 22, 12:54 am)
Re: [PATCH 2/2] spawn pager via run_command interface, Johannes Sixt, (Tue Jul 22, 1:29 am)
Re: git status in clean working dir, Johannes Schindelin, (Tue Jul 22, 4:24 am)
Re: git status in clean working dir, David Bremner, (Tue Jul 22, 7:10 am)
Re: git status in clean working dir, Ask Bjørn Hansen, (Wed Jul 23, 11:56 pm)
Re: git status in clean working dir, Jeff King, (Thu Jul 24, 9:54 am)