Home » Mailing list archives » git » 2008 » July » 14

Re: [PATCH] bash completion: Fix the . -> .. revision range completion

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Shawn O. Pearce <spearce@...>
To: Linus Torvalds <torvalds@...>
Cc: Junio C Hamano <gitster@...>, Petr Baudis <pasky@...>, <git@...>
Subject: Re: [PATCH] bash completion: Fix the . -&gt; .. revision range completion
Date: Monday, July 14, 2008 - 2:27 am

Linus Torvalds <torvalds@linux-foundation.org> wrote:

What is $COMP_WORDBREAKS set to in your shell?  In mine it
appears to be:

	" \"'@><=;|&(:"

which is the I believe the shell default.

Björn Steinbrink (doener on #git) is running bash 3.2.39 from
Debian and has the same setting, and the completion works correctly
there too.  He reports that removing : from COMP_WORDBREAKS will
get the behavior you are reporting as broken.

I have to say, this sounds to me like you (or some package on your
system) modified COMP_WORDBREAKS away from the default that other
distributions use and that is what is breaking us here.  Since we
can have only one setting for this variable in the shell I do not
thing it would be a good idea for our completion package to force
a specific setting upon the user.

Though we could try to detect : in there and if it is not present
use the workaround you posted.  But I wonder if just asking the
user to include : is easier.

-- 
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Junio C Hamano, (Sun Jul 13, 5:38 pm)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Petr Baudis, (Sun Jul 13, 7:07 pm)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Junio C Hamano, (Sun Jul 13, 7:25 pm)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Linus Torvalds, (Sun Jul 13, 7:52 pm)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Shawn O. Pearce, (Sun Jul 13, 8:00 pm)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Linus Torvalds, (Mon Jul 14, 1:38 am)
Re: [PATCH] bash completion: Fix the . -> .. revision ran..., Shawn O. Pearce, (Mon Jul 14, 2:27 am)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Linus Torvalds, (Mon Jul 14, 10:50 am)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Shawn O. Pearce, (Tue Jul 15, 12:25 am)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Andreas Ericsson, (Tue Jul 15, 4:05 am)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Shawn O. Pearce, (Tue Jul 15, 7:38 pm)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Andreas Ericsson, (Wed Jul 16, 3:20 am)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Andreas Ericsson, (Tue Jul 15, 4:10 am)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Andreas Ericsson, (Tue Jul 15, 4:17 am)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Björn, (Mon Jul 14, 2:47 am)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Björn, (Mon Jul 14, 2:50 am)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Linus Torvalds, (Mon Jul 14, 10:51 am)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Andreas Ericsson, (Mon Jul 14, 8:39 am)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Shawn O. Pearce, (Mon Jul 14, 1:57 am)
Re: [PATCH] bash completion: Fix the . -&gt; .. revision ran..., Shawn O. Pearce, (Sun Jul 13, 6:06 pm)