| From | Subject | Date |
|---|---|---|
| Junio C Hamano | Re: [PATCH?] Fix 'git show' on signed tag of signed tag ...
The code looks good. It should not have been accessing the object without
making sure it has been parsed.
And it's not a leak. Once you instantiate "struct object" derived class,
we hold onto it (at least to its skeleton).
Thanks.
--
| Jul 1, 4:55 pm 2008 |
| Junio C Hamano | Re: [OT] Your branch is ahead of the tracked remote bran ...
Yup.
I have $HOME/git-active/bin on my $PATH and then these:
lrwxrwxrwx 1 junio junio 10 2008-05-25 18:13 /home/junio/git-active -> git-master
drwxr-sr-x 6 junio junio 4096 2007-04-04 02:49 /home/junio/git-maint
drwxr-sr-x 5 junio junio 4096 2007-12-14 22:46 /home/junio/git-master
drwxr-sr-x 6 junio junio 4096 2008-06-23 22:02 /home/junio/git-next
drwxr-sr-x 7 junio junio 4096 2007-12-02 02:52 /home/junio/git-pu
drwxr-sr-x 4 junio junio 4096 2006-10-14 22:43 ...
| Jul 1, 4:55 pm 2008 |
| Junio C Hamano | Re: [PATCH/v2] git-basis, a script to manage bases for g ...
Well, I have a moderately strong objection to this.
This very much feels like adding a missing feature to "git bundle" command
itself. Why isn't it a new option to it?
For that matter, I am not sure how this integrates to a larger workflow.
You have a site (or more) to "push" your changes to, and you would need to
remember up to which revisions you have given out bundles to. To remember
which site is at what basis level, you would need an extra infrastructure
than what this separate ...
| Jul 1, 4:55 pm 2008 |
| Junio C Hamano | Re: [PATCH 14/14] Build in merge
Are you sure about that? I've been deliberately fixing that patch.
As far as I understand it, your series:
- starts out building infrastructure;
- adds tests;
- finally replaces git-merge with the new implementation.
and the test in question comes when git-merge built from that version is
still the scripted version with limitation.
So if you build and test after applying individual steps (you sure do
that, don't you?), the test has to start with expecting failure (from ...
| Jul 1, 4:55 pm 2008 |
| Junio C Hamano | Re: [PATCH 3/7] Documentation: complicate example of "ma ...
While I agree with the above, are we ready to talk about "git-svn"
or "git-remote" that early in the tutorial material?
We would want to mention the typesetting convention early in the manuals
(git(7), gittutorial(7) and user-manual.html) as well, so how about...
Conventions used in this document
---------------------------------
When talking about a git subcommand 'cmd', this documentation
typesets the name of it like 'git-cmd', and that is the name you
ask for its manual ...
| Jul 1, 4:54 pm 2008 |
| Junio C Hamano | Re: [PATCH] git-add--interactive: manual hunk editing mode
Thanks, both.
--
| Jul 1, 4:54 pm 2008 |
| Jeff King | Re: git push requires a subsequent git reset --hard ?
See:
http://git.or.cz/gitwiki/GitFaq#head-b96f48bc9c925074be9f95c0fce69bcece5f6e73
and
http://git.or.cz/gitwiki/GitFaq#head-46de97a5ac549d3adf406c22674b3325ae25d09c
What you did is OK, but there is a better way to do it.
-Peff
--
| Jul 1, 10:19 am 2008 |
| Neshama Parhoti | git push requires a subsequent git reset --hard ?
Hi all,
I took with me a copy of a local repository to a week away from my station
(just rsync'ed it to my laptop).
On my return, I just "git push myuser@my-station:/my/git/repo" from my laptop.
It seemed to work with no probs.
On my station the git repo got the new commits, as I can see in
git-log, but the actual files were left untouched.
So I need to do something like "git reset --hard HEAD" to get
the changes into the local files.
Is that considered normal ?
or did I do something ...
| Jul 1, 9:51 am 2008 |
| Jakub Narebski | Re: git push requires a subsequent git reset --hard ?
This is considered normal. Push would never touch index nor working
area (although if you are the only user, and you know what you are
doing, you can add "git reset --hard HEAD" to post-receive hook). It
is the only way: "push" cannot be opposite of "pull" and do a merge
because there is nobody to resolve conflict on remote side.
So you should either do mirroring (1:1 refspec) push into bare
repository (without working directory), or push into remotes section,
remotes/satellite or ...
| Jul 1, 10:29 am 2008 |
| Paul Gardiner | How do I stop git enumerating my working directory
Hi,
I'm a recent convert to git. I've been swapping over my projects
from cvs to git. The latest candidate for conversion is the
config files for my Linux server. I've been using cvs to record
all the config changes, and - mostly-automatically - to setup
new servers. Git will do a far better job, I think, but
I think I'm going to run into a problem: the root directory
of the server will be the working directory. Only relatively
few files will be under version control. How do I stop ...
| Jul 1, 8:57 am 2008 |
| Matthieu Moy | Re: How do I stop git enumerating my working directory
To me, it seems the opposite ;-).
I just tried to "git init" my $HOME, then "git status" takes forever,
but "echo '*' > .gitignore; git status" completes immediately.
So, an option is to put "*" in your .gitignore, and then "git add -f"
files explicitely, or to work your .gitignore finer.
--
Matthieu
--
| Jul 1, 9:37 am 2008 |
| Brian Gernhardt | Re: How do I stop git enumerating my working directory
That's where you're wrong. You can't get git to pay attention to
anything inside an ignored directory using the .gitignore files. Once
you ignore a directory, git stops looking at it completely. You can
force git to look at a file inside an ignored directory by adding it
directly, though. Git will pay attention to files you add for
changes, but won't pay any attention to other files around it.
See the log below for what I mean:
$ mkdir temp
$ cd temp
$ git ...
| Jul 1, 12:01 pm 2008 |
| Sylvain Joyeux | [PATCH] fix "git-submodule add a/b/c/repository"
The 'master' version of git-submodule.sh fails to see that
a/b/c/repository is an already existing repository and messes up the
whole thing. The following patch fixes that.
--
Sylvain
From 2bca2e17a01cd81ce30f81750583ab943ab57ff0 Mon Sep 17 00:00:00 2001
From: Sylvain Joyeux <sylvain.joyeux@dfki.de>
Date: Tue, 1 Jul 2008 16:45:04 +0200
Subject: [PATCH] fix submodule add for non-toplevel in-project directories
This patch fixes git-submodule add for submodules that
already exist in the ...
| Jul 1, 8:00 am 2008 |
| Sylvain Joyeux | [PATCH] better git-submodule status output
Oups.. sorry for the patch-as-attachment in the previous mail
This patch makes the output of git-submodule more useful to handle the
management of a repository using multiple submodules. Namely, it
displays informations about how the current checked out version relates
to the registered one (i.e. direct parent, direct child, "just
different", registered revision does not exist), and displays if the
submodules contain uncommitted changes.
This (among other things) allows to do git-submodule ...
| Jul 1, 8:01 am 2008 |
| Sylvain Joyeux | [PATCH] better git-submodule status output
This patch makes the output of git-submodule more useful to handle the
management of a repository using multiple submodules. Namely, it
displays informations about how the current checked out version relates
to the registered one (i.e. direct parent, direct child, "just
different", registered revision does not exist), and displays if the
submodules contain uncommitted changes.
This (among other things) allows to do git-submodule update while
knowing exactly what will happen.
Sylvain
| Jul 1, 7:57 am 2008 |
| Nanako Shiraishi | [PATCH v2] gitcli: Document meaning of --cached and --index
We saw this explanation repeated on the mailing list a few times. Even
though the description of individual options to particular commands are
explained in their manual pages, the reason behind choosing which is which
has not been clearly explained in any of the documentation.
Signed-off-by: Nanako Shiraishi <nanako3@lavabit.com>
---
Here is a resend with updates that fix the mistakes you pointed out in
the previous version. Includes an update to the Documentation section
(Sverre Rabbelier ...
| Jul 1, 7:02 am 2008 |
| Thomas Rast | [PATCH?] Fix 'git show' on signed tag of signed tag of commit
The cmd_show loop resolves tags by showing them, then pointing the
object to the 'tagged' member. However, this object is not fully
initialized; it only contains the SHA1. (This resulted in a segfault
if there were two levels of tags.) We apply parse_object to get a
full object.
Noticed by Kalle Olavi Niemitalo on IRC.
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
I'm not 100% sure this is the right fix; I just had a quick stab at
the code, made a fix and tested it. It ...
| Jul 1, 2:47 am 2008 |
| Johannes Schindelin | Re: [PATCH?] Fix 'git show' on signed tag of signed tag ...
Hi,
AFAICT this is the correct way to solve the problem.
We do not "leak" memory here, since we just assume objects to be
singletons (they are immutable, after all).
FWIW I had a "release_all_objects()" function in my personal fork for a
long time, which was quite painful to write. But maintaining the "move
all builtins into libgit.a and avoid fork()&&exec()ing them" patch was the
only user, and since it became way too painful to maintain out of the
tree, I dropped ...
| Jul 1, 9:39 am 2008 |
| Jakub Narebski | Re: [OT] Your branch is ahead of the tracked remote bran ...
I agree that having this information in git-status would be useful,
especially that it would make having this reminder in buffer/editor
when editing commit message.
--
Jakub Narebski
Poland
ShadeHawk on #git
--
| Jul 1, 5:44 am 2008 |
| SZEDER | Re: [OT] Your branch is ahead of the tracked remote bran ...
Hi Ingo,
# 4) Consider changing your PS1 to also show the current branch:
# PS1='[\u@\h \W$(__git_ps1 " (%s)")]\$ '
#
# The argument to __git_ps1 will be displayed only if you
# are currently in a git repository. The %s token will be
# the name of the current branch.
Regards,
Gábor
--
| Jul 1, 4:41 am 2008 |
| Miklos Vajna | Re: [OT] Your branch is ahead of the tracked remote bran ...
I remember about a mail from Junio where he wrote he has a lot of
versions installed under ~/git/git-version. So usually he has git from
next as default and he can try ~/git/git-1.5.4/git if he want 1.5.4,
etc.
| Jul 1, 4:41 am 2008 |
| Ingo Molnar | [OT] Your branch is ahead of the tracked remote branch ' ...
i recently switched to 1.5.6.1.89.gd5446 and i'm getting this:
Switched to branch "master"
Your branch is ahead of the tracked remote branch 'origin/master' by 50 commits.
it's a very useful detail! It's especially useful when two branches
diverge in a non-trivial way.
I used to have ad-hoc scripts to discover this in the past:
earth4:~/tip> tip-compare-remote
master : differs from remote (-50 commits)
tip : differs from remote ...
| Jul 1, 2:13 am 2008 |
| Junio C Hamano | Re: [OT] Your branch is ahead of the tracked remote bran ...
Thanks for a rare positive usability feedback. When I started reading
your message, I almost expected that I'd hear you say "I am getting this
useless cruft and it wastes extra cycles."
Somebody must have had a very bright idea that day in late February this
year.
--
| Jul 1, 2:32 am 2008 |
| Björn | Re: [OT] Your branch is ahead of the tracked remote bran ...
Just "git checkout" works for me:
git (master) $ git checkout
Your branch is behind the tracked remote branch 'origin/master' by 6 commits,
and can be fast-forwarded.
Björn
--
| Jul 1, 11:01 am 2008 |
| Jakub Narebski | Re: [OT] Your branch is ahead of the tracked remote bran ...
Because I alos use StGit, I have added to my prompt visual
differentiation if the branch is under StGit control.
But I have my own git prompt function, based on git-completion.bash
but different. It shows current branch (or "HEAD" if on detached
HEAD), current repository, and current working directory. It laso has
number of command in history, the same as in my ordinary prompt.
--
Jakub Narebski
Poland
ShadeHawk on #git
--
| Jul 1, 5:47 am 2008 |
| Mikael Magnusson | Re: [OT] Your branch is ahead of the tracked remote bran ...
{14:44:16|~code/git}% git checkout master
Checking out files: 100% (180/180), done.
Switched to branch "master"
{14:44:24|~code/git}% git shard HEAD\~5
HEAD is now at 8e69d78 Merge branch 'maint'
{14:44:28|~code/git}% git checkout HEAD
Your branch is behind the tracked remote branch 'origin/master' by 6 commits,
and can be fast-forwarded.
--
Mikael Magnusson
--
| Jul 1, 5:46 am 2008 |
| Ingo Molnar | Re: [OT] Your branch is ahead of the tracked remote bran ...
random (likely stupid) idea: perhaps git could use ... a separate Git
repo to track gitexecdir installations in $HOME/bin/? That could be
tagged appropriately so you'd always know what to uninstall and whether
there are clashes or incompatibilities.
[ Oh, and i could switch between git versions without having to rebuild
;-) ]
Ingo
--
| Jul 1, 4:22 am 2008 |
| Bruce Stephens | Re: [OT] Your branch is ahead of the tracked remote bran ...
I agree, it's a really nice little feature. Indeed, I occasionally do
"git checkout master" just to get the message (to see where I am).
It feels logical for "git status" to offer the same information (when
the information is appropriate).
[...]
--
| Jul 1, 2:26 am 2008 |
| Ingo Molnar | Re: [OT] Your branch is ahead of the tracked remote bran ...
Git usability is certainly very good. (And what matters even more to me
than absolute usability, Git's usability is improving in a monotonic
way.)
[ You normally only hear from me if i find one of those rare outliers
that confuse me somewhere. So by reading my feedback you must be
There's a small detail i was thinking about: is there a way to get this
extra output without actually switching branches? Right now i do this:
earth4:~/tip> git-checkout tip; git-checkout master
Checking ...
| Jul 1, 3:07 am 2008 |
| Ingo Molnar | Re: [OT] Your branch is ahead of the tracked remote bran ...
i have a tip-curr (shortcut: 'tc') scriptlet to answer the "where I am
amongst 100+ branches" question:
earth4:~/tip> tc
tip/master 200a86b: Merge branch 'x86/unify-setup'
which is just a thin wrapper around git-log:
earth4:~/tip> cat ~/bin/tip/tip-curr
#!/bin/bash
. ~/bin/tip/tip-lib
echo "tip/"$(get_current_branch)" "$(git log -1 --pretty=format:"%h: %s")
Ingo
--
| Jul 1, 3:14 am 2008 |
| Miklos Vajna | Re: [OT] Your branch is ahead of the tracked remote bran ...
There is a 10-lines-length note about this in RelNotes, but I think
removing the old version is a task of the package manager. At least till
the git Makefile does not have an 'uninstall' target.
| Jul 1, 4:16 am 2008 |
| Junio C Hamano | Re: [OT] Your branch is ahead of the tracked remote bran ...
Perhaps like this, but be warned this is untested except for compilation
testing.
builtin-checkout.c | 39 +++++++++++++++++++++------------------
wt-status.c | 22 ++++++++++++++++++++++
2 files changed, 43 insertions(+), 18 deletions(-)
diff --git a/builtin-checkout.c b/builtin-checkout.c
index 93ea69b..2cbc39c 100644
--- a/builtin-checkout.c
+++ b/builtin-checkout.c
@@ -305,7 +305,7 @@ static int merge_working_tree(struct checkout_opts *opts,
return 0;
}
-static ...
| Jul 1, 12:16 pm 2008 |
| Junio C Hamano | Re: [PATCH] Make default expiration period of reflog use ...
Thanks for reminding, but I am of two minds about the change.
(1) The change would untie the base tree of the stash from the history
behind it and allow previously rewound tips of branches that these
stashes were built on top of. Without the patch, these otherwise
unreachable commits will never be reclaimed.
(2) Today, you can say "git log stash" (note the lack of "-g" option) to
view the history behind the stash through two artificial commits that
stash creates. ...
| Jul 1, 12:28 am 2008 |
| Junio C Hamano | Re: [PATCH 14/14] Build in merge
I still have problems with the above. I'd write it this way:
int len, early;
...
/* See if remote matches <name>^^^.. or <name>~<number> */
for (len = 0, ptr = remote + strlen(remote);
remote < ptr && ptr[-1] == '^';
ptr--)
len++;
if (len)
early = 1;
else {
early = 0;
ptr = strrchr(remote, '~');
if (ptr) {
int seen_nonzero = 0;
len++; /* count ~ */
while (*++ptr && isdigit(*ptr)) {
seen_nonzero |= (*ptr != '0');
len++;
}
if ...
| Jul 1, 12:27 am 2008 |
| Miklos Vajna | Re: [PATCH 14/14] Build in merge
Thanks for pointing that out. I remember I used to run 'make test'
before sending a patch, but that took a lot of time and then I used to
run only t*merge*.sh, which - it turns out - was a bad idea, since I
haven't noticed breaking t3404.
I'm now running a full 'make test' before I send the patch.
| Jul 1, 5:55 am 2008 |
| Shawn O. Pearce | [JGIT PATCH 6/8] Support 'git upload-pack' and 'git rece ...
Within the next 6 months C git clients will begin asking remote
servers for 'git $command' rather than 'git-$command' when using the
SSH transport. This change is to allow the C git programs to be
removed from the user's $PATH, leaving only the git wrapper binary.
For the first 6 months after C git 1.6.0 gets released clients will
continue to ask for 'git-$command' but users may change that behavior
by specifically asking for 'git $command' in remote.$name.uploadpack
or ...
| Jun 30, 8:04 pm 2008 |
| Shawn O. Pearce | [JGIT PATCH 4/8] Shorten progress message text from PackWriter
There are traditionally three phases to a pack algorithm:
the enumeration phase, commonly called "Counting objects"
the delta search phase, commonly called "Compressing objects"
the output phase, commonly called "Writing objects"
Our prior messages were too long for the text progress display
and caused the progress meters to not line up vertically on the
console. The shorter (and more traditional) text does fit into
the column structure used by the text progress display.
Signed-off-by: ...
| Jun 30, 8:04 pm 2008 |
| Shawn O. Pearce | [JGIT PATCH 3/8] Refuse to create or delete funny ref na ...
If the RemoteRefUpdate requests us to create a remote name of just
"master" (say due to a bug in the push command line tool) we would do
just that, creating "$project.git/master" on the remote side. This is
not a valid ref for Git and confusion ensues when C Git tries to
operate on the same repository.
Normally these sorts of bad refs are blocked by git-receive-pack
on the remote side, but here we don't have that so we must do the
blocking as part of the push connection.
Signed-off-by: ...
| Jun 30, 8:04 pm 2008 |
| Shawn O. Pearce | [JGIT PATCH 5/8] Correctly name the stderr redirection t ...
When we open git-receive-pack for the local transport case we still
create a thread to redirect any error messages to the System.err
console. In this case the thread should be named after the command
we are running.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
.../org/spearce/jgit/transport/TransportLocal.java | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/TransportLocal.java ...
| Jun 30, 8:04 pm 2008 |
| Shawn O. Pearce | [JGIT PATCH 2/8] Delete reflog when deleting ref during ...
If we remove a ref we must also remove the reflog.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
.../spearce/jgit/transport/WalkPushConnection.java | 7 +++++++
.../jgit/transport/WalkRemoteObjectDatabase.java | 13 +++++++++++++
2 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/WalkPushConnection.java b/org.spearce.jgit/src/org/spearce/jgit/transport/WalkPushConnection.java
index f63bedd..5450b84 100644
--- ...
| Jun 30, 8:03 pm 2008 |
| Shawn O. Pearce | [JGIT PATCH 0/8] Minor push fixups
A (small by recent standards) series to fix some issues with push
in both the dumb and smart transports.
We also can now package jgit as a stand-alone shell+JAR combination;
I install this into my path and have been favoring it over C Git
for a few days now.
--
Shawn O. Pearce (8):
Correct thin pack completion in IndexPack to handle some bundles
Delete reflog when deleting ref during dumb transport push
Refuse to create or delete funny ref names over dumb transports
Shorten ...
| Jun 30, 8:03 pm 2008 |
| Shawn O. Pearce | [JGIT PATCH 1/8] Correct thin pack completion in IndexPa ...
Recently I saw a bundle with a chain of deltas to base objects as
A->B->C, where A was the delta depending on the base B. In this
pack all of the objects used OBJ_REF_DELTA to link to their base
and C was not in the pack (it was assumed to be in the repository).
Because of the ordering of the ObjectIds for B and C jgit tried to
resolve A's delta base by pulling from the repository, as B was not
found in the pack file. The reason B was not found was because it
was waiting in the queue (to be ...
| Jun 30, 8:03 pm 2008 |
| Shawn O. Pearce | [JGIT PATCH 8/8] Don't try to pack 0{40} during push of ...
`jgit push origin :refs/heads/die refs/heads/master` tries to pack
0{40} to delete branch "die" while also packing the objects needed
to update branch master. Since "die" is being removed we do not
want to pack any objects for it, as there is nothing to pack.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
.../jgit/transport/BasePackPushConnection.java | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git ...
| Jun 30, 8:04 pm 2008 |
| Shawn O. Pearce | [JGIT PATCH 7/8] Pack jgit into a portable single file c ...
On UNIX (and even Cygwin) we can package the entire jgit library into
a single JAR file and prefix that JAR with a shell script to start the
JVM, passing in the script/JAR file as the only classpath. This trick
works because the table of contents for the ZIP file is at the end of
the stream, and the JVM tends to only do random access through that
table when it looks up classes for loading.
A tiny shell script called make_jgit.sh compiles everything with the
command line javac and packages it ...
| Jun 30, 8:04 pm 2008 |
| Stephan Beyer | git sequencer prototype
Hi,
here is the patchset for the git-sequencer prototype, documentation,
test suite and a first git-am and git-rebase-i migration.
Indeed, monster patches. ;)
I'm using sequencer-based git-am and git-rebase-i and also git-sequencer
itself for around 2-3 weeks now. So, for me, it is reality-proven, but
I'm curious about your opinions/suggestions in usage and source.
The migration patches are a little hard to code-review in the diff-form,
but feel free to apply, test, and then look at the ...
| Jun 30, 7:38 pm 2008 |
| Junio C Hamano | Re: git sequencer prototype
Heh, these three typically come in different order. Look at the log
message and docs to see if the design is sound, then look at the code, and
if things overall look Ok, then finally apply and test.
I unfortunately ran out of time tonight and will look at them probably
Thursday evening. It seems that another GSoC topic is finally nearing
completion and I can shift my attention to other topics now.
By the way Christian is not CC'ed?
--
| Jul 1, 1:51 am 2008 |
| Stephan Beyer | Re: git sequencer prototype
Hmm, I usually prefer testing first (on such large patches), because I think
Shame on me, I forgot to Cc my mentors ;-)
Regards,
Stephan
--
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F
--
| Jul 1, 7:53 am 2008 |
| Jakub Narebski | Re: [RFC/PATCH 2/4] Add git-sequencer prototype documentation
Hi,
Ah. I'm sorry. So it is like "git branch <ref>", isn't it?
Ah, so squash --from <mark> picks up everything since "mark <mark>",
but does not include marked commit! Clever! In this case allowing
O.K. I guess that is something left for later, especially that
forbidding merges in squashed commit is default (and you can always
Perhaps stating that it returns 128 on fatal error, or rewording
that any other return value means some fatal error (does it?)
would be better. But ...
| Jul 1, 11:04 am 2008 |
| Jakub Narebski | Re: [RFC/PATCH 2/4] Add git-sequencer prototype documentation
I hope that it could be also used by git-cherry-pick and git-revert,
Does it run pre-commit hooks, for example checking for merge markers
Does it mean that editor will be invoked with only _unprocessed_
part of the TODO file? It looks like it, but it might be not
Nice.
Do all options make sense? What about `--index' and `--cached',
How do you squash merges? Creating merge with an union of parents,
excluding commits which got squashed?
It means
...
| Jul 1, 6:02 am 2008 |
| Stephan Beyer | git-rebase-i migration to sequencer
Hi,
the patches for rebase-i migration follow.
Why this intermediate mail?
Because the patches will not apply to master/next/pu/whatever.
It needs js/rebase-i-sequencer, that is "dropped for now" from
git.git. So you have to do some extra work to apply.
Well, I could've just added a "Squashed js/rebase-i-sequencer patch"
or something, but
1. I didn't write the patches so I don't want to claim I'm the author,
2. It's an opportunity to try sequencer, as follows:
If you still have the ...
| Jun 30, 7:39 pm 2008 |
| Stephan Beyer | [RFC/PATCH 2/4] Add git-sequencer prototype documentation
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
---
Documentation/git-sequencer.txt | 348 +++++++++++++++++++++++++++++++++++++++
1 files changed, 348 insertions(+), 0 deletions(-)
create mode 100644 Documentation/git-sequencer.txt
diff --git a/Documentation/git-sequencer.txt b/Documentation/git-sequencer.txt
new file mode 100644
index 0000000..e0c6410
--- /dev/null
+++ ...
| Jun 30, 7:38 pm 2008 |
| Stephan Beyer | [RFC/PATCH 1/4] Add git-sequencer shell prototype
git sequencer is planned as a backend for user scripts
that execute a sequence of git instructions and perhaps
need manual intervention, for example git-rebase or git-am.
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
---
Some comments:
- It's declared as plumbing, but the prototype can't really be
named "plumbing", imho, since it uses porcelain like git-commit.
- I hope it is ...
| Jun 30, 7:38 pm 2008 |
| Stephan Beyer | [RFC/PATCH 2/2] Migrate git-rebase--i to use git-sequencer
Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
---
git-rebase--interactive.sh | 423 ++++++-----------------------------------
t/t3404-rebase-interactive.sh | 29 ++--
2 files changed, 71 insertions(+), 381 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index ad16fa2..60f43b2 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -35,28 +35,13 @@ skip skip current patch and continue rebasing process
...
| Jun 30, 7:39 pm 2008 |
| Stephan Beyer | [RFC/PATCH 3/4] Add git-sequencer test suite (t3350)
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
---
Note that the --quiet tests are test_expect_failure, because I
have not really cared about the output behavior of sequencer,
and --quiet cannot be a trivial exec >/dev/null, because sometimes
editors are invoked, etc.
Also note that the fake-editor is quite different from the one
in the rebase tests. According to a "session", the file ...
| Jun 30, 7:38 pm 2008 |
| Stephan Beyer | [PATCH 1/2] Make rebase--interactive use OPTIONS_SPEC
Also add some checks that --continue/--abort/--skip
actions are used without --onto, -p, -t, etc.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
---
git-rebase--interactive.sh | 72 ++++++++++++++++++++++++++++---------------
1 files changed, 47 insertions(+), 25 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 7e073bb..ad16fa2 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -10,10 +10,27 @@
# The original idea comes ...
| Jun 30, 7:39 pm 2008 |
| Stephan Beyer | Re: [RFC/PATCH 2/4] Add git-sequencer prototype documentation
Hi,
On Tue, Jul 01, 2008 at 06:02:54AM -0700,
Right, you've already mentioned it several times. ;-)
But I haven't included it currently, because git-sequencer currently *uses*
cherry-pick/revert to pick/revert commits, and I think this can lead to
some confusion.
And, I think there also has to be some discussion, e.g.
if even the single cherry-pick/revert uses sequencer, then the behavior
changes for the user: currently you have to "git commit" after a
conflict on cherry-pick. When it uses ...
| Jul 1, 9:03 am 2008 |
| Stephan Beyer | [RFC/PATCH 4/4] Migrate git-am to use git-sequencer
This patch also adds --abort to git-am, which is just a
trivial implication of using git-sequencer.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
---
Hm, what to say here?
I have to admit that interactive mode is purely tested.
Well, I've used sequencer-based git-am for a while, but never really
used the interactive mode (except for first manual test cases).
Documentation/git-am.txt | 5 +-
git-am.sh | 552 +++++++++++++---------------------------------
git-rebase.sh ...
| Jun 30, 7:38 pm 2008 |
| Stephan Beyer | Re: [RFC/PATCH 2/4] Add git-sequencer prototype documentation
Hi,
I don't know. If something like "last created commit" is better,
Good question. The reflog is another mistery to me that I haven't really
cared about, because I haven't used it yet myself.
At least the reflog test cases for git rebase -i in the test suite pass.
Forbidding merges is default currently. It's just a sanity check. And
the option bypasses this check.
Regards,
Stephan
--
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F
--
| Jul 1, 12:50 pm 2008 |
| Raimund Bauer | Re: [PATCH] Teach "git apply" to prepend a prefix with " ...
patch uses -d or --directory
regards,
Ray
--
| Jul 1, 11:10 am 2008 |
| Johannes Schindelin | Re: [PATCH] Teach "git apply" to prepend a prefix with " ...
Hi,
Hey, "--cd=" is free! And it would make explaining easier why -p is
applied first.
Ciao,
Dscho
--
| Jul 1, 9:36 am 2008 |
| Johannes Schindelin | Re: [PATCH] Teach "git apply" to prepend a prefix with " ...
Hi,
Yeah, I am not too happy, but I saw you and hpa on IRC agreeing on that
option name. I would have said "--prefix", but that is too ambiguous,
what with "prefix" already meaning "path relative to the working directory
D'oh.
I did. An earlier version (as I found out by using the reflogs, as I tend
to do a lot these last couple of weeks) even had a "-". Musta been late.
Ciao,
Dscho
--
| Jul 1, 9:34 am 2008 |
| H. Peter Anvin | Re: [PATCH] Teach "git apply" to prepend a prefix with " ...
There is an analogous concept in patch(1), it's just implemented by
cd'ing to a subdirectory first. ;)
I think --root makes sense as the root of the patch. The other
alternative would be --add (by analogy with --strip); the biggest
advantage there is that -a, as a short option, isn't used for anything
either by git-am, git-apply, or patch.
Incidentally, has anyone talked to the patch(1) maintainers about adding
support for the git extensions, like binary patches? The main reason is ...
| Jul 1, 9:05 am 2008 |
| H. Peter Anvin | Re: [PATCH] Teach "git apply" to prepend a prefix with " ...
So it does.
-hpa
--
| Jul 1, 1:27 pm 2008 |
| H. Peter Anvin | Re: [PATCH] Teach "git apply" to prepend a prefix with " ...
Although that could imply cd'ing into another git repository to some people.
-hpa
--
| Jul 1, 9:57 am 2008 |
| Junio C Hamano | Re: [PATCH] Teach "git apply" to prepend a prefix with " ...
I looked for precedence of this concept outside git but did not find
anything that exactly matched.
The -p<num> came from patch where it is also called --strip=num. This new
option --root is about the reverse operation and it is about inserting at
the beginning --- it is rerooting, in other words, but then --root is good
enough and shorter. mkisofs uses the word "graft" when it allows tree
shifting (enabled with --graft-points), but the word "graft" means a
totally different thing to us, so ...
| Jul 1, 2:21 am 2008 |
| Jeff King | Re: [PATCH/v2] git-basis, a script to manage bases for g ...
I don't use bundles myself, so I can't comment on how useful this is for
a bundle-based workflow. But it seems like a sensible idea in general.
When a new feature depends on other, more generic improvements
to existing code, it is usually split into two patches. E.g.,
1/2: add --stdin to git-bundle
2/2: add git-basis
with the advantages that:
- it is slightly easier to review each change individually
- it is easier for other features to build on the generic improvement
...
| Jul 1, 2:51 am 2008 |
| Junio C Hamano | Re: [PATCH] bisect: error out when given any good rev th ...
I do not see much niceness value to such an option, though. I think such
a switch is going the opposite way from improving usability.
You cannot bisect the history with such a draconian switch when you learn
from somebody that 'maint' is Ok but 'master' is broken, and you already
know it is a regression somewhere introduced in 'master', because you know
you did _not_ fix it (or at least you do not remember fixing it) only for
'maint'.
--
| Jun 30, 6:13 pm 2008 |
| Christian Couder | Re: [PATCH] bisect: error out when given any good rev th ...
Yeah, perhaps we should then check that it can be a mistake by testing if
bad is an ancestor of good. If bad is indeed an ancestor of good, it's
probably a mistake and we may even ask if the user wants good and bad to be
Yes this can be a good idea, if the user gave only one good rev. It maybe
more tricky if he gave many good revs, but in this case we may perhaps drop
Yeah that might be a plan.
Another option is to introduce a switch to "git bisect start",
perhaps --strict, to ...
| Jun 30, 5:20 pm 2008 |
| Kristian | Re: What's cooking in git.git (topics)
Yeah, that's one reason, my main problem with .git/branches is that for
a user that wants to learn about git and peeks into .git it's pretty
confusing. "I wonder where and how git stores the information about
branches... oh look, .git/branches, that must it... hmm, wait no..."
Git is still getting a lot of bad-mouthing for being hard to learn and
inconsitent. I think it makes sense to push git towards consistency and
simplicity (where is doesn't affect the flexibility) and this seemed
like a ...
| Jul 1, 8:44 am 2008 |
| Stephen Rothwell | Re: What's cooking in git.git (topics)
I use "git remote add" for each new repository and haven't had anything
in the branches directory of any of my trees for a long time ...
--=20
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
| Jun 30, 5:57 pm 2008 |
| J. Bruce Fields | Re: [PATCH 3/7] Documentation: complicate example of "ma ...
Is this confusion really common?
I can see how it might be possible in the case of a subcommand that
itself has subcommands, but it seems less likely in the two examples you
add below (where the third token is an option or a url). I like your
"git svn" example better. Or "git remote" might be good.
--
| Jul 1, 9:23 am 2008 |
| Junio C Hamano | Re: [PATCH 0/7] Some superficial documentation changes
Yes, the earlier "line break adjustments" patch really helped.
I've queued all of them to 'pu' while reading them over, except for the
last one. I did not look very carefully, but the parts I did look at made
sense.
In general, I've always preferred to see command names "git-foo" typeset
in teletype face, consistent with examples (also typeset in tt), because
they are both something the end users are expected to type. With this
transition, we are however making "git-foo" not something ...
| Jul 1, 1:42 am 2008 |
| Olivier Marin | Re: [RFC/PATCH 7/7] Documentation formatting and cleanup
Are those kind of changes really an improvement?
but the file does not compile, now.
Olivier.
--
| Jul 1, 6:09 am 2008 |
| Junio C Hamano | Re: [RFC/PATCH 7/7] Documentation formatting and cleanup
There are other places with the same breakage.
You would need something like this (using the {asterisk} macro I
wrote for updating the docs for another topic). The patch shows only a
single use location but there are others in the same file.
diff --git a/Documentation/asciidoc.conf b/Documentation/asciidoc.conf
index 10c1a15..40d43b7 100644
--- a/Documentation/asciidoc.conf
+++ b/Documentation/asciidoc.conf
@@ -8,6 +8,7 @@
# the command.
[attributes]
+asterisk=&#42;
plus=&#43;
...
| Jul 1, 2:34 pm 2008 |
| Junio C Hamano | Re: Multiple remote.<...>.fetch and .push patterns
I'd actually suggest:
$ edit .git/config
and create this section:
[remote "ko"]
url = master.kernel.org:/pub/scm/git/git.git/
fetch = +refs/heads/*:refs/remotes/ko/*
push = heads/master
push = heads/next
push = +heads/pu
push = heads/maint
(I used to say ko-master but these days I say ko/master).
--
| Jul 1, 2:27 am 2008 |
| Jakub Narebski | Re: Multiple remote.<...>.fetch and .push patterns
remote.<name>.fetch in config is equivalent of "Pull:" line in
$GIT_DIR/remotes/<name>, while remote.<name>.push in config is
eqiovalent of "Push:" line in $GIT_DIR/remotes/<name>.
--
Jakub Narebski
Poland
ShadeHawk on #git
--
| Jul 1, 6:04 am 2008 |
| Michael J Gruber | Re: Multiple remote.<...>.fetch and .push patterns
Sure, it just seemed OP wanted cut-n-paste commands for his co-workers
OK, that would make it ko/workers above ;)
Seriously: I found the info about those config keys in "git-push.1";
it's also in "git-{pull,fetch}.1". I would expect that info to be in
"git-{remote,config}.1". The latter points to it, the former not really.
Michael
--
| Jul 1, 2:59 am 2008 |
| Michael J Gruber | Re: Multiple remote.<...>.fetch and .push patterns
The files under remotes are the old way of configuring remotes (see git
help push). The new are config lines in the remotes section, as written
by "git remote". I don't think "git remote" can write the lines you
want, so I'd suggest:
git config remote.ko.url kernel.org:/pub/scm/git/git.git
git config remote.ko.fetch refs/heads/master:refs/tags/ko-master
git config --add remote.ko.fetch refs/heads/next:refs/tags/ko-next
git config --add remote.ko.fetch ...
| Jul 1, 2:00 am 2008 |
| Melchior FRANZ | Re: [RFC] Single system account for multiple git users
Indeed. This is AFAIK the main reason why git might not be used
by a project where I'm contributor. gitosis could help here, but
I guess that a built-in solution would be preferred. An external
addon looks a bit like band-aid. ;-)
m.
--
| Jul 1, 1:55 am 2008 |
| Thomas Rast | [PATCH] git-add--interactive: manual hunk editing mode
Adds a new option 'e' to the 'add -p' command loop that lets you edit
the current hunk in your favourite editor.
If the resulting patch applies cleanly, the edited hunk will
immediately be marked for staging. If it does not apply cleanly, you
will be given an opportunity to edit again. If all lines of the hunk
are removed, then the edit is aborted and the hunk is left unchanged.
Applying the changed hunk(s) relies on Johannes Schindelin's new
--recount option for git-apply.
Note that the ...
| Jul 1, 4:44 am 2008 |
| Jeff King | Re: What's cooking in git.git (topics)
Thomas,
Now that this is in next, maybe it is a good time to repost the
add--interactive patch (it should be independent of Dscho's 2/2 "add -e"
patch).
-Peff
--
| Jul 1, 3:11 am 2008 |
| Johannes Schindelin | Re: [PATCH] git-add--interactive: manual hunk editing mode
Hi,
He will not :-)
Ciao,
Dscho
--
| Jul 1, 9:48 am 2008 |
| Clifford Caoile | Re: [msysGit] Re: How to reduce remaining differences to ...
Hi:
As one of the extra patches in 4msysgit, there is the cca/git.el
branch [1] which I contributed [2] previously for Emacs git.el users
on Windows. However I have not gotten any feedback whatsoever, so
perhaps parking it in 4msysgit is not appropriate. I plan to
separately to host these patch(es). Please ignore it or remove it at
your convenience.
References:
[1] http://repo.or.cz/w/git/mingw/4msysgit.git?a=shortlog;h=refs/heads/cca/git.el
[2] ...
| Jun 30, 5:03 pm 2008 |
| Miklos Vajna | [PATCH 00/14] Build in merge
Sorry for the resend, but I again squashed an unrelated hunk to the last
patch, so I'm sending the changed patches:
08: Add new test to ensure git-merge handles more than 25 refs.
13: git-commit-tree: make it usable from other builtins
14: Build in merge
I really hope I won't overlook this next time.
The interdiff from the previous version is empty, I just moved that
unrelated hunk from patch 13 to patch 08.
Junio C Hamano (2):
Introduce get_merge_bases_many()
Introduce ...
| Jun 30, 7:37 pm 2008 |
| Johannes Schindelin | Re: [PATCH 13/14] git-commit-tree: make it usable from o ...
Hi,
Oh, sorry!
Funnily enough, I committed and tested this change in my clone of
builtin-merge before I realized that I am in the wrong directory ;-)
Ciao,
Dscho
--
| Jun 30, 10:07 pm 2008 |
| Miklos Vajna | [PATCH 13/14] git-commit-tree: make it usable from other ...
Move all functionality (except option parsing) from cmd_commit_tree() to
commit_tree(), so that other builtins can use it without a child
process.
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
builtin-commit-tree.c | 71 ++++++++++++++++++++++++++++--------------------
builtin.h | 4 +++
2 files changed, 45 insertions(+), 30 deletions(-)
diff --git a/builtin-commit-tree.c b/builtin-commit-tree.c
index 3881f6c..7a9a309 100644
--- a/builtin-commit-tree.c
+++ ...
| Jun 30, 7:37 pm 2008 |
| Junio C Hamano | Re: [PATCH 13/14] git-commit-tree: make it usable from o ...
That's a bad practice. It makes it much harder to review the incremental
changes from the previous round.
I'll cope, though.
--
| Jun 30, 10:50 pm 2008 |
| Miklos Vajna | [PATCH 08/14] Add new test to ensure git-merge handles m ...
The old shell version handled only 25 refs but we no longer have this
limitation. Add a test to make sure this limitation will not be
introduced again in the future.
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
t/t7602-merge-octopus-many.sh | 52 +++++++++++++++++++++++++++++++++++++++++
1 files changed, 52 insertions(+), 0 deletions(-)
create mode 100755 t/t7602-merge-octopus-many.sh
diff --git a/t/t7602-merge-octopus-many.sh b/t/t7602-merge-octopus-many.sh
new file mode ...
| Jun 30, 7:37 pm 2008 |
| Miklos Vajna | Re: [PATCH 13/14] git-commit-tree: make it usable from o ...
Sorry. I just did this way because in my patch I wanted to let
cmd_commit_tree() use a commit_list and I saw Dscho already did it, and
Thanks.
| Jul 1, 5:09 am 2008 |
| Miklos Vajna | [PATCH 14/14] Build in merge
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
Interdiff since the previous version:
git diff fab9109..b86e8ad
Individual commits:
git log b86e8ad
Makefile | 2 +-
builtin-merge.c | 1148 +++++++++++++++++++++++++
builtin.h | 1 +
git-merge.sh => contrib/examples/git-merge.sh | 0
...
| Jun 30, 7:22 pm 2008 |
| Miklos Vajna | [PATCH 14/14] Build in merge
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
Makefile | 2 +-
builtin-merge.c | 1148 +++++++++++++++++++++++++
builtin.h | 1 +
git-merge.sh => contrib/examples/git-merge.sh | 0
git.c | 1 +
5 files changed, 1151 insertions(+), 1 deletions(-)
create mode 100644 ...
| Jun 30, 7:37 pm 2008 |
| Miklos Vajna | Re: [PATCH 13/13] Build in merge
e".
I just realized that builtin-reset forks read-tree as well, so I did
Ah, and this way I don't need memrchr(), which was pointed out to be
Right. Now I do
strbuf_addstr(&truname, "refs/heads/");
Before appending the remote name to truname, so that should exclude
Now if the second token is a valid SHA1 then I die() if it's not a
Yes, now it's just:
Thanks, that was the case. I thought "false || exit" exits with status
Done.
| Jun 30, 7:13 pm 2008 |
| Miklos Vajna | Re: [PATCH 14/14] Build in merge
You are right. I though we care about it, but now I realized such a
comment was only in git-merge.annotated (in Dscho's fork), not in
git-merge.sh. And yes, I mixed up head_invalid for two purposes. Thanks
Now he/she does. :-)
(I updated my working branch on repo.or.cz, will send a patch soon, as
well.)
| Jul 1, 5:50 am 2008 |
| Miklos Vajna | [PATCH 14/14] Build in merge
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
Interdiff: git diff 01a7dae..7709df7
Individual commits (there is only one change this time): git log 7709df7
Ah and please don't forget to apply the testsuite fix I sent in
$gmane/86981. (Or is it easier if I resend the whole series?)
Makefile | 2 +-
builtin-merge.c | 1158 ...
| Jul 1, 6:18 am 2008 |
| Miklos Vajna | [PATCH 13/14] git-commit-tree: make it usable from other ...
Move all functionality (except option parsing) from cmd_commit_tree() to
commit_tree(), so that other builtins can use it without a child
process.
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
This patch is against master, you need to pull from me or first rebase
mv/merge-in-c against current master.
I did it this way to avoid an unnecessary conflict with Dscho's recent
patch to commit-tree (ef98c5c).
builtin-commit-tree.c | 71 ...
| Jun 30, 7:22 pm 2008 |
| Junio C Hamano | Re: [PATCH 14/14] Build in merge
Wait a minute... Are you calling a detached HEAD as head_invalid here? I
Which is about HEAD pointing at a branch that isn't born yet. They are
two very different concepts.
Either the above "else if (head_invalid)" is wrong, or more likely the
setting of head_invalid we saw earlier is wrong.
Probably what you meant was:
- "char *branch" points at either "HEAD" (when detached) or
the name of the branch (e.g. "master" when "refs/heads/master");
- "unsigned char head[]" ...
| Jun 30, 11:23 pm 2008 |
| Olivier Croquette | Re: Patches for qgit on MacOS X
Sure you can, it is just because I overlooked the existence of the
version 2 :)
After compiling qt4-mac from source (it took quite some time), I have
been able to compile qgit2 too without a hitch, so I guess the patch is
irrelevant for qgit2. Are you using a different mechanism to access the
environment?
--
| Jul 1, 1:05 am 2008 |
| Steffen Prohaska | Re: [ANNOUNCE] GIT 1.5.6.1
The msysgit release is available at
http://code.google.com/p/msysgit/downloads
Besides GIT 1.5.6.1, the installer also brings an updated
msys-1.0.dll that works on Vista.
Steffen
--
| Jul 1, 4:29 am 2008 |
| Karl | Re: [StGit PATCH 03/14] Write to a stack log when stack ...
I had an even better idea: no default value. Every caller gets to say
either log = True or log = False, which makes it immediately obvious
to the reader. (That is, every caller still using the old
infrastructure; with the new infrastructure, we log if and only if a
transaction is run.)
--
Karl Hasselström, kha@treskal.com
www.treskal.com/kalle
--
| Jul 1, 1:13 pm 2008 |
| previous day | today | next day |
|---|---|---|
| June 30, 2008 | July 1, 2008 | July 2, 2008 |
