Re: squashing patches

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Monday, June 9, 2008 - 12:34 pm

Stephan Beyer <s-beyer@gmx.net> writes:


I actually expected that the primitive command sequence the backward
compatible "edit" would expand to would be a pair, "pick" followed by
"pause".  Whenever the sequencer sees "pause", it does not do anything but
reports the current HEAD and gives the control back to the user, so that
the user can do amend or whatever before telling you to --continue.

Similarly, I expected the backward-compatible "squash" to expand to a
pair, "pick" followed by "zucchini 2".  Whenever the sequencer sees
"zucchini <n>", it prepares a commit log to describe the top <n> commits,
resets HEAD back by <n> commits, and gives control to your editor.

About the other parts in your original message:

 - The "tag" command looked a little out of place;

 - I would have called your "file" command "patch" (we might want to have
   another file related operation later).

 - The --author option presumably would be to lie about the authorship but
   without taking it from an existing commit.  (1) Don't you need to have
   an option similar to -C option of "git-commit"?  (2) Don't you need to
   also be able to lie about the author timestamp?



--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] git-sequencer.txt, Stephan Beyer, (Sat Jun 7, 3:01 pm)
squashing patches (was: Re: [RFC] git-sequencer.txt), Stephan Beyer, (Mon Jun 9, 4:45 am)
Re: squashing patches (was: Re: [RFC] git-sequencer.txt), Johannes Schindelin, (Mon Jun 9, 7:04 am)
Re: squashing patches, Paolo Bonzini, (Mon Jun 9, 8:10 am)
Re: squashing patches, Paolo Bonzini, (Mon Jun 9, 8:43 am)
Re: squashing patches, Stephan Beyer, (Mon Jun 9, 9:29 am)
Re: squashing patches, Paolo Bonzini, (Mon Jun 9, 9:37 am)
Re: [RFC] git-sequencer.txt, Jakub Narebski, (Mon Jun 9, 9:49 am)
Re: squashing patches, Junio C Hamano, (Mon Jun 9, 12:34 pm)
[RFC/PATCH] Add git-squash tool and tests, Stephan Beyer, (Mon Jun 9, 1:29 pm)
Re: [RFC/PATCH] Add git-squash tool and tests, Johannes Schindelin, (Mon Jun 9, 1:34 pm)
Re: squashing patches, Stephan Beyer, (Mon Jun 9, 1:43 pm)
Re: squashing patches, Jeff King, (Mon Jun 9, 1:53 pm)
Re: [RFC/PATCH] Add git-squash tool and tests, Paolo Bonzini, (Mon Jun 9, 1:53 pm)
Re: squashing patches, Junio C Hamano, (Mon Jun 9, 2:02 pm)
Re: [RFC/PATCH] Add git-squash tool and tests, Johannes Schindelin, (Mon Jun 9, 2:34 pm)
Re: [RFC/PATCH] Add git-squash tool and tests, Stephan Beyer, (Mon Jun 9, 4:42 pm)
Re: [RFC/PATCH] Add git-squash tool and tests, Stephan Beyer, (Mon Jun 9, 4:46 pm)
Re: squashing patches, Stephan Beyer, (Mon Jun 9, 4:57 pm)
Re: [RFC/PATCH] Add git-squash tool and tests, Johannes Schindelin, (Mon Jun 9, 5:26 pm)
Re: squashing patches, Stephan Beyer, (Mon Jun 9, 5:38 pm)
Re: squashing patches, Jeff King, (Mon Jun 9, 6:00 pm)
Re: [RFC] git-sequencer.txt, Stephan Beyer, (Mon Jun 9, 6:21 pm)
Re: [RFC] git-sequencer.txt, Christian Couder, (Mon Jun 9, 9:46 pm)
Re: [RFC] git-sequencer.txt, Jakub Narebski, (Mon Jun 9, 11:17 pm)
Re: [RFC] git-sequencer.txt, Stephan Beyer, (Tue Jun 10, 1:59 am)
Re: [RFC] git-sequencer.txt, Christian Couder, (Tue Jun 10, 9:10 pm)
Re: [RFC] git-sequencer.txt, Daniel Barkalow, (Wed Jun 11, 10:07 am)
[RFCv2/FYI] git-sequencer.txt, Stephan Beyer, (Wed Jun 11, 5:22 pm)
Re: [RFCv2/FYI] git-sequencer.txt, Paolo Bonzini, (Wed Jun 11, 6:31 pm)
Re: [RFCv2/FYI] git-sequencer.txt, Junio C Hamano, (Wed Jun 11, 10:16 pm)
Re: [RFCv2/FYI] git-sequencer.txt, Jakub Narebski, (Thu Jun 12, 7:10 am)
Re: [RFCv2/FYI] git-sequencer.txt, Stephan Beyer, (Thu Jun 12, 8:29 am)
Re: [RFCv2/FYI] git-sequencer.txt, Paolo Bonzini, (Thu Jun 12, 8:56 am)
Re: [RFCv2/FYI] git-sequencer.txt, Stephan Beyer, (Thu Jun 12, 10:07 am)
Re: [RFCv2/FYI] git-sequencer.txt, Stephan Beyer, (Thu Jun 12, 10:20 am)
Re: [RFCv2/FYI] git-sequencer.txt, Paolo Bonzini, (Thu Jun 12, 10:04 pm)
Re: [RFCv2/FYI] git-sequencer.txt, Stephan Beyer, (Fri Jun 13, 5:16 am)
Re: [RFCv2/FYI] git-sequencer.txt, Paolo Bonzini, (Fri Jun 13, 7:42 am)
Re: [RFCv2/FYI] git-sequencer.txt, Olivier Marin, (Fri Jun 13, 12:24 pm)