Re: [PATCH v3] git-add--interactive: manual hunk editing mode

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <git@...>
Cc: Johannes Schindelin <Johannes.Schindelin@...>, Thomas Rast <trast@...>, Jeff King <peff@...>, Junio C Hamano <gitster@...>
Date: Monday, June 9, 2008 - 1:46 am

On Monday 09 June 2008, Johannes Schindelin wrote:

Is there a good reason against having *both*?

AFAICS, there's nothing stopping us from having both a "-e"-option to 
git-add, and an "e"-command inside git-add--interactive.

...just like we have "-p" and "p" today...

("git-add -e" would open the entire diff in an editor, as would "e" from the 
*main* menu of git-add--interactive. However, "e" from the *single hunk* 
menu would of course open only that single hunk within the editor. We could 
even have an "E" command to open all remaining/undecided hunks in an 
editor.)


Have fun! :)

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] git-add--interactive: manual hunk editing mode, Thomas Rast, (Fri May 23, 4:21 pm)
Re: [PATCH] git-add--interactive: manual hunk editing mode, Johannes Schindelin, (Thu May 29, 12:12 pm)
Re: [PATCH v3] git-add--interactive: manual hunk editing mode, Johannes Schindelin, (Sun Jun 8, 7:19 pm)
Re: [PATCH v3] git-add--interactive: manual hunk editing mode, Johan Herland, (Mon Jun 9, 1:46 am)
Re: [PATCH v3] git-add--interactive: manual hunk editing mode, Andreas Ericsson, (Tue Jun 10, 7:19 am)
Re: [PATCH v4] git-add--interactive: manual hunk editing mode, Johannes Schindelin, (Mon Jun 23, 2:54 pm)
apply --recount, was Re: [PATCH v4] git-add--interactive: ma..., Johannes Schindelin, (Mon Jun 23, 5:16 pm)
Re: [PATCH 1/3] Allow git-apply to ignore the hunk headers (..., Johannes Schindelin, (Fri Jun 27, 1:43 pm)
[PATCH 0/3] Manual editing for 'add' and 'add -p', Thomas Rast, (Tue Jun 24, 3:07 pm)
Re: [PATCH 0/3] Manual editing for 'add' and 'add -p', Miklos Vajna, (Tue Jun 24, 3:53 pm)
Re: [PATCH v3] git-add--interactive: manual hunk editing mode, Johannes Schindelin, (Mon Jun 9, 12:13 pm)
Re: [RFC PATCH] git-add--interactive: manual hunk editing mo..., Johannes Schindelin, (Thu Jun 5, 6:28 am)
Re: [RFC PATCH] git-add--interactive: manual hunk editing mo..., Johannes Schindelin, (Fri Jun 6, 10:31 am)
Re: [RFC PATCH] git-add--interactive: manual hunk editing mo..., Johannes Schindelin, (Sun Jun 8, 7:02 pm)
Re: [RFC PATCH] git-add--interactive: manual hunk editing mo..., Johannes Schindelin, (Sun Jun 8, 7:06 pm)
Re: [PATCH] git-add--interactive: manual hunk editing mode, Junio C Hamano, (Fri May 30, 5:35 pm)
Re: [PATCH] git-add--interactive: manual hunk editing mode, Johannes Schindelin, (Fri May 30, 5:49 am)
Re: [PATCH] git-add--interactive: manual hunk editing mode, Jakub Narebski, (Fri May 30, 6:46 am)