Re: [PATCH] remote show: fix the -n option

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Johannes Schindelin <Johannes.Schindelin@...>
Cc: Junio C Hamano <gitster@...>, <git@...>
Date: Monday, June 9, 2008 - 12:16 am

Johannes Schindelin a écrit :

Am I wrong if I say that dry run is for commands that modify something? For
example there is no "diff --dry-run" probably because diff does not change
anything. A dry run has no real meaning for diff.

This the same for "git remote show": it's a read-only command, it just display
a summary of the remote and does not modify anything. With -n, it just skips
the ls-remote (read-only) step and yes the result can be different, some parts
can be missing. Exactly like "route -n", we skip the dns resolution, the host
names are missing.

Now, if we talk about "prune", I completely agree. A --dry-run flag make sens.
But it's not the same thing than the "show -n" one. For what reason would I
want to ask "prune" to skip the ls-remote step? What I would find more useful
is to make "prune" show what it is doing (like "update") and add a --dry-run
option to say "just show me, but do not touch anything". And we can even add a
-p flag to "update" to say "prune at the same time".


Will fix. (my tabs were only 4 spaces long)


I don't understand. Is it ok or not?

Thanks for your comments,
Olivier.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
remote show/prune: strange -n(--dry-run) option., Olivier Marin, (Sat Jun 7, 8:54 pm)
[PATCH] remote show: fix the -n option, Olivier Marin, (Sun Jun 8, 8:48 pm)
[PATCH v2] remote show: fix the -n option, Olivier Marin, (Mon Jun 9, 11:58 am)
Re: [PATCH v2] remote show: fix the -n option, Johannes Schindelin, (Mon Jun 9, 12:35 pm)
Re: [PATCH v2] remote show: fix the -n option, Junio C Hamano, (Mon Jun 9, 9:10 pm)
[PATCH 0/4] remote show/prune improvement, Olivier Marin, (Tue Jun 10, 10:50 am)
Re: [PATCH 0/4] remote show/prune improvement, Jakub Narebski, (Tue Jun 10, 11:09 am)
Re: [PATCH 0/4] remote show/prune improvement, Olivier Marin, (Tue Jun 10, 12:10 pm)
Re: [PATCH 0/4] remote show/prune improvement, Jakub Narebski, (Tue Jun 10, 1:11 pm)
[PATCH 1/4] remote show: fix the -n option, Olivier Marin, (Tue Jun 10, 10:51 am)
Re: [PATCH v2] remote show: fix the -n option, Shawn O. Pearce, (Mon Jun 9, 9:19 pm)
Re: [PATCH v2] remote show: fix the -n option, Johannes Schindelin, (Mon Jun 9, 10:39 pm)
Re: [PATCH v2] remote show: fix the -n option, Olivier Marin, (Mon Jun 9, 12:58 pm)
Re: [PATCH v2] remote show: fix the -n option, Johannes Schindelin, (Mon Jun 9, 1:56 pm)
Re: [PATCH v2] remote show: fix the -n option, Olivier Marin, (Mon Jun 9, 2:37 pm)
[PATCH] builtin-remote: make reuse of code easier by not die..., Johannes Schindelin, (Mon Jun 9, 4:11 pm)
Re: [PATCH] remote show: fix the -n option, Johannes Schindelin, (Sun Jun 8, 9:16 pm)
Re: [PATCH] remote show: fix the -n option, Olivier Marin, (Sun Jun 8, 10:06 pm)
Re: [PATCH] remote show: fix the -n option, Johannes Schindelin, (Sun Jun 8, 10:35 pm)
Re: [PATCH] remote show: fix the -n option, Olivier Marin, (Mon Jun 9, 12:16 am)
Re: [PATCH] remote show: fix the -n option, Johannes Schindelin, (Mon Jun 9, 12:53 am)
Re: [PATCH] remote show: fix the -n option, Olivier Marin, (Mon Jun 9, 10:22 am)
Re: [PATCH] remote show: fix the -n option, Olivier Marin, (Mon Jun 9, 11:43 am)
Re: [PATCH] remote show: fix the -n option, Johannes Schindelin, (Mon Jun 9, 12:31 pm)