Re: [JGIT PATCH v3 0/23] Implementation of a file tree iteration using ignore rules.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Florian Köberle
Date: Sunday, June 8, 2008 - 9:37 am

>> Unsupported are colon expressions like ":alpha:". I didn't expect git-add to support it, but as I just noticed git does.
Just did some tests and noted that the shell and git does not support 
them. I guess I thought that they work because [:alpha:] matched "a".

Hi Robin

The bash shell doesn't support [:alpha:] too:
$ mkdir test
$ cd test
$ touch a
$ touch b
$ touch :
$ ls [:alpha:]
:  a

The fnmatch function of the python module fnmatch 
(http://docs.python.org/lib/module-fnmatch.html) does not support 
:alpha: too.

example:
$python
 >>> from fnmatch import fnmatch
 >>> fnmatch("a","[:alpha:]")
False

So I see no reason for displaying a warning.

Best regards,
Florian
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[JGIT PATCH v3 02/23] Added the class FileNameMatcher and ..., Florian Koeberle, (Fri May 23, 1:34 pm)
[JGIT PATCH v3 03/23] Added the interface FilePattern., Florian Koeberle, (Fri May 23, 1:34 pm)
[JGIT PATCH v3 04/23] Added the class Rule., Florian Koeberle, (Fri May 23, 1:34 pm)
[JGIT PATCH v3 05/23] Added the iterface Rules., Florian Koeberle, (Fri May 23, 1:34 pm)
[JGIT PATCH v3 06/23] Added the class FileNamePattern., Florian Koeberle, (Fri May 23, 1:34 pm)
[JGIT PATCH v3 07/23] Added the class FilePathPattern., Florian Koeberle, (Fri May 23, 1:34 pm)
[JGIT PATCH v3 08/23] Added the class IgnoreRuleListFactory., Florian Koeberle, (Fri May 23, 1:34 pm)
[JGIT PATCH v3 12/23] Added the class AddRuleListFactory., Florian Koeberle, (Fri May 23, 1:34 pm)
[JGIT PATCH v3 13/23] Formatted Constants class., Florian Koeberle, (Fri May 23, 1:34 pm)
[JGIT PATCH v3 15/23] Added class AddRulesFactory., Florian Koeberle, (Fri May 23, 1:34 pm)
[JGIT PATCH v3 17/23] Added class LightFileTreeIterable., Florian Koeberle, (Fri May 23, 1:34 pm)
[JGIT PATCH v3 18/23] Added path related constants to the ..., Florian Koeberle, (Fri May 23, 1:34 pm)
[JGIT PATCH v3 21/23] Formatted Repository class., Florian Koeberle, (Fri May 23, 1:34 pm)
Re: [JGIT PATCH v3 05/23] Added the iterface Rules., Robin Rosenberg, (Thu Jun 5, 5:22 pm)
Re: [JGIT PATCH v3 06/23] Added the class FileNamePattern., Robin Rosenberg, (Thu Jun 5, 5:22 pm)
Re: [JGIT PATCH v3 21/23] Formatted Repository class., Robin Rosenberg, (Thu Jun 5, 5:23 pm)
Re: [JGIT PATCH v3 0/23] Implementation of a file tree ite ..., Florian Köberle, (Sun Jun 8, 9:37 am)