Home » Mailing list archives » git » 2008 » June » 6

Re: [PATCH v3 0/2] git add --edit

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Johannes Schindelin
Subject: Re: [PATCH v3 0/2] git add --edit
Date: Friday, June 6, 2008 - 6:59 am

Hi,

On Thu, 5 Jun 2008, Junio C Hamano wrote:


Yes, it did.  In my tests, I did not realize that the "line" parameter was 
set just after the second "@@" in the hunk header.  Therefore, the code 
counted a space at the beginning of the hunk header comment as a common 
line.

In my later tests, I finally realized my error, and changed the code.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/2] Allow git-apply to fix up the line counts, Johannes Schindelin, (Thu Jun 5, 3:16 am)
[PATCH 2/2] git-add: introduce --edit (to edit the diff vs ..., Johannes Schindelin, (Thu Jun 5, 3:17 am)
Re: [PATCH 1/2] Allow git-apply to fix up the line counts, Johannes Sixt, (Thu Jun 5, 4:24 am)
Re: [PATCH 1/2] Allow git-apply to fix up the line counts, Johannes Schindelin, (Thu Jun 5, 6:04 am)
Re: [PATCH 1/2] Allow git-apply to fix up the line counts, Johannes Sixt, (Thu Jun 5, 6:36 am)
Re: [PATCH 1/2] Allow git-apply to fix up the line counts, Johannes Schindelin, (Thu Jun 5, 6:47 am)
Re: [PATCH 1/2] Allow git-apply to fix up the line counts, Johannes Sixt, (Thu Jun 5, 7:13 am)
Re: [PATCH 1/2] Allow git-apply to fix up the line counts, Johannes Schindelin, (Thu Jun 5, 7:54 am)
Re: [PATCH 1/2] Allow git-apply to fix up the line counts, Johannes Sixt, (Thu Jun 5, 8:07 am)
[PATCH v2 0/2] git add --edit, Johannes Schindelin, (Thu Jun 5, 9:19 am)
[PATCH v2 1/2] Allow git-apply to ignore the hunk headers, Johannes Schindelin, (Thu Jun 5, 9:20 am)
[PATCH v2 2/2] git-add: introduce --edit (to edit the diff ..., Johannes Schindelin, (Thu Jun 5, 9:20 am)
Re: [PATCH v2 2/2] git-add: introduce --edit (to edit the ..., Pieter de Bie, (Thu Jun 5, 11:12 am)
Re: [PATCH 1/2] Allow git-apply to fix up the line counts, Junio C Hamano, (Thu Jun 5, 11:39 am)
Re: [PATCH v2 1/2] Allow git-apply to ignore the hunk headers, Junio C Hamano, (Thu Jun 5, 2:16 pm)
Re: [PATCH v2 1/2] Allow git-apply to ignore the hunk headers, Johannes Schindelin, (Thu Jun 5, 3:39 pm)
[PATCH v3 0/2] git add --edit, Johannes Schindelin, (Thu Jun 5, 4:06 pm)
[PATCH v3 1/2] Allow git-apply to ignore the hunk headers ..., Johannes Schindelin, (Thu Jun 5, 4:06 pm)
[PATCH v3 2/2] git-add: introduce --edit (to edit the diff ..., Johannes Schindelin, (Thu Jun 5, 4:07 pm)
Re: [PATCH v2 1/2] Allow git-apply to ignore the hunk headers, Junio C Hamano, (Thu Jun 5, 4:22 pm)
Re: [PATCH v2 1/2] Allow git-apply to ignore the hunk headers, Johannes Schindelin, (Thu Jun 5, 4:36 pm)
Re: [PATCH v3 1/2] Allow git-apply to ignore the hunk head ..., Junio C Hamano, (Thu Jun 5, 9:55 pm)
Re: [PATCH v3 0/2] git add --edit, Junio C Hamano, (Thu Jun 5, 9:55 pm)
Re: [PATCH v3 1/2] Allow git-apply to ignore the hunk head ..., Govind Salinas, (Thu Jun 5, 10:18 pm)
Re: [PATCH v2 1/2] Allow git-apply to ignore the hunk headers, Paolo Bonzini, (Fri Jun 6, 12:02 am)
Re: [PATCH v3 2/2] git-add: introduce --edit (to edit the ..., Olivier Marin, (Fri Jun 6, 3:02 am)
Re: [PATCH v2 1/2] Allow git-apply to ignore the hunk headers, Sergei Organov, (Fri Jun 6, 3:33 am)
Re: [PATCH v3 1/2] Allow git-apply to ignore the hunk head ..., Johannes Schindelin, (Fri Jun 6, 6:58 am)
Re: [PATCH v3 0/2] git add --edit, Johannes Schindelin, (Fri Jun 6, 6:59 am)
Re: [PATCH v3 1/2] Allow git-apply to ignore the hunk head ..., Johannes Schindelin, (Fri Jun 6, 7:00 am)
Re: [PATCH v2 1/2] Allow git-apply to ignore the hunk headers, Johannes Schindelin, (Fri Jun 6, 7:04 am)
Re: [PATCH v3 2/2] git-add: introduce --edit (to edit the ..., Johannes Schindelin, (Fri Jun 6, 7:21 am)
Re: [PATCH v2 1/2] Allow git-apply to ignore the hunk headers, Johannes Schindelin, (Fri Jun 6, 7:27 am)
Re: [PATCH v2 1/2] Allow git-apply to ignore the hunk headers, Junio C Hamano, (Fri Jun 6, 8:14 am)
Re: [PATCH v3 1/2] Allow git-apply to ignore the hunk head ..., Junio C Hamano, (Fri Jun 6, 8:34 am)
Re: [PATCH v3 1/2] Allow git-apply to ignore the hunk head ..., Junio C Hamano, (Fri Jun 6, 9:13 am)
Re: [PATCH v3 1/2] Allow git-apply to ignore the hunk head ..., Johannes Schindelin, (Fri Jun 6, 9:37 am)
Re: [PATCH v3 1/2] Allow git-apply to ignore the hunk head ..., Junio C Hamano, (Fri Jun 6, 9:46 am)
Re: [PATCH v3 1/2] Allow git-apply to ignore the hunk head ..., Johannes Schindelin, (Fri Jun 6, 10:35 am)