Home » Mailing list archives » git » 2008 » June » 28

Re: [PATCH] Revert "git-svn: Speed up fetch"

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Mikael Magnusson <mikachu@...>
To: Avery Pennarun <apenwarr@...>
Cc: Eric Wong <normalperson@...>, Adam Roben <aroben@...>, Samuel Bronson <naesten@...>, <B.Steinbrink@...>, <git@...>
Subject: Re: [PATCH] Revert "git-svn: Speed up fetch"
Date: Saturday, June 28, 2008 - 7:51 pm

2008/6/28 Avery Pennarun <apenwarr@gmail.com>:

Wasn't this the problem that was fixed by
d683a0e00cd4734b4fab704baef1ee76205722be[1]?

-- 
Mikael Magnusson

[1]

commit d683a0e00cd4734b4fab704baef1ee76205722be
Author: Junio C Hamano <gitster@pobox.com>
Date:   Tue May 27 23:33:22 2008 -0700

    Git::cat_blob: allow using an empty blob to fix git-svn breakage

    Recent "git-svn optimization" series introduced Git::cat_blob() subroutine
    whose interface was broken in that it returned the size of the blob but
    signalled an error by returning 0.  You can never use an empty blob with
    such an interface.

    This fixes the interface to return a negative value to signal an error.

    Reported by Björn Steinbrink.

    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
git-svn messed up import, badly, Björn, (Sat Jun 28, 3:48 pm)
[PATCH] Revert "git-svn: Speed up fetch", Avery Pennarun, (Sat Jun 28, 4:57 pm)
Re: [PATCH] Revert "git-svn: Speed up fetch", Mikael Magnusson, (Sat Jun 28, 7:51 pm)
Re: [PATCH] Revert "git-svn: Speed up fetch", Avery Pennarun, (Sat Jun 28, 7:58 pm)
[PATCH v2] git-svn: avoid filling up the disk with temp files., Avery Pennarun, (Sat Jun 28, 7:33 pm)
Re: [PATCH v2] git-svn: avoid filling up the disk with temp ..., Eric Wong, (Sat Jun 28, 10:38 pm)
Re: [PATCH v2] git-svn: avoid filling up the disk with temp ..., Björn, (Sat Jun 28, 8:58 pm)
Re: [PATCH v2] git-svn: avoid filling up the disk with temp ..., Björn, (Sat Jun 28, 10:24 pm)
[PATCH] git cat-file: Fix memory leak in batch mode, Björn, (Sat Jun 28, 9:21 pm)
Re: [PATCH] git cat-file: Fix memory leak in batch mode, Junio C Hamano, (Sat Jun 28, 11:36 pm)
Re: [PATCH] git cat-file: Fix memory leak in batch mode, Björn, (Sun Jun 29, 7:54 am)