git mailing list

FromSubjectsort iconDate
Kevin Ballard
Git aliases executed from wrong dir
If I create an alias with `git config alias.foo '!pwd'` and then run it from a subdirectory of my repo, it prints out the root of my repo. This prevents the ability to create aliases that take filenames, as they simply won't work if you try and reference a file from a subdirectory. -- Kevin Ballard http://kevin.sb.org kevin@sb.org http://www.tildesoft.com --
Jun 25, 4:44 pm 2008
Kevin Ballard
Re: Git aliases executed from wrong dir
To clarify, this only appears to affect shell aliases (i.e. ones that start with !). git config alias.foo 'ls-files' Works fine from a subdir git config alias.foo '!git ls-files' Doesn't behave right from a subdir. -Kevin Ballard -- Kevin Ballard http://kevin.sb.org kevin@sb.org http://www.tildesoft.com --
Jun 25, 4:49 pm 2008
Dmitry Potapov
git rebase interactive: usability issue
Hello All, Today I got another user complaining that git rebase interactive sometimes squashing changes without being told to do that. Studying the reflog revealed what I expected to see: the user started the process of editing of chain of patches started by "git rebase -i", and then used "git commit --amend" to correct some of them, but at some point the process of rebasing was stopped due to a conflict caused by some previous changes. The user after resolving this conflict run "git commit ...
Jun 25, 4:32 pm 2008
Sam G.
Searching all git objects
Hi all, We recently had a developer make a large commit (mostly centered around one file) which she believed she properly pushed to a remote repository last week, but looking at both her repository and the remote repository, that commit is now nowhere to be found. If somehow the master branch she was working on in her repository has lost the reference to the commit through perhaps some errant rebasing, then perhaps an object containing the commit (or an object containing the file ...
Jun 25, 4:06 pm 2008
Shawn O. Pearce
Re: Searching all git objects
Odds are it is in her HEAD reflog. You can look for it with `git log -g`. If you know some part of the commit message you may be able to filter it down with `git log -g --grep=X` or part of the change with `git log -g -SX`. A coworker just did something like that today and lost his change; looking in the HEAD reflog and cherry-picking the commit recovered it quite easily. -- Shawn. --
Jun 25, 4:17 pm 2008
Tarmigan
Re: Searching all git objects
If it helps, I like viewing the reflog with gitk. Like this: gitk $(git log -g --pretty=format:%H) Is there a shorter way to do this with gitk? It would be awesome to have `gitk -g` . -Tarmigan --
Jun 25, 4:32 pm 2008
Junio C Hamano
[PATCH] Make clients ask for "git program" over ssh and ...
This will allow server side programs such as upload-pack to be installed outside $PATH. Connections to git-daemon still ask for "git-program" to retain backward compatibility for daemons before 1.5.6.1 and 1.6.0. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- * This is essentially your patch. This can be in 1.6.0 clients and it should also be in 1.5.6.1 as people might keep ancient clients to talk to new servers that won't have anything but "git" on $PATH. builtin-clone.c ...
Jun 25, 3:55 pm 2008
Shawn O. Pearce Jun 25, 4:02 pm 2008
Shawn O. Pearce
Re: [PATCH] Ask for "git program" even against git-daemon
Agreed about holding back. But I wonder if this patch is even worth it at some later point in time. Are we also going to change git-daemon to stop accepting "git-" form? Is it a worthwhile change? -- Shawn. --
Jun 25, 4:27 pm 2008
Junio C Hamano
[PATCH] Ask for "git program" even against git-daemon
This drops backward compatibility support to ask for "git-program" form when talking to git-daemon. Now all git native requests use "git program" form over ssh, local and git transports. This needs to be held back until everybody runs git-daemon from 1.5.6.1 or 1.6.0 or newer. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- * According to the roadmap we exchanged earlier, this should happen in a major release (that increments the second dewey-decimal digit from the left) that ...
Jun 25, 3:58 pm 2008
Shawn O. Pearce
Re: [PATCH] Ask for "git program" even against git-daemon
Sorry I wasn't clear. I was talking about the SSH transport only. For git:// we could just always send git-upload-pack, like your transitional patch does. Then we stay compatible with even very old git:// servers. -- Shawn. --
Jun 25, 4:57 pm 2008
Junio C Hamano
Re: [PATCH] Ask for "git program" even against git-daemon
This was merely responding to... From: "Shawn O. Pearce" <spearce@spearce.org> Subject: Re: [PATCH] Keep some git-* programs in $(bindir) Date: Wed, 25 Jun 2008 00:37:41 -0400 Message-ID: <20080625043741.GD11793@spearce.org> Daniel Barkalow <barkalow@iabervon.org> wrote: > ... > Should they use "git upload-pack" or should they look for their helper > programs in a libexec dir? I don't think that either of these programs is > useful to run ...
Jun 25, 4:36 pm 2008
Shawn O. Pearce
Re: [PATCH] Make clients ask for "git program" over ssh ...
Ack. Thanks for cleaning up the code in connect.c to not segfault or send garbage. I think you want to squash this in as well: diff --git a/builtin-send-pack.c b/builtin-send-pack.c index d76260c..f693a6d 100644 --- a/builtin-send-pack.c +++ b/builtin-send-pack.c @@ -12,7 +12,7 @@ static const char send_pack_usage[] = " --all and explicit <ref> specification are mutually exclusive."; static struct send_pack_args args = { - /* .receivepack = */ "git-receive-pack", + /* ...
Jun 25, 4:13 pm 2008
Junio C Hamano
[PATCH] daemon: accept "git program" as well
This is a step to futureproof git-daemon to accept clients that ask for "git upload-pack" and friends, instead of using the more traditional dash-form "git-upload-pack". By allowing both, it makes the client side easier to handle, as it makes "git" the only thing necessary to be on $PATH when invoking the remote command directly via ssh. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- "Shawn O. Pearce" <spearce@spearce.org> writes: > Junio C Hamano <gitster@pobox.com> wrote: ...
Jun 25, 3:47 pm 2008
Junio C Hamano
Re: [PATCH] daemon: accept "git program" as well
By the way I looked at gitosis (Tommi CC'ed). http://repo.or.cz/w/gitosis.git?a=blob;f=gitosis/serve.py;h=c0b7135bf45305ee1079b0dcab... In gitosis/serve.py, there are COMMANDS_READONLY and COMMANDS_WRITE array that holds 'git-upload-pack' and 'git-receive-pack' commands, and they are compared with user commands after doing: verb, args = command.split(None, 1) (and "verb" is looked up in the set of valid commands). It should not ...
Jun 25, 4:26 pm 2008
Kevin Ballard
[PATCH] git-send-email: Accept fifos as well as files
When a fifo is given, validation must be skipped because we can't read the fifo twice. Ideally git-send-email would cache the read data instead of attempting to read twice, but for now just skip validation. Signed-off-by: Kevin Ballard <kevin@sb.org> --- git-send-email.perl | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index 0b04ba3..16d4375 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -393,7 ...
Jun 25, 3:44 pm 2008
Junio C Hamano
Re: policy and mechanism for less-connected clients
First of all, if you are in CVS mindset, you may not want to necessarily do "git pull", but "git fetch" followed by "git rebase". I suspect the last one in the above sequence of yours is "git stash pop". "git diff [--options] origin..." (three-dots) is often used. This is a shorthand for: git diff [--options] $(git merge-base origin HEAD) HEAD This would be useful if you are using "fetch + rebase", but in any case git log --graph --pretty=oneline origin.. may be prettier these ...
Jun 25, 3:13 pm 2008
David Jeske
Re: policy and mechanism for less-connected clients
I don't want to replicate CVS behavior, just the workflow. I've considered rebase, but the diagrams on the documentation page look scarry. I want to keep the dag-nodes made by their local git commit;. At those commits the code worked and tested in their tree. rebase looks like it tosses those dag-nodes when it rewrites the diffs -- who knows if the tests actually pass for every point along that new rebase. That's no good. I can see the use of rebase when your job is to "author an ...
Jun 25, 4:03 pm 2008
Jakub Narebski
Re: policy and mechanism for less-connected clients
Push into it. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git --
Jun 25, 3:10 pm 2008
Jakub Narebski
Re: policy and mechanism for less-connected clients
git push <remote> HEAD # with current enough git -- Jakub Narebski Warsaw, Poland ShadeHawk on #git --
Jun 25, 1:54 pm 2008
Jakub Narebski
Re: policy and mechanism for less-connected clients
<opublikowany i wysłany> git-merge-base -- Jakub Narebski Warsaw, Poland ShadeHawk on #git --
Jun 25, 1:52 pm 2008
Thomas Rast
[PATCH] git-send-email: add support for TLS via Net::SMTP::SSL
We do this by handing over the Net::SMTP instance to Net::SMTP::SSL, which avoids Net::SMTP::TLS and its weird error checking. This trick is due to Brian Evins. Signed-off-by: Thomas Rast <trast@student.ethz.ch> --- The SMTP at my university only works with TLS, so I needed this. The trick referred to above was posted here: http://kerneltrap.org/mailarchive/git/2007/10/31/374810 - Thomas Documentation/git-send-email.txt | 16 ++++++++++++---- git-send-email.perl | ...
Jun 25, 12:42 pm 2008
Dmitry Potapov
Re: why is git destructive by default? (i suggest it not be!)
Why? Let's suppose you work with CVS and you started to edit some file and then realize than the change that you make is stupid, would not you want just to discard these change without committing them to CVS? Perhaps, you are confused by thinking that git commit and cvs commit are conceptually same commands. IMHO, far better to analogue to cvs commit would be git push to a repository with denyNonFastForwards policy. Git commit allows you to save your changes locally as series of patches, but ...
Jun 25, 11:06 am 2008
Junio C Hamano
Re: [PATCH] Ask for "git program" when asking for "git-p ...
Sigh... I thought you by now knew me better than that... Yes, I didn't say it explicitly because I thought it was too obvious, which was a mistake. These except for the ones that are preparation (such as "prepare daemon so that future clients can ask with non-dash forms") need to happen at release boundaries, but these 6/12 months figures set the minimums. E.g. even if we had 6 week release cycles and 1.7.0 were to be done 6 weeks after 1.6.0, that is still too early for the client side to ...
Jun 25, 10:42 am 2008
Jakub Narebski
Re: update-index --assume-unchanged doesn't make things ...
Which git version do you use? Does it have the following configuration variable (also available as command option): status.showUntrackedFiles:: By default, linkgit:git-status[1] and linkgit:git-commit[1] show files which are not currently tracked by Git. Directories which contain only untracked files, are shown with the directory name only. Showing untracked files means that Git needs to lstat() all all the files in the whole repository, which might ...
Jun 25, 12:30 pm 2008
Avery Pennarun
Re: update-index --assume-unchanged doesn't make things ...
Thanks, I didn't know about that one. Using that definitely makes "git status" go much faster (pretty much instantaneous if I've also used --assume-unchanged on everything). Now the catch is, if I want to implement the daemon I was talking about earlier, I'd like to be able to notice untracked files (or directories with untracked files) individually. Ideally, I guess the best way would be to just keep a separate list of all existing files that aren't in the index, and have git status look ...
Jun 25, 12:53 pm 2008
Avery Pennarun
Re: update-index --assume-unchanged doesn't make things ...
Hmm, can you do dnotify over NFS? I'd like to know how hg goes any faster. As far as I can see, git is going as fast as can be without some kind of daemon or other magic. (Except for my point #3, which seems relatively minor.) Thanks, Avery --
Jun 25, 11:02 am 2008
Michael J Gruber
Re: update-index --assume-unchanged doesn't make things ...
Avery Pennarun venit, vidit, dixit 25.06.2008 18:44: Looks like users on slow NFS would profit, too. Hate to say it, but hg feels faster on (slow) NFS than git. Yet I use git, for other reasons ;) Michael --
Jun 25, 10:38 am 2008
Jakub Narebski
Re: update-index --assume-unchanged doesn't make things ...
You can try to take a look at how (third-party and Linux only) inotify extension for Mercurial works. AFAIK IIRC it uses some kind of daemon which watches for inotify notices and updates Mercorial's equivalent of index. -- Jakub Narebski Poland --
Jun 25, 2:35 pm 2008
Avery Pennarun
update-index --assume-unchanged doesn't make things go fast
Hi all, Using git 1.5.6.64.g85fe, but this applies to various other versions I've tried. I have a git repo with about 17000+ files in 1000+ directories. In Linux, "git status" runs in under a second, which is perfectly fine. But on Windows, which can apparently only stat() about 1000 files per second, "git status" takes at least 17 seconds to run, even with a hot cache. (I've confirmed that stat() is so slow on Windows by writing a simple program that just runs stat() in a tight loop. The ...
Jun 25, 9:44 am 2008
Junio C Hamano
Re: update-index --assume-unchanged doesn't make things ...
That's on 'master' progressing forward to eventually become 1.6.0. --
Jun 25, 12:41 pm 2008
Robin Rosenberg
Re: gitwiki/EclipsePlugin
You mean they *are* overly verbose? Our INSTALL has a lot more details than your wiki, so I'm not sure I understand your problem. ) 7: uncheck all *.test projects not important ) 10: restart eclipse with parameter -clean We're going to set up an official update site in the not too distant future. Cheers, -- robin --
Jun 25, 11:55 am 2008
M
gitwiki/EclipsePlugin
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi list, I felt quite helpless when trying to get egit running as neither http://git.or.cz/gitwiki/EclipsePlugin nor the README/INSTALL aren't overly verbose. I put the idiot-proof recipe on http://wiki.jcurl.org/index.php5?title=GitSvn#Eclipse_Plugin - maybe you can weave it into either wiki or INSTALL? Greetings, M -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - ...
Jun 25, 9:34 am 2008
Rhodes, Kate
Re: how to list all files that will be comitted
yeah, but i was hoping for plumbing, not porcelain, that showed just what i wanted so that i didn't have to parse status' output. -Kate --
Jun 25, 9:01 am 2008
Michael J Gruber
Re: how to list all files that will be comitted
I don't think git ls-files does that, but git diff --cached --name-only will. Cheers, Michael --
Jun 25, 9:19 am 2008
Rhodes, Kate
how to list all files that will be comitted
I know ls-files is the tool I need but I haven't been able to figure out what combination of options will give me the files that have been added to the index. -Kate --
Jun 25, 8:31 am 2008
Ian Hilt
Re: how to list all files that will be comitted
I wasn't able to make "git ls-files" do what you want. However, "git diff --name-only --cached" did. It's still porcelain, but it does what you want :) -- Ian Hilt Ian.Hilt (at) gmx.com GnuPG key: 0x4AFC1EE3 --
Jun 25, 9:24 am 2008
Ian Hilt
Re: how to list all files that will be comitted
Have you tried "git status" ? It will output something similar to the following: # On branch master # Changes to be committed: # (use "git reset HEAD <file>..." to unstage) # # modified: somefile # # Changed but not updated: # (use "git add <file>..." to update what will be committed) # # modified: anotherfile # -- Ian Hilt Ian.Hilt (at) gmx.com GnuPG key: 0x4AFC1EE3 --
Jun 25, 8:57 am 2008
Reece Dunn
Re: how to list all files that will be comitted
`git status` will do this, unless you need to do additional processing on the results. HTH, - Reece --
Jun 25, 9:14 am 2008
Karl
Re: how to list all files that will be comitted
Unless you want a listing of all the files in the index, you probably want to call diff-index. git diff-index --cached <tree-ish> gives you the diff between the index and a tree-ish. With the --name-only option, you get only the filenames and not all the modes, blob sha1s, etc. -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle --
Jun 25, 9:14 am 2008
Rhodes, Kate
Re: how to list all files that will be comitted
Perfect, exactly what I wanted. Thanks. -Kate --
Jun 25, 9:16 am 2008
Jeff King
Re: [Bug] for-each-ref: %(object) and %(type) unimplemented
Looks like they were part of the original set of atoms, but they just never ended up implemented. Clearly nobody has actually cared in the intervening time, but it is easy enough to add them. See below. Since you seem to be testing for-each-ref, maybe it would make sense to put together a test script that exercises each of the atoms? -- >8 -- for-each-ref: implement missing tag values The "type" and "object" fields for tags were accepted as valid atoms, but never implemented. ...
Jun 25, 9:08 am 2008
Jeff King
Re: [Bug] for-each-ref: %(object) and %(type) unimplemented
Hmm. Actually, there is a test in t6300 that runs with each atom name. Unfortunately, it doesn't bother actually checking the output for sanity, so the fact that these atoms returned the empty string was missed. -Peff --
Jun 25, 9:14 am 2008
Junio C Hamano
Re: [Bug] for-each-ref: %(object) and %(type) unimplemented
The doc does not say any such thing. A tag object does not have 'parent' nor 'tree' header fields. Neither a commit have 'object' nor 'type' header fields and you cannot ask for them when showing a commit object. --
Jun 25, 12:38 pm 2008
Lea Wiemann
[Bug] for-each-ref: %(object) and %(type) unimplemented
Try the following on a repository with tag objects in it: git for-each-ref --format='%(object)' git for-each-ref --format='%(type)' Each command prints only newlines. The %(type) and %(object) options are not rejected with an error message (like "%(doesnotexist)"), but they don't seem to be implemented. "%(tag)" works though. Anyone care to implement the missing options? Or should they rather be removed from the documentation? -- Lea --
Jun 25, 8:01 am 2008
Mikael Magnusson
Re: [Bug] for-each-ref: %(object) and %(type) unimplemented
The documentation also says "tree" and "parent" should work (which they also don't). -- Mikael Magnusson --
Jun 25, 12:08 pm 2008
Mikael Magnusson
Re: [Bug] for-each-ref: %(object) and %(type) unimplemented
Ah, sorry, I read this paragraph: In addition to the above, for commit and tag objects, the header field names (tree, parent, object, type, and tag) can be used to specify the value in the header field. But not this one (which perhaps should be right after the above instead of 3 paragraphs down): In any case, a field name that refers to a field inapplicable to the object referred by the ref does not ...
Jun 25, 1:36 pm 2008
Erez Zilber
Where does gitweb take the owner name from?
Hi, On the main page of gitweb (the one that lists all projects), there's an "Owner" column. On my gitweb, it is empty for all projects. Where is this information taken from? Here is how it looks on the server when I run 'ls -l': drwxr-xr-x 7 erez.zilber linux 4096 Jun 25 17:36 my_test.git Thanks, Erez --
Jun 25, 7:41 am 2008
Michael J Gruber
Re: Where does gitweb take the owner name from?
Sources considered by gitweb are: 1. projectlist file 2. owner key in .git/config ("gitweb.owner") 3. file owner of the git dir It's funny this results in an empty owner in your case: What does "finger erez.silber" say? Michael Use the source, Luke ;) sub git_get_project_owner { my $project = shift; my $owner; return undef unless $project; $git_dir = "$projectroot/$project"; if (!defined $gitweb_project_owner) { ...
Jun 25, 8:50 am 2008
Jakub Narebski
Re: Where does gitweb take the owner name from?
Unfortunately it is not stated explicitely neither in gitweb/README, not gitweb/INSTALL. Nevertheless when you grep for 'owner' in gitweb/README you can find the following fragments: * $projects_list Source of projects list, either directory to scan, or text file with list of repositories (in the "<URI-encoded repository path> SPC <URI-encoded repository owner>" line format, [...]). Set to $GITWEB_LIST during installation. If empty, $projectroot is used to scan for ...
Jun 25, 1:12 pm 2008
Petr Baudis
Re: policy and mechanism for less-connected clients
Hi, Please note that we support pushing using the HTTP DAV extensions. It seems to be only rarely used in practice though, since developers seem to either work at sane companies, are tunneling through the firewalls or the firewalls are adjusted if this is required for development of their day-job applications. There are some cases where this is useful, but I don't tihnk they are very numerous (in practicular, I've had more requests (about three?) for git-cvsserver than for HTTP DAV ...
Jun 25, 7:03 am 2008
Theodore Tso
Re: policy and mechanism for less-connected clients
So this isn't true security, since someone determined (or an ingenious enough fool) can always blow away repository if you allow them to add changes; they could just add a change which rm's all of the files, yes? You just want to prevent something stupid. Well, as long as they don't do non-fast forward updates (i.e., they never do something like: "git push publish +head:head", or any other incantation involving a leading '+' in the refspec), they should be pretty safe. I don't see how they ...
Jun 25, 6:34 am 2008
Junio C Hamano
Re: policy and mechanism for less-connected clients
Well, if you do not trust them, just set receive.denynonfastforwards and they won't be able to. --
Jun 25, 10:34 am 2008
David Jeske
Re: policy and mechanism for less-connected clients
Some answers thanks to Jakub... I'm told I need... and... git push HEAD which just leaves this one.... Question: How do I create a branch on a remote repo when I'm on my local machine, without sshing to it? --
Jun 25, 2:34 pm 2008
David Jeske
Re: policy and mechanism for less-connected clients
Thanks for the info about shared object storage for shared repositories. That's great, and looks like a good implementation method. Previously I was thinking in terms of making a different server to change behavior. However, I think the comments I've read are shifting my mindset towards making a client-wrapper. I want to provide a system [wrapper] without the user-burden of thinking about three repositories (local, my-public, shared-public). Doing this as a wrapper has other benefits, like the ...
Jun 25, 12:37 pm 2008
Johannes Gilger
Re: Errors building git-1.5.6 from source on Mac OS X 10.4.11
Hi, I just followed your exact instructions (even using the same prefix in configure) and ran the whole test-suite (and after that the offending test t2004 by itself again). It worked without a flaw here, though that probably does not help you much. I too am using Mac OS 10.4.11 with GCC 4.0.1. Just wanted to let you know. Regards, Jojo -- git version 1.5.6.12.g73f03 --
Jun 25, 7:38 am 2008
Alex Riesen
Re: Errors building git-1.5.6 from source on Mac OS X 10.4.11
If you don't mind helping the investigation a bit, could you please go into the t/ directory and run bash -x t2004-checkout-cache-temp.sh -d -v -i and post the output here? This diagnostics are much more useful (well, essential, in this case). Are running the tests on HFS+, BTW? --
Jun 25, 10:53 am 2008
Ifejinelo Onyiah
Errors building git-1.5.6 from source on Mac OS X 10.4.11
Hi, I have made several attempts to build Git (version 1.5.6) on my Mac OS X 10.4.11 (Tiger) but have had little luck. At the time of my last try (2008-06-25 11:08) there were no pre-built binaries for Tiger on the Git home page. I downloaded the source file from home page and issued the following commands: % tar -xzf git-1.5.6.tar.gz % cd git-1.5.6 % ./configure --prefix=/Users/io1/Applications/Git/1.5.6 % make They all run fine but when I issue the make test command, it dies at the ...
Jun 25, 6:20 am 2008
Jakub Narebski
Re: policy and mechanism for less-connected clients
repo.or.cz has support for forks, i.e. sharing object database (for old objects) via alternates, although it is not "common object database" (as in, for example, $GIT_DIR/objects symlinked to single common parent repository) GitHub has also some support for "forks", but as it is closed source I don't think anybody knows how it is done. -- Jakub Narebski Poland ShadeHawk on #git --
Jun 25, 2:30 am 2008
Dmitry Potapov
[PATCH 2/2] update-hook-example: optionally allow non-fa ...
Sometimes it is desirable to have non-fast-forward branches in a shared repository. A typical example of that is the 'pu' branch. This patch extends the format of allowed-users and allow-groups files by using the '+' sign at the beginning as the mark that non-fast-forward pushes are permitted to the branch. Signed-off-by: Dmitry Potapov <dpotapov@gmail.com> --- Documentation/howto/update-hook-example.txt | 20 ++++++++++++-------- 1 files changed, 12 insertions(+), 8 deletions(-) diff ...
Jun 25, 1:26 am 2008
Dmitry Potapov
[PATCH v2] update-hook-example: optionally allow non-fas ...
Sometimes it is desirable to have non-fast-forward branches in a shared repository. A typical example of that is the 'pu' branch. This patch extends the format of allowed-users and allow-groups files by using the '+' sign at the beginning as the mark that non-fast-forward pushes are permitted to the branch. Signed-off-by: Dmitry Potapov <dpotapov@gmail.com> --- <snip> Thank you for advice. I have corrected the patch. Documentation/howto/update-hook-example.txt | 75 ...
Jun 25, 4:14 pm 2008
Dmitry Potapov
[PATCH 1/2] fix update-hook-example to work with packed ...
The update-hook-example used 'test -f' to check the tag present, which does not work if the checked reference is packed. This check has been changed to use 'git rev-parse $tag' instead. Signed-off-by: Dmitry Potapov <dpotapov@gmail.com> --- Documentation/howto/update-hook-example.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/howto/update-hook-example.txt b/Documentation/howto/update-hook-example.txt index 88765b5..a8d3bae 100644 --- ...
Jun 25, 1:26 am 2008
Junio C Hamano
Re: [PATCH 2/2] update-hook-example: optionally allow no ...
Thanks. 1/2 queued for 'maint' (as it was an obvious fix) to be included in 1.5.6.1, but not this one that is a feature enhancement even though it "expr substr"? Please don't. cf. http://www.opengroup.org/onlinepubs/000095399/utilities/expr.html I'd probably write this part like so: ... pipe ... | while read heads users do # does this rule apply to us? head_pattern=${heads#+} matchlen=$(expr "$1" : "$head_pattern") ...
Jun 25, 1:04 pm 2008
Junio C Hamano
Re: [PATCH] Ship sample hooks with .sample suffix
The question obviously was about using outside Windows context as we have been talking about merging it into my history ;-) I'll push out the master with the *.sample patch hopefully soon. --
Jun 25, 1:09 am 2008
Karl
[StGit PATCH 2/2] New refresh tests
Test stg refresh more extensively -- including some things it only recently learned to do. Signed-off-by: Karl Hasselström <kha@treskal.com> --- t/t2300-refresh-subdir.sh | 29 ++++++++++++++++++++++++++++- 1 files changed, 28 insertions(+), 1 deletions(-) diff --git a/t/t2300-refresh-subdir.sh b/t/t2300-refresh-subdir.sh index 92c1cc8..d731a11 100755 --- a/t/t2300-refresh-subdir.sh +++ b/t/t2300-refresh-subdir.sh @@ -4,7 +4,7 @@ test_description='Test the refresh command from a ...
Jun 24, 9:30 pm 2008
Karl
[StGit PATCH 1/2] Convert "stg refresh" to the new infra ...
And in the process, make it more powerful: it will now first create a temp patch containing the updates, and then try to merge it into the patch to be updated. If that patch is applied, this is done by popping, pushing, and coalescing; if it is unapplied, it is done with an in-index merge. The temp patch creation and merging is logged in two separate stages, so that the user can undo them separately. Also, whenever path limiting is used, we will now use a temporary index in order to avoid ...
Jun 24, 9:30 pm 2008
Mike Hommey
Re: [PATCH] pack.indexversion config option now defaults to 2
(...) Wouldn't it be a good idea to add a warning in git update-server-info when it detects pack.indexVersion is not 1, too ? Mike --
Jun 24, 10:56 pm 2008
Mike Hommey
Re: [PATCH] pack.indexversion config option now defaults to 2
The warning could just say that people with older git won't be able to clone over dumb protocols. Nothing more. Mike --
Jun 25, 11:58 am 2008
Nicolas Pitre
[PATCH] pack.indexversion config option now defaults to 2
As announced for 1.6.0. Git older than version 1.5.2 (or any other git version with this option set to 1) may revert to version 1 of the pack index by manually deleting all .idx files and recreating them using 'git index-pack'. Communication over the git native protocol is unaffected since the pack index is never transferred. Signed-off-by: Nicolas Pitre <nico@cam.org> --- Documentation/config.txt | 6 +++--- pack-write.c | 2 +- 2 files changed, 4 insertions(+), 4 ...
Jun 24, 9:25 pm 2008
Junio C Hamano
Re: [PATCH] pack.indexversion config option now defaults to 2
I know, as I did that myself; but I wanted to be conservative and gave a No worries. After re-reading what you wrote I think both are fine as they are. I do not mind adding the above 7 lines to the indexVersion one myself. --
Jun 25, 12:19 pm 2008
Linus Torvalds
Re: [PATCH] pack.indexversion config option now defaults to 2
Rather than talk about when it does _not_ matter, wouldn't it be better to talk about when it _can_ matter? Namely when using dumb protocols, either http or rsync, with the other end being some ancient git thing (and it is worth mentioning version of what counts as 'ancient' too, I can't remember, probably means that pretty much nobody else can either). Linus --
Jun 24, 9:32 pm 2008
Junio C Hamano
Re: [PATCH] pack.indexversion config option now defaults to 2
I agree with you that the description of the change (in the commit log) and the instruction (in the documentation) could be more helpful and explicit. For the other "usedeltabaseoffset" change, I think the insn in the documentation Nico added is reasonable: + By default, linkgit:git-repack[1] creates packs that use + delta-base offset. If you need to share your repository with + git older than version 1.4.4, either directly or via a dumb + protocol such as http, then you need to set this ...
Jun 24, 9:59 pm 2008
Nicolas Pitre
Re: [PATCH] pack.indexversion config option now defaults to 2
That would give the idea that index v2 is not good, while what we want is to encourage everyone to move to index v2 ASAP. Nicolas --
Jun 25, 11:53 am 2008
Junio C Hamano
Re: [PATCH] pack.indexversion config option now defaults to 2
Can you describe how that warning will help whom in the bigger picture? The way as I understand everybody runs "git update-server-info" is: * "git push" pushes into a publishing repository, then * "post-receive" (or "post-update") hook triggers "update-server-info". If you spit out a warning from update-server-info, it will be shown to the pusher over sideband, but this will not necessarily help the pusher, who may or may not have shell access to the repository. --
Jun 24, 11:06 pm 2008
Nicolas Pitre
Re: [PATCH] pack.indexversion config option now defaults to 2
$ git describe --contains b6945f5 Looks fine to me. Will you amend the patches or do you want me to repost them? Nicolas --
Jun 25, 11:49 am 2008
Mike Hommey
Re: [PATCH] pack.indexversion config option now defaults to 2
There are also those that get the message to run update-server-info when trying to clone over dumb protocol when the info/refs file is not there... I actually didn't think about the post-receive hook. Well, then, update-server-info could output the warning only if stderr is a tty. Mike --
Jun 24, 11:14 pm 2008
Nicolas Pitre
[PATCH] repack.usedeltabaseoffset config option now defa ...
As announced for 1.6.0. Access over the native protocol by old git versions is unaffected as this capability is negociated by the protocol. Otherwise setting this config option to "false" and doing a 'git repack -a -d' is enough to remain compatible with ancient git versions (older than 1.4.4). Signed-off-by: Nicolas Pitre <nico@cam.org> --- Documentation/config.txt | 10 +++++++--- git-repack.sh | 6 +----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git ...
Jun 24, 9:24 pm 2008
Avery Pennarun
[BUG] Recent git-svn gets checksum errors on very large ...
My svn repo has 17000+ files in 1000+ directories. I managed to narrow my problem down to this sequence of steps: mkdir poo cd poo git init git svn init file:///home/averyp/svn.bak/branches/MyBranch git svn fetch -r3095 2>&1 | tee git.out Which culminates in: Checksum mismatch: ThirdParty/whateverdir/blahblah expected: c342eaa17fe219a764c06642bb951474 got: 848bbb56e4c22755ffb687fb70ae1ac6 For extra excitement, if I run the same command multiple ...
Jun 24, 8:23 pm 2008
Junio C Hamano
Re: [PATCH] factorize pack structure allocation
Thanks. This is a much better equivalent to the "probably fixed with this" patch you sent earlier ;-) --
Jun 24, 8:22 pm 2008
Junio C Hamano
[PATCH] Ask for "git program" when asking for "git-progr ...
The daemon expects to see the dashed form and we cannot change older servers. But when invoking programs on the remote end over SSH, the command line the client side build is under client's control. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- * This I haven't even compile tested at all, but it feels right. We probably should do this before bindir=>libexecdir move; as long as this is in place on the client side the version running on the server end should not matter. ...
Jun 24, 8:26 pm 2008
Junio C Hamano
Re: [PATCH] Ask for "git program" when asking for "git-p ...
Yeah, I missed the patch to connect.c that was buried among other changes. Sorry. --
Jun 24, 10:53 pm 2008
Shawn O. Pearce
Re: [PATCH] Ask for "git program" when asking for "git-p ...
This plan makes a lot of sense to me. I'm behind it. For whatever that means. At least I'll shutup and stop making noise about this Yea, 6 and 12 seem like a good idea. Its a couple of releases and gives people time to migrate their server installations. -- Shawn. --
Jun 24, 10:38 pm 2008
Junio C Hamano
Re: [PATCH] Ask for "git program" when asking for "git-p ...
Of course. I am assuming that he runs git-shell for user account, and that's what the change in 'next' is about. --
Jun 24, 10:30 pm 2008
Daniel Barkalow
Re: [PATCH] Keep some git-* programs in $(bindir)
Should they use "git upload-pack" or should they look for their helper programs in a libexec dir? I don't think that either of these programs is useful to run independantly, but I don't know if finding a program that doesn't go in $PATH on a remote machine is going to be any fun. -Daniel *This .sig lefti ntentionally blank* --
Jun 24, 9:19 pm 2008
Junio C Hamano
Re: [PATCH] Ask for "git program" when asking for "git-p ...
<< a patch to conditionally change "git-program" default to "git program" snipped >> How would that help client that talk with git-daemon, unlike what I sent earlier? --
Jun 24, 10:09 pm 2008
Shawn O. Pearce
Re: [PATCH] Keep some git-* programs in $(bindir)
I think you mean git-upload-archive, given what daemon.c says. Or line 34 of builtin-archive.c, which calls git-upload-archive by way of git_connect(). -- Shawn. --
Jun 24, 9:17 pm 2008
Junio C Hamano
[PATCH] Keep some git-* programs in $(bindir)
Otherwise remote executions directly over ssh won't find them as they used to. --upload-pack and --receive-pack options _could_ be used on the client side, but things should keep working out-of-box for older clients. Later versions of clients (fetch-pack and send-pack) probably could start asking for these programs with dashless form, but that is a different topic. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- * しらいしななこ <nanako3@lavabit.com> writes: > Doesn't "git archive ...
Jun 24, 8:22 pm 2008
Shawn O. Pearce
Re: [PATCH] Keep some git-* programs in $(bindir)
IMHO they should in the future use "git upload-pack". But this may not work with all servers, especially those that use $SSH_ORIGINAL_COMMAND to dispatch to the correct command, or abort if the user tries to request something dangerous. Gitosis comes to mind. I'm not sure we can get away with doing this in 1.6.0 as it is effectively a network protocol breakage. We have thus far never caused a newer client to fail talking to an older server. I'm not sure we should start doing that in ...
Jun 24, 9:37 pm 2008
Shawn O. Pearce
Re: [PATCH] Ask for "git program" when asking for "git-p ...
Actually I'd go the other direction. Allow the higher up level to supply "git upload-pack" and convert it to git- for the git:// Pasky also has to update: $ git ls-remote --upload-pack='git upload-pack' repo.or.cz:/srv/git/egit.git fatal: unrecognized command 'git upload-pack '/srv/git/egit.git'' fatal: The remote end hung up unexpectedly diff --git a/builtin-clone.c b/builtin-clone.c index 5c5acb4..98d0f0f 100644 --- a/builtin-clone.c +++ b/builtin-clone.c @@ -37,7 +37,7 @@ static ...
Jun 24, 9:44 pm 2008
Junio C Hamano
Re: [PATCH] Ask for "git program" when asking for "git-p ...
If we force --upload-pack workaround to _everybody_ we are already lost. Also I think the previous one still lets you work it around by giving a full path, like "/usr/local/bin/git-upload-pack", because "/usr" does not match "git-" ;-) --
Jun 24, 10:13 pm 2008
Junio C Hamano
Re: [PATCH] Ask for "git program" when asking for "git-p ...
Well, the thing is, "higher up" would not have enough clue to see if it needs to give dashed form (for git-daemon) or space form (for ssh), so that suggestion won't help much. I do not care too much about closed source service, but gitosis should be able to update the pattern to allow "git[ -]upload-pack" reasonably easily. Any other suggestions that is workable? --
Jun 24, 9:32 pm 2008
Junio C Hamano
Re: [PATCH] Ask for "git program" when asking for "git-p ...
Ok, let's map this out seriously. * 1.6.0 will install the server-side programs in $(bindir) so that people coming over ssh will find them on the $PATH * In 1.6.0 (and 1.5.6.1), we will change "git daemon" to accept both "git-program" and "git program" forms. When the spaced form is used, it will behave as if the dashed form is requested. This is a prerequisite for client side change to start asking for "git program". * In the near future, there will no client-side change. ...
Jun 24, 10:27 pm 2008
Theodore Tso
Re: [PATCH] Ask for "git program" when asking for "git-p ...
Is that really 6 and 12 months, or "6/12 months or at the next major release boundary, whichever is later". i.e., would make some of these changes as part of a minor dot release, such as having the client side change what it starts asking for in 1.6.3 or some such? Presumably the earliest that change would happen is 1.7, and the earliest to make the server side installation changes is 1.8, right? Or did you really mean a hard 6/12 months, regardless of release cycle issues? ...
Jun 25, 6:06 am 2008
Shawn O. Pearce
Re: [PATCH] Ask for "git program" when asking for "git-p ...
Nack on that implementation. I think this is a problem for systems based on say gitosis, or some pattern like it. Day-job doesn't use gitosis, but has switched to a Perl based forced ssh tool that smells a lot like gitosis. Gitosis is popular. github probably uses something similar. But nobody knows (or probably cares) since they don't release their source. gitosis is likely looking for "$git-upload-pack '(.*)'$" to be in the $SSH_ORIGINAL_COMMAND environment variable, if you ...
Jun 24, 8:45 pm 2008
Shawn O. Pearce
Re: [PATCH] Ask for "git program" when asking for "git-p ...
Shouldn't "git upload-pack" work on the server side as far back as 0.99.9k? That's back really old. And my patch fixed "git " to be "git-" when talking to git-daemon, thus keeping clients compatible with all current git:// servers. For SSH servers that can't handle "git upload-pack" the user can change it to --upload-pack=git-upload-pack and get back to the old behavior, until the server operator can upgrade. Check my change in git_connect again: diff --git a/connect.c ...
Jun 24, 10:34 pm 2008
Nicolas Pitre
[PATCH 4/4] verify-pack: test for detection of index v2 ...
Signed-off-by: Nicolas Pitre <nico@cam.org> --- t/t5302-pack-index.sh | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/t/t5302-pack-index.sh b/t/t5302-pack-index.sh index 09fd917..ecec591 100755 --- a/t/t5302-pack-index.sh +++ b/t/t5302-pack-index.sh @@ -162,4 +162,18 @@ test_expect_success \ '[index v2] 5) pack-objects refuses to reuse corrupted data' \ '! git pack-objects test-5 <obj-list' +test_expect_success \ + '[index v2] 6) ...
Jun 24, 8:19 pm 2008
Nicolas Pitre
[PATCH 3/4] verify-pack: check packed object CRC when us ...
To do so, check_pack_crc() moved from builtin-pack-objects.c to pack-check.c where it is more logical to share. Signed-off-by: Nicolas Pitre <nico@cam.org> --- builtin-pack-objects.c | 22 ---------------------- pack-check.c | 39 +++++++++++++++++++++++++++++++++++++-- pack.h | 2 +- 3 files changed, 38 insertions(+), 25 deletions(-) diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c index 827673c..28207d9 100644 --- ...
Jun 24, 8:19 pm 2008
Nicolas Pitre
[PATCH 2/4] move show_pack_info() were it belongs
This is called when verify_pack() has its verbose argument set, and verbose in this context makes sense only for the actual 'git verify-pack' command. Therefore let's move show_pack_info() to builtin-verify-pack.c instead and remove useless verbose argument from verify_pack(). Signed-off-by: Nicolas Pitre <nico@cam.org> --- builtin-fsck.c | 2 +- builtin-verify-pack.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++- http-push.c | 2 +- http-walker.c | ...
Jun 24, 8:18 pm 2008
Nicolas Pitre
[PATCH 1/4] optimize verify-pack a bit
Using find_pack_entry_one() to get object offsets is rather suboptimal when nth_packed_object_offset() can be used directly. Signed-off-by: Nicolas Pitre <nico@cam.org> --- cache.h | 1 + pack-check.c | 4 +--- sha1_file.c | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/cache.h b/cache.h index a68866c..16222a3 100644 --- a/cache.h +++ b/cache.h @@ -711,6 +711,7 @@ extern void close_pack_windows(struct packed_git *); extern void unuse_pack(struct ...
Jun 24, 8:17 pm 2008
Daniel Barkalow Jun 25, 12:17 pm 2008
David Jeske
Re: policy and mechanism for less-connected clients
Yup. That's one of the reasons git is so attractive. There is some good stuff ...most notably, all their DAGs in a single repository to save space is important. Thousands of copies of thousands of repositories adds up. Especially when most of the users who want to commit something probably commit <1-10k of unique stuff. Seems pretty easy to change though. git.or.cz and github will both be wanting this eventually. The other big one is ACLs in 'well named' repositories, so multiple people ...
Jun 24, 10:20 pm 2008
Theodore Tso
Re: policy and mechanism for less-connected clients
Up to here, you can do this all with repo.or.cz, and/or github; you just give each developer their own repository, which they are allowed to push to, and no once else. Within their own repository they can This is also easy; you just establish remote tracking branches. I have a single shell scripted command, git-get-all, which pulls from all of the repositories I am interested in into various remote tracking branches so while I am disconnected, I can see what other This is the wierd one. ...
Jun 24, 7:33 pm 2008
Raimund Bauer
Re: policy and mechanism for less-connected clients
But a branch in repository also has a local history. The ref-log. And git could use that to produce a distributed branch-history. <wishful thinking> A developer prepares a series of commits in a local branch to push to the server. On the server the ref-log of a branch gets updated with a new entry for each push, and other developers pulling from the server get the servers ref-log as ref-log of their remote tracking branch and can see the push-points there. Those push-points seem to be ...
Jun 25, 1:12 pm 2008
David Jeske
policy and mechanism for less-connected clients
I'd like to hear feedback and ideas about a different mechanism than is being used with git-pull or git-push. The purpose of this mechanism is to host a distributed source repository in a world where most most developer contributors are behind firewalls and do not have access to, or do not want to configure a unix server, ftp, or ssh to possibly contribute to a project. The model of allowing less-authoritative developers to make their changes available for more-authoritative users to pull is ...
Jun 24, 5:36 pm 2008
Adam Brewster
Re: [PATCH/RFC] Created git-basis and modified git-bundl ...
Yes. I figure that patching to make --not --stdin work how I'd like would break something else, and implementing --not-stdin seems hackish. Adam Brewster --
Jun 24, 6:14 pm 2008
Jakub Narebski
Re: [PATCH/RFC] Created git-basis and modified git-bundl ...
Ah, sorry, I have forgot about that. This is definitely, both in the case of revisions Does it prefix bases with ^, i.e. ^basis (negative revision)? I think it should, then there would be no need for strange --stdin semantic, or implementing --stdin in such way that --not--stdin I think that --stdin would be better idea, as it can be used to enumerate all refs to send, even if they are too many or they have too long names to use arguments. Ahh... git-rev-list... well, I though about ...
Jun 24, 5:21 pm 2008
Teemu Likonen
Re: [PATCH] factorize pack structure allocation
Because of time zone issues I didn't get a chance to check this until now. This fixes the segfault issue for me. Thanks! --
Jun 25, 12:19 am 2008
Shawn O. Pearce
Re: [JGIT PATCH 4/4] LsTree: Enable pattern matching in LsTree
Are we only supporting `jgit ls-tree . '*.c'` ? Or do we want to allow `jgit ls-tree . 'src/*.c'`? ls-tree is only a little sample program that is not likely to have a lot of real-world users calling it; but is a good demonstration of how to use TreeWalk. So I really don't care either way. The WildCardTreeFilter on the other hand could be applied to a RevWalk, such as to grab history for not just 'foo.c' but anything that matches 'f*.c'. But then you have to ask, why is the ...
Jun 24, 9:09 pm 2008
Patrick.Higgins
RE: Windows symlinks
We might be able to get by with them, but submodules appear to be significantly more complex than symlinks, and we sometimes symlink just a file or two if that's all we need. Splitting up submodules to that level of granularity would be hard to manage. My understanding of the submodule workflow is: Projects A, B, and C (we actually have about 17 of these) all share common code in project Common. Then, each of A, B, and C adds Common as a submodule. While working on project A, the need arises to ...
Jun 25, 10:50 am 2008
Avery Pennarun
Re: Windows symlinks
Perhaps git-submodule would do what you're looking for. Avery --
Jun 24, 5:04 pm 2008
Johannes Sixt
Re: [PATCH] Ship sample hooks with .sample suffix
I am very confident in the series as far as using it on Windows is concerned. But I must admit that I have started to use it on Linux only recently. Therefore, cooking it in 'next' for a few days is probably not a mistake. -- Hannes --
Jun 24, 11:51 pm 2008
Peter Baumann
Re: [PATCH] Ship sample hooks with .sample suffix
Wouldn't it be better to name the hooks $hook.deactivated so its obvious to anybody that they are not executed? Just my 2 cents. -Peter --
Jun 24, 10:18 pm 2008
Christian Holtje
Re: [PATCH] pre-commit hook should ignore carriage retur ...
definitely; that sounds like an obvious thing for "diff --check". Ciao! --
Jun 24, 5:19 pm 2008
Junio C Hamano
Re: [PATCH] Ship sample hooks with .sample suffix
I'll queue the patch to 'master' and I suspect that this will make 31d6632 (Windows: Change the name of hook scripts to make them not executable., 2007-11-30) unnecessary. I've looked at diff between ee1e0a3 (the original "pull" request) and 8fd39ba (after WS fixup on borrowed code and other changes). They all looked fine except for git.c::main() where do .. while does not have a { } around the body (which is not required by C language but it just looked funny). I am very tempted to pull ...
Jun 24, 7:48 pm 2008
Junio C Hamano
[PATCH] Ship sample hooks with .sample suffix
We used to mark hooks we ship as samples by making them unexecutable, but some filesystems cannot tell what is executable and what is not. This makes it much more explicit. The hooks are suffixed with .sample (but now are made executable), so enabling it is still one step operation (instead of "chmod +x $hook", you would do "mv $hook.sample $hook") but now they won't get accidentally enabled on systems without executable bit. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- * This ...
Jun 24, 7:09 pm 2008
Boaz Harrosh
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
I was under the impression that --hard means working-directory-also as opposed to tree-and-index-only. Nothing to do with destructive-discarding. If it is then something is missing. I need 2 distinct functions. You combine to functions under I did lern the lingo and got bitten. I wanted to do one thing also got the other one. there is: git-reset --clean - destructive-discarding any local changes git-reset --hard - move tree index and working directory to new head How can I separate ...
Jun 25, 2:12 am 2008
Theodore Tso
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Well, I think you really want this to handle filenames with spaces: for i in $* do git checkout HEAD -- "$i" done I still think it would be nice this as a built-in for "git revert-file" since this is much easier to type than "git checkout HEAD -- " (all those characters and capital letters). But if it ends up being a private shell script for people who do this a lot, that's also fine. I will say that it was not at all obvious that "git checkout" can also be used to revert files, ...
Jun 25, 12:50 pm 2008
Johannes Schindelin
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Hi, Actually, I don't find this a good reason at all. The fact that other SCMs bastardized a term to mean something it clearly does not mean, is irrelevant here. The thing is: if we say "let's switch branches", what command would spring to mind to a (non-CVS-braindamaged) user? Exactly: "git branch". That is the command that should do something with branches. Ciao, Dscho --
Jun 25, 5:33 am 2008
Johannes Schindelin
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Hi, Nice. And now my friend says "why does this braindamaged Git not have that command by _default_? Hmm? It is _just as braindamaged_ as CVS!" And I would not have anything reasonable for my defense. Because Git _should_ have an intuitive command to switch branches by default. "git checkout" just does not fly, especially given that it can be used to revert single files (which "git revert" should know how to, but does not, see ...
Jun 25, 5:38 am 2008
Junio C Hamano
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
No, I wrote -- only for clarity, because you can happen to have a branch whose name is the same as the file. Otherwise you can safely omit it, just like git-diff and any other commands that follow the -- convention. I have a work tree that has an untracked file HEAD and master just to catch script breakages that forgets to place -- in appropriate places when they deal with user supplied pathnames. --
Jun 25, 1:48 pm 2008
Matthias Kestenholz
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
But why? I don't want to 'branch', I want to 'checkout' another branch, which incidentally matches the git command I need to use to achieve that. Matthias --
Jun 25, 3:24 am 2008
Boaz Harrosh
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
OK Thanks, I see. I have made myself that git-move-head script that uses checkouts and renames so I guess I'm happy. I used to use the --hard as a shortcut. Boaz --
Jun 25, 2:59 am 2008
Junio C Hamano
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Isn't that this? #!/bin/sh exec git checkout HEAD -- "$@" --
Jun 25, 10:22 am 2008
Theodore Tso
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Stupid quesiton --- where is this documented? I don't see this documented either in the man page for git or git-checkout. Regards, - Ted --
Jun 25, 2:05 pm 2008
Johannes Schindelin
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Hi, just to add to Junio's comments: But "reset" _means_ to discard something. Frankly, we could introduce "git reset --hard --force --really --really-i-mean-it --do-reset-the-fscking-working-directory-NOW", but I do not think that it makes sense. If you want to reset the working directory, you want to reset the working directory. If you wanted to save the changes somewhere, you should have Apparently not. So again, "reset --hard" means to reset HEAD, index and working ...
Jun 25, 3:16 am 2008
Anton Gladkov
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Because 'checkout' in other SCMs like CVS or SVN means 'get latest data from repo', i.e. it acts like 'pull' or 'fetch' in git. And 'branch' means branch manipulation: creating, deleting, switching... -- Best regards, Anton mailto:agladkov@parallels.com --
Jun 25, 3:46 am 2008
Anton Gladkov
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Craig, I'm not trying to say that git incorrectly uses 'checkout' word :) -- Best regards, Anton mailto:agladkov@parallels.com --
Jun 25, 8:18 am 2008
Theodore Tso
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
The one thing I would worry about is the potential ambiguity if you do something like "git checkout FOOBAR", and FOOBAR was both a branch name as well as a file name. How should it be interpreted? I'd argue the real problem was we conflated two distinct operations: "switching to a new branch", and "reverting a file" to the same name, checkout. Hence the suggestion to add a new command, "git revert-file", where there would be no ambiguity. - Ted --
Jun 25, 1:38 pm 2008
Johannes Sixt
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
$ git config alias.switch checkout $ git switch topic Hm? Notice that the command even reports back: Switched to branch "topic" ^^^^^^^^ -- Hannes --
Jun 25, 3:41 am 2008
Avery Pennarun
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
The real question here is the --. Is it strictly needed? It's optional in things like git-diff, which just do their best to guess what you mean if you don't use the --. If reset and checkout made the -- optional, then you could do: git reset filename # undo an accidental "add" git checkout filename # undo accidental modifications that haven't been added ...and save git reset --hard for people willing to take that risk. (The fact that git-gui includes git reset --hard as a ...
Jun 25, 1:22 pm 2008
Junio C Hamano
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Won't fly. 'git checkout -- "$@"' is to revert to the last staged version. * You say "git checkout branch" when you want to "check out that branch"; * You say "git checkout -- file" when you want to "check out the file from the index"; * You say "git checkout v1.5 -- file" when you want to "check out the file out of that revision". It's not that hard. --
Jun 25, 1:11 pm 2008
Ian Hilt
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Something that I think has not been emphasized enough for whatever reason is how _easy_ it is to test out git commands. For example, if you have a really_important_repo that you don't want to screw up, but you need to do a potentially destructive thing to it, just do, $ cp -r /path/to/really_important_repo ~/test $ cd ~/test && git destructive and you find out whether your mental concept of what "git destructive" does is correct or not without possibly losing your work. -- Ian ...
Jun 25, 6:19 am 2008
Steven Walter
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
No, it's not "that hard." But are you really claiming that it's beyond improvement? -- -Steven Walter <stevenrwalter@gmail.com> --
Jun 25, 1:37 pm 2008
Junio C Hamano
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
I just replied to Avery about that. -- is always the way to disambiguate between refs (that come before --) and paths (that come after --), not limited to "git checkout" but with other commands such as "git log", "git diff", etc. --
Jun 25, 1:50 pm 2008
Junio C Hamano
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Then you should revise your impression, as it is simply *WRONG*. When I say something about history of git, I know what I am talking about ;-) Reset has been about nuking local changes from the very beginning. That is why it removes MERGE_HEAD, rr-cache/MERGE_RR as well as removing conflicted stages in the index and reverts local changes from the worktree. It is "my worktree state is a mess, and I cannot even describe nor care which paths are dirty --- just get rid of the local changes so ...
Jun 25, 2:23 am 2008
Craig L. Ching
RE: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Checkout, for me and a lot of people I work with, never meant "get latest data from repo", it always meant "get me a workspace". Anyway, just sharing a dissenting opinion, I don't agree that the checkout verb Cheers, Craig --
Jun 25, 7:49 am 2008
Junio C Hamano
Re* [PATCH] cmd_reset: don't trash uncommitted changes u ...
Ah, interesting. It appears that the current "reset in C" inherited that bug from the scripted version. It works most of the time without -- except for one place. # prove that the work tree is clean... $ git reset --hard HEAD is now at 7b7f39e Fix use after free() in builtin-fetch $ git diff $ git diff --cached # what's different since HEAD^? $ git diff --name-only HEAD^ builtin-fetch.c # reset the path $ git reset HEAD^ ...
Jun 25, 2:24 pm 2008
Junio C Hamano Jun 25, 2:34 pm 2008
Theodore Tso
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
I agree that "git switch" would be a great alias to have for "git checkout". It is much more intuitive; traditionally, the issue has always been that it's not so intuitive for existing git users, who have gotten used to the existing quirks, and it people won't want to break things for the existing users. (There are analogues to this is the English language --- why is it that "though", "through", "plough", "cough", "hough", or "tough" don't rhyme[1]?) Neither does the English language; but ...
Jun 25, 6:51 am 2008
Avery Pennarun
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
"$@" notation actually handles spaces just fine. It's magic that way. On the other hand, "for i in $*" does not, because all the spaces get How about making "git checkout" default to HEAD if no revision is supplied? There's precedent for this in, say, git-diff (and I think a few others). Incidentally, "checkout <filename>" was also the way to do a revert operation in CVS. And the way to switch branches, too, iirc. So git isn't being too unusual here. That said, the commands ...
Jun 25, 1:04 pm 2008
Petr Baudis
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Just to chime in, this reminds me of Cogito - it had cg-switch for switching branches (like git checkout) and cg-restore for restoring files in working copy (like git checkout, too; but you would pass -f if you wanted to overwrite existing copy). (Though, Cogito didn't quite get it right either since it tried to overload cg-switch with the git branch functionality of creating new branches. I still didn't quite come in terms with any UI model of the branches I know about.) -- Petr ...
Jun 25, 3:44 pm 2008
Junio C Hamano
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
You are asking a wrong person. My git knowledge mostly comes from yearlong reading of the mailing list articles, and doing a bit myself also helps ;-). --
Jun 25, 2:35 pm 2008
Avery Pennarun
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Oops, I got mixed up. Only git-reset requires the --. Would it make sense to bring git-reset into line with everything else, then? Thanks, Avery --
Jun 25, 1:58 pm 2008
Junio C Hamano
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Sorry, I do not understand that remark. Does "$@" corrupt embedded spaces in its parameters? --
Jun 25, 1:09 pm 2008
Michael J Gruber
Re: exit status 141 from git-svn
That seems to be the first piece of information you're giving regarding your environment and setup. Giving more may result in getting more answers. (I grepped for 141 in the source after your first posting) Maybe you can cut'n'paste the actual output of git svn fetch? What's the command line you're using, where's the svn repo? Michael --
Jun 25, 7:47 am 2008
Alex Riesen
Re: [PATCH v2] pre-commit hook should ignore carriage re ...
You coud just strip the trailing (cr)lf, instead of chomp: if (s/^\+//) { $lineno++; - chomp; + s/\r?\n$//so; if (/\s$/) { bad_line("trailing whitespace", $_); Makes for a shorter patch and less code. --
Jun 25, 11:14 am 2008
Christian Holtje
Re: [PATCH v2] pre-commit hook should ignore carriage re ...
That's a good idea! However, this patch is not going anyplace, I think. Junio submitted a different patch to disable the pre-commit example. Junio, do you want me to make this change anyway? It does make sense. The unittests for the pre-commit hook may or may not still be useful. Ciao! --
Jun 25, 11:47 am 2008
Junio C Hamano
Re: [PATCH v2] pre-commit hook should ignore carriage re ...
"disable" is not an issue. The intention has always been that these are samples, and it was an accident that some packaging shipped them enabled by mistake. The patch was to make that mistake harder to make. The issue now is about keeping the example hooks _relevant_. The one we have does not work well with projects that want to check in files with CRLF line endings (iow, without using autocrlf to attempt to make the project files cross-platform), so it is irrelevant for such projects ...
Jun 25, 12:14 pm 2008
Michael J Gruber
Re: git svn clone a non-standard repository
All of those module?/{tags,branches} are empty, right? I assume branches So you want one git repo, reflecting the modules simply by different subdirs? I'm afraid that raises similar problems like those I asked about in my (yet unanswered) post This should give you all "modules" (as subsdirs) for all branches and tags already. svn branch "branchname" becomes git remote branch "branchname", svn tag "tagname" becomes git remote branch "tags/tagname". Note that your new git branch trunk ...
Jun 25, 8:25 am 2008
Avery Pennarun
Re: [PATCH/RFC] git-svn: sanitize_remote_name should acc ...
I think there might be higher-level problems here: what is it sanitizing anyway, and why? If it found my D2007_Win32 svn-remote entry in the config (as it seems to have done when trying to locate its parent branch during fetch), and *then* it sanitized it to D2007.Win32, that doesn't even make any sense. Clearly something straight from the config file doesn't need to be sanitized. However, I don't understand the code well enough to be able to say a) whether that's exactly what happened, or ...
Jun 25, 8:01 am 2008
Eric Wong
Re: [PATCH/RFC] git-svn: sanitize_remote_name should acc ...
Thanks, Weird. It looks like a stupid bug on my part. I'm surprised --
Jun 24, 11:44 pm 2008
Eric Wong
Re: [PATCH/RFC] git-svn: sanitize_remote_name should acc ...
No, nothing to do with DNS hostnames in the remote names. I think I just looked at remotes2config.sh one day and used it as a reference :x It's late and I've had a rough few days, but shouldn't sanitize_remote_name() just escape . and "? Right now it's converting stuff to . which has me very confused... -- Eric Wong (in need of sleep and sanity atm...) --
Jun 25, 12:45 am 2008
Junio C Hamano
Re: [PATCH/RFC] git-svn: sanitize_remote_name should acc ...
In [foo "bar"] baz = value foo and baz must be config.c::iskeychar() (and baz must be isalpha()), but "bar" can be almost anything. Isn't "not underscore" coming from DNS hostname part restriction? --
Jun 25, 12:11 am 2008
Eric Wong
Re: [PATCH/RFC] git-svn: sanitize_remote_name should acc ...
Wait, nevermind, this is for remotes, not remote *branches*. Umm... are underscores now allowed in git config files? -- Eric Wong --
Jun 24, 11:55 pm 2008
Karl
Re: [NON-TOY PATCH] git bisect: introduce 'fixed' and 'u ...
Ha. It would not be hard to make it accept any two tags the user happens to use. fast/slow, works/broken, fina-fisken/totalkvaddad, ... it even comes with built-in internationalization! /me ducks. -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle --
Jun 25, 12:27 am 2008
Jakub Narebski
Re: git-fetch remote tag to local branch fails
Why not use one of existing tools (see InterfacesFrontendsAndTools page on Git Wiki, http://git.or.cz/gitwiki/), like IsiSetup, or etckeeper? -- Jakub Narebski Poland ShadeHawk on #git --
Jun 25, 2:10 am 2008
Klas Lindberg
Re: git-fetch remote tag to local branch fails
One tree tracks a configuration file that just contains specs for other trees. The idea is something like this: Given a refspec on the configuration tree, git-view the configuration file and use the contained refspecs to clone/pull/fetch/reset/whatever a bunch of other trees. Note that I'm not trying to solve the problem addressed by the Well yes, but that is only half of it. One of the scenarios I'm pondering is this: A user wants to take an old configuration based on tags and try some ...
Jun 25, 1:50 am 2008
Erez Zilber
Re: git-clone works with ssh but not with http/https/git
Thanks. I was able to config xinetd, and everything seems to work now. I would like to thank everyone here for the quick and very useful help. Erez --
Jun 24, 11:56 pm 2008
Matthieu Moy
Re: why is git destructive by default? (i suggest it not be!)
Depending on the definition of "potentially destructive", most commands are "potentially destructive". git pull loses the point where the branch used to point when the reflog expires. git add loses the old content of the index. ... And adding too many --force options removes its real value. Many people type "rm -fr" any time they just want "rm", just because they were annoyed by the multiple interactive confirmations of plain "rm" (if aliased to "rm -i"). Asking people to type --force ...
Jun 25, 5:20 am 2008
Jing Xue
Re: why is git destructive by default? (i suggest it not be!)
Is that really necessary? The way it works now, when I choose "reset foo branch to here", a dialog prompts me to pick from the three reset modes, with 'Mixed' being the default. So I'd have to explicitly pick 'Hard', which has a message "discards ALL local changes" right next to it. If people are so conditioned to ignore that, I doubt it'll take very long for them to be conditioned to just automatically confirm the confirmation dialog. The same applies to the command line as ...
Jun 25, 10:56 am 2008
Jeff King
Re: [PATCH] clone: create intermediate directories of de ...
The git_dir variable is always set from the directory provided on the command line. However, the work_tree can be overridden by the environment. For some reason I missed the giant 'work_tree = getenv("GIT_WORK_TREE")' when I looked before. But that means that they are not necessarily related. So my original patch was too clever. Here is the less clever patch, with an extra test that would break with the clever version. -- >8 -- clone: create intermediate directories of destination ...
Jun 24, 10:41 pm 2008
Daniel Barkalow
Re: [PATCH] clone: create intermediate directories of de ...
Looks good, thanks. Acked-by: Daniel Barkalow <barkalow@iabervon.org> -Daniel *This .sig left intentionally blank* --
Jun 24, 11:11 pm 2008
Shawn O. Pearce
Re: [JGIT PATCH 00/10] Support writing pack index version 2
Yea, OK, I know what that is. I busted PackIndex.isTOC. I asked it to compare a 4 byte array (TOC only) to an 8 byte array (TOC + version) and of course 4 != 8 so it fails. Thus all V2 index files look like V1 files. Only they aren't; and then all hell breaks loose when we start treating parts of the V2 index as different sections of the V1 index. That's because Marek's branch includes additional tests for features he added to PackIndexV2. But all PackIndexV2 reading is ...
Jun 24, 8:54 pm 2008
Shawn O. Pearce
[JGIT PATCH 06/10 v2] Reuse the magic tOc constant for p ...
We need this constant to detect version 2 index files at read time, but we also need it to create version 2 index files. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> --- Fixed isTOC test to return true when h.length == 8, which is always the case as it has both the TOC and the version. Also rebased into my branch: repo.or.cz:/srv/git/egit/spearce.git index-v2 With this patch in the series all tests pass again. .../src/org/spearce/jgit/lib/PackIndex.java | ...
Jun 24, 9:01 pm 2008
Boaz Harrosh
Re: why is git destructive by default? (i suggest it not be!)
Does not work. only --hard will do the job. The working directory is not touched and if you'll do a git-diff you'll see the diff between old-head the closest to git reset --hard that I can think of is: Lets say I have $ git-branch -a * mybranch remote/master I can $ git reset --hard remote/master Or I can $ git-checkout -b temp_mybranch remote/master $ git-branch -M temp_mybranch mybranch The second will complain if I have local changes. I have just written 2 scripts. One ...
Jun 25, 1:57 am 2008
Theodore Tso
Re: why is git destructive by default? (i suggest it not be!)
Well, it was Brandon Casey who was asserting that git reset --hard was evil, which I generally don't agree with. I do use workflows that use it a fair amount, usually because its more convenient to type "git checkout <foo>; git reset --hard <baz>" than something involving "git update-ref refs/heads/<foo> <baz>". The former has more characters than the latter, and involves more disk I/O since it mutates the working directory; but it's something about needing to type "refs/heads/" such that I ...
Jun 24, 7:26 pm 2008
Jakub Narebski
Re: why is git destructive by default? (i suggest it not be!)
Hmmmm.... Wouldn't it be easier on fingers to use git reset --soft integration -- Jakub Narebski Poland --
Jun 25, 1:58 am 2008
Junio C Hamano
Re: why is git destructive by default? (i suggest it not be!)
That does not do anything close to what Ted is doing, does it? Anyway, here is how I conclude my git day: git checkout next ... merge more and test ... be happy that next is in very good shape ;-) git branch -f pu git checkout pu git merge ... merge other topics to rebuild pu git merge ... ... which is probably a bit less error prone then update-ref, if you type from the command line like I do. --
Jun 25, 2:14 am 2008
Johannes Gilger
Re: [PATCH] cmd_reset: don't trash uncommitted changes u ...
Oh no. I can only agree and repeat myself, as I think this is nonsense. git is a tool, and like every tool you can hurt yourself with it if you don't read the manual and follow really simple guidelines. I used git reset --hard on a test-repo before using it on my real code, and it has never bit me since. Why do we have --hard then? It would be "An option which does nothing unless you also specify -f on the command-line". Just my opinion, but I think quite a few people feel the ...
Jun 24, 10:29 pm 2008
Junio C Hamano
Re: Fix t5303 (the test case for pack corruptions) on Windows
Thanks. By the way, there are others. t/t9106-git-svn-dcommit-clobber-series.sh:23: perl -i -p -e "s/^58$/5588/" file && t/t9106-git-svn-dcommit-clobber-series.sh:24: perl -i -p -e "s/^61$/6611/" file && t/t9106-git-svn-dcommit-clobber-series.sh:43: perl -i -p -e 's/^4\$/4444/' file && t/t9106-git-svn-dcommit-clobber-series.sh:44: perl -i -p -e 's/^7\$/7777/' file && templates/hooks--prepare-commit-msg.sample:25: perl -i -ne 's/^/# /, s/^# #/#/ if /^Conflicts/ .. /#/; print' "$1" ...
Jun 25, 10:42 am 2008
Alex Riesen
Fix t5303 (the test case for pack corruptions) on Windows
The perldiag(1) has following to say about this: "Can't do inplace edit without backup" (F) You're on a system such as MS-DOS that gets confused if you try reading from a deleted (but still opened) file. You have to say -i.bak, or some such. Signed-off-by: Alex Riesen <raa.lkml@gmail.com> --- t/t5303-pack-corruption-resilience.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t5303-pack-corruption-resilience.sh ...
Jun 25, 9:44 am 2008
Alex Riesen
[PATCH] Fix t5303 (the test case for pack corruptions) o ...
The perldiag(1) has following to say about this: "Can't do inplace edit without backup" (F) You're on a system such as MS-DOS that gets confused if you try reading from a deleted (but still opened) file. You have to say -i.bak, or some such. Signed-off-by: Alex Riesen <raa.lkml@gmail.com> --- Ouch, I have the svn tests disabled, so I couldn't notice. FWIW, resending with the rest corrected. t/t5303-pack-corruption-resilience.sh | 4 ++-- ...
Jun 25, 11:35 am 2008
Alex Riesen
Re: how to rewalk the commit list after rename detection
Try looking at git log --follow <name> --
Jun 25, 12:04 pm 2008
Jakub Narebski
Re: how to rewalk the commit list after rename detection
Unfortunately it _almost_ works, see: "git log --follow <filename> doesn't follow across 'subtree strategy' merge" Message-ID: <200806221451.50624.jnareb@gmail.com> http://permalink.gmane.org/gmane.comp.version-control.git/85766 ("git log --follow gitweb/gitweb.perl follows rename from gitweb/gitweb.cgi, but not rename (moving) from gitweb.cgi in a merge commit). -- Jakub Narebski Poland ShadeHawk on #git --
Jun 25, 1:50 pm 2008
Junio C Hamano
What's cooking in git.git (topics)
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' while commits prefixed with '+' are in 'next'. The topics list the commits in reverse chronological order. It already is beginning to become clear what 1.6.0 will look like. What's already in 'next' all are well intentioned (I do not guarantee they are already bug-free --- that is what cooking them in 'next' is for) and are good set of feature enhancements. But bigger changes will be: * MinGW will be ...
Jun 25, 2:31 am 2008
Johannes Sixt
Re: [RFC] Re: Convert 'git blame' to parse_options()
We use threads only for those fork()s that are not followed by an exec(). So this is not a reason to worry about memory leaks in the option parser. -- Hannes --
Jun 24, 11:09 pm 2008
Andreas Ericsson
Re: [PATCH 5/7] parse-opt: fake short strings for caller ...
Why not just provide some api-functions to return a strbuf of the short and long options each? parse_opt_short_help(strbuf *sb, options...); parse_opt_long_help(strbuf *sb_long, options...); That way multi-parseopt programs can get their help-texts done right with very little extra work. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 --
Jun 25, 8:07 am 2008
Olivier Marin
Re: [PATCH 12/13] Build in merge
Hi, I did not read your patches yet but I noticed the two following bugs while testing current pu. You probably want to add DIFF_OPT_SET(&opts, COLOR_DIFF) to have a nice colored diff Here, the second call to find_unique_abbrev() will overwrite the previous returned value because this function return a pointer to a static buffer. Olivier. --
Jun 25, 9:22 am 2008
Shawn O. Pearce
Re: What's cooking in git.git (topics)
FYI, it actually runs git-upload-pack, gets the list of advertised refs, then closes the connection immediately. The other side sees the client hang up and just terminates silently, since the client didn't "want" anything packed and sent. -- Shawn. --
Jun 24, 8:32 pm 2008
Junio C Hamano
Re: What's cooking in git.git (topics)
Then that would be this patch on top of nd/dashless topic. Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 929136b..babf16b 100644 --- a/Makefile +++ b/Makefile @@ -1268,7 +1268,7 @@ install: all $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)' $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitexecdir_SQ)' $(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexecdir_SQ)' - $(INSTALL) git$X '$(DESTDIR_SQ)$(bindir_SQ)' + $(INSTALL) git$X ...
Jun 24, 7:57 pm 2008
Miklos Vajna
Re: What's cooking in git.git (topics)
On Tue, Jun 24, 2008 at 05:11:44PM -0700, Jakub Narebski <jnareb@gmail.com>= =20 $ git ls-remote server:/home/vmiklos/git/test bash: git-upload-pack: command not found fatal: The remote end hung up unexpectedly
Jun 25, 12:29 am 2008
しらいしななこ
Re: What's cooking in git.git (topics)
Doesn't "git archive --remote=<repo>" also execute git program on a remote machine? -- Nanako Shiraishi http://ivory.ap.teacup.com/nanako3/ --
Jun 24, 8:08 pm 2008
Jakub Narebski
Re: What's cooking in git.git (topics)
What does "git ls-remote server:/home/vmiklos/git/test" invoke on server? -- Jakub Narebski Poland ShadeHawk on #git --
Jun 24, 5:11 pm 2008
Shawn O. Pearce
Re: What's cooking in git.git (topics)
Yes, it runs git-upload-archive on the remote side. The three primary services for the remote side are documented in daemon.c: 403 static struct daemon_service daemon_service[] = { 404 { "upload-archive", "uploadarch", upload_archive, 0, 1 }, 405 { "upload-pack", "uploadpack", upload_pack, 1, 1 }, 406 { "receive-pack", "receivepack", receive_pack, 0, 1 }, 407 }; (with git- prefixes). IMHO all three need to be in $PATH, along with git and gitk, through at ...
Jun 24, 8:26 pm 2008
Junio C Hamano
What's in git.git (stable)
We'd need a maint release soon to push out the mkstemp() breakage but not tonight. There are a handful changes that are in 'master' and 'next' that need backport/backmerge before 1.5.6.1 happens. * The 'maint' branch has these fixes since the last announcement. Jan Krüger (1): git-svn: make rebuild respect rewriteRoot option Patrick Higgins (1): Workaround for AIX mkstemp() * The 'master' branch has these since the last announcement in addition to the above. Jeff King (1): ...
Jun 25, 2:34 am 2008
Johannes Sixt
Re: [PATCH] git-gui: Don't select the wrong file if the ...
Thanks. It works here, too: Tested-by: Johannes Sixt <johannes.sixt@telecom.at> -- Hannes --
Jun 25, 3:49 am 2008
Shawn O. Pearce Jun 25, 1:57 pm 2008
Abhijit Menon-Sen
[PATCH] git-gui: Don't select the wrong file if the last ...
Johannes Sixt noticed that if the last file in the list was staged, my earlier patch would display the diff for the penultimate file, but show the file _before_ that as being selected. This was due to my misunderstanding the lno argument to show_diff. This patch fixes the problem: lno is not decremented in the special case to handle the last item in the list (though we still need to use $lno-1 to find the right path for the next diff). Signed-off-by: Abhijit Menon-Sen ...
Jun 25, 3:36 am 2008
Jeff King
Re: [PATCH 1/3] Allow git-apply to ignore the hunk heade ...
Sorry, this is my fault. I hadn't looked at the recount patches closely, but I had thought they were submit-worthy, so I encouraged Thomas to include them in his series (since his patch depends on them). I'll try to look them over more closely in the next day or two. -Peff --
Jun 24, 10:45 pm 2008
previous daytodaynext day
June 24, 2008June 25, 2008June 26, 2008