Re: [PATCH/RFC] git-svn: sanitize_remote_name should accept underscores.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Eric Wong <normalperson@...>
Cc: Junio C Hamano <gitster@...>, <git@...>
Date: Wednesday, June 25, 2008 - 11:01 am

On 6/25/08, Eric Wong <normalperson@yhbt.net> wrote:

I think there might be higher-level problems here: what is it
sanitizing anyway, and why?  If it found my D2007_Win32 svn-remote
entry in the config (as it seems to have done when trying to locate
its parent branch during fetch), and *then* it sanitized it to
D2007.Win32, that doesn't even make any sense.  Clearly something
straight from the config file doesn't need to be sanitized.

However, I don't understand the code well enough to be able to say a)
whether that's exactly what happened, or b) other places where
sanitize_remote_name() *is* important, or c) whether
sanitize_remote_name() is even correct.

Have fun,

Avery
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH/RFC] git-svn: sanitize_remote_name should accept ..., Avery Pennarun, (Wed Jun 25, 11:01 am)