Removes unused functions object_list_append(), object_list_legnth() and bject_list_contains(). Signed-off-by: Nanako Shiraishi <nanako3@lavabit.com> --- This is my first foray into C programming, so please be kind. object.c | 31 ------------------------------- object.h | 7 ------- 2 files changed, 0 insertions(+), 38 deletions(-) diff --git a/object.c b/object.c index 50b6528..b386d58 100644 --- a/object.c +++ b/object.c @@ -215,37 +215,6 @@ struct object_list *object_list_...

Removes get_refs_directory() that is not used anywhere. Signed-off-by: Nanako Shiraishi <nanako3@lavabit.com> --- cache.h | 1 - environment.c | 7 ------- 2 files changed, 0 insertions(+), 8 deletions(-) diff --git a/cache.h b/cache.h index fdf07b7..64eba9d 100644 --- a/cache.h +++ b/cache.h @@ -311,7 +311,6 @@ extern char *git_work_tree_cfg; extern int is_inside_work_tree(void); extern const char *get_git_dir(void); extern char *get_object_directory(void); -extern c...

So these four patches end up adding support for conditionally enabling fsync() on loose object creation in the .gitconfig file with something like [core] FsyncObjectFiles = true which can be useful on filesystems that don't already guarantee data consistency for other reasons (whether due to ordered writes or due to full data journalling). Actually, just the last one adds the fairly trivial feature, the three first patches are just cleanups of the config parsing that I needed in o...

Maybe it would be easier still to read (and unmeasurably more efficient) to actually do it like: if (!prefixcmp(var, "core.")) return git_default_core_config(var+5, value); ... int git_default_core_config(const char *var, const char *value) { if (!strcmp(var, "pager")) I was curious a while ago and instrumented git_config to write the PID to a tempfile each time it was called. Most git programs parse the config files (.git/config, ~/.gitconfig, /etc/gitconfig)...

I actually find the hierarchy a bit nonsensical. We talk about core.pager and branch.master.remote, but the config file doesn't look like that. So I buy that it's [core] pager but then it seems kind of arbitrary to have [branch "master"] remote instead of [branch] master.remote or [branch] [master] remote which is of course impossible because we don't have a "close section" syntax element. It seems like the '.' implies hierarchy, but the syntax of the file ...

From: Linus Torvalds <torvalds@linux-foundation.org> Date: Wed, 18 Jun 2008 14:40:35 -0700 Subject: [PATCH 2/4] Split up default "user" config parsing into helper routine This follows the example of the "core" config, and splits out the default "user" config option parsing into a helper routine. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> --- config.c | 17 +++++++++++++---- 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/config.c b/config.c ...

From: Linus Torvalds <torvalds@linux-foundation.org> Date: Wed, 18 Jun 2008 15:18:44 -0700 Subject: [PATCH 4/4] Add config option to enable 'fsync()' of object files As explained in the documentation[*] this is totally useless on filesystems that do ordered/journalled data writes, but it can be a useful safety feature on filesystems like HFS+ that only journal the metadata, not the actual file contents. It defaults to off, although we could presumably in theory some day auto-enable it on...

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> --- git-merge.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-merge.sh b/git-merge.sh index 5fc5f52..8026ccf 100755 --- a/git-merge.sh +++ b/git-merge.sh @@ -13,7 +13,7 @@ n don't show a diffstat at the end of the merge summary (synonym to --stat) log add list of one-line log to merge commit message squash create a single commit instead of...

Instead of using IO::String to create an in-memory filehandle, use open() with a scalar reference as the filename. This feature has been available since Perl 5.8.0 (which was released in 2002), so it should be available pretty much everywhere by now. Signed-off-by: Michael Hendricks <michael@ndrix.org> --- This patch should apply on top of Junio's lw/perlish branch. t/t9700/test.pl | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/t/t9700/test.pl b/t...

Hi, Did I miss something? Was this patch not more about Git.pm? BTW I think it is not nice at all how the dependency hell with Git.pm is made worse recently. It is fascinating through how much _pain_ we go with the shell scripts to maintain portability, even with _very_ old or obscure systems (see the SCO server patches that came in not long ago!), and just walk over that portability when it comes to Perl... Ciao, Dscho --

Hi, Heh. The part about the shell scripts was actually meant as a genuine praise. And I did not mean to criticize _you_ for introducing IO::Stream. Ciao, Dscho --

Hi, So? Why do you want to break the _test_ on those machines where you need I have to point out that the platforms I was speaking of are not know to make upgrading as easy as Linux. And some of them _do_ come with pretty old perl. And yes, I had this exact issue (remember when I worked on removing Git's dependency on Python? That was it. Not enough quota. Uncooperative admin. Desperate need for a sensible SCM). In any case, I have to reiterate my point: breaking backwards-compa...

"use 5.008;" is preferred form; "use v5.8.0" might yield obscure error messages on perls < 5.6, which is not the desired result. --

Signed-off-by: Florian Koeberle <florianskarten@web.de> --- .../spearce/jgit/fnmatch/FileNameMatcherTest.java | 726 ++++++++++++++++++++ .../jgit/errors/InvalidPatternException.java | 65 ++ .../jgit/errors/NoClosingBracketException.java | 69 ++ .../src/org/spearce/jgit/fnmatch/AbstractHead.java | 74 ++ .../org/spearce/jgit/fnmatch/CharacterHead.java | 53 ++ .../org/spearce/jgit/fnmatch/FileNameMatcher.java | 351 ++++++++++ .../src/org/spearce/jgit/fnmatch/GroupH...

Patience please. When there is long series it *will* take time for a number of reasons. Most have nothing to do with this project at all. But in general you will find a short patch series *much* easier to get through than a long one. If you think my grouping is ok, then ack and I can commit from there. I --

I am sending this out just as the final minute preview before 1.5.6 final, hopefully tomorrow night. * The 'maint' branch has these fixes since the last announcement. Junio C Hamano (1): diff.c: fix emit_line() again not to add extra line SZEDER Gábor (1): diff: reset color before printing newline * The 'master' branch has these since the last announcement in addition to the above. Alejandro Mery (1): git-am: head -1 is obsolete and doesn't work on some new systems Avery Pe...

[Empty message]

I guess I should have searched the list _before_ creating these patches since I just now stumbled upon some of the questions about how this should be done for example: http://kerneltrap.org/mailarchive/git/2008/3/1/1035344 From my testing this seems to work fine, but I may have missed a use case. I actually created these patches because I was annoyed that: git shortlog --author=bohrer -s HEAD didn't work, and this also fixes that issue. -- Shawn --

I have to say that this conceptually is broken. How would you tell without knowing what "--flag" is if the thing in argv[] after that is a parameter to that option or the end of the options? --

Not necessarily. You could structure individual option parsers like how diff option parsers are done. You iterate over argv[], feed diff option parser the current index into argv[] and ask if it is an option diff understands, have diff eat the option (and possibly its parameter) to advance the index, or allow diff option to say "I do not understand this", and then handle it yourself or hand it to other parsers. --

I think that is the more painful approach Jeff mentioned, and my comment was to show that it is not the only way. --

Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com> --- builtin-shortlog.c | 54 +++++++++++++++++++++++++++------------------------ 1 files changed, 29 insertions(+), 25 deletions(-) diff --git a/builtin-shortlog.c b/builtin-shortlog.c index e6a2865..b1087b5 100644 --- a/builtin-shortlog.c +++ b/builtin-shortlog.c @@ -7,9 +7,12 @@ #include "utf8.h" #include "mailmap.h" #include "shortlog.h" +#include "parse-options.h" -static const char shortlog_usage[] = -"git-shortlog [-n]...

Hi Jakub, thank you very much -- you solved my problem and it works like a charm. :-) Have a nice day, Martin --

You'll need another patch for the decorator to pick up derived resources properly. Probably not the final solution to decorations. For one thing the I'd say implementing .git/info/exlude is the proper solution. The others are mere workarounds. -- robin From 7acc0e63886ed8eda6b38a5edbfe9a6aa4d509dc Mon Sep 17 00:00:00 2001 From: Robin Rosenberg <robin.rosenberg@dewire.com> Date: Wed, 18 Jun 2008 23:50:42 +0200 Subject: [PATCH] Decorate derived resources as ignored. This is done by ...

Hi, Just a typo here: s/eror/error/ Olivier. --