Re: [PATCH] Remove dependency on IO::String from Git.pm test

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Michael Hendricks <michael@...>
Cc: <gitster@...>, <git@...>
Date: Wednesday, June 18, 2008 - 10:46 am

Michael Hendricks <michael@ndrix.org> writes:


Besides if I understand correctly gitweb very much requires Perl >= 5.8
because of required Unicode support.

Nevertheless adding "use v5.8.0;" or "use 5.008_000;" would be I guess
good idea.


And best solution, although perhaps unnecessary, would be to check
for version >= 5.8, if older check for IO::String, and even if that
fails, simply skip those tests that require in-memory filehandle
(or use tempfile).

-- 
Jakub Narebski
Poland
ShadeHawk on #git
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Remove dependency on IO::String from Git.pm test, Michael Hendricks, (Wed Jun 18, 9:37 am)
Re: [PATCH] Remove dependency on IO::String from Git.pm test, Jakub Narebski, (Wed Jun 18, 10:46 am)
Re: [PATCH] Remove dependency on IO::String from Git.pm test, Johannes Schindelin, (Wed Jun 18, 1:00 pm)
Re: [PATCH] Remove dependency on IO::String from Git.pm test, Johannes Schindelin, (Wed Jun 18, 3:37 pm)
Re: [PATCH] Remove dependency on IO::String from Git.pm test, Johannes Schindelin, (Wed Jun 18, 3:35 pm)
Re: [PATCH] Remove dependency on IO::String from Git.pm test, Rafael Garcia-Suarez, (Wed Jun 18, 11:10 am)