Re: git-rerere observations and feature suggestions

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: <git@...>
Date: Monday, June 16, 2008 - 4:50 pm

Ingo Molnar <mingo@elte.hu> writes:


Oh, "unsafe switch" that is off by default will not hurt anybody, and I do
not mind it as a new feature.  We are in agreement in that sense.

Perhaps the way forward would be (and this is independent of the issue of
recording removal as a possible form of resolution):

 (1) Introduce a new configuration rerere.autoupdate that is off by
     default, but when it is on, paths cleanly resolved by rerere will
     also be updated in the index (if we have capability to record
     removal, this may remove such a path from the index as the result).

 (2) The callers of rerere that expects rerere to resolve needs to be
     changed to see if the resulting index after rerere is fully merged,
     and continue.  Currently the callers are "merge", "rebase" and "am",
     I think.  This step might be a bit more involved than you might
     think, as rerere currently happens in the codepath that knows the
     caller does _not_ go further than leaving the failed conflict to be
     sorted out by the user (rerere is designed as merely a way to help).

     Also you _might_ want a separate configuration rerere.autocommit to
     control this --- the user (but not you) might be willing to allow
     autoupdate but you may still want to eyeball the result.

Independent of the above, we have two potential new features:

 * Introduce "git rerere revert paths..."  that brings the index and
   working tree back to the conflicted state after a previous resolution
   is applied, because that resolution is incorrect.  The old resolution
   cached in rr-cache is also removed.

   This however will become much less useful if you allow autoresolution
   to be committed automatically, as the caller will move ahead without
   giving you a chance to say "oh, that one is bad -- do not proceed".

 * Somehow record the fact that the resolution for a particular conflict
   signature is to remove the resulting path.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
git-rerere observations and feature suggestions, Ingo Molnar, (Mon Jun 16, 7:01 am)
Re: git-rerere observations and feature suggestions, Johannes Schindelin, (Tue Jun 17, 6:24 am)
Re: git-rerere observations and feature suggestions, Jakub Narebski, (Mon Jun 16, 4:11 pm)
Re: git-rerere observations and feature suggestions, Junio C Hamano, (Mon Jun 16, 2:46 pm)
Re: git-rerere observations and feature suggestions, Ingo Molnar, (Mon Jun 23, 5:49 am)
Re: git-rerere observations and feature suggestions, Jeff King, (Mon Jun 23, 11:12 am)
Re: git-rerere observations and feature suggestions, Ingo Molnar, (Mon Jun 23, 11:22 am)
Re: git-rerere observations and feature suggestions, Peter Zijlstra, (Mon Jun 23, 10:19 am)
Re: git-rerere observations and feature suggestions, Peter Zijlstra, (Mon Jun 23, 10:26 am)
Re: git-rerere observations and feature suggestions, Junio C Hamano, (Mon Jun 16, 3:10 pm)
Re: git-rerere observations and feature suggestions, Ingo Molnar, (Mon Jun 16, 3:44 pm)
Re: git-rerere observations and feature suggestions, Ingo Molnar, (Mon Jun 16, 3:09 pm)
Re: git-rerere observations and feature suggestions, Ingo Molnar, (Wed Jun 18, 6:57 am)
Re: git-rerere observations and feature suggestions, Jakub Narebski, (Wed Jun 18, 6:01 pm)
Re: git-rerere observations and feature suggestions, Miklos Vajna, (Wed Jun 18, 6:38 pm)
Re: git-rerere observations and feature suggestions, Junio C Hamano, (Thu Jun 19, 3:30 am)
Re: git-rerere observations and feature suggestions, Miklos Vajna, (Thu Jun 19, 4:33 am)
Re: git-rerere observations and feature suggestions, Miklos Vajna, (Thu Jun 19, 6:06 am)
Re: git-rerere observations and feature suggestions, Miklos Vajna, (Thu Jun 19, 3:29 am)
Re: git-rerere observations and feature suggestions, Ingo Molnar, (Wed Jun 18, 7:36 am)
Re: git-rerere observations and feature suggestions, Miklos Vajna, (Wed Jun 18, 7:29 am)
Re: git-rerere observations and feature suggestions, Ingo Molnar, (Wed Jun 18, 2:43 pm)
Re: git-rerere observations and feature suggestions, Miklos Vajna, (Wed Jun 18, 3:53 pm)
Re: git-rerere observations and feature suggestions, Junio C Hamano, (Mon Jun 16, 4:50 pm)
Re: git-rerere observations and feature suggestions, Theodore Tso, (Mon Jun 16, 7:27 am)
Re: git-rerere observations and feature suggestions, Ingo Molnar, (Mon Jun 16, 3:52 pm)
Re: git-rerere observations and feature suggestions, Junio C Hamano, (Mon Jun 16, 4:25 pm)
Re: git-rerere observations and feature suggestions, Ingo Molnar, (Mon Jun 16, 4:46 pm)
Re: git-rerere observations and feature suggestions, Junio C Hamano, (Mon Jun 16, 5:37 pm)
Re: git-rerere observations and feature suggestions, Mike Hommey, (Mon Jun 16, 7:09 am)
Re: git-rerere observations and feature suggestions, Pierre Habouzit, (Mon Jun 16, 11:48 am)
Re: git-rerere observations and feature suggestions, Pierre Habouzit, (Mon Jun 16, 11:57 am)
Re: git-rerere observations and feature suggestions, Sverre Rabbelier, (Mon Jun 16, 12:18 pm)