Re: [PATCH 3/4] remote prune: print the list of pruned branches

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Olivier Marin <dkr+ml.git@...>
Cc: Johannes Schindelin <Johannes.Schindelin@...>, Shawn O. Pearce <spearce@...>, <git@...>, Olivier Marin <dkr@...>
Date: Thursday, June 12, 2008 - 3:00 am

Olivier Marin <dkr+ml.git@free.fr> writes:


Thanks.  I've queued the series (with minor fixups and rewording) to
'next' already, hoping that we can merge this fix to 'master' before
1.5.6.

But I am very tempted to also apply the following on top.  Thoughts?

-- >8 --
[PATCH] "remote prune": be quiet when there is nothing to prune

The previous commit made it always say "Pruning $remote" but reported the
URL only when there is something to prune.  Make it consistent by not
saying anything at all when there is nothing to prune.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin-remote.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/builtin-remote.c b/builtin-remote.c
index 4b00cf9..145dd85 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -560,12 +560,13 @@ static int prune(int argc, const char **argv)
 
 		get_remote_ref_states(*argv, &states, 1);
 
-		printf("Pruning %s\n", *argv);
-		if (states.stale.nr)
+		if (states.stale.nr) {
+			printf("Pruning %s\n", *argv);
 			printf("URL: %s\n",
 			       states.remote->url_nr
 			       ? states.remote->url[0]
 			       : "(no URL)");
+		}
 
 		for (i = 0; i < states.stale.nr; i++) {
 			const char *refname = states.stale.items[i].util;
-- 
1.5.6.rc2.26.g8c37
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
remote show/prune: strange -n(--dry-run) option., Olivier Marin, (Sat Jun 7, 8:54 pm)
[PATCH] remote show: fix the -n option, Olivier Marin, (Sun Jun 8, 8:48 pm)
[PATCH v2] remote show: fix the -n option, Olivier Marin, (Mon Jun 9, 11:58 am)
Re: [PATCH v2] remote show: fix the -n option, Johannes Schindelin, (Mon Jun 9, 12:35 pm)
Re: [PATCH v2] remote show: fix the -n option, Junio C Hamano, (Mon Jun 9, 9:10 pm)
[PATCH 0/4] remote show/prune improvement, Olivier Marin, (Tue Jun 10, 10:50 am)
Re: [PATCH 0/4] remote show/prune improvement, Jakub Narebski, (Tue Jun 10, 11:09 am)
Re: [PATCH 0/4] remote show/prune improvement, Olivier Marin, (Tue Jun 10, 12:10 pm)
Re: [PATCH 0/4] remote show/prune improvement, Jakub Narebski, (Tue Jun 10, 1:11 pm)
Re: [PATCH 3/4] remote prune: print the list of pruned branc..., Junio C Hamano, (Thu Jun 12, 3:00 am)
[PATCH 1/4] remote show: fix the -n option, Olivier Marin, (Tue Jun 10, 10:51 am)
Re: [PATCH v2] remote show: fix the -n option, Shawn O. Pearce, (Mon Jun 9, 9:19 pm)
Re: [PATCH v2] remote show: fix the -n option, Johannes Schindelin, (Mon Jun 9, 10:39 pm)
Re: [PATCH v2] remote show: fix the -n option, Olivier Marin, (Mon Jun 9, 12:58 pm)
Re: [PATCH v2] remote show: fix the -n option, Johannes Schindelin, (Mon Jun 9, 1:56 pm)
Re: [PATCH v2] remote show: fix the -n option, Olivier Marin, (Mon Jun 9, 2:37 pm)
[PATCH] builtin-remote: make reuse of code easier by not die..., Johannes Schindelin, (Mon Jun 9, 4:11 pm)
Re: [PATCH] remote show: fix the -n option, Johannes Schindelin, (Sun Jun 8, 9:16 pm)
Re: [PATCH] remote show: fix the -n option, Olivier Marin, (Sun Jun 8, 10:06 pm)
Re: [PATCH] remote show: fix the -n option, Johannes Schindelin, (Sun Jun 8, 10:35 pm)
Re: [PATCH] remote show: fix the -n option, Olivier Marin, (Mon Jun 9, 12:16 am)
Re: [PATCH] remote show: fix the -n option, Johannes Schindelin, (Mon Jun 9, 12:53 am)
Re: [PATCH] remote show: fix the -n option, Olivier Marin, (Mon Jun 9, 10:22 am)
Re: [PATCH] remote show: fix the -n option, Olivier Marin, (Mon Jun 9, 11:43 am)
Re: [PATCH] remote show: fix the -n option, Johannes Schindelin, (Mon Jun 9, 12:31 pm)