'git format-patch' on older commits, and mailinglist

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Marius Storm-Olsen
Date: Tuesday, June 10, 2008 - 3:09 am

Hi,

Recently, I sent out patches which were fixed up with --amend on older=20
commits. When I sent them out, the patches contained
     Date: <more than 2 days old datestamp>
in the headers. Now, sending these mails is fine, and mail clients=20
generally handles it perfectly fine. However, after doing this I got=20
an email from postmaster@vger.kernel.org, basically telling me to not=20
do this, since they get a lot of bounces where the return is marked with
     Diagnostic Code: smtp; 550 (4.5 DATE_IN_PAST_48_96 Date: is 48 to=20
96 hours before Received: date)

This is understandable. The question is, do we fix the tools to handle=20
this, so that emails are always generated with now() date, and the=20
commit content contains a tag for the original commit; or do we simply=20
say, always send patches to the mailing list with a current timestamp?

Maybe my workflow is incorrect too. I don't mind pointers on this.

I guess rebasing before generating the patch series would have fixed=20
this, but I really didn't need to. I simply reset HEAD~2, fixed with=20
--amend, then cherry-picked the other on top again; then created the=20
patch series.

--=20
=2Emarius
- simply wondering what others on the git mailinglist do..
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
'git format-patch' on older commits, and mailinglist, Marius Storm-Olsen, (Tue Jun 10, 3:09 am)
Re: 'git format-patch' on older commits, and mailinglist, Junio C Hamano, (Tue Jun 10, 3:37 pm)