Re: [PATCH] Reset the graph plotter internals when HEAD has changed.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Robin Rosenberg <robin.rosenberg.lists@...>
Cc: <git@...>, Robin Rosenberg <robin.rosenberg@...>
Date: Monday, June 9, 2008 - 8:40 pm

Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:

Hmm.
 

Tossing the currentWalk just because HEAD changed to a different
commit shouldn't be necessary.  Its very heavy-handed.  Clearly
there is a bug in the plotter code where the reset does not clear
state right.

For now this is a reasonable work around.  I'll try to remember
to come back and debug this case in the future as tossing the
entire SWTWalk does reduce redraw performance.

Thanks for at least coming up with the work-around.

-- 
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[EGIT PATCHES] Assorted minor fixes, Robin Rosenberg, (Mon Jun 9, 6:50 pm)
Re: [EGIT PATCHES] Assorted minor fixes, Shawn O. Pearce, (Mon Jun 9, 8:31 pm)
Re: [EGIT PATCHES] Assorted minor fixes, Robin Rosenberg, (Tue Jun 10, 2:29 am)
Re: [PATCH] Reset the graph plotter internals when HEAD has ..., Shawn O. Pearce, (Mon Jun 9, 8:40 pm)
[PATCH] Fix a typo., Robin Rosenberg, (Mon Jun 9, 6:50 pm)
[PATCH] Drop an unused empty menu contribution., Robin Rosenberg, (Mon Jun 9, 6:50 pm)