login
Header Space

 
 

[PATCH] http-push: remove remote locks on exit signals

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <git@...>
Date: Thursday, May 22, 2008 - 3:55 pm

If locks are not cleaned up the repository is inaccessible for 10 minutes.

Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---

Hi,

To test this I created a large file, added it, commited, pushed, waited one
second and pressed Ctrl+C. If this method is acceptable for the regression
tests, or if you have a better idea, let me know. I will write up a script.

Regards,
Clemens

---
 http-push.c |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)

diff --git a/http-push.c b/http-push.c
index 5b23038..b1f5302 100644
--- a/http-push.c
+++ b/http-push.c
@@ -1349,6 +1349,24 @@ static int unlock_remote(struct remote_lock *lock)
 	return rc;
 }
 
+static void remove_locks(void)
+{
+	struct remote_lock *lock = remote->locks;
+	
+	fprintf(stderr, "Removing remote locks...\n");
+	while (lock) {
+		unlock_remote(lock);
+		lock = lock->next;
+	}
+}
+
+static void remove_locks_on_signal(int signo)
+{
+	remove_locks();
+	signal(SIGINT, SIG_DFL);
+	raise(signo);
+}
+
 static void remote_ls(const char *path, int flags,
 		      void (*userFunc)(struct remote_ls_ctx *ls),
 		      void *userData);
@@ -2255,6 +2273,8 @@ int main(int argc, char **argv)
 		goto cleanup;
 	}
 
+	signal(SIGINT, remove_locks_on_signal);
+
 	/* Check whether the remote has server info files */
 	remote->can_update_info_refs = 0;
 	remote->has_info_refs = remote_exists("info/refs");
-- 
1.5.5.1.1.g95a6

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] http-push: remove remote locks on exit signals, Clemens Buchacher, (Thu May 22, 3:55 pm)
Re: [PATCH] http-push: remove remote locks on exit signals, Junio C Hamano, (Fri May 23, 5:40 pm)
Re: [PATCH] http-push: remove remote locks on exit signals, Clemens Buchacher, (Fri May 23, 6:17 pm)
[PATCH] http-push: remove remote locks on exit signals, Clemens Buchacher, (Sun May 25, 2:27 pm)
[PATCH] Reset the signal being handled, Clemens Buchacher, (Sun May 25, 2:26 pm)
Re: [PATCH] Reset the signal being handled, Johannes Schindelin, (Mon May 26, 5:34 am)
[PATCH] lockfile: reset the correct signal, Clemens Buchacher, (Mon May 26, 3:35 pm)
Re: [PATCH] lockfile: reset the correct signal, Johannes Schindelin, (Mon May 26, 5:36 pm)
Re: [PATCH] lockfile: reset the correct signal, Clemens Buchacher, (Tue May 27, 3:49 am)
speck-geostationary