login
Header Space

 
 

builtin-clone does not fallback to copy when link fails

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Daniel Barkalow <barkalow@...>
Cc: Git Mailing List <git@...>, Johannes Schindelin <Johannes.Schindelin@...>
Date: Tuesday, May 20, 2008 - 12:28 pm

When cloning with the new builtin-clone, if the src repo is not
on the same disk as the dest repo, cloning fails. This is because
hard linking does not fall back to copying like the shell version
did.

The shell version also made a distinction between defaulting to
hard linking and an explicit request to hard link. In the latter
case it would not fall back to copying, but would die.

I'll also mention that the 'use_local_hardlinks' variable in cmd_clone
is not used. It looks like there was some initial thought that this
variable would be used and then an alternative solution was found
where option_no_hardlinks was accessed directly. So use_local_hardlinks
should probably be cleaned out.

-brandon

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
builtin-clone does not fallback to copy when link fails, Brandon Casey, (Tue May 20, 12:28 pm)
Re: builtin-clone does not fallback to copy when link fails, Daniel Barkalow, (Tue May 20, 2:16 pm)
Re: builtin-clone does not fallback to copy when link fails, Johannes Schindelin, (Tue May 20, 5:48 pm)
speck-geostationary