Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Avery Pennarun
Date: Friday, May 16, 2008 - 7:03 am

On 5/16/08, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

In my experience, fgetc() is pretty fantastically slow because you
have a function call for every byte (and, I gather, modern libc does
thread locking for every fgetc).  It's usually much faster to fread()
into a buffer and then access the buffer.  I don't know if that's
appropriate (or matters) here, though.

Have fun,

Avery
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
git bug: rebase fatal failure, Tommy Thorn, (Thu May 15, 12:27 am)
Re: git bug: rebase fatal failure, Johannes Schindelin, (Fri May 16, 3:41 am)
Re: git bug: rebase fatal failure, Johannes Schindelin, (Fri May 16, 4:01 am)
[PATCH] mailsplit and mailinfo: gracefully handle NUL char ..., Johannes Schindelin, (Fri May 16, 6:03 am)
Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL ..., Avery Pennarun, (Fri May 16, 7:03 am)
Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL ..., Johannes Schindelin, (Fri May 16, 7:32 am)
Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL ..., Johannes Schindelin, (Fri May 16, 4:59 pm)
Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL ..., Johannes Schindelin, (Fri May 16, 5:26 pm)
Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL ..., Stephen R. van den Berg, (Sat May 17, 3:07 am)
Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL ..., Johannes Schindelin, (Sat May 17, 3:18 am)
Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL ..., Johannes Schindelin, (Thu May 22, 3:38 am)
Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL ..., Johannes Schindelin, (Fri May 23, 4:21 am)