login
Header Space

 
 

[PATCH 2/3] git-gc: always use -A when manually repacking

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <gitster@...>
Cc: <git@...>, Brandon Casey <drafnel@...>
Date: Saturday, May 10, 2008 - 12:01 am

From: Brandon Casey <drafnel@gmail.com>

Now that repack -A will leave unreferenced objects unpacked, there is
no reason to use the -a option to repack (which will discard unreferenced
objects). The unpacked unreferenced objects will not be repacked by a
subsequent repack, and will eventually be pruned by git-gc based on the
gc.pruneExpire config option.
---
 builtin-gc.c |   13 ++-----------
 1 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/builtin-gc.c b/builtin-gc.c
index f99ebc7..6db2f51 100644
--- a/builtin-gc.c
+++ b/builtin-gc.c
@@ -256,17 +256,8 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
 			"performance. You may also\n"
 			"run \"git gc\" manually. See "
 			"\"git help gc\" for more information.\n");
-	} else {
-		/*
-		 * Use safer (for shared repos) "-A" option to
-		 * repack when not pruning. Auto-gc makes its
-		 * own decision.
-		 */
-		if (prune)
-			append_option(argv_repack, "-a", MAX_ADD);
-		else
-			append_option(argv_repack, "-A", MAX_ADD);
-	}
+	} else
+		append_option(argv_repack, "-A", MAX_ADD);
 
 	if (pack_refs && run_command_v_opt(argv_pack_refs, RUN_GIT_CMD))
 		return error(FAILED_RUN, argv_pack_refs[0]);
-- 
1.5.5.67.g9a49

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: git gc &amp; deleted branches, Brandon Casey, (Thu May 8, 9:41 pm)
Re: git gc &amp; deleted branches, Jeff King, (Fri May 9, 12:19 am)
Re: git gc &amp; deleted branches, Geert Bosch, (Fri May 9, 11:00 am)
Re: git gc &amp; deleted branches, Brandon Casey, (Fri May 9, 11:14 am)
Re: git gc &amp; deleted branches, Nicolas Pitre, (Fri May 9, 12:12 pm)
Re: git gc &amp; deleted branches, Junio C Hamano, (Fri May 9, 6:33 pm)
Re: git gc &amp; deleted branches, Jeremy Maitin-Shepard, (Fri May 9, 8:07 pm)
Re: git gc &amp; deleted branches, Shawn O. Pearce, (Fri May 9, 8:20 pm)
Re: git gc &amp; deleted branches, Junio C Hamano, (Fri May 9, 9:21 pm)
Re: git gc &amp; deleted branches, Jeremy Maitin-Shepard, (Fri May 9, 9:51 pm)
Re: git gc &amp; deleted branches, Jeff King, (Sat May 10, 1:25 am)
Re: git gc &amp; deleted branches, Jeremy Maitin-Shepard, (Sat May 10, 1:36 am)
Re: git gc &amp; deleted branches, Johannes Schindelin, (Sat May 10, 5:04 am)
Re: git gc &amp; deleted branches, Jeremy Maitin-Shepard, (Sat May 10, 12:24 pm)
Re: git gc &amp; deleted branches, Johannes Schindelin, (Sun May 11, 7:11 am)
Re: git gc &amp; deleted branches, Jeremy Maitin-Shepard, (Fri May 9, 8:43 pm)
Re: git gc &amp; deleted branches, Brandon Casey, (Fri May 9, 12:54 pm)
Re: git gc &amp; deleted branches, Jeff King, (Fri May 9, 11:53 am)
Re: git gc &amp; deleted branches, Brandon Casey, (Fri May 9, 11:56 am)
Re: git gc &amp; deleted branches, Junio C Hamano, (Thu May 8, 11:21 pm)
[PATCH 2/3] git-gc: always use -A when manually repacking, , (Sat May 10, 12:01 am)
speck-geostationary