login
Header Space

 
 

Re: detecting rename->commit->modify->commit

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ittay Dror <ittayd@...>
Cc: <git@...>
Date: Thursday, May 1, 2008 - 11:09 am

On Thu, May 01, 2008 at 05:54:06PM +0300, Ittay Dror wrote:


My two cents:

1. I think he is overly obsessed with renaming. He seems concerned that
somebody will show up, make a big renaming patch, and then break your
system. Guess what? They can also show up, make a big code change patch,
and then break your system. In either case you have to review the
changes before accepting them, and it is up to the version control
system to show you the changes in a way you can understand.

2. I see the same old "git developers decided renaming wasn't
important" argument. I think this is bogus. I think renaming _is_
important, but I actually prefer git's approach of deducing renames,
because it reflects a fundamental property of git: we track states, not
changes, and git doesn't care how you arrive at each state. So I am free
to use a combination of git commands, editors, patch application tools,
or anything else to get my tree to the right place.

3. He doesn't like that git doesn't track _directory_ renames. This is
not a fundamental problem with git's approach (which could deduce
directory renames after the fact), but rather comes from the fact that
directory renames are controversial. That is, even if you know (through
deduction or because an explicit rename was recorded) that "subdir1"
moved to "subdir2", that doesn't necessarily mean that new files added
into "subdir1" should make that move, as well.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
detecting rename-&gt;commit-&gt;modify-&gt;commit, Ittay Dror, (Thu May 1, 10:10 am)
Re: detecting rename-&gt;commit-&gt;modify-&gt;commit, Sitaram Chamarty, (Thu May 1, 12:39 pm)
Re: detecting rename-&gt;commit-&gt;modify-&gt;commit, Avery Pennarun, (Thu May 1, 11:27 am)
Re: detecting rename-&gt;commit-&gt;modify-&gt;commit, Steven Grimm, (Thu May 1, 3:12 pm)
Re: merge renamed files/directories?, Ittay Dror, (Sun May 4, 2:08 am)
Re: merge renamed files/directories?, Avery Pennarun, (Mon May 5, 12:40 pm)
Re: merge renamed files/directories?, Robin Rosenberg, (Mon May 5, 5:49 pm)
Re: merge renamed files/directories?, Linus Torvalds, (Mon May 5, 6:20 pm)
Re: merge renamed files/directories?, Avery Pennarun, (Mon May 5, 9:38 pm)
Re: merge renamed files/directories?, Linus Torvalds, (Mon May 5, 10:19 pm)
Re: merge renamed files/directories?, Shawn O. Pearce, (Mon May 5, 9:46 pm)
Re: merge renamed files/directories?, Avery Pennarun, (Mon May 5, 9:58 pm)
Re: merge renamed files/directories?, Shawn O. Pearce, (Mon May 5, 10:12 pm)
Re: merge renamed files/directories?, Steven Grimm, (Mon May 5, 7:07 pm)
Re: merge renamed files/directories?, Linus Torvalds, (Mon May 5, 8:29 pm)
Re: merge renamed files/directories?, Theodore Tso, (Tue May 6, 11:47 am)
Re: merge renamed files/directories?, Linus Torvalds, (Tue May 6, 12:10 pm)
Re: merge renamed files/directories?, Ittay Dror, (Tue May 6, 12:32 pm)
Re: merge renamed files/directories?, Linus Torvalds, (Tue May 6, 12:39 pm)
Re: merge renamed files/directories?, Linus Torvalds, (Tue May 6, 12:15 pm)
Re: merge renamed files/directories?, Linus Torvalds, (Mon May 5, 8:40 pm)
Re: merge renamed files/directories?, Jakub Narebski, (Sun May 4, 5:34 am)
Re: detecting rename-&gt;commit-&gt;modify-&gt;commit, Avery Pennarun, (Thu May 1, 11:50 am)
Re: detecting rename-&gt;commit-&gt;modify-&gt;commit, Avery Pennarun, (Thu May 1, 3:45 pm)
Re: detecting rename->commit->modify->commit, Jeff King, (Thu May 1, 11:09 am)
Re: detecting rename-&gt;commit-&gt;modify-&gt;commit, David Tweed, (Thu May 1, 11:30 am)
Re: detecting rename-&gt;commit-&gt;modify-&gt;commit, Teemu Likonen, (Thu May 1, 4:39 pm)
Re: detecting rename-&gt;commit-&gt;modify-&gt;commit, Sitaram Chamarty, (Thu May 1, 10:06 pm)
Re: detecting rename-&gt;commit-&gt;modify-&gt;commit, Junio C Hamano, (Thu May 1, 10:38 pm)
Re: detecting rename-&gt;commit-&gt;modify-&gt;commit, Sitaram Chamarty, (Fri May 2, 12:59 pm)
Re: detecting rename-&gt;commit-&gt;modify-&gt;commit, Jakub Narebski, (Thu May 1, 11:47 am)
speck-geostationary