git mailing list

FromSubjectsort iconDate
Prasanna Mumbai
Newbie please help.
Hi all, I am a newbie to git. Do we have any documentation for the usage of git. Basically i have downloaded open-fcoe project into my machine, i want to roll back to the earlier version. I want some documents which gives a list of command to be used to see the different versions and download the somewhat older/stable version. Thanks in Advance. ~Cheers Prasanna --
Apr 9, 3:03 pm 2008
Vincent Kergonna Apr 9, 3:19 pm 2008
Dirk Süsserott
[PATCH] Documentation/git-request-pull: Fixed a typo ("s ...
From: Dirk Suesserott <newsletter@dirk.my1.cc> Signed-off-by: Dirk Suesserott <newsletter@dirk.my1.cc> --- Documentation/git-request-pull.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/git-request-pull.txt b/Documentation/git-request-pull.txt index 270df9b..9a14c04 100644 --- a/Documentation/git-request-pull.txt +++ b/Documentation/git-request-pull.txt @@ -24,7 +24,7 @@ OPTIONS URL to include in the summary. <end>:: - Commit to send at; ...
Apr 9, 1:20 pm 2008
Miklos Vajna
Re: [PATCH] Add --only-merges flag to display only merge ...
Hm I was not exactly correct. Trivial fixes are pushed to master OK, that's something others should decide. :-) I find it useful but maybe Oh, I forgot about --grep. Though I still think --only-merges would be a solution and --grep=3D"Merge " is just a workaround, in practice it works fine, so thanks for the hint. :-)
Apr 9, 1:38 pm 2008
Junio C Hamano
Re: [PATCH] Add --only-merges flag to display only merge ...
For that particular use case, I'd suggest --first-parent. It is not just about filtering the output but more importantly also affects the way the traversal is done (it does not descend into side branches). It simply is more suited for the job you described. At this point, I have a mild aversion to a random addition to rev-list that does not have to affect how the traversal works but only filters the output, and more importantly does only a single purpose filtering. It is very much unclear ...
Apr 9, 1:06 pm 2008
Heikki Orsila
[PATCH] Add core.sharedRepository == read-only-group
The attached patch adds a new permission mode for core.sharedRepository. -- Heikki Orsila heikki.orsila@iki.fi http://www.iki.fi/shd
Apr 9, 12:37 pm 2008
Matthias Kestenholz
[PATCH] Use color.ui variable in scripts too
Signed-off-by: Matthias Kestenholz <mk@spinlock.ch> --- This patch adds color.ui support for scripts. It does that by modifying `git config --get-colorbool`, because there is no way to differentiate between undefined and `false` configuration variables in scripts. Additionally, the scripts don't need to be changed. I have only tested git add -i; git svn uses the same functions in Git.pm, so it should work too. Of course, it would have been nicer if I had made this change before the ...
Apr 9, 12:32 pm 2008
Joachim B Haga
[PATCH] Re: git clean removes directories when not asked to
I have tried to fix this, but I don't know the code. The previous logic was obviously (?) broken, as it had this (paraphrased): if (remove_directories || matches) remove_dir_recursively(...); which should have been &&. But with only this change, top-level directories were not removed even if "-d" was given. Looking at the (!ISDIR) branch, I guessed that it should instead trigger if pathspec is NULL; i.e, generally treat (!pathspec) as a match. It looks like the behaviour is correct now, ...
Apr 9, 10:04 am 2008
Teemu Likonen
Friendly refspecs (Was: Re: git annoyances)
I have found this refs/heads/*:refs/remotes/* stuff quite confusing, but I'm starting to understand them. I know my way with them but still they seem quite unnecessary hackerish. Pull and push work pretty nicely without knowing about any refs/* stuff; they can be operated with simple branch names. Fetch is another story. Some ideas: $ git fetch <URL> would be equivalent to $ git fetch <URL> +refs/heads/*:refs/remotes/<name>/* In other words, fetch all the branches from remote repo ...
Apr 9, 1:08 pm 2008
Nicolas Pitre
Re: git annoyances
Amen! Nicolas --
Apr 9, 4:45 pm 2008
Jon Loeliger
Re: git annoyances
Hey Junio, I'm hearing you here! :-) I think a furtherance of this notion is to teach "git fetch ; git merge" before "git pull". Thanks, jdl --
Apr 9, 2:39 pm 2008
Jeff King
Re: git annoyances
For me personally, I think this bottom-up approach makes the most sense to learning (this may look familiar from the commit message to a patch I sent earlier): 1. here is what "git pull $repo $branch" means 2. here is a way to shorten it to "git pull $repo" (set up remote $repo) 3. here is a way to shorten it to "git pull" (default to origin) But I think there are people who will get to the list and say "why didn't you just tell me 'git pull' in the first place?" That is, ...
Apr 9, 2:45 pm 2008
Junio C Hamano
Re: Friendly refspecs
Teemu Likonen <tlikonen@iki.fi> writes: [By the way, please never redirect the response to your messages away from you with: Mail-Followup-To: Jeff King <peff@peff.net>, Ingo Molnar <mingo@elte.hu>, git@vger.kernel.org You wasted 30 seconds of my (and anybody who potentially wanted to give advice to you) time by forcing me fix the To: header while composing this response. I know Jeff understands what I am going to mention, and I do I'd suggest you to study: ...
Apr 9, 2:21 pm 2008
Avery Pennarun
Re: Friendly refspecs (Was: Re: git annoyances)
But what should <name> be if you didn't provide it by doing git-remote-add? I think the lack of an obvious name for them is exactly why the branch names don't get created automatically. Avery --
Apr 9, 1:32 pm 2008
André Goddard Rosa
Re: git annoyances
Something along the lines of: Error description Why it happened How to solve/Sugestion -- []s, André Goddard --
Apr 9, 4:56 pm 2008
Avery Pennarun
Re: git annoyances
My co-workers frequently get confused by this too. The problem is that "x86/latest" is a locally existing remote branch ref, while "x86 latest" is supposed to be a branch ref on a remote system. I think the real problem here is that you can't refer to a remote+branch as a single "word". If you could, then people could just learn to use that everywhere and never get confused. For example, in svn you can talk about svn+ssh://reposerver/path/to/repo/branches/foo@1234; it's a single "word" ...
Apr 9, 10:08 am 2008
Johannes Schindelin
Re: [PATCH] git-remote: show all remotes with "git remot ...
Hi, Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Ciao, Dscho --
Apr 9, 9:54 am 2008
Ingo Molnar
Re: git annoyances
well, current git got to /home/mingo/linux-2.6-x86.git/ which is a local path. (it is printing it in the error message above) So i think it was rather unambiguous what i meant and Git knew about it, right? but even if it _was_ ambiguous, i think tools should generally default to a minimal amount of hassle for new users and should try to pick reasonable "action" versus any "inaction". (as long as the behavior is still deterministic and reasonable even to the long-time user) but more ...
Apr 9, 1:41 pm 2008
Jeff King
[PATCH] git-remote: show all remotes with "git remote show"
Many other commands use the "no arguments" form to show a list (e.g., git-branch, git-tag). While we did show all remotes for just "git remote", we displayed a usage error for "git remote show" with no arguments. This is counterintuitive, since by giving it _more_ information, we get _less_ result. The usage model can now be thought of as: - "git remote show <remote>": show a remote - "git remote show": show all remotes - "git remote": assume "show"; i.e., shorthand for "git remote ...
Apr 9, 8:15 am 2008
Ingo Molnar Apr 9, 1:07 pm 2008
Daniel Barkalow
Re: git annoyances
Git is missing the fact that, while refs/remotes/x86/latest doesn't exist, there is a fetch rule that would create it. It should suggest "git fetch x86" or "git fetch x86 latest". This is a bit tricky, because you've used a shorthand for something that doesn't exist, so there isn't a unique answer for which full name you're looking for, but there is a unique solution (in this case) for which one could be created by a pattern you The right error message here would probably ...
Apr 9, 12:21 pm 2008
Jeff King
Re: Friendly refspecs (Was: Re: git annoyances)
This has been discussed before and rejected, because the point of doing a fetch of a URL (rather than a remote name) is to do a "one-off" thing. IOW, you don't _want_ the tracking branches, as they will just clutter your branch space (plus choosing the last component is a bad heuristic; lots of people must ask Linus to pull from their .../linux-2.6 repository). Almost nobody says "git fetch <URL>"; it is just a subpart of "git pull <URL>" which is intended for one-off merges (i.e., you are ...
Apr 9, 1:34 pm 2008
Teemu Likonen
Re: Friendly refspecs (Was: Re: git annoyances)
First, thank you for such a detailed information and giving somewhat different point of view from mine. Ok, "git fetch <URL>" has its own "point", as you noted, and no doubt it's for good reasons. I just had partially misunderstood its point. See Hmm, maybe. I recently wanted to join two purely local repos together. Both of them had just one branch. Totally different histories so no actual mergin would happen; just two branches in the same repo. I don't know why but "git fetch ...
Apr 9, 3:25 pm 2008
Jeff King
Re: Friendly refspecs (Was: Re: git annoyances)
Ah, OK. In that case, I think the right thing to do would not be to set up a remote, but to fetch explicitly into a local branch. I assume when you say "joining" you mean "so I can get rid of the individual ones". So something like: cd repo1 git fetch ../repo2 master:repo2-topic which creates refs/heads/repo2 in repo1, and you can safely delete repo2. If you _did_ want to keep repo2 around indefinitely, and you are "joining" so that you can do diffs, then you probably do want a ...
Apr 9, 3:51 pm 2008
Ingo Molnar
git annoyances
i just had a rather annoying session with git - here's the dump and commentary, in case anyone is interested in usability fineprint. it was with git-core-1.5.4.3-2.fc8 - so if it's all fixed/improved in 1.5.5, or if this is blatant user error for which i deserve to be punished then my apologies! usually i just have a single git repo that tracks everything interesting, but this time i did something i rarely do: i tried to merge one local tree of mine into another local tree of mine. So ...
Apr 9, 3:14 am 2008
Björn
Re: git annoyances
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I gues that's key here. The remote was added, but you don't actually have fetched the branches yet. Thus the merge fails, but the pull with The syntax is "git pull <repository> <refspec>" So you're trying to fetch/pull from a repository in "x86/latest", that path doesn't exist and that is pretty fatal as you cannot fetch/pull AFAIK merge cannot handle stuff that's outside your repo. To merge stuff from another repo without ...
Apr 9, 3:41 am 2008
Jeff King
Re: git annoyances
As you figured out later, the problem was that "git remote add" doesn't actually fetch the remote's contents: it just sets up the remote. There is a "-f" option which does the fetch automagically after adding. In this case, had "-f" been the default, it would have Just Worked for you. So that's something for us to consider, but I'm not sure if we This is another place where we might have DWYM, by seeing that your repository name started with "<name of a remote>/" and splitting it ...
Apr 9, 7:57 am 2008
Junio C Hamano
Re: git annoyances
Thanks. It is always enlightening to see this kind of walkthru session to learn where the UI warts are. The ones with concrete suggestions for You told git that "I'll interact with this other repository from now on, so please help me with some extra settings to do so. Namely I do not want to keep typing it in full URL all the time so I want an abbreviated way to tell you I am talking about this remote repository, and also I want to have set of remote tracking branches for this ...
Apr 9, 2:04 pm 2008
Jim Meyering
[PATCH] (parsecvs) avoid "git mktag" failure with newer git
With recent git, parsecvs now always fails like this: ... Save: master *.................... 1 of 269 Save: master *.................... 2 of 269 error: char77: malformed tagger field fatal: invalid tag signature file git-mktag < '.git-cvs/tag-0': No such file or directory This is due to the change that makes git's mktag perform stricter input validation. parsecvs patch below. [BTW, Keith, or anyone with ...
Apr 9, 3:01 am 2008
Junio C Hamano
A note from the maintainer
Welcome to git community. This message talks about how git.git is managed, and how you can work with it. * IRC and Mailing list Many active members of development community hang around on #git IRC channel on Freenode. Its log is available at: http://colabti.org/irclogger/irclogger_log/git The development however is primarily done on the git mailing list (git@vger.kernel.org). If you have patches, please send them to the list, following Documentation/SubmittingPatches. I ...
Apr 9, 2:44 am 2008
Junio C Hamano
What's cooking in git.git (topics)
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' while commits prefixed with '+' are in 'next'. The topics list the commits in reverse chronological order. Caution. "next" has been rebuilt with the remaining topics on top of "master". "maint" is still for 1.5.4.X maintenance track for tonight. A rough timeline from now on. * Brown paper back fixes, if any, for 1.5.5.1 (2008-04-16). * Discussion and review on new feature and enhancement patch ...
Apr 9, 2:43 am 2008
Junio C Hamano
What's in git.git (stable)
* The 'master' branch has these since v1.5.5. Frank Lichtenheld (4): var: Don't require to be in a git repository. Git.pm: Don't require a repository instance for config Git.pm: Don't require repository instance for ident send-email: Don't require to be called in a repository Gerrit Pape (2): gitweb: fallback to system-wide config file if default config does not exist gitweb: fallback to system-wide config file (fixup) Govind Salinas (1): pretty.c: add %x00 format ...
Apr 9, 2:44 am 2008
Junio C Hamano
[ANNOUNCE] GIT 1.5.5
The latest feature release GIT 1.5.5 is available at the usual places: http://www.kernel.org/pub/software/scm/git/ git-1.5.5.tar.{gz,bz2} (tarball) git-htmldocs-1.5.5.tar.{gz,bz2} (preformatted docs) git-manpages-1.5.5.tar.{gz,bz2} (preformatted docs) RPMS/$arch/git-*-1.5.5-1.$arch.rpm (RPM) We kept this cycle just slightly over two months, as the previous 1.5.4 cycle was painfully tooooo long. GIT v1.5.5 Release Notes ======================== Updates since ...
Apr 8, 11:51 pm 2008
Junio C Hamano
Re: [PATCH 1/8] git-rebase.sh: Fix --merge --abort failu ...
This dq should not be necessary. The rest of this looked fine. --
Apr 8, 11:50 pm 2008
Junio C Hamano Apr 8, 11:50 pm 2008
Junio C Hamano
Re: Is my repository broken?
That's not a fair complaint. It is often very hard to document that "we do not do X", because the line to stop at becomes fuzzier as you try to do more thorough job. We do not warn on empty ident, we do not warn on typos in commit log messages, we do not warn on empty blob, we do not warn on ... You get the idea. --
Apr 8, 11:50 pm 2008
Julian Phillips
Re: Is my repository broken?
I didn't mean it as a complaint, but rather was hoping for a response of the form "no, it's not there" or "it's in the ... section" - sorry for not being clear. It caught me out, if that was my own fault then fair enough - but if this was because the documentation doesn't make it clear then I can submit a documentation patch to try and help others avoid the same problem. I think that the fast-import tool is extremely useful, and generally very well documented. That doesn't mean that ...
Apr 9, 3:01 am 2008
Carlos Rica
[PATCH] Fix documentation syntax of optional arguments i ...
When an argument for an option is optional, like in -n from git-tag, putting a space between the option and the argument is interpreted as a missing argument for the option plus an isolated argument. Documentation now reflects the need to write the parameter following the option -n, as in "git tag -nARG", for instance. Signed-off-by: Carlos Rica <jasampler@gmail.com> --- Documentation/git-tag.txt | 4 ++-- parse-options.c | 2 +- 2 files changed, 3 insertions(+), 3 ...
Apr 8, 9:24 pm 2008
Carlos Rica
Re: [PATCH] Fix documentation syntax of optional argumen ...
When an argument for an option is optional, like in -n from git-tag, puting a space between the option and the argument is interpreted as a missing argument for the option plus an isolated argument. Documentation now reflects the need to write the parameter following the option -n, as in "git tag -nARG", for instance. Signed-off-by: Carlos Rica <jasampler@gmail.com> --- I forgot to make the same change to the command's syntax in builtin-tag.c. I didn't check if this also happens for ...
Apr 9, 4:07 am 2008
Bryan Donlan
[PATCH 4/8] test-lib.sh: Fix some missing path quoting
Signed-off-by: Bryan Donlan <bdonlan@fushizen.net> --- t/test-lib.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 7c2a8ba..17d4bc0 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -329,7 +329,7 @@ test_create_repo () { repo="$1" mkdir "$repo" cd "$repo" || error "Cannot setup test environment" - "$GIT_EXEC_PATH/git" init --template=$GIT_EXEC_PATH/templates/blt/ >/dev/null 2>&1 || + "$GIT_EXEC_PATH/git" init ...
Apr 8, 6:30 pm 2008
Bryan Donlan
Re: [PATCH 1/8] git-rebase.sh: Fix --merge --abort failu ...
How exotic ought it be? I'm not entirely sure which characters are allowed on windows or any other non-unixes that git supports (are there any?) Thanks, Bryan --
Apr 9, 8:02 am 2008
Bryan Donlan
Re: [PATCH 1/8] git-rebase.sh: Fix --merge --abort failu ...
Since Junio asked(?) that it be removed, I'll drop it from the next rev I can do that, but it'd have to come as the last patch in the patchset, or it would obviously cause test failures. My goal here was to ensure that the bug I fixed in the patch would be tested in an isolated manner. If you like I can add a change to the trash directory to the next rev of I assumed that if git reset failed here we'd probably want to know :) Thanks, Bryan --
Apr 9, 7:37 am 2008
Bryan Donlan
Re: [PATCH 7/8] Use test_set_editor in t9001-send-email.sh
I split it out as it's not really related to the goals of 5/8 or 8/8, but is rather pure elimination of code duplication. However if it's considered better to squash it into 5/8 I'd be happy to do so. Thanks, Bryan --
Apr 9, 7:16 am 2008
Johannes Sixt
Re: [PATCH 5/8] test-lib.sh: Add a test_set_editor funct ...
Clever! It assumes that $VISUAL is always run as sh -c "$VISUAL ...", but I think this assumption is valid. A hint along these lines in the comment could turn out helpful. -- Hannes --
Apr 8, 11:36 pm 2008
Bryan Donlan
[PATCH 5/8] test-lib.sh: Add a test_set_editor function ...
In particular, this function correctly handles cases where the pwd contains spaces, quotes, and other troublesome metacharacters. Signed-off-by: Bryan Donlan <bdonlan@fushizen.net> --- t/test-lib.sh | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 17d4bc0..6f43376 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -160,6 +160,15 @@ die () { trap 'die' exit +test_set_editor () { + # If the editor path contains a ...
Apr 8, 6:30 pm 2008
Johannes Sixt
Re: [PATCH 2/8] config.c: Escape backslashes in section ...
What is your definition of "properly"? Please give an example of what went wrong. -- Hannes --
Apr 8, 11:31 pm 2008
Johannes Sixt
Re: [PATCH 1/8] git-rebase.sh: Fix --merge --abort failu ...
This is not strictly necessary: The RHS expression of an assignment does not undergo IFS splitting; but better safe than sorry. (But note that 'export foo=$bar', which is not POSIX, is *not* an assignment, and In effect, you modify only this test to stress-test strange characters, but other tests in the test suite still run in a "sane" environment. IOW, I don't think you should go to this extreme for this one test only. The better approach would be to rename 'trash' in test-lib.sh to this ...
Apr 8, 11:55 pm 2008
Johannes Sixt
Re: [PATCH 2/8] config.c: Escape backslashes in section ...
Could you then please add this to the commit message, most importantly, the last sentence? -- Hannes --
Apr 9, 7:25 am 2008
Bryan Donlan
Re: [PATCH 2/8] config.c: Escape backslashes in section ...
The included patch to the test suite is an example - specifically if an element of the configuration key name other than the first or last contains a backslash, it would not be escaped on output, but would be treated as an escape sequence on input. Thus the backslash would be lost. --
Apr 9, 7:13 am 2008
Bryan Donlan
[PATCH 7/8] Use test_set_editor in t9001-send-email.sh
Signed-off-by: Bryan Donlan <bdonlan@fushizen.net> --- t/t9001-send-email.sh | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 030f66c..0a65785 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -144,10 +144,7 @@ test_expect_success 'setup fake editor' ' chmod +x fake-editor ' -FAKE_EDITOR="$(pwd)/fake-editor" -export FAKE_EDITOR -GIT_EDITOR='"$FAKE_EDITOR"' -export ...
Apr 8, 6:30 pm 2008
Bryan Donlan
[PATCH 3/8] git-send-email.perl: Handle shell metacharac ...
Also, update t/t9001-send-email.sh to test for this bug. Signed-off-by: Bryan Donlan <bdonlan@fushizen.net> --- git-send-email.perl | 2 +- t/t9001-send-email.sh | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index be4a20d..975df1c 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -510,7 +510,7 @@ EOT close(C); my $editor = $ENV{GIT_EDITOR} || $repo->config("core.editor") || $ENV{VISUAL} || ...
Apr 8, 6:29 pm 2008
Bryan Donlan
[PATCH 1/8] git-rebase.sh: Fix --merge --abort failures ...
Also update t/t3407-rebase-abort.sh to exercise the bug Signed-off-by: Bryan Donlan <bdonlan@fushizen.net> --- git-rebase.sh | 4 +- t/t3407-rebase-abort.sh | 55 +++++++++++++++++++++++++++------------------- 2 files changed, 34 insertions(+), 25 deletions(-) diff --git a/git-rebase.sh b/git-rebase.sh index 60c458f..389b5cb 100755 --- a/git-rebase.sh +++ b/git-rebase.sh @@ -42,7 +42,7 @@ To restore the original branch and stop rebasing run \"git rebase --abort\". unset ...
Apr 8, 6:29 pm 2008
Bryan Donlan
[PATCH 0/8] Fix git's test suite to pass when the path c ...
This patch series fixes bugs in git and git's testsuite to allow all tests to pass when the working directory contains whitespace and/or shell metacharacters. The first three patches in this series fix bugs in git itself that were uncovered in the process of fixing the test suite. Each contains additional tests and/or updates to existing tests to exercise the bug in question. The remaining patches fix bugs in the test suite itself. Bryan Donlan (8): git-rebase.sh: Fix --merge --abort ...
Apr 8, 6:29 pm 2008
Johannes Sixt
Re: [PATCH 3/8] git-send-email.perl: Handle shell metach ...
Your defintion of "properly"? I didn't immediately see what is wrong with the status quo and, hence, why your fix would solve a problem. -- Hannes --
Apr 8, 11:31 pm 2008
Johannes Sixt
Re: [PATCH 1/8] git-rebase.sh: Fix --merge --abort failu ...
I for my taste could live without a test because the fix is so obvious. Given that you have to prepend 'cd "$work_dir"' to *all* the tests, this really just highlights that for the purpose of this test the name 'trash' of the regular test directory is just too simple ;) Of course, it's Junio's draw, and he likes to have tests for fixes that On second sight, this indeed looks just like an omission and your change is good. -- Hannes --
Apr 9, 7:51 am 2008
Bryan Donlan
Re: [PATCH 3/8] git-send-email.perl: Handle shell metach ...
This fixes the git-send-perl semantics for launching an editor when $GIT_EDITOR (or friends) contains shell metacharacters to match launch_editor() in builtin-tag.c. If we use the current approach (sh -c '$0 $@' "$EDITOR" files ...), we see it fails when $EDITOR has shell metacharacters: $ sh -x -c '$0 $@' "$VISUAL" "foo" + "$FAKE_EDITOR" foo "$FAKE_EDITOR": 1: "$FAKE_EDITOR": not found Whereas builtin-tag.c will invoke sh -c "$EDITOR \"$@\"". Note that with the method git-send-perl ...
Apr 9, 7:28 am 2008
Bryan Donlan
[PATCH 2/8] config.c: Escape backslashes in section name ...
Signed-off-by: Bryan Donlan <bdonlan@fushizen.net> --- config.c | 2 +- t/t1303-wacky-config.sh | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/config.c b/config.c index 0624494..6c07245 100644 --- a/config.c +++ b/config.c @@ -672,7 +672,7 @@ static int store_write_section(int fd, const char* key) if (dot) { strbuf_addf(&sb, "[%.*s \"", (int)(dot - key), key); for (i = dot - key + 1; i < store.baselen; i++) { - if (key[i] == ...
Apr 8, 6:29 pm 2008
Johannes Sixt
Re: [PATCH 7/8] Use test_set_editor in t9001-send-email.sh
I'd squash this into 5/8 or 8/8. Dunno. -- Hannes --
Apr 9, 12:01 am 2008
Bryan Donlan
[PATCH 6/8] lib-git-svn.sh: Fix quoting issues with path ...
Signed-off-by: Bryan Donlan <bdonlan@fushizen.net> --- t/lib-git-svn.sh | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/t/lib-git-svn.sh b/t/lib-git-svn.sh index 9decd2e..1b37ba8 100644 --- a/t/lib-git-svn.sh +++ b/t/lib-git-svn.sh @@ -7,9 +7,9 @@ then exit fi -GIT_DIR=$PWD/.git -GIT_SVN_DIR=$GIT_DIR/svn/git-svn -SVN_TREE=$GIT_SVN_DIR/svn-tree +GIT_DIR="$PWD/.git" +GIT_SVN_DIR="$GIT_DIR/svn/git-svn" +SVN_TREE="$GIT_SVN_DIR/svn-tree" svn ...
Apr 8, 6:30 pm 2008
Bryan Donlan
[PATCH 8/8] Fix tests breaking when checkout path contai ...
This fixes the remainder of the issues where the test script itself is at fault for failing when the git checkout path contains whitespace or other shell metacharacters. Signed-off-by: Bryan Donlan <bdonlan@fushizen.net> --- t/t0000-basic.sh | 4 +- t/t0001-init.sh | 2 +- t/t1020-subdirectory.sh | 24 +++++----- t/t1501-worktree.sh | 14 +++--- t/t3050-subprojects-fetch.sh ...
Apr 8, 6:30 pm 2008
DigitalPig
Re: ANNOUNCE: Git Forum
I agree with that. For me, each day this group shows 200+ topics when I opened Gnus. I think this could be divided into two groups, one for git-user and the other for git-devel. -- DigitalPig E-mail: digitalpiglee AT gmail DOT com ALL WE SEEN IS ILLUSION. --
Apr 8, 5:49 pm 2008
Robert Haines
Re: ANNOUNCE: Git Forum
This is missing the point slightly. If you ask a question on this list now it will be read by a lot of people who know git intimately and will help in very short order. These are the people who come to the list for other things (development discussions, patches, etc). If you split the group these people will not see your questions so they won't get answered. How does that help the community or make it stronger? It might well fracture the community into two groups: One that is ...
Apr 9, 9:57 am 2008
Rafael Garcia-Suarez
Re: Test suite failures due to Error.pm issues.
The private Error file is not installed if perl/Makefile.PL detects than an Error.pm recent enough on your system. Do you actually have perl/blib/lib/Error.pm ? Try to run (cd perl; make clean; cd ..; make) and try the tests again. --
Apr 9, 1:34 am 2008
Wincent Colaiuta
Re: ANNOUNCE: Git Forum
Just out of interest, who'll be receiving the income (if any) from the massive Google AdWords blocks at the top of every single page? (I'm guessing the providers of the free forum hosting.) Wincent --
Apr 9, 3:19 am 2008
Ulrik Sverdrup
Re: [PATCH] git-archive: ignore prefix when checking fil ...
Thanks for the patch René! First I reproduced my problem on vanilla git v1.5.5, and it is still there as in v.1.5.4.4. I applied this patch and that fixed my issue, testing both tar and zip. Ulrik Sverdrup --
Apr 9, 3:58 pm 2008
René Scharfe
[PATCH] git-archive: ignore prefix when checking file at ...
Ulrik Sverdrup noticed that git-archive doesn't correctly apply the attribute export-subst when the option --prefix is given, too. When it checked if a file has the attribute turned on, git-archive would try to look up the full path -- including the prefix -- in .gitattributes. That's wrong, as the prefix doesn't need to have any relation to any existing directories, tracked or not. This patch makes git-archive ignore the prefix when looking up if value of the attribute export-subst for a ...
Apr 9, 2:14 pm 2008
Daniel Barkalow
Re: ANNOUNCE: Git Forum
We actually encourage people to send email to the list without subscribing if they just have a particular question they'd like answered and don't want a ton of other mail. -Daniel *This .sig left intentionally blank* --
Apr 9, 11:08 am 2008
Johannes Schindelin
Re: [PATCH] Add --only-merges flag to display only merge ...
Hi, I usually did something like this: git log -1 $(git rev-list --parents | sed -n "s/ .* .*//p") Hth, Dscho --
Apr 9, 7:06 am 2008
Johannes Schindelin
Re: [PATCH] Add --only-merges flag to display only merge ...
Hi, Yep, I wrote "-1", but what I actually meant was "--no-walk". Sorry, Dscho --
Apr 9, 8:00 am 2008
Miklos Vajna
Re: [PATCH] Add --only-merges flag to display only merge ...
On Wed, Apr 09, 2008 at 05:00:14PM +0200, Johannes Schindelin <Johannes.Sch= Oh, I see. But I still think it would be handy to have an option for this if there is an option to filter out merges as well.
Apr 9, 11:31 am 2008
Miklos Vajna
Re: [PATCH] Add --only-merges flag to display only merge ...
On Wed, Apr 09, 2008 at 04:06:57PM +0200, Johannes Schindelin <Johannes.Sch= If you mean: git log -1 $(git rev-list --parents HEAD | sed -n "s/ .* .*//p") then it'll show only the first merge, --only-merges shows each merge. (While of course you can still use -1 or tag.. or so.)
Apr 9, 7:51 am 2008
Adam Simpkins
Re: "gitk" and "git log --graph": Strange behaviour with ...
Yes, I see this behavior too. The --follow option disables parent rewriting, which gitk and "git log --graph" both rely on in this instance. Without --follow, the revision list is first pruned, and then the parents are rewritten to include only those in the pruned list. The revision walk then occurs only over the pruned list. With --follow, the revision list is not pruned, so parent rewriting doesn't happen (and even if it did, I don't think it would have any effect, since all commits ...
Apr 9, 2:40 am 2008
Björn
Re: Fwd: [Bug 163341] Re: git-svn gets wrong parent revi ...
[Grmpf, the next time you drop from me Cc:, I'll not bother to answer...] Change the "." to "file:///tmp/test-repo/trunk" in the svn cp command and you get: Changed paths: A /release (from /trunk:3) Seems more useful. No idea why SVN decides to record crap when you use Uhm, and what happens then, when you actually _did_ just copy over a few files, but not all of them? Right, you get a branch to start at a later revision and see a bunch of reverts. Equally broken. Björn --
Apr 9, 1:03 am 2008
Björn
Re: Fwd: [Bug 163341] Re: git-svn gets wrong parent revi ...
I'd probably patch git-svn locally once and revert it after the import, if your suggested change really makes sense for your repo. Another option would be to adjust the branches afterwards, but that's probably awkward in your case. Maybe a patch that allows to toggle the branch Sure it can be. svn co $repo full-repo-here cd full-repo-here svn cp trunk branches/b1 (at rev 5) echo 123 > trunk/foo # (new file) echo 456 > trunk/bar # 431 other files changed (exaggeration ;-)) svn commit ...
Apr 9, 4:28 am 2008
Thomas Leonard
Re: Fwd: [Bug 163341] Re: git-svn gets wrong parent revi ...
That's good advice, but I'm wondering how to convert my existing svn Sure, if you create a situation that GIT can't represent then there's nothing much git-svn can do. However, when there are different source revisions: - Taking the highest revision will give correct results in the common case, and "equally broken" results in the uncommon case. - Taking any other revision (the current behaviour) is guaranteed to give the wrong result. There's no way a branch that was created with ...
Apr 9, 3:39 am 2008
Pascal Obry
Re: Automated/Daily build systems supporting git?
No sorry, I have only a server on a local network. Pascal. -- --|------------------------------------------------------ --| Pascal Obry Team-Ada Member --| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE --|------------------------------------------------------ --| http://www.obry.net --| "The best way to travel is by means of imagination" --| --| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595 --
Apr 9, 3:51 am 2008
Alex Bennee
Re: Automated/Daily build systems supporting git?
I don't suppose you have a demo site showing it in action? -- Alex, homepage: http://www.bennee.com/~alex/ The worst is not so long as we can say "This is the worst." -- King Lear --
Apr 9, 3:39 am 2008
Alex Bennee
Re: Automated/Daily build systems supporting git?
Thanks for the pointer, it's a nice example of using the git hooks. However perhaps it's a little too simple for our needs. We have multiple build targets/hosts and configurations building out of the one repository. We currently have a homemade script that runs nightlies and emails the results, however to expand the build test we probably want something that give a simple web-page overview of the current status. -- Alex, homepage: http://www.bennee.com/~alex/ Scientists will study ...
Apr 9, 3:31 am 2008
Matthieu Moy
Re: git bisect on multiple cores
Probably logarithmically with the number of cores. But for reasonable machines, this number is relatively low, so the log is not so costly. For a binary search, using just 2 cores, you can try the next in the list in case of a "git bisect good" for example, and if the hypothesis is true, you've just gained a factor 2 (assuming it happens 50% of times, that should be a 50% speedup). Similarly, you should get a factor 2 with 3 cores. And as said before, you can also try trisection or N-section. ...
Apr 9, 1:07 am 2008
Karl
Re: git bisect on multiple cores
Adding parallelism to a binary search scales very badly -- I'd say about logarithmically, but I haven't thought hard about it. If it's possible to use the extra cores to speed up the build+test cycle, that's vastly preferable. -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle --
Apr 9, 12:17 am 2008
Karl
Re: git bisect on multiple cores
Yeah. But to get a factor 3, you need 7 cores; and for 4, you need 15. It goes downhill from there. If your build+test cycle is parallelizable at all, I don't think you'll find those numbers hard to beat. (There's also the fact that testing several revisions at once assumes that the whole build+test cycle is automated, or at least most of it. Otherwise you need more people as well as more cores.) -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle --
Apr 9, 1:27 am 2008
Christian Couder
Re: git bisect on multiple cores
Yes, you can do that. If you have cloned your repository twice (or more), then you can bisect compile and test at the same time in your 3 repositories (or more if you really want). For example if bisecting in one repo asks you to test revision X, then you can bisect and then build (and even maybe start testing) in another repo assuming revision X is good, and in yet in another one assuming revision X is bad. (In the repo where you assume X is good you use: "git bisect start ...
Apr 8, 9:29 pm 2008
Christian Couder
Re: git bisect on multiple cores
In fact, you have to give all the good revisions you have, not just the last one. So it should be "git bisect start CURRENT-BAD X GOOD1 GOOD2 ..." or "git bisect start X GOOD1 GOOD2 ..." Above also you must give all the good ones, so it is: Regards, Christian. --
Apr 8, 10:47 pm 2008
René Scharfe
Re: [PATCH 2/2] pretty=format: Add %d to show decoration
Cute idea. :) What about objects with multiple decoration? How about producing a comma-separated list like git-log does? How about making %d imply --decorate? You could load the decorations foobar2000 (http://foobar2000.org/) has a kind of music tagging language, and one of its features might be interesting for us here: you can group a placeholder and other stuff inside brackets. The construct resolves to an empty string if the placeholder is NULL, i.e. in your example "[ (%d)]" would ...
Apr 9, 2:40 pm 2008
Michael Haggerty
Re: [PATCH] cvsps/cvsimport: fix branch point calculatio ...
Good point. I re-read the cvsps manpage and found the information about "FUNKY" and "INVALID" tags. I'd forgotten that cvsps does the right thing in some cases by warning the user about tags that are beyond its abilities to describe. (But there are other problems that cvsps doesn't warn about; see below.) Then I looked in the git-cvsimport code to see how it deals with FUNKY and INVALID tags. It does the *wrong* thing by explicitly ignoring these warnings (!). IMHO git-cvsimport should ...
Apr 8, 6:53 pm 2008
Junio C Hamano
Re: Migrating svn to git with heavy use of externals
Its actually the other way around. In-tree .gitmodules is used to give hints to prime what is placed in .git/config, which after initialized should serve as the authoritative information on managed submodules as far as your repository is concerned. "git submodule init" may be a handy way to do this "priming", but you do not necessarily have to use it but instead manually adjust .git/config yourself; this is so that you can configure remote url that is different from what .gitmodules suggests ...
Apr 8, 11:43 pm 2008
Avery Pennarun
Re: Intricacies of submodules [was: Migrating svn to git ...
Sorry, I wasn't clear. I meant that there's no fundamental reason that this shouldn't be possible; as far as I know, there's no way to make git do this in an obvious way (yet). It's encouraging that other people seem to want the same behaviour as me, which means I might get to working on it sooner :) Not that this should discourage you from trying, of course: perhaps I'm just missing something too. Note: I think a big part of the secret is using "." as the location of the submodule's ...
Apr 9, 1:27 pm 2008
Roman Shaposhnik
Re: Migrating svn to git with heavy use of externals
Well, may be we are talking about slightly different things, or there's a version mismatch, but here's what I get with 1.5.4.5: $ git init $ git submodule add /tmp/GIT/1 Initialized empty Git repository in /tmp/GIT/3/1/.git/ $ cat .git/config [core] repositoryformatversion = 0 filemode = true bare = false logallrefupdates = true Now, .gitmodules is there alright, so if I do: $ git submodule init I get the migration of settings to .git/config: $ ...
Apr 8, 9:39 pm 2008
Avery Pennarun
Re: Migrating svn to git with heavy use of externals
That I don't know. If there aren't any others, then I agree, I'm not Not exactly. The idea is that if the supermodule and submodules are all lumped into a single repo (and your refs are set up correctly), then cloning the supermodule will also clone all the submodules. So everyone will have all the necessary refs anyway; as long as git-checkout checks them out, .gitmodules shouldn't have to exist at all, becaues there's nothing "special" for git-submodule to do. Have fun, Avery --
Apr 8, 11:34 pm 2008
Roman Shaposhnik
Intricacies of submodules [was: Migrating svn to git wit ...
Interesting! How do you make it happen? Do you use git hooks or something? On my end, I can't really reproduce that behavior of clone but I would very much like to: $ alias mkrepo="git init; touch file; git add file; git commit -mInit" $ mkdir super ; cd super $ mkrepo $ mkdir submodule ; cd submodule $ mkrepo $ cd .. $ git submodule add submodule Adding existing repo at 'submodule' to the index $ git commit -mSubmodule Created commit 5921c87: Submodule 2 files ...
Apr 9, 12:57 pm 2008
Roman Shaposhnik
Re: Migrating svn to git with heavy use of externals
I could be mistaken, but I don't think "git submodule add" does anything to the .git/config. In fact, how settings migrate between .gitmodules and .git/config has been a long standing source of slight confusion for me. Please correct me if I'm wrong, but it seems that the only reason for the file .gitmodules to be there at all is because it can be revved through commits, just as any file under Git's control. .git/config doesn't have such a property. Other than that, it is not Speaking of ...
Apr 8, 8:03 pm 2008
Avery Pennarun
Re: Migrating svn to git with heavy use of externals
You have the last paragraph right, but I think the first paragraph wrong :) .gitmodules doesn't do anything unless git-submodule reads it, which it does in git-submodule-init and git-submodule-add. (You know git-submodule-add is screwing with .git/config because you don't need to call git-submodule-init when you use it.) git-submodule-update, Indeed, this is the majority of the coolness right there. The rest of the screwiness with .gitmodules and so on is really just to support fetching ...
Apr 8, 8:33 pm 2008
Jörg
Re: git-merge adds test to a message -- bug?
Hallo Johannes, It this really a proper way to call git merge? The manpage says: The second syntax (<msg> HEAD <remote>) is supported for historical reasons. Do not use it from the command line or in new scripts. It is the same as git merge -m <msg> <remote>. And how would you pass the option for the strategy to this form? Git rebase calls git merge with -s. Bye, J=F6rg. --=20 But in the case of "git revert", it should be an ancestor (or the user is just insane, in which ...
Apr 9, 3:40 am 2008
Jörg Sommer
[PATCH/RFC 06/10] Unify the lenght of $SHORT* and the co ...
--- git-rebase--interactive.sh | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 1698c3e..060b40f 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -600,9 +600,9 @@ do MERGES_OPTION=--no-merges fi - SHORTUPSTREAM=$(git rev-parse --short $UPSTREAM) - SHORTHEAD=$(git rev-parse --short $HEAD) - SHORTONTO=$(git rev-parse --short $ONTO) + SHORTUPSTREAM=$(git ...
Apr 9, 4:58 pm 2008
Jörg Sommer
[PATCH/RFC 09/10] Select all lines with fake-editor
The old fake-editor selects only lines they start with pick, if you give the number of a line. With the new commands mark, merge and reset it was not possible to select such lines for the new TODO list. The new fake-editor selects all kinds of lines, but replaces only the command “pick” with a different action. --- t/t3404-rebase-interactive.sh | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh index ...
Apr 9, 4:58 pm 2008
Jörg Sommer
[PATCH/RFC 07/10] fake-editor: output TODO list if unchanged
It's much helpful to see the TODO list generated by rebase in the verbose output. This makes it easier to check, if the list was not broken by design. --- t/t3404-rebase-interactive.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh index 892fd5d..aa4bb8d 100755 --- a/t/t3404-rebase-interactive.sh +++ b/t/t3404-rebase-interactive.sh @@ -73,7 +73,7 @@ esac test -z "$EXPECT_COUNT" || test ...
Apr 9, 4:58 pm 2008
Jörg Sommer
Teach rebase interactive more commands to do better pres ...
Junio proposed to add the commands mark, merge and reset to rebase interactive for a better support of rebase with preserve merges. The current format can only cope with flat lineare lists of commits and not with the non
Apr 9, 4:58 pm 2008
Jörg Sommer
[PATCH/RFC 08/10] Don't append default merge message to ...
Picked from <7vabko3dm2.fsf@gitster.siamese.dyndns.org> From: gitster@pobox.com (Junio C Hamano) Date: Sun, 23 Mar 2008 22:17:09 -0700 --- git-merge.sh | 24 +++++++++++++----------- 1 files changed, 13 insertions(+), 11 deletions(-) diff --git a/git-merge.sh b/git-merge.sh index 7dbbb1d..bd9699d 100755 --- a/git-merge.sh +++ b/git-merge.sh @@ -250,17 +250,19 @@ else # We are invoked directly as the first-class UI. head_arg=HEAD - # All the rest are the commits being merged; ...
Apr 9, 4:58 pm 2008
Jörg Sommer
[PATCH/RFC 03/10] Teach rebase interactive the merge command
This command redoes merges. It's useful if you rebase a branch that contains merges and you want to preserve these merges. You can also use it to add new merges. --- git-rebase--interactive.sh | 25 +++++++++++++++++++++++++ t/t3404-rebase-interactive.sh | 3 +++ 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 7dac51b..18cdf3d 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ ...
Apr 9, 4:58 pm 2008
Jörg Sommer
[PATCH/RFC 04/10] Move redo merge code in a function
--- git-rebase--interactive.sh | 31 +++++++++++++++++-------------- 1 files changed, 17 insertions(+), 14 deletions(-) diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 18cdf3d..973770e 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -114,6 +114,22 @@ has_action () { grep '^[^#]' "$1" >/dev/null } +redo_merge() { + author_script=$(get_author_ident_from_commit $sha1) + eval "$author_script" + msg="$(git cat-file commit $sha1 | ...
Apr 9, 4:58 pm 2008
Jörg Sommer
[PATCH/RFC 05/10] Rework redo_merge
--- git-rebase--interactive.sh | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 973770e..1698c3e 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -115,14 +115,17 @@ has_action () { } redo_merge() { - author_script=$(get_author_ident_from_commit $sha1) - eval "$author_script" + local sha1 + sha1=$1 + shift + + eval "$(get_author_ident_from_commit $sha1)" ...
Apr 9, 4:58 pm 2008
Jörg Sommer
[PATCH/RFC 02/10] Teach rebase interactive the reset command
--- git-rebase--interactive.sh | 20 ++++++++++++++++++++ t/t3404-rebase-interactive.sh | 10 ++++++++++ 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index b001ddf..7dac51b 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -258,6 +258,16 @@ parse_mark() { return 1 } +mark_to_sha1() { + local mark + if mark=$(parse_mark $1) + then + cat "$MARKS"/$mark + else + return ...
Apr 9, 4:58 pm 2008
Jörg Sommer
[PATCH/RFC 10/10] Do rebase with preserve merges with ad ...
--- git-rebase--interactive.sh | 248 ++++++++++++++++++++++++----------------- t/t3404-rebase-interactive.sh | 34 ++++++ 2 files changed, 181 insertions(+), 101 deletions(-) diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 060b40f..27bd87e 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -22,12 +22,10 @@ TODO="$DOTEST"/git-rebase-todo DONE="$DOTEST"/done MSG="$DOTEST"/message ...
Apr 9, 4:58 pm 2008
Jörg Sommer
[PATCH/RFC 01/10] Teach rebase interactive the mark command
This new command can be used to set symbolic marks for an commit while doing a rebase. This symbolic name can later be used for merges or resets. --- git-rebase--interactive.sh | 36 ++++++++++++++++++++++++++++++++++++ t/t3404-rebase-interactive.sh | 21 +++++++++++++++++++++ 2 files changed, 57 insertions(+), 0 deletions(-) diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 8aa7371..b001ddf 100755 --- a/git-rebase--interactive.sh +++ ...
Apr 9, 4:58 pm 2008
previous daytodaynext day
April 8, 2008April 9, 2008April 10, 2008