Home » Mailing list archives » git » 2008 » April » 9

[PATCH 5/8] test-lib.sh: Add a test_set_editor function to safely set $VISUAL

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Bryan Donlan <bdonlan@...>
To: <git@...>
Cc: Johannes Sixt <j.sixt@...>, Adam Roben <aroben@...>, <gitster@...>, Bryan Donlan <bdonlan@...>
Subject: [PATCH 5/8] test-lib.sh: Add a test_set_editor function to safely set $VISUAL
Date: Tuesday, April 8, 2008 - 9:30 pm

In particular, this function correctly handles cases where the pwd contains
spaces, quotes, and other troublesome metacharacters.

Signed-off-by: Bryan Donlan <bdonlan@fushizen.net>
---
 t/test-lib.sh |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 17d4bc0..6f43376 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -160,6 +160,15 @@ die () {
 
 trap 'die' exit
 
+test_set_editor () {
+	# If the editor path contains a quote, just using VISUAL='"path"' isn't
+	# enough.
+	FAKE_EDITOR="$1"
+	export FAKE_EDITOR
+	VISUAL='"$FAKE_EDITOR"'
+	export VISUAL
+}
+
 test_tick () {
 	if test -z "${test_tick+set}"
 	then
-- 
1.5.5.8.gbbd98

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/8] Fix git's test suite to pass when the path conta..., Bryan Donlan, (Tue Apr 8, 9:29 pm)
[PATCH v2 00/10] Fix git's test suite to pass when the path ..., Bryan Donlan, (Thu Apr 10, 2:50 am)
[PATCH v3 00/10] Fix git's test suite to pass when the path ..., Bryan Donlan, (Sun May 4, 1:37 am)
Re: [PATCH v3 00/10] Fix git's test suite to pass when the p..., Johannes Sixt, (Mon May 5, 3:03 am)
Re: [PATCH v3 00/10] Fix git's test suite to pass when the p..., Bryan Donlan, (Mon May 5, 3:59 am)
Re: [PATCH v3 00/10] Fix git's test suite to pass when the p..., Johannes Sixt, (Mon May 5, 4:19 am)
[PATCH v3 01/10] git-rebase.sh: Fix --merge --abort failures..., Bryan Donlan, (Sun May 4, 1:37 am)
[PATCH v3 02/10] config.c: Escape backslashes in section nam..., Bryan Donlan, (Sun May 4, 1:37 am)
[PATCH v3 03/10] git-send-email.perl: Handle shell metachara..., Bryan Donlan, (Sun May 4, 1:37 am)
[PATCH v3 04/10] test-lib.sh: Add a test_set_editor function..., Bryan Donlan, (Sun May 4, 1:37 am)
[PATCH v3 05/10] Use test_set_editor in t9001-send-email.sh, Bryan Donlan, (Sun May 4, 1:37 am)
[PATCH v3 06/10] test-lib.sh: Fix some missing path quoting, Bryan Donlan, (Sun May 4, 1:37 am)
[PATCH v3 07/10] lib-git-svn.sh: Fix quoting issues with pat..., Bryan Donlan, (Sun May 4, 1:37 am)
[PATCH v3 08/10] Don't use the export NAME=value form in the..., Bryan Donlan, (Sun May 4, 1:37 am)
[PATCH v2 01/10] git-rebase.sh: Fix --merge --abort failures..., Bryan Donlan, (Thu Apr 10, 2:50 am)
Re: [PATCH v2 01/10] git-rebase.sh: Fix --merge --abort fail..., Junio C Hamano, (Thu Apr 10, 3:45 am)
Re: [PATCH v2 01/10] git-rebase.sh: Fix --merge --abort fail..., Bryan Donlan, (Thu Apr 10, 4:48 am)
[PATCH v2 02/10] config.c: Escape backslashes in section nam..., Bryan Donlan, (Thu Apr 10, 2:50 am)
[PATCH v2 03/10] git-send-email.perl: Handle shell metachara..., Bryan Donlan, (Thu Apr 10, 2:50 am)
[PATCH v2 04/10] test-lib.sh: Add a test_set_editor function..., Bryan Donlan, (Thu Apr 10, 2:50 am)
[PATCH v2 05/10] Use test_set_editor in t9001-send-email.sh, Bryan Donlan, (Thu Apr 10, 2:50 am)
[PATCH v2 06/10] test-lib.sh: Fix some missing path quoting, Bryan Donlan, (Thu Apr 10, 2:50 am)
[PATCH v2 07/10] lib-git-svn.sh: Fix quoting issues with pat..., Bryan Donlan, (Thu Apr 10, 2:50 am)
[PATCH v2 08/10] Don't use the export NAME=value form in the..., Bryan Donlan, (Thu Apr 10, 2:50 am)
[PATCH v2 09/10] Fix tests breaking when checkout path conta..., Bryan Donlan, (Thu Apr 10, 2:50 am)
[PATCH v2 10/10] Rename the test trash directory to contain ..., Bryan Donlan, (Thu Apr 10, 2:50 am)
[PATCH 1/8] git-rebase.sh: Fix --merge --abort failures when..., Bryan Donlan, (Tue Apr 8, 9:29 pm)
Re: [PATCH 1/8] git-rebase.sh: Fix --merge --abort failures ..., Johannes Sixt, (Wed Apr 9, 2:55 am)
Re: [PATCH 1/8] git-rebase.sh: Fix --merge --abort failures ..., Bryan Donlan, (Wed Apr 9, 10:37 am)
Re: [PATCH 1/8] git-rebase.sh: Fix --merge --abort failures ..., Johannes Sixt, (Wed Apr 9, 10:51 am)
Re: [PATCH 1/8] git-rebase.sh: Fix --merge --abort failures ..., Bryan Donlan, (Wed Apr 9, 11:02 am)
Re: [PATCH 1/8] git-rebase.sh: Fix --merge --abort failures ..., Johannes Sixt, (Thu Apr 10, 2:10 am)
[PATCH 2/8] config.c: Escape backslashes in section names pr..., Bryan Donlan, (Tue Apr 8, 9:29 pm)
Re: [PATCH 2/8] config.c: Escape backslashes in section name..., Johannes Sixt, (Wed Apr 9, 2:31 am)
Re: [PATCH 2/8] config.c: Escape backslashes in section name..., Bryan Donlan, (Wed Apr 9, 10:13 am)
Re: [PATCH 2/8] config.c: Escape backslashes in section name..., Johannes Sixt, (Wed Apr 9, 10:25 am)
[PATCH 3/8] git-send-email.perl: Handle shell metacharacters..., Bryan Donlan, (Tue Apr 8, 9:29 pm)
Re: [PATCH 3/8] git-send-email.perl: Handle shell metacharac..., Johannes Sixt, (Wed Apr 9, 2:31 am)
Re: [PATCH 3/8] git-send-email.perl: Handle shell metacharac..., Junio C Hamano, (Wed Apr 9, 11:39 pm)
Re: [PATCH 3/8] git-send-email.perl: Handle shell metacharac..., Bryan Donlan, (Wed Apr 9, 10:28 am)
[PATCH 4/8] test-lib.sh: Fix some missing path quoting, Bryan Donlan, (Tue Apr 8, 9:30 pm)
[PATCH 5/8] test-lib.sh: Add a test_set_editor function to s..., Bryan Donlan, (Tue Apr 8, 9:30 pm)
Re: [PATCH 5/8] test-lib.sh: Add a test_set_editor function ..., Johannes Sixt, (Wed Apr 9, 2:36 am)
[PATCH 6/8] lib-git-svn.sh: Fix quoting issues with paths co..., Bryan Donlan, (Tue Apr 8, 9:30 pm)
[PATCH 7/8] Use test_set_editor in t9001-send-email.sh, Bryan Donlan, (Tue Apr 8, 9:30 pm)
Re: [PATCH 7/8] Use test_set_editor in t9001-send-email.sh, Johannes Sixt, (Wed Apr 9, 3:01 am)
Re: [PATCH 7/8] Use test_set_editor in t9001-send-email.sh, Bryan Donlan, (Wed Apr 9, 10:16 am)
[PATCH 8/8] Fix tests breaking when checkout path contains s..., Bryan Donlan, (Tue Apr 8, 9:30 pm)