git mailing list

FromSubjectsort iconDate
Daniel Geisler
auto interessiert
Ich bin an Ihrem Auto sehr interessiert, aber ich bin konfus, weil ich das gleiche auto und die gleichen fotos auf www.autoscout24.de mit einem anderen verk
Apr 7, 5:34 pm 2008
Neil Schemenauer
State of the art svn to git conversion?
Hi, I'm attempting to convert a fairly large SVN repository to git (about 60000 revisions, quite a few branches and tags). It looks like git-svn is the main tool for this purpose but it is very slow. The initial fetch takes many hours to finish (yes, I'm working locally) and seems to periodically die after a few thousand revisions. Is git-svn really the best tool? Ideally I would like to feed an svn dump into some tool and end up with a git repository. If I would feed incremental dumps into ...
Apr 7, 2:50 pm 2008
Junio C Hamano
Re: [PATCH 2/4] log and rev-list: Fixed newline termination ...
Yeah, I agree that sounds quite bad, and that is why I favor more explicit and independent way to choose between separator and terminator (like the "tformat" thing). --
Apr 7, 1:43 pm 2008
Adam Simpkins
Re: [PATCH 2/4] log and rev-list: Fixed newline termination ...
How about an extra option to explicitly toggle the separator on or off? For example, how about "--sep=<count>"? Using --sep=0 would put no separator between entries. --sep=N would put N separators between entries. If this option isn't explicitly specified, the default should be --sep=0 for ONELINE, and --sep=1 for everything else. Using --sep=2 with USERFORMAT would achieve the behavior of getting an extra line of padding between entries. This still leaves unresolved the fact that ...
Apr 7, 3:01 pm 2008
Johannes Schindelin
[PATCH 1/2] decorate: use "const struct object"
We use the object only as key for the decoration, therefore we should access it as const struct object. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- decorate.c | 10 +++++----- decorate.h | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/decorate.c b/decorate.c index 23f6b00..3aee3b7 100644 --- a/decorate.c +++ b/decorate.c @@ -6,13 +6,13 @@ #include "object.h" #include "decorate.h" -static unsigned int hash_obj(struct objec...
Apr 7, 9:40 am 2008
Johannes Schindelin
[PATCH 2/2] pretty=format: Add %d to show decoration
With this patch, "git log --decorate --pretty=format:%d", shows the name decoration (i.e. whenever a commit matches a ref, that ref's name is shown). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- Maybe %d should expand to " (<name decoration>)" instead of "<name decoration>"? Documentation/pretty-formats.txt | 1 + pretty.c | 9 +++++++++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/Documentation/p...
Apr 7, 9:41 am 2008
Kai Hendry
Integration branching
I've been asked to setup & host a git repo of an "integration branch" of WebKit for our developers. So I expected it to work like so: git clone git://git.webkit.org/WebKit.git git checkout -b test <Make a few small changes and commit> git-config remote.upload.url ssh://git.webvm.net/srv/git/webkit-test x61:~/aplix/test/WebKit% git push --thin -v upload test Pushing to ssh://git.webvm.net/srv/git/webkit-test Counting objects: 371612, done. Compressing objects: 100% (67851/67851), ...
Apr 7, 9:02 am 2008
Junio C Hamano
Re: Integration branching
A set of big questions is how that git.webvm.net/srv/git/webkit-test repository was prepared, what its history look like and how it relates to the history your repository has. I presume that that is different from the repository you are pushing from (which is "x61:aplix/test/WebKit" repository), but other than that you did not give any details to guess By the way, that --thin is an implementation detail and not meant for the end user consumption. I do not think it would matter in this case, W...
Apr 7, 1:41 pm 2008
Kai Hendry
Re: Integration branching
webkit-test was just a `git --bare init --shared` and completely empty with I tried pushing (publishing) the changes to WebKit trunk. With thanks, --
Apr 7, 2:18 pm 2008
Junio C Hamano
Re: Integration branching
That explains it without the "theory" in my previous message. The destination repository must be populated with full history somehow (and one way would have been to start it by cloning from the upstream), but if it was empty that is alright as well, because your push made it up-to-date. IOW, there is nothing to worry about and the system is working as designed. Further pushes will update it incrementally. --
Apr 7, 2:44 pm 2008
Avery Pennarun
Re: Integration branching
Basically every git repository needs to be entirely self-sufficient, that is, it should be possible to check out a copy without referring to any external repositories. So your initial push to an empty repository will always upload all the objects, even if you pulled from some other. The good news is that if your friends who checked out of the main repository want to try out your branch, it *won't* accidentally download all the extra objects over again. git will notice that they already have th...
Apr 7, 2:32 pm 2008
Luke Diamand
git repo being corrupted?
I've recently started to notice the following being reported: % git-status error: bad index file sha1 signature fatal: index file corrupt (a) Is there anything I can do to fix this (apart from git-clone from the repo and start over) ? git-fsck reports the same problem. (b) What is causing it? Is it just my hard disk failing, or is it a bug? A memory test seems to be OK. Linux 2.6.22-3-amd64 File system is XFS git version 1.5.4.4 --
Apr 7, 6:04 am 2008
Luciano Rocha
Re: git repo being corrupted?
You're using XFS. Did you have a power fail in the recent past? --=20 lfr 0/0
Apr 7, 7:17 am 2008
Luke Diamand Apr 7, 7:21 am 2008
Luciano Rocha
Re: git repo being corrupted?
XFS doesn't order metadata writes with data writes, so if the power fails, it can find an update in the journal but the data wasn't written. Then it fills the file with zeroes to the new size. I've lost /etc/passwd once with that behaviour... Also, ext3 doesn't order the metadata and data updates with data=3Dwriteback, but the default is data=3Dordered, which does. I use xfs, but only when I know I have at least daily backups (or on systems with UPS and with UPS initiated orderly shutdowns). ...
Apr 7, 7:39 am 2008
David Brown
Re: git repo being corrupted?
This behavior should be a lot better for recent kernels. xfs does even better with write barriers. But any file change that is more than one write can be corrupted or split by an inopportune powerdown. David --
Apr 7, 12:15 pm 2008
Luciano Rocha
Re: git repo being corrupted?
To be fair, it hasn't happened to me lately. But I haven't lost power Maybe, but I'm still waiting for barrier support through device-mapper. --=20 lfr 0/0
Apr 7, 12:47 pm 2008
Adam Simpkins
[PATCH 4/4] log and rev-list: Improve --graph output when co...
This change automatically enables parent rewriting when --graph is specified. This makes the graph output look much nicer when commit pruning is enabled. The existing rev_info "parents" flag has been split into two flags: "rewrite_parents" causes the parents to be rewritten, while "print_parents" causes the log and rev-list commands to print the parents. The --parents option now enables both rewrite_parents and print_parents, while --graph enables only rewrite_parents. Signed-off-by: Adam Simp...
Apr 7, 4:01 am 2008
David Kågedal
Re: [REGRESSION] git-gui
A Swedish keyboard has [] on alt-gr (Modeshift) 8 and 9. Plus and minus are unshifted and = is on shift-0. So with a Swedish layout, it is annoying when zoom in is on = rather than +, just because someone assumed that it would be harder to press the more logical plus key. -- David Kågedal --
Apr 7, 3:38 am 2008
Teemu Likonen
Re: [REGRESSION] git-gui
The above also applies to Finnish and Norwegian keyboards, probably to many more. The key pair '=' and '-' would be a poor UI decision. In principle one should never assume that a key is in certain place in the keyboard; it's much better idea to be logical with _characters_. So if a key pair much be defined for different aspects of the same functionality, let's choose logical pairs from common characters: +- [] {} () <> zZ aA bB ... (To me all these are OK.) --
Apr 7, 4:10 am 2008
Junio C Hamano
Re: bug in git-apply
I think the issue is much older than that. The faulty one is 4be6096 (apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches, 2006-09-17), which incorrectly loosened the match_beginning/match_end computation too much, whose botch may have been hidden by what the surrounding code did. And 65aadb9 (apply: force matching at the beginning., 2006-05-24) is equally wrong in that it tried to take hints from leading context lines, to decide if the hunk must match at the beginning, but in thi...
Apr 6, 9:11 pm 2008
Karl
Re: bug in git-apply
Well, it does fix the stgit test suite failure, so I'm all for it! (Though I see you've already pushed it to master.) Thanks. -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle --
Apr 7, 3:04 am 2008
Junio C Hamano
Re: bug in git-apply
This actually is a fix for maint; even though your test case does not let you observe the breakage directly, only because must-match-at-end check prevents the single-liner test hunk from applying cleanly. --
Apr 7, 3:12 am 2008
Shawn O. Pearce
Re: [EGIT PATCH 1/3] FindToolbar port to the new history page.
Well, I just rebased my entire tree, and then plopped your four patches (these three plus 009f) on top of it. So no need to rebase. Its better. I'd like to be able to use more of RevFilter in the search, but as you pointed out support isn't all there yet. I'm taking in this series as is. We can improve on it further later. Thanks. -- Shawn. --
Apr 7, 1:19 am 2008
Linus Torvalds
Re: [PATCH 1/4] Add history graph API
In traditional C, and inside structure declarations etc, yes. In modern C, in other contexts, no. Modern C considers a function declaration to be its own scope (it's the scope of the function definition, which in a declaration is obviously just the declaration). So if you use a "struct xyzzy *" in a function declaration, it will be a *different* "struct xyzzy *" from one declared later. Try to compile something like this: int fn(struct xyzzy *); int fn(struct xyzzy *); with a...
Apr 7, 12:15 pm 2008
Junio C Hamano
Re: [PATCH 1/4] Add history graph API
The current practice is we expect .c files to include necessary .h files themselves and avoid including .h files from others (I do not personally necessarily agree with this practice, by the way, but that is the way it We seem to consistently use postfix when increment is done only for its side effect. --
Apr 6, 11:12 pm 2008
Teemu Likonen
Re: [PATCH 1/4] Add history graph API
Also, the output is not indented for options that display some additional information to commit message. Those include: --raw --stat --numstat --shortstat --summary --name-only --name-status I'm not sure if the diff output of -p, -u etc. should be indented--probably not--but for different stat and summary options it would be nice to not have their output displayed over the graph area. Especially --name-status is funny since it displays "M" to column 1 to indicate modified file while ...
Apr 7, 1:24 am 2008
Adam Simpkins
Re: [PATCH 1/4] Add history graph API
Hmm. This is a harder problem to fix. All of the options you list above are handled by the internal diff API. The diff API doesn't have any knowledge about log and rev-list options, such as --graph. The nicest way to fix this would probably be to write new diff API functions that output to a strbuf instead of printing directly to stdout. Then the log code could prefix each line of the buffer with the graph info before printing it. However, this would be a lot of work, and I'm not sure that ...
Apr 7, 4:34 am 2008
Teemu Likonen
Re: [PATCH 1/4] Add history graph API
Ok, then I'd suggest that it's left as is. The --graph may be useful with some stat options even when the graph area is parially broken by some other output. --
Apr 7, 4:56 am 2008
Teemu Likonen
Re: [PATCH 1/4] Add history graph API
As I've spent some time in testing the --graph functionality I'm spamming my discoveries here. When limiting the log output to a subdirectory or to a file the graph becomes quite hard to understand. Probably the easiest way to demonstrate my point is to compare side by side (for example) git log --graph --pretty=oneline -- Documentation/ and gitk -- Documentation/ in the Git repository. gitk draws lines between commits even when they are not in direct parent-child relationship (i.e...
Apr 7, 3:26 am 2008
Adam Simpkins
Re: [PATCH 1/4] Add history graph API
Interesting, I wasn't aware of this gitk behavior. I took a look at the gitk code, and they're able to do this by passing the "--parents" option to "git log". This causes git to rewrite the parent information so that it lists the most recent ancestor that is in the resulting commit set, instead of the actual parent. It was pretty easy to change "git log --graph" to do the same; I just sent out a new patch for it. Thanks for all the testing! -- Adam Simpkins adam@adamsimpkins.net --
Apr 7, 4:06 am 2008
Teemu Likonen
[PATCH v2] bash: Add more command line option completions fo...
Signed-off-by: Teemu Likonen <tlikonen@iki.fi> --- Hmm, why not add some more useful long options? There are plenty of them of course but I feel these are one of the most common. contrib/completion/git-completion.bash | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 4d81963..02a5fd3 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.ba...
Apr 7, 8:25 am 2008
Adam Simpkins
[PATCH 1/4] graph API: Fixed coding style problems
- Removed pre-declarations of structs from graph.h; all users are expected to include the necessary header files first. - Replaced prefix increment and decrement operators with postfix operators Signed-off-by: Adam Simpkins <adam@adamsimpkins.net> --- graph.c | 42 +++++++++++++++++++++--------------------- graph.h | 5 ----- 2 files changed, 21 insertions(+), 26 deletions(-) diff --git a/graph.c b/graph.c index be4000f..6f99063 100644 --- a/graph.c +++ b/graph.c @@ -190,7 +...
Apr 7, 4:01 am 2008
Adam Simpkins
[PATCH 2/4] log and rev-list: Fixed newline termination issu...
Previously, the --graph option had problems when used together with --pretty=format. The output was missing a newline at the end of each entry, before the next graph line. This change updates the code to treat CMIT_FMT_USERFORMAT just like CMIT_FMT_ONELINE, even when --graph is not in use. Like CMIT_FMT_ONELINE, the pretty_print_commit() output for CMIT_FMT_USERFORMAT lacks a terminating newline. Similarly, there should be no blank line between entries for CMIT_FMT_USERFORMAT. The old code to...
Apr 7, 4:01 am 2008
Junio C Hamano
Re: [PATCH 2/4] log and rev-list: Fixed newline termination ...
The log family traditionally defined LF (or NUL when -z is in effect) as separator between each pair of entries, not as terminator after each entry. This was because it would make much more sense to use separator semantics when "git log -2" and "git log -1" is asked for. The former gives the tip, separator (typically an extra LF), and the second, while the latter just shows the tip. Neither case give extra LF after the last entry. This worked only because each entry were supposed to end with it...
Apr 7, 4:21 am 2008
Junio C Hamano
Re: [PATCH 2/4] log and rev-list: Fixed newline termination ...
Some alternatives to specify terminator semantics I considered are: (1) Presence of %_ in "--pretty=format:..." triggers terminator semantics and %_ itself interpolates an empty string; otherwise separator semantics is used. (2) Presence of %n in "--pretty=format:..." means a multi-line output and uses separator as before; lack of %n means it is a one-line format and uses terminator. (3) A new option --pretty=tformat:... (i.e. tformat instead of format) means LF (...
Apr 7, 4:52 am 2008
Jakub Narebski
Re: [PATCH 2/4] log and rev-list: Fixed newline termination ...
Or %_ might interpolate to _single_ separator, swallowing all separators that follows it (something like collapsing whitespace). Either that, or %_ interpolate to separator value, and %*_ collapses separators (terminators). I guess that literal newline in format would also mean multi-line output. Also '%b' (body) should mean multi-line output. BTW. rpm uses [% ... ] to iterate over a set of (parallel) arrays in --queryformat, which is a bit similar to --pretty=format:<fmt>, e.g. 'r...
Apr 7, 9:19 am 2008
Jeff King
Re: [PATCH 2/4] log and rev-list: Fixed newline termination ...
How about: (5) There is no automagic terminator or separator for user formats. %n translates to a newline. %N translates to a newline, unless this is the final record, in which case it translates to the empty string. So: # oneline git log --pretty=format:'%h %s%n' # multiline git log --pretty=format:'%h%nSubject: %s%n%N' The main drawback is that dropping the automatic separator breaks existing uses. We could work around this by automatically appending ...
Apr 7, 9:17 am 2008
Adam Simpkins
[PATCH 3/4] log and rev-list: Fix --graph output with --pret...
As pointed out by Teemu Likonen, the initial line of pretty_print_commit() output wasn't correctly prefixed by the graph information. Signed-off-by: Adam Simpkins <adam@adamsimpkins.net> --- log-tree.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/log-tree.c b/log-tree.c index 0d7e521..d2cb26a 100644 --- a/log-tree.c +++ b/log-tree.c @@ -166,11 +166,16 @@ void log_write_email_headers(struct rev_info *opt, const char *name, } printf("From %s Mo...
Apr 7, 4:01 am 2008
Nicolas Pitre
Re: Achieving efficient storage of weirdly structured repos
Well, in your example, the large image part should already be common to many objects due to deltas if they're really the same: different objects will only have different EXIF data plus a delta reference to the same base image object. So in a way the split is already there. Needs only that some applications exploit this information at runtime. Nicolas --
Apr 6, 8:13 pm 2008
Jeff King
Re: Achieving efficient storage of weirdly structured repos
Yes, the resulting packfiles find the deltas and are pretty efficient (although it is quite slow to pack). However, the delta information is not used at all for inexact rename detection. Are you proposing to make that information available to the rename detector? -Peff --
Apr 6, 8:18 pm 2008
Nicolas Pitre
Re: Achieving efficient storage of weirdly structured repos
In practice I don't know how well that would work since the current heuristic groups deltas and their base according to the name under which those objects are known. So it is possible that some inexact renames end up creating objects that currently never delta against each other even if that would be the right thing to do. But in some cases, that might be beneficial to look at the delta object themselves when diffing files as the delta might already contain the information telling the up...
Apr 6, 8:36 pm 2008
Eric Wong
[PATCH] git-svn: fix following renamed paths when tracking a...
When using git-svn to follow only a single (empty) path per svn-remote (i.e. not using --stdlayout), following the history of a renamed path was broken in c586879cdfa4f8181a14e953a9152a4639eef333. This reverts the regression for the single (emtpy) path per svn-remote case. To avoid breaking the tests in a committed revision, this is an addendum to a patch originally submitted by Santhosh Kumar Mani <santhoshmani@gmail.com>: > git-svn: add test for renamed directory fetch > ...
Apr 7, 3:08 am 2008
David Mansfield
Re: [PATCH] cvsps/cvsimport: fix branch point calculation an...
More or less, yes. It gets worse if a user does 'cvs update' in a It's not 'my framing of the problem.' It's 'the design goal of cvsps is not compatible with the desire to use the output of cvsps to create a Yes. That's what cvs2git was designed for. Look at the name. In order to create the 'fixup' branch, you have to make some out of operations, which is fine if that's what your design goal is. The design goal of cvsps was always simply to show who did what and in what chronological o...
Apr 7, 1:54 pm 2008
Jean-François Veillette
Re: [PATCH] cvsps/cvsimport: fix branch point calculation an...
I do use it, please fix the duo cvsps/git-cvsimport (if possible). The fact that it's integrated with git make it very useful and handy. It is working well for almost all of my cvs repo that I track with git. If it would work for all of them it would be wonderful ! - jfv --
Apr 7, 2:07 pm 2008
Eric Wong
Re: git-svn: regression with funny chars in svn repo url
I've known of this bug for a while but didn't track it down until now. Please let me know if this fixes things for you and if there are any regressions; thanks. From a9ebe54adf7ae2620fba1f638dee9566f8ccca82 Mon Sep 17 00:00:00 2001 From: Eric Wong <normalperson@yhbt.net> Date: Mon, 7 Apr 2008 00:41:44 -0700 Subject: [PATCH] git-svn: fix cloning of HTTP URLs with '+' in their path With this, git svn clone -s http://svn.gnome.org/svn/gtk+ is successful. Also modified the funky rename t...
Apr 7, 4:11 am 2008
Eric Wong
Re: git-svn stomps on user properties
Sorry, I'm not ignoring you, I just haven't had time to look into this yet. -- Eric Wong --
Apr 7, 3:40 am 2008
Eric Wong
Re: git-svn breaks on gtk+ import
Hi Tim, the HTTP repository should be fixed with the patch in http://article.gmane.org/gmane.comp.version-control.git/78961 -- Eric Wong --
Apr 7, 4:20 am 2008
previous daytodaynext day
April 6, 2008April 7, 2008April 8, 2008