git mailing list

FromSubjectsort iconDate
Karl
bug in git-apply
StGit's test suite has started failing, and it's due to a change in git that I'm pretty sure is a bug. I built a small test case using just git for easier testing: mkdir foo cd foo git init touch xx git add xx git commit -m 'first' git checkout -b branch echo aaa >> xx git add xx git commit -m 'second' git checkout master echo bbb >> xx git add xx git commit -m 'third' git diff branch^ branch > p git apply < p && echo "this should not ...
Apr 6, 4:53 pm 2008
Jakub Narebski
Re: [bug] git-clone over ssh fails when repository has l ...
<opublikowany i wysłany> It looks for me as permission problems, as thought loose objects get created unreadable by git daemon, or something... -- Jakub Narebski Warsaw, Poland ShadeHawk on #git --
Apr 6, 1:50 pm 2008
Roger C. Soares
[EGIT PATCH 3/3] Use RevFlag to highlight find results i ...
Make the toolbar aware of the highlight flag so that we can roolback CommitGraphTable and prevent it from consulting a Map in it's doPaint method. Signed-off-by: Roger C. Soares <rogersoares@intelinet.com.br> --- .../egit/ui/internal/history/CommitGraphTable.java | 13 ++++----- .../egit/ui/internal/history/FindResults.java | 27 +++++++++++++++++++- .../egit/ui/internal/history/FindToolbar.java | 6 +++- .../ui/internal/history/FindToolbarThread.java | 12 ++++---- ...
Apr 6, 2:42 pm 2008
Roger C. Soares
[EGIT PATCH 2/3] Change the find toolbar find-in prefs i ...
The find toolbar now searches only in one field at a time and the user can change the find-in field by clicking on the button. The button shows an icon so the user knows at all times what field is selected. We don't have the option to find in 2 or more fields at the same time anymore, but from day to day usage I noticed that I usually only want to search in one field at a time. It feels a lot better to me and makes it more like gitk. Signed-off-by: Roger C. Soares ...
Apr 6, 2:42 pm 2008
Roger C. Soares
[EGIT PATCH 1/3] FindToolbar port to the new history page.
This is a port from the find toolbar to the new history page. It is replacing the current highlight flag in order to have the find feature back but most of the code from the toolbar shall be replaced to make use of the new infrastructure added into jgit (RevFlag and RevFilter). Signed-off-by: Roger C. Soares <rogersoares@intelinet.com.br> --- Hi Shawn, I'm reseding the toolbar port with the fixes for the items you mentioned. It's on top of 009f11e2c8971b6053, don't know if it would have ...
Apr 6, 2:41 pm 2008
Jonas Fonseca
[ANNOUNCE] tig-0.11
Hello, This tig release brings many fixes and improvements to the user interface. Fix pager mode and disable view rely on git directory. The date and author columns as well as references can now be toggled on and off. Local (unsigned) tags are now shown as references and the builtin reference colors have been changed to highlight the current branch and the remote tracked by the current branch. The status and stage views are now reloaded after running external commands (e.g. git commit) so ...
Apr 6, 1:05 pm 2008
Adam Simpkins
Re: [PATCH 3/4] git log and git rev-list: Add --graph option
Yep, I forgot to test that one. Thanks for pointing it out. It looks like it shouldn't be too hard to fix. I'll try to fix it and submit a patch later this evening. -- Adam Simpkins adam@adamsimpkins.net --
Apr 6, 3:51 pm 2008
Adam Simpkins
Re: [PATCH 1/4] Add history graph API
Yes, it does. Unfortunately, it doesn't have any effect with --pretty=format. Actually, going back and testing this, it looks like I have a bug when handling --graph together with --pretty=format. There's a missing newline after the user's format message and the next graph line. I'll try to fix this and submit a patch later this evening. -- Adam Simpkins adam@adamsimpkins.net --
Apr 6, 3:47 pm 2008
Johannes Schindelin
Re: [PATCH 1/4] Add history graph API
Hi, AFAICT you do not even need them then. Using "struct strbuf *" without ever declaring struct strbuf before that is perfectly valid. Ciao, Dscho --
Apr 6, 3:15 pm 2008
Teemu Likonen
[PATCH] bash: Add command line completion of --graph (git log)
Signed-off-by: Teemu Likonen <tlikonen@iki.fi> --- contrib/completion/git-completion.bash | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 791e30f..cd26d0c 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -754,6 +754,7 @@ _git_log () --pretty= --name-status --name-only --raw --not --all --left-right ...
Apr 6, 2:25 pm 2008
Adam Simpkins
Re: [PATCH 1/4] Add history graph API
I added them so that graph.h can be included without including any other header files first. They can be taken out if we assume that all Sorry, force of habit. I tried to remember to use postfix in most places, but I guess I forgot in that place. I do most of my programming in C++, which allows crazy things like defining prefix and postfix ++ and -- operators on classes. When using these on classes, the prefix operator is normally more efficient than the postfix version, so I'm just in ...
Apr 6, 3:04 pm 2008
Teemu Likonen
Re: [PATCH 1/4] Add history graph API
I don't know anything about the inside stuff but from user's point of view this is the kind of text-based graph I'd agree to be integrated to Git (well, I integrated it already to my Git). I like this a lot, thanks. Maybe git-doc.txt should be updated with new option(s)? --
Apr 6, 1:30 pm 2008
Johannes Schindelin
Re: [PATCH 1/4] Add history graph API
Hi, You do not need those. Apart from that, it looks very, very clean to me. (Except maybe the prefix ++ that could have been a postfix ++ in the line before, but that is just me.) Ciao, Dscho --
Apr 6, 2:06 pm 2008
Johannes Schindelin
Re: [PATCH 1/4] Add history graph API
Hi, Would "--decorate" help? Ciao, Dscho --
Apr 6, 1:42 pm 2008
Teemu Likonen
Re: [PATCH 3/4] git log and git rev-list: Add --graph option
The '--graph' seems to work nicely with every '--pretty=' option except 'email'. $ git log --graph --pretty=email | M From 77ad7a49d3cc946487ca759e5361effbcfb03be5 [...] From: Junio C Hamano <gitster@pobox.com> |\ Date: Fri, 4 Apr 2008 22:38:32 -0700 | | Subject: [PATCH] Merge git://repo.or.cz/git-gui | | | | * git://repo.or.cz/git-gui: | | git-gui: use +/- instead of ]/[ to show [...] | | git-gui: Update french translation | | git-gui: Switch keybindings ...
Apr 6, 2:15 pm 2008
Adam Simpkins
Re: [PATCH 1/4] Add history graph API
Ah, you're right, I forgot about that. I'll send out a new patch to update Documentation/rev-list-options.txt -- Adam Simpkins adam@adamsimpkins.net --
Apr 6, 2:44 pm 2008
Adam Simpkins
[PATCH 2/4] graph API: Added additional utility function ...
Added several graph_show_* functions that print directly to stdout instead of to a strbuf. Also added functions for explicitly adding vertical padding in the graph. Signed-off-by: Adam Simpkins <adam@adamsimpkins.net> --- Documentation/technical/api-history-graph.txt | 28 +++++ graph.c | 140 +++++++++++++++++++++++++ graph.h | 51 +++++++++ 3 files changed, 219 insertions(+), 0 deletions(-) diff --git ...
Apr 6, 11:42 am 2008
Adam Simpkins
[PATCH 4/4] git log: Updated --graph to work even when t ...
Signed-off-by: Adam Simpkins <adam@adamsimpkins.net> --- graph.c | 22 +++++++++++++++------- revision.c | 3 --- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/graph.c b/graph.c index e6d1d3a..be4000f 100644 --- a/graph.c +++ b/graph.c @@ -1,6 +1,8 @@ #include "cache.h" #include "commit.h" #include "graph.h" +#include "diff.h" +#include "revision.h" /* * TODO: @@ -174,17 +176,24 @@ static void graph_ensure_capacity(struct git_graph *graph, int ...
Apr 6, 11:42 am 2008
Adam Simpkins
[PATCH 5/5] Document the new --graph option for log and ...
Signed-off-by: Adam Simpkins <adam@adamsimpkins.net> --- Documentation/rev-list-options.txt | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt index 2648a55..ce6a101 100644 --- a/Documentation/rev-list-options.txt +++ b/Documentation/rev-list-options.txt @@ -75,6 +75,16 @@ you would get an output line this: -xxxxxxx... 1st on a ...
Apr 6, 2:47 pm 2008
Adam Simpkins
[PATCH 3/4] git log and git rev-list: Add --graph option
The --graph option causes a text-based representation of the history graph to be printed on the left-hand side of the output. Signed-off-by: Adam Simpkins <adam@adamsimpkins.net> --- The --graph option can be used with any --pretty format. If this change is too intrusive for people's liking, a smaller change could probably be done that only adds --pretty=graph and --pretty=graph:<user_fmt> options. At the moment, --graph and --reverse are mutually exclusive. With Junio's new --children ...
Apr 6, 11:42 am 2008
Adam Simpkins
[PATCH 1/4] Add history graph API
This new API allows the commit history to be displayed as a text-based graphical representation. Signed-off-by: Adam Simpkins <adam@adamsimpkins.net> --- This is a replacement for the git-graph patch I submitted last weekend. It adds the graph functionality as a new API. A subsequent commit updates "git log" and "git rev-list" to use the new API. I saw that Jan Engelhardt also submitted a patch for his git-forest script this past week. It looks like a fine tool, too. I think there are ...
Apr 6, 11:42 am 2008
Adam Simpkins
Re: [PATCH 1/4] Add history graph API
Trying to compile the following test code with gcc 4.1.2 results in a warning. test.c: #include <stdio.h> void test(struct strbuf *sb); int main(int argc, char **argv) { test(NULL); return 0; } $ gcc -c test.c test.c:3: warning: ‘struct strbuf’ declared inside parameter list test.c:3: warning: its scope is only this definition or declaration, which is probably not what you want -- Adam Simpkins adam@adamsimpkins.net --
Apr 6, 3:58 pm 2008
Shawn O. Pearce
Re: [PATCH] Add interactive option in rebase command com ...
I agree with Pascal here, include the option. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> -- Shawn. --
Apr 6, 12:09 pm 2008
Junio C Hamano
Re: [PATCH] Add interactive option in rebase command com ...
I personally do not think this is worth it where a single "-i" is enough. --
Apr 6, 11:19 am 2008
Elijah Newren
Re: [PATCH] Add interactive option in rebase command com ...
One advantage of bash completion, in my opinion, is being able to be reminded of option names by tabbing twice to get a list of possible completions. For exactly such a case, I'd be in favor of this patch. Just my $0.02, Elijah --
Apr 6, 11:33 am 2008
Pascal Obry
[PATCH] Add interactive option in rebase command complet ...
Signed-off-by: Pascal Obry <pascal@obry.net> --- contrib/completion/git-completion.bash | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 791e30f..96a712b 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -865,7 +865,7 @@ _git_rebase () return ;; --*) - __gitcomp "--onto --merge --strategy" + __gitcomp "--onto --merge ...
Apr 6, 10:32 am 2008
Shawn O. Pearce
Re: [PATCH] Add interactive option in rebase command com ...
Gaaaah. I didn't mean SBO. I mean Acked-by! Stupid fingers. -- Shawn. --
Apr 6, 1:08 pm 2008
Pascal Obry
Re: [PATCH] Add interactive option in rebase command com ...
I like unambiguous name (I do prefer --interactive instead of -i). It is painful to enter so the bash completion come quite handy here. The patch is safe, simple and clean, I see no reason to not include it. Pascal. -- --|------------------------------------------------------ --| Pascal Obry Team-Ada Member --| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE --|------------------------------------------------------ --| ...
Apr 6, 11:46 am 2008
Christian Couder
[PATCH] test suite: remove useless TERM cruft in "t7005- ...
In commit 15387e32ff5116b82d3fe53df55b8c87eec83e01 I added some cruft to reset TERM to its previous value before the "test_done" at the end of "t7005-editor.sh" because otherwise "test_done" would have printed the test result with a bad TERM env variable (this resulted in output with no color on konsole). But since commit c2116a1783a3d555d41892ae7db0dd0934d4ddf1 colored output is printed in a subshell with TERM reset to its original value so the cruft added in my patch above is now ...
Apr 6, 10:08 am 2008
Pascal Obry
[PATCH] Add prefix oriented completions for diff and for ...
Signed-off-by: Pascal Obry <pascal@obry.net> --- contrib/completion/git-completion.bash | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 791e30f..618d278 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -639,7 +639,9 @@ _git_diff () --find-copies-harder --pickaxe-all --pickaxe-regex --text --ignore-space-at-eol ...
Apr 6, 9:56 am 2008
Shawn O. Pearce Apr 6, 12:45 pm 2008
Jakub Narebski
Re: [PATCH] merge, pull: introduce '--diffstat' option
It looks more like --shortlog, by the way... (Stupid backwards compatibility...) -- Jakub Narebski Warsaw, Poland ShadeHawk on #git --
Apr 6, 7:37 am 2008
Shawn O. Pearce
Re: [PATCH] Add description of OFS_DELTA to the pack for ...
You are missing the description that the position within _this_ packfile is determined by: offset_of_type_byte - n_byte_offset The above can still be taken to mean the offset is from the start Hmm. I've just spent 5 minutes reading this and I'm still not certain what the result is. 2^0 only gets added to the result if there is at least 2 bytes of data in the offset encoding; in your description above it sounds like we should add 2^0 (1) even when there is only 1 offset byte (n=1), ...
Apr 6, 12:07 pm 2008
Shawn O. Pearce
Re: [PATCH v3] Add description of OFS_DELTA to the pack ...
Yup. :-) Acked-by: Shawn O. Pearce <spearce@spearce.org> -- Shawn. --
Apr 6, 3:26 pm 2008
Peter Eriksen
[PATCH] Add description of OFS_DELTA to the pack format ...
Signed-off-by: Peter Eriksen <s022018@student.dtu.dk> --- I'll take it in smaller steps this time. Documentation/technical/pack-format.txt | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/Documentation/technical/pack-format.txt b/Documentation/technical/pack-format.txt index aa87756..f6b1405 100644 --- a/Documentation/technical/pack-format.txt +++ b/Documentation/technical/pack-format.txt @@ -103,10 +103,20 @@ Pack file entry: <+ packed ...
Apr 6, 6:47 am 2008
Shawn O. Pearce
Re: [PATCH v2] Add description of OFS_DELTA to the pack ...
Except that only a positive offset value is here, as it is always a treated as a negative offset (you can only refer to a base that was before you, as that is the only way to know the base's offset Yes, that sounds correct. -- Shawn. --
Apr 6, 1:28 pm 2008
Peter Eriksen
[PATCH v2] Add description of OFS_DELTA to the pack form ...
Signed-off-by: Peter Eriksen <s022018@student.dtu.dk> --- Documentation/technical/pack-format.txt | 16 +++++++++++++++- 1 files changed, 15 insertions(+), 1 deletions(-) On Sun, Apr 06, 2008 at 03:07:24PM -0400, Shawn O. Pearce wrote: Yes, I misunderstood that. Peter diff --git a/Documentation/technical/pack-format.txt b/Documentation/technical/pack-format.txt index aa87756..953c7ee 100644 --- a/Documentation/technical/pack-format.txt +++ ...
Apr 6, 1:19 pm 2008
Peter Eriksen
[PATCH v3] Add description of OFS_DELTA to the pack form ...
Signed-off-by: Peter Eriksen <s022018@student.dtu.dk> --- Documentation/technical/pack-format.txt | 16 +++++++++++++++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/Documentation/technical/pack-format.txt b/Documentation/technical/pack-format.txt index aa87756..6b2170f 100644 --- a/Documentation/technical/pack-format.txt +++ b/Documentation/technical/pack-format.txt @@ -103,10 +103,24 @@ Pack file entry: <+ packed object data: If it is not DELTA, then ...
Apr 6, 1:51 pm 2008
seventh guardian
Re: [bug] git-clone over ssh fails when repository has l ...
On Sun, Apr 6, 2008 at 7:06 PM, seventh guardian The last repo also exhibits the problem after committing a local change. A hard reset to "origin" fixes the problem, but also throws away the local changes.. Cheers, Renato --
Apr 6, 11:11 am 2008
Jeff King
Re: [bug] git-clone over ssh fails when repository has l ...
It sounds like your remote repository has a bogus HEAD that points to a non-existent object. Can you ssh to <host> and confirm that you can do a "git show HEAD" in the remote repo? -Peff --
Apr 6, 9:11 am 2008
seventh guardian
Re: [bug] git-clone over ssh fails when repository has l ...
I figured ;) Let me see if I can explain it better: remote master: the project git server, located remotely over the internet local master: my laptop repository, made by cloning the project master repo slave(s): my local machines, which clone the local master, instead of the remote master (to save bandwidth) So on the local master (my laptop) I did: $ git-clone http://remote.master.address/foo/bar.git Because I had to do some local changes to the code (what I've called a "local commit"), ...
Apr 6, 10:11 am 2008
Jeff King
Re: [bug] git-clone over ssh fails when repository has l ...
You are going to have to clarify what you mean by "local commit" and "local master". Those aren't terms that are commonly used, so I don't understand what you are talking about. Can you describe which git commands you used to create this situation? -Peff --
Apr 6, 9:56 am 2008
seventh guardian
Re: [bug] git-clone over ssh fails when repository has l ...
My process is the same as yours, except for the "time-torture" the repositories have suffered. Surprisingly, everything worked on a fresh clone. So I suspect my "local master" repo's are somewhat messed up.. Will try to investigate further. Thanks! Renato --
Apr 6, 12:02 pm 2008
seventh guardian
[bug] git-clone over ssh fails when repository has local ...
Hello, First of all I kindly ask you to put my e-mail in CC as I'm not subscribed to the list. Secondly, I did try to find similar issues on the archives, but failed to do so. I apologize if this is not a bug. I keep some local git repositories on my laptop, which are also used by other machines on my home network. In order to avoid unnecessary burden on the master servers, I've tried keeping a "local master" on the laptop and clone the repo's over ssh on the other machines. I have some ...
Apr 6, 6:45 am 2008
seventh guardian
Re: [bug] git-clone over ssh fails when repository has l ...
I can, but it is a local commit. It seems like local commits aren't being "cloned over" to the slaves.. As I said, this only happens for "local masters" where I have local commits. If my master is untouched, then I can successfuly clone the repo. Thanks, Renato --
Apr 6, 9:22 am 2008
Jeff King
Re: [bug] git-clone over ssh fails when repository has l ...
That shouldn't matter to git; it doesn't care at all about where commits Can you give an exact set of steps to reproduce? There doesn't seem to be anything wrong with those repos, and I was able to do: m1$ git clone git://anongit.freedesktop.org/git/nouveau/xf86-video-nouveau/ m1$ cd xf86-video-nouveau && echo foo >>COPYING && git commit -a -m foo m2$ git clone ssh://m1/path/to/xf86-video-nouveau So now my guess is when you make local changes, something funny is going on. Can you ...
Apr 6, 11:17 am 2008
Jeff King
Re: [bug] git-clone over ssh fails when repository has l ...
OK, I understand now. I think that is a reasonable terminology for your situation, but keep in mind that git doesn't really understand the concept of a "master". From the perspective of your slaves, there is only your "local master" as the remote "origin", and they can't tell any Hmm. This _should_ just work, but something funny is going on. For some reason the "local master" is telling us that his HEAD points to f7a51afd, but we don't actually get that object. But I'm not quite sure how we ...
Apr 6, 10:51 am 2008
seventh guardian
Re: [bug] git-clone over ssh fails when repository has l ...
This object is the correct HEAD, but it is a local commit (I rebase Sure, I just thought it would confuse more than it would help. I was obviously wrong, as I'm actually using git:// instead of http://.... sorry... ;) I'm experiencing this with both these repo's, as I have committed some local changes to them: git://anongit.freedesktop.org/git/nouveau/mesa git://anongit.freedesktop.org/git/nouveau/xf86-video-nouveau/ On the other hand, I don't have this issue with this repo, ...
Apr 6, 11:06 am 2008
Junio C Hamano
Re: [PATCH 2/6] merge, pull: introduce '--(no-)stat' option
...this hunk removes the original options from OPTIONS_SPEC, I suspect you would get "unknown option 'stat'" from underlying "git rev-parse --parseopt". You probably haven't noticed the breakage because you replaced all existing --summary with --stat in the tests, though. Oops. We would want to take a three-stage approach where we (1) start accepting both forms without changing the official names shown to the users, (2) deprecate the old names and make the new ones official, and then ...
Apr 5, 7:36 pm 2008
Junio C Hamano
Re: How do I set the committer with cherry-pick? (or is ...
You've already done that. They are not what you _wrote_ so your name won't be on "Author:" lines, but you made into commits in the final history, and your name would appear on "Committer:" lines. A _better way_, especially because you are already pulling from them, would be just "pull", without having to cherry-pick to clean-up the history. The reason you are being forced to cherry-pick is probably _their_ histories you pulled are suboptimal and full of garbage commit, ...
Apr 5, 5:05 pm 2008
Pat Maddox
Re: How do I set the committer with cherry-pick? (or is ...
That makes sense. So let's say somebody made some changes of their own that I don't want in the repository. Would the best thing for them to do be to create a new branch off of my main line, and then cherry-pick their commits in themself. Then they send me the url along with the branch, so that when I pull from them it's only the new commits applied to the main line. And finally, when I experimented with doing a pull instead of cherry-pick, it listed the original author as the committer ...
Apr 5, 5:58 pm 2008
Junio C Hamano
Re: How do I set the committer with cherry-pick? (or is ...
Well, at that point, you are not the committer for their changes on their clean history, and you shouldn't expect to be recorded as such. Your contribution to the project might still be recorded as the committer of the merge commit that pulled their contributions in, though. Any history is just as valid as your integration branch's history. There may be hundreds of potential histories in the universe --- each and every contributor, anybody who clones and plays with the project may create ...
Apr 5, 6:18 pm 2008
Shawn O. Pearce
Re: [PATCH] git-pack-objects.txt: Make wording slightly ...
Yea, this is a good improvement in readability. I can't even -- Shawn. --
Apr 5, 9:35 pm 2008
Junio C Hamano
Re: [PATCH] Update, and clear up the pack format documen ...
Right. Saying just "n-byte offset" can be mistaken as the offset from the Ah, I forgot about that one. --
Apr 5, 11:16 pm 2008
Shawn O. Pearce
Re: [PATCH] Update, and clear up the pack format documen ...
That is not correct. The ofs_delta is encoded as an n-byte offset that is subtracted from the current object's first byte (the byte holding the type/representation field and first 4 bits of length). The n-byte encoding for an ofs_delta is different then the one used for the length. We add 1 for each byte where the MSB is 1. We also store the data in big-endian form (the most significant byte is first and the least significant byte is last). See get_delta_base in sha1_file.c for the ...
Apr 5, 9:51 pm 2008
Daniel Barkalow
Re: rebase--interactive in C vs. sequencer
I was mainly working from rebase--interactive, and a lot of what I have is Not at the moment. I've been busy with a new job recently, and my git work I haven't actually looked at it recently, so I don't entirely remember how far I got. I think my most recent code is based around the idea of having a sequence file and a file of saved options, but it's just kind of a sketch and most of the stuff isn't actually implemented. IIRC, the last thing I ran into was trying to decide where to ...
Apr 6, 2:44 pm 2008
Stephan Beyer
Re: [PATCH] alias.c: use git_config_string() to get alias_val
Ah, ok. Didn't knew that such reasoning goes into the commit message, Or to use the cast. ;-) I agree ;-) So what to do? Keep it? And there are still some easy `Janitor tasks', like in builtin-apply.c: -- diff --git a/builtin-apply.c b/builtin-apply.c index b5f78ac..ce0a0c3 100644 --- a/builtin-apply.c +++ b/builtin-apply.c @@ -2978,12 +2978,8 @@ static int apply_patch(int fd, const char *filename, int inaccurate_eof) static int git_apply_config(const char *var, const ...
Apr 6, 4:02 am 2008
Christian Couder
Re: [PATCH] alias.c: use git_config_string() to get alias_val
Yes. And thanks, your patch looks good, but please send a proper patch for it latter if you really care about it. (By proper I mean in its own email and not attached. And I know my patch included in my previous email was bad (corrupted tab, sorry about that, and not in its own email), but it was only for discussion, yours too granted.) Now I think that you should focus on your GSoC application as you don't have much time left to improve it and I just asked you for more ...
Apr 6, 6:29 am 2008
Christian Couder
Re: [PATCH] alias.c: use git_config_string() to get alias_val
Hi, So you should say in the commit message that you decided to cast to "const char **" despite what is on the Janitor page, and most importantly explain Yes, so perhaps it's not a good idea to convert the original file to Yes, but there are only 2 callers and only one in git.c changes the buffer. A patch like this (not tested) one makes use of a strbuf to copy the buffer returned by alias_lookup in git.c, so that it is now possible (if we really want it) to change alias_lookup to ...
Apr 5, 10:49 pm 2008
Gerrit Pape
Re: [PATCH (BUGFIX)] gitweb: Fix "Use of uninitialized v ...
Yes, I take responsibility for the git Debian packages. Regards, Gerrit. --
Apr 6, 3:22 am 2008
Jeff King
Re: Achieving efficient storage of weirdly structured repos
I have considered something like this for one of my repos, which is full of images. The large image data very rarely changes, but the small EXIF tags do. My thought was something like: - add a new object type, multiblob; a multiblob contains zero or more "child" sha1s, each of which is another multiblob or a blob. The data in the multiblob is an in-order concatenation of its children. - you would create multiblobs with a "smart" git-add that understands the filetype and ...
Apr 6, 9:10 am 2008
Roman Shaposhnik
Re: Achieving efficient storage of weirdly structured repos
Hi Linus, It sure is old-fashioned. My only excuse is that since git repack is a shell script around git-pack-objects I've always felt comfortable just using It was pretty much the result of (cd .git/objects ; find . -type f | tr -d './') Omitting that was quite silly on my part, but I was really convinced that because of the internal sorting the original ordering of objects So it seems that my list of objects was different from what git-rev- list/setup_revisions() would have ...
Apr 5, 5:13 pm 2008
Linus Torvalds
Re: Achieving efficient storage of weirdly structured repos
Ok, that explains it. And yes, it definitely works, but I think you now understand why it gave you that oddly pessimised pack-file. That said, I think it's also a really good example of how the git pack-files really are just a "bag of objects", and the fact that it worked but was non-optimal is a very good way to show something very fundamental Well, a pack actually as two *different* orderings, in that there's one ordering that is used for laying out the result in the pack-file, ...
Apr 5, 5:48 pm 2008
Jeff King
Re: [PATCH] merge, pull: introduce '--diffstat' option
I'll add a belated "yes I agree" to this. This is what I was trying to describe earlier in the thread, but for some reason couldn't think of the obvious name "log" to replace merge.summary. :) -Peff --
Apr 6, 6:53 am 2008
SZEDER Gábor
[PATCH 0/6] merge summary and diffstat options cleanup
I have only looked at the 'merge.diffstat' config variable, and wanted to make the command line option consistent with it. But you are right, The first patch is an independent documentation cleanup that could be merged regardless of the other patches, but the others depend on it. Patches 2-5 are implementing your first four point. Patch 4 not only adds the 'merge.log' config variable, but also adds corresponding command line options. Finally, the last patch removes all the deprecated ...
Apr 5, 6:23 pm 2008
SZEDER Gábor
[PATCH 3/6] add 'merge.stat' config variable
This variable has the same effect, as 'merge.diffstat'. Also mention it in the documentation. Signed-off-by: SZEDER Gábor <szeder@ira.uka.de> --- Documentation/merge-config.txt | 4 ++++ Documentation/merge-options.txt | 2 +- git-merge.sh | 1 + 3 files changed, 6 insertions(+), 1 deletions(-) diff --git a/Documentation/merge-config.txt b/Documentation/merge-config.txt index cc815cc..6d0a797 100644 --- a/Documentation/merge-config.txt +++ ...
Apr 5, 6:23 pm 2008
SZEDER Gábor
[PATCH 1/6] doc: moved merge.* config variables into sep ...
Include the new file from config.txt and git-merge.txt. Signed-off-by: SZEDER Gábor <szeder@ira.uka.de> --- Documentation/config.txt | 32 +------------------------------- Documentation/git-merge.txt | 13 +------------ Documentation/merge-config.txt | 31 +++++++++++++++++++++++++++++++ 3 files changed, 33 insertions(+), 43 deletions(-) create mode 100644 Documentation/merge-config.txt diff --git a/Documentation/config.txt b/Documentation/config.txt index 04c01c5..f009740 ...
Apr 5, 6:23 pm 2008
SZEDER Gábor
[PATCH 2/6] merge, pull: introduce '--(no-)stat' option
This option has the same effect as '--(no-)summary' (i.e. whether to show a diffsat at the end of the merge or not), and it is consistent with the '--stat' option of other git commands. Documentation, tests, and bash completion are updaed accordingly. '--(no-)summary' options are still accepted, but are not advertised. Signed-off-by: SZEDER Gábor <szeder@ira.uka.de> --- Documentation/git-merge.txt | 2 +- Documentation/merge-options.txt | 4 ++-- ...
Apr 5, 6:23 pm 2008
SZEDER Gábor
[PATCH 4/6] fmt-merge-msg: add '--(no-)log' options and ...
These are doing the same as the '--(no-)summary' options or the 'merge.summary' config variable, but are consistent with the soon to be added 'merge --(no-)log' options. The 'merge.summary' config variable and '--(no-)summary' options are still accepted, but are not advertised. 'merge.log' takes precedence over 'merge.summary'. Update documentation and test accordingly. Signed-off-by: SZEDER Gábor <szeder@ira.uka.de> --- Documentation/git-fmt-merge-msg.txt | 10 +++++----- ...
Apr 5, 6:23 pm 2008
SZEDER Gábor
[PATCH 6/6] merge: remove deprecated summary and diffsta ...
Also remove them from 'pull' and 'fmt-merge-msg'. Signed-off-by: SZEDER Gábor <szeder@ira.uka.de> --- builtin-fmt-merge-msg.c | 12 +++--------- git-merge.sh | 5 ++--- git-pull.sh | 4 ++-- 3 files changed, 7 insertions(+), 14 deletions(-) diff --git a/builtin-fmt-merge-msg.c b/builtin-fmt-merge-msg.c index d49f545..0bf87c1 100644 --- a/builtin-fmt-merge-msg.c +++ b/builtin-fmt-merge-msg.c @@ -12,12 +12,7 @@ static int merge_summary; static int ...
Apr 5, 6:23 pm 2008
SZEDER Gábor
[PATCH 5/6] merge, pull: add '--(no-)log' command line option
These are the command line option equivalents of the 'merge.log' config variable. The patch also updates documentation and bash completion accordingly, and adds a test. Signed-off-by: SZEDER Gábor <szeder@ira.uka.de> --- Documentation/merge-options.txt | 9 +++++++++ contrib/completion/git-completion.bash | 2 +- git-merge.sh | 8 ++++++-- git-pull.sh | 8 +++++--- t/t7600-merge.sh | 16 ...
Apr 5, 6:23 pm 2008
Paul Mackerras
Re: [PATCH] tcl/tk8.5: fix changing colors through Edit- ...
Thanks for reminding me. I have applied it. Paul. --
Apr 5, 8:09 pm 2008
previous daytodaynext day
April 5, 2008April 6, 2008April 7, 2008