Hi,

On Sun, 6 Apr 2008, Adam Simpkins wrote:

quoted text
> On Sun, Apr 06, 2008 at 10:06:24PM +0100, Johannes Schindelin wrote:
> > 
> > On Sun, 6 Apr 2008, Adam Simpkins wrote:
> > 
> > > +/* Defined in commit.h */
> > > +struct commit;
> > > +/* Defined in strbuf.h */
> > > +struct strbuf;
> > 
> > You do not need those.
> 
> I added them so that graph.h can be included without including any other 
> header files first.  They can be taken out if we assume that all users 
> of graph.h will include commit.h and strbuf.h first.

AFAICT you do not even need them then.  Using "struct strbuf *" without 
ever declaring struct strbuf before that is perfectly valid.

Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html