Re: [updated PATCH] Same default as cvsimport when using --use-log-author

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Eric Wong <normalperson@...>
Cc: Junio C Hamano <gitster@...>, <git@...>, Andy Whitcroft <apw@...>
Date: Tuesday, April 29, 2008 - 5:13 pm

Eric Wong wrote:



I have to correct myself here.  What happens is that if in the commit
message there is no From: or Signed-off-by: to be found to parse, that
results in an empty $name_field, and causes $email to stay undefined,
which eventually results in the same silly generated UUID-domain I'm
trying to get rid of.

So it's not triggering the 'unknown' above.



Well, it is triggered, but rather because $name_field is empty, and
consequently $email is never set.




That is a good change (IMO), but I still need my patch (or something
similar) to cover the undefined $name_field case.  Proposed new patch
follows.
-- 
Sincerely,                                                          srb@cuci.nl
           Stephen R. van den Berg.

"There's a lot to be said for not saying a lot."
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[updated PATCH] Same default as cvsimport when using --use-l..., Stephen R. van den Berg, (Sun Apr 27, 1:32 pm)
Re: [updated PATCH] Same default as cvsimport when using --u..., Johannes Schindelin, (Mon Apr 28, 6:15 am)
Re: [updated PATCH] Same default as cvsimport when using --u..., Stephen R. van den Berg, (Tue Apr 29, 5:13 pm)
[updated2 PATCH] git-svn: Same default as cvsimport when usi..., Stephen R. van den Berg, (Tue Apr 29, 5:20 pm)