Home » Mailing list archives » git » 2008 » April » 14

Re: [PATCH v2.1] Teach rebase interactive the mark command

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Shawn O. Pearce
Subject: Re: [PATCH v2.1] Teach rebase interactive the mark command
Date: Monday, April 14, 2008 - 4:29 pm

Jrg Sommer <joerg@alea.gnuu.de> wrote:

Yay.


Uh, that's a bug in fast-import.  ":4abc" is _not_ a mark if you
read the language specification.  Only ":4" is a mark.  So we are
accepting crap and reading it in odd ways.  Not good.

-- 
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/4] Move redo merge code in a function, Jörg Sommer, (Sun Mar 23, 2:42 pm)
[PATCH 2/4] Rework redo_merge, Jörg Sommer, (Sun Mar 23, 2:42 pm)
[PATCH 3/4] Add a function for get the parents of a commit, Jörg Sommer, (Sun Mar 23, 2:42 pm)
[PATCH 4/4] git-rebase -i: New option to support rebase wi ..., Jörg Sommer, (Sun Mar 23, 2:42 pm)
Re: [PATCH 1/4] Move redo merge code in a function, Johannes Schindelin, (Sun Mar 23, 3:26 pm)
Re: [PATCH 2/4] Rework redo_merge, Johannes Schindelin, (Sun Mar 23, 3:29 pm)
Re: [PATCH 3/4] Add a function for get the parents of a commit, Johannes Schindelin, (Sun Mar 23, 3:33 pm)
Re: [PATCH 4/4] git-rebase -i: New option to support rebas ..., Johannes Schindelin, (Sun Mar 23, 3:41 pm)
Re: [PATCH 4/4] git-rebase -i: New option to support rebas ..., Jörg, (Mon Mar 24, 4:14 am)
Re: [PATCH 4/4] git-rebase -i: New option to support rebas ..., Johannes Schindelin, (Mon Mar 24, 6:08 am)
Re: [PATCH 4/4] git-rebase -i: New option to support rebas ..., Junio C Hamano, (Mon Mar 24, 11:35 am)
Re: [PATCH 4/4] git-rebase -i: New option to support rebas ..., Junio C Hamano, (Mon Mar 24, 4:30 pm)
Re: [PATCH 4/4] git-rebase -i: New option to support rebas ..., Jörg, (Mon Mar 24, 4:40 pm)
Re: [PATCH 4/4] git-rebase -i: New option to support rebas ..., Jörg, (Tue Mar 25, 3:13 am)
Teach rebase interactive more commands to do better preser ..., Jörg Sommer, (Wed Apr 9, 4:58 pm)
[PATCH/RFC 01/10] Teach rebase interactive the mark command, Jörg Sommer, (Wed Apr 9, 4:58 pm)
[PATCH/RFC 02/10] Teach rebase interactive the reset command, Jörg Sommer, (Wed Apr 9, 4:58 pm)
[PATCH/RFC 03/10] Teach rebase interactive the merge command, Jörg Sommer, (Wed Apr 9, 4:58 pm)
[PATCH/RFC 04/10] Move redo merge code in a function, Jörg Sommer, (Wed Apr 9, 4:58 pm)
[PATCH/RFC 05/10] Rework redo_merge, Jörg Sommer, (Wed Apr 9, 4:58 pm)
[PATCH/RFC 06/10] Unify the lenght of $SHORT* and the comm ..., Jörg Sommer, (Wed Apr 9, 4:58 pm)
[PATCH/RFC 07/10] fake-editor: output TODO list if unchanged, Jörg Sommer, (Wed Apr 9, 4:58 pm)
[PATCH/RFC 08/10] Don't append default merge message to -m ..., Jörg Sommer, (Wed Apr 9, 4:58 pm)
[PATCH/RFC 09/10] Select all lines with fake-editor, Jörg Sommer, (Wed Apr 9, 4:58 pm)
[PATCH/RFC 10/10] Do rebase with preserve merges with adva ..., Jörg Sommer, (Wed Apr 9, 4:58 pm)
Re: [PATCH/RFC 01/10] Teach rebase interactive the mark co ..., Mike Ralphson, (Thu Apr 10, 2:33 am)
Re: [PATCH/RFC 01/10] Teach rebase interactive the mark co ..., Junio C Hamano, (Fri Apr 11, 4:48 pm)
Re: [PATCH/RFC 02/10] Teach rebase interactive the reset c ..., Junio C Hamano, (Fri Apr 11, 4:56 pm)
Re: [PATCH/RFC 06/10] Unify the lenght of $SHORT* and the ..., Junio C Hamano, (Fri Apr 11, 5:00 pm)
Re: [PATCH/RFC 06/10] Unify the lenght of $SHORT* and the ..., Jörg, (Sat Apr 12, 2:13 am)
Re: [PATCH/RFC 02/10] Teach rebase interactive the reset c ..., Jörg, (Sat Apr 12, 2:37 am)
Re: [PATCH/RFC 01/10] Teach rebase interactive the mark co ..., Jörg, (Sat Apr 12, 3:11 am)
Re: [PATCH/RFC 01/10] Teach rebase interactive the mark co ..., Jörg, (Sat Apr 12, 3:17 am)
Re: [PATCH/RFC 01/10] Teach rebase interactive the mark co ..., Shawn O. Pearce, (Sat Apr 12, 8:56 pm)
Re: [PATCH/RFC 01/10] Teach rebase interactive the mark co ..., Jörg, (Sun Apr 13, 9:50 am)
[PATCH v2 01/13] fake-editor: output TODO list if unchanged, Jörg Sommer, (Sun Apr 13, 5:20 pm)
[PATCH v2 02/13] Don't append default merge message to -m ..., Jörg Sommer, (Sun Apr 13, 5:20 pm)
[PATCH v2 03/13] Move cleanup code into it's own function, Jörg Sommer, (Sun Apr 13, 5:20 pm)
[PATCH v2 04/13] Teach rebase interactive the mark command, Jörg Sommer, (Sun Apr 13, 5:21 pm)
[PATCH v2 05/13] Teach rebase interactive the reset command, Jörg Sommer, (Sun Apr 13, 5:21 pm)
[PATCH v2 06/13] Move redo merge code in a function, Jörg Sommer, (Sun Apr 13, 5:21 pm)
[PATCH v2 07/13] Teach rebase interactive the merge command, Jörg Sommer, (Sun Apr 13, 5:21 pm)
[PATCH v2 08/13] Unify the lenght of $SHORT* and the commi ..., Jörg Sommer, (Sun Apr 13, 5:21 pm)
[PATCH v2 09/13] Select all lines with fake-editor, Jörg Sommer, (Sun Apr 13, 5:21 pm)
[PATCH v2 10/13] Do rebase with preserve merges with advan ..., Jörg Sommer, (Sun Apr 13, 5:21 pm)
[PATCH v2 11/13] Add option --first-parent, Jörg Sommer, (Sun Apr 13, 5:21 pm)
[PATCH v2 12/13] Teach rebase interactive the tag command, Jörg Sommer, (Sun Apr 13, 5:21 pm)
[PATCH v2 13/13] Add option --preserve-tags, Jörg Sommer, (Sun Apr 13, 5:21 pm)
Re: [PATCH/RFC 01/10] Teach rebase interactive the mark co ..., Shawn O. Pearce, (Sun Apr 13, 11:24 pm)
Re: [PATCH/RFC 01/10] Teach rebase interactive the mark co ..., Junio C Hamano, (Sun Apr 13, 11:54 pm)
Re: [PATCH/RFC 01/10] Teach rebase interactive the mark co ..., Jörg, (Mon Apr 14, 3:06 am)
[PATCH v2.1] Teach rebase interactive the mark command, Jörg Sommer, (Mon Apr 14, 3:39 am)
Re: [PATCH v2.1] Teach rebase interactive the mark command, Shawn O. Pearce, (Mon Apr 14, 4:29 pm)
Re: [PATCH v2 02/13] Don't append default merge message to ..., Junio C Hamano, (Sun Apr 20, 9:52 am)
mark parsing in fast-import, Jörg, (Sun Apr 20, 4:44 pm)
Re: [PATCH v2 02/13] Don't append default merge message to ..., Jörg, (Sun Apr 20, 5:17 pm)
Re: mark parsing in fast-import, Shawn O. Pearce, (Sun Apr 20, 5:26 pm)
Re: mark parsing in fast-import, Jörg, (Mon Apr 21, 1:41 am)
Re: mark parsing in fast-import, Shawn O. Pearce, (Mon Apr 21, 4:59 pm)
Re: [PATCH v2 02/13] Don't append default merge message to ..., Junio C Hamano, (Mon Apr 21, 10:27 pm)
Re: [PATCH v2 04/13] Teach rebase interactive the mark command, Junio C Hamano, (Mon Apr 21, 10:32 pm)
Re: [PATCH v2 04/13] Teach rebase interactive the mark command, Junio C Hamano, (Tue Apr 22, 1:13 am)
Re: [PATCH v2 04/13] Teach rebase interactive the mark command, Johannes Schindelin, (Tue Apr 22, 1:52 am)
Re: mark parsing in fast-import, Jörg, (Tue Apr 22, 2:39 am)
Re: [PATCH v2 04/13] Teach rebase interactive the mark command, Jörg, (Tue Apr 22, 2:55 am)
Re: [PATCH v2 04/13] Teach rebase interactive the mark command, Johannes Schindelin, (Tue Apr 22, 3:31 am)
Re: [PATCH v2 04/13] Teach rebase interactive the mark command, Junio C Hamano, (Tue Apr 22, 11:04 am)
Re: mark parsing in fast-import, Shawn O. Pearce, (Tue Apr 22, 4:15 pm)
[PATCH v2] Make mark parsing much more restrictive, Jörg Sommer, (Fri Apr 25, 2:04 am)
Re: [PATCH v2 04/13] Teach rebase interactive the mark command, Jörg, (Fri Apr 25, 2:11 am)
[PATCH v2.2] Teach rebase interactive the mark command, Jörg Sommer, (Fri Apr 25, 2:44 am)
Re: [PATCH v2.2] Teach rebase interactive the mark command, Junio C Hamano, (Sat Apr 26, 11:13 pm)
Re: [PATCH v2.2] Teach rebase interactive the mark command, Jörg, (Sun Apr 27, 1:28 am)