Hi Jakub,

OK, I'll look deeper into the mailer issues. Any comments on the  
actual code in the patch, and the question regarding git-log vs git- 
cat-file?

Speaking of which -- is there any particular reason for not running  
git-log once, instead of forking it (or git-cat-file) for every commit  
in the log? There seems to be a special case for merges, but it'd  
appear to be more efficient to query the SQLite DB for the commits  
provided by git-log rather than the other way around, no?

Any thoughts?

(git-send-email appears to fail for me without providing an error.)

Many thanks,
Fredrik

13 apr 2008 kl. 18.59 skrev Jakub Narebski:
quoted text
> Fredrik Noring <noring@nocrew.org> writes:
>
>> (My mailer destroys inline patches, so I'm attaching it. Sorry about
>> that.)
>
> Could you please attach it as 1.) attachement=inline if possible, to
> have them displayed along the email; 2.) use text/plain mimetype, not
> application/octet-stream (you might need to change patch extension
> from *.patch to *.txt; you can change default extension of files
> generated by git-format-patch via format.suffix configuration
> variable), and what is tied with it 3.) use Transfer-Encoding: 8bit
> (or something like that), not base64, and preferably not
> quoted-printable?
>
> Or change your mailer (or configure it), or use git-send-email.
> -- 
> Jakub Narebski
> Poland
> ShadeHawk on #git
>

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html