[PATCH] Default to fetching a remote after adding it.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Gabriel
Date: Friday, April 11, 2008 - 12:29 pm

This is what the user wants in 99% of cases.

Signed-off-by: Gabriel <g2p.code@gmail.com>
---

Also update some tests; disregard the previous patch.

 Documentation/git-remote.txt |    4 ++--
 builtin-remote.c             |    2 +-
 t/t5503-tagfollow.sh         |    2 +-
 t/t5512-ls-remote.sh         |    2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt
index 2cbd1f7..04de972 100644
--- a/Documentation/git-remote.txt
+++ b/Documentation/git-remote.txt
@@ -10,7 +10,7 @@ SYNOPSIS
 --------
 [verse]
 'git-remote'
-'git-remote' add [-t <branch>] [-m <master>] [-f] [--mirror] <name> <url>
+'git-remote' add [-t <branch>] [-m <master>] [--no-fetch] [--mirror] <name> <url>
 'git-remote' rm <name>
 'git-remote' show <name>
 'git-remote' prune <name>
@@ -34,7 +34,7 @@ Adds a remote named <name> for the repository at
 <url>.  The command `git fetch <name>` can then be used to create and
 update remote-tracking branches <name>/<branch>.
 +
-With `-f` option, `git fetch <name>` is run immediately after
+Without the `--no-fetch` option, `git fetch <name>` is run immediately after
 the remote information is set up.
 +
 With `-t <branch>` option, instead of the default glob
diff --git a/builtin-remote.c b/builtin-remote.c
index 044215a..c0d7d96 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -54,7 +54,7 @@ static int fetch_remote(const char *name)
 
 static int add(int argc, const char **argv)
 {
-	int fetch = 0, mirror = 0;
+	int fetch = 1, mirror = 0;
 	struct path_list track = { NULL, 0, 0 };
 	const char *master = NULL;
 	struct remote *remote;
diff --git a/t/t5503-tagfollow.sh b/t/t5503-tagfollow.sh
index 86e5b9b..fd075d9 100755
--- a/t/t5503-tagfollow.sh
+++ b/t/t5503-tagfollow.sh
@@ -134,7 +134,7 @@ test_expect_success 'new clone fetch master and tags' '
 		mkdir clone2 &&
 		cd clone2 &&
 		git init &&
-		git remote add origin .. &&
+		git remote add origin .. --no-fetch &&
 		GIT_DEBUG_SEND_PACK=3 git fetch 3>../$U &&
 		test $B = $(git rev-parse --verify origin/master) &&
 		test $S = $(git rev-parse --verify tag2) &&
diff --git a/t/t5512-ls-remote.sh b/t/t5512-ls-remote.sh
index c0dc949..08855ed 100755
--- a/t/t5512-ls-remote.sh
+++ b/t/t5512-ls-remote.sh
@@ -17,7 +17,7 @@ test_expect_success setup '
 		git show-ref -d	| sed -e "s/ /	/"
 	) >expected.all &&
 
-	git remote add self $(pwd)/.git
+	git remote add self $(pwd)/.git --no-fetch
 
 '
 
-- 
1.5.5.25.g9415

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
git annoyances, Ingo Molnar, (Wed Apr 9, 3:14 am)
Re: git annoyances, Björn, (Wed Apr 9, 3:41 am)
Re: git annoyances, Jeff King, (Wed Apr 9, 7:57 am)
Re: git annoyances, Avery Pennarun, (Wed Apr 9, 10:08 am)
Re: git annoyances, Daniel Barkalow, (Wed Apr 9, 12:21 pm)
Friendly refspecs (Was: Re: git annoyances), Teemu Likonen, (Wed Apr 9, 1:08 pm)
Re: Friendly refspecs (Was: Re: git annoyances), Avery Pennarun, (Wed Apr 9, 1:32 pm)
Re: Friendly refspecs (Was: Re: git annoyances), Jeff King, (Wed Apr 9, 1:34 pm)
Re: git annoyances, Ingo Molnar, (Wed Apr 9, 1:41 pm)
Re: git annoyances, Junio C Hamano, (Wed Apr 9, 2:04 pm)
Re: Friendly refspecs, Junio C Hamano, (Wed Apr 9, 2:21 pm)
Re: git annoyances, Jon Loeliger, (Wed Apr 9, 2:39 pm)
Re: git annoyances, Jeff King, (Wed Apr 9, 2:45 pm)
Re: Friendly refspecs (Was: Re: git annoyances), Teemu Likonen, (Wed Apr 9, 3:25 pm)
Re: Friendly refspecs (Was: Re: git annoyances), Jeff King, (Wed Apr 9, 3:51 pm)
Re: git annoyances, Nicolas Pitre, (Wed Apr 9, 4:45 pm)
Re: git annoyances, André Goddard Rosa, (Wed Apr 9, 4:56 pm)
Re: Friendly refspecs (Was: Re: git annoyances), Jeff King, (Wed Apr 9, 5:03 pm)
Re: Friendly refspecs (Was: Re: git annoyances), Jeff King, (Wed Apr 9, 5:11 pm)
Re: git annoyances, Jean-Christian de Rivaz, (Wed Apr 9, 11:08 pm)
Re: Friendly refspecs, Teemu Likonen, (Thu Apr 10, 12:38 am)
Re: Friendly refspecs, Junio C Hamano, (Thu Apr 10, 12:51 am)
Re: Friendly refspecs, Jeff King, (Thu Apr 10, 1:03 am)
Re: git annoyances, Sverre Rabbelier, (Thu Apr 10, 1:19 am)
Re: git annoyances, Karl , (Thu Apr 10, 1:41 am)
git-bisect annoyances, Ingo Molnar, (Thu Apr 10, 4:47 am)
Re: git annoyances, Daniel Barkalow, (Thu Apr 10, 7:08 am)
Re: git annoyances, Avery Pennarun, (Thu Apr 10, 8:05 am)
Re: git annoyances, Govind Salinas, (Thu Apr 10, 12:45 pm)
Re: git-bisect annoyances, Christian Couder, (Thu Apr 10, 10:41 pm)
Re: git-bisect annoyances, Junio C Hamano, (Thu Apr 10, 10:56 pm)
Re: git annoyances, Karl , (Fri Apr 11, 12:00 am)
Re: git annoyances, Luciano Rocha, (Fri Apr 11, 3:15 am)
Re: git annoyances, Wincent Colaiuta, (Fri Apr 11, 3:27 am)
Re: git-bisect annoyances, Ingo Molnar, (Fri Apr 11, 4:41 am)
Re: [PATCH] When a remote is added but not fetched, tell t ..., Johannes Schindelin, (Fri Apr 11, 8:21 am)
Re: [PATCH] Default to fetching a remote after adding it., Stephen Sinclair, (Fri Apr 11, 12:17 pm)
[PATCH] Default to fetching a remote after adding it., Gabriel, (Fri Apr 11, 12:29 pm)
Re: [PATCH] Default to fetching a remote after adding it., Wincent Colaiuta, (Fri Apr 11, 12:36 pm)
Re: git-bisect annoyances, Christian Couder, (Fri Apr 11, 11:56 pm)
Re: [PATCH] Default to fetching a remote after adding it., Johannes Schindelin, (Sat Apr 12, 7:33 am)
Re: [PATCH] Default to fetching a remote after adding it., Johannes Schindelin, (Sat Apr 12, 8:24 am)
Re: Friendly refspecs, Teemu Likonen, (Sun Apr 13, 2:31 am)
[PATCH] Add examples section to 'git fetch' manual, Teemu Likonen, (Sun Apr 13, 2:34 am)
Re: [PATCH] Add examples section to 'git fetch' manual, Junio C Hamano, (Sun Apr 13, 11:56 am)
Re: [PATCH] Add examples section to 'git fetch' manual, Matt Graham, (Sun Apr 13, 12:48 pm)
Re: [PATCH] Add examples section to 'git fetch' manual, Teemu Likonen, (Sun Apr 13, 1:05 pm)
Re: [PATCH] Add examples section to 'git fetch' manual, Junio C Hamano, (Sun Apr 13, 6:02 pm)
Re: Friendly refspecs, Jeff King, (Tue Apr 15, 8:48 pm)
Re: Friendly refspecs, Jeff King, (Tue Apr 15, 9:25 pm)
Re: Friendly refspecs, Junio C Hamano, (Tue Apr 15, 9:41 pm)
Re: Friendly refspecs, Jeff King, (Tue Apr 15, 9:47 pm)
Re: Friendly refspecs, Daniel Barkalow, (Wed Apr 16, 8:42 am)