[PATCH] When a remote is added but not fetched, tell the user.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Gabriel
Date: Thursday, April 10, 2008 - 4:25 pm

A helpful message tells the user when a remote was added
without being fetched, and how to fetch it.

Our default of not fetching is breaking the users' workflow
in the common "let me access this repo" use case.
This message alleviates the problem.

Signed-off-by: Gabriel <g2p.code@gmail.com>
---
 builtin-remote.c |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/builtin-remote.c b/builtin-remote.c
index d77f10a..044215a 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -111,8 +111,16 @@ static int add(int argc, const char **argv)
 			return 1;
 	}
 
-	if (fetch && fetch_remote(name))
-		return 1;
+	if (fetch) {
+		if (fetch_remote(name))
+			return 1;
+	}
+	else {
+		printf ("Added remote repository `%s' without fetching it.\n"
+			"Before accessing the branches of this "
+			"remote, run `git fetch %s' "
+			"or `git remote update'.\n", name, name);
+	}
 
 	if (master) {
 		strbuf_reset(&buf);
-- 
1.5.5.24.geb27

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
git annoyances, Ingo Molnar, (Wed Apr 9, 3:14 am)
Re: git annoyances, Björn, (Wed Apr 9, 3:41 am)
Re: git annoyances, Jeff King, (Wed Apr 9, 7:57 am)
Re: git annoyances, Avery Pennarun, (Wed Apr 9, 10:08 am)
Re: git annoyances, Daniel Barkalow, (Wed Apr 9, 12:21 pm)
Friendly refspecs (Was: Re: git annoyances), Teemu Likonen, (Wed Apr 9, 1:08 pm)
Re: Friendly refspecs (Was: Re: git annoyances), Avery Pennarun, (Wed Apr 9, 1:32 pm)
Re: Friendly refspecs (Was: Re: git annoyances), Jeff King, (Wed Apr 9, 1:34 pm)
Re: git annoyances, Ingo Molnar, (Wed Apr 9, 1:41 pm)
Re: git annoyances, Junio C Hamano, (Wed Apr 9, 2:04 pm)
Re: Friendly refspecs, Junio C Hamano, (Wed Apr 9, 2:21 pm)
Re: git annoyances, Jon Loeliger, (Wed Apr 9, 2:39 pm)
Re: git annoyances, Jeff King, (Wed Apr 9, 2:45 pm)
Re: Friendly refspecs (Was: Re: git annoyances), Teemu Likonen, (Wed Apr 9, 3:25 pm)
Re: Friendly refspecs (Was: Re: git annoyances), Jeff King, (Wed Apr 9, 3:51 pm)
Re: git annoyances, Nicolas Pitre, (Wed Apr 9, 4:45 pm)
Re: git annoyances, André Goddard Rosa, (Wed Apr 9, 4:56 pm)
Re: Friendly refspecs (Was: Re: git annoyances), Jeff King, (Wed Apr 9, 5:03 pm)
Re: Friendly refspecs (Was: Re: git annoyances), Jeff King, (Wed Apr 9, 5:11 pm)
Re: git annoyances, Jean-Christian de Rivaz, (Wed Apr 9, 11:08 pm)
Re: Friendly refspecs, Teemu Likonen, (Thu Apr 10, 12:38 am)
Re: Friendly refspecs, Junio C Hamano, (Thu Apr 10, 12:51 am)
Re: Friendly refspecs, Jeff King, (Thu Apr 10, 1:03 am)
Re: git annoyances, Sverre Rabbelier, (Thu Apr 10, 1:19 am)
Re: git annoyances, Karl , (Thu Apr 10, 1:41 am)
git-bisect annoyances, Ingo Molnar, (Thu Apr 10, 4:47 am)
Re: git annoyances, Daniel Barkalow, (Thu Apr 10, 7:08 am)
Re: git annoyances, Avery Pennarun, (Thu Apr 10, 8:05 am)
Re: git annoyances, Govind Salinas, (Thu Apr 10, 12:45 pm)
[PATCH] When a remote is added but not fetched, tell the user., Gabriel, (Thu Apr 10, 4:25 pm)
Re: git-bisect annoyances, Christian Couder, (Thu Apr 10, 10:41 pm)
Re: git-bisect annoyances, Junio C Hamano, (Thu Apr 10, 10:56 pm)
Re: git annoyances, Karl , (Fri Apr 11, 12:00 am)
Re: git annoyances, Luciano Rocha, (Fri Apr 11, 3:15 am)
Re: git annoyances, Wincent Colaiuta, (Fri Apr 11, 3:27 am)
Re: git-bisect annoyances, Ingo Molnar, (Fri Apr 11, 4:41 am)
Re: [PATCH] When a remote is added but not fetched, tell t ..., Johannes Schindelin, (Fri Apr 11, 8:21 am)
Re: [PATCH] Default to fetching a remote after adding it., Stephen Sinclair, (Fri Apr 11, 12:17 pm)
Re: [PATCH] Default to fetching a remote after adding it., Wincent Colaiuta, (Fri Apr 11, 12:36 pm)
Re: git-bisect annoyances, Christian Couder, (Fri Apr 11, 11:56 pm)
Re: [PATCH] Default to fetching a remote after adding it., Johannes Schindelin, (Sat Apr 12, 7:33 am)
Re: [PATCH] Default to fetching a remote after adding it., Johannes Schindelin, (Sat Apr 12, 8:24 am)
Re: Friendly refspecs, Teemu Likonen, (Sun Apr 13, 2:31 am)
[PATCH] Add examples section to 'git fetch' manual, Teemu Likonen, (Sun Apr 13, 2:34 am)
Re: [PATCH] Add examples section to 'git fetch' manual, Junio C Hamano, (Sun Apr 13, 11:56 am)
Re: [PATCH] Add examples section to 'git fetch' manual, Matt Graham, (Sun Apr 13, 12:48 pm)
Re: [PATCH] Add examples section to 'git fetch' manual, Teemu Likonen, (Sun Apr 13, 1:05 pm)
Re: [PATCH] Add examples section to 'git fetch' manual, Junio C Hamano, (Sun Apr 13, 6:02 pm)
Re: Friendly refspecs, Jeff King, (Tue Apr 15, 8:48 pm)
Re: Friendly refspecs, Jeff King, (Tue Apr 15, 9:25 pm)
Re: Friendly refspecs, Junio C Hamano, (Tue Apr 15, 9:41 pm)
Re: Friendly refspecs, Jeff King, (Tue Apr 15, 9:47 pm)
Re: Friendly refspecs, Daniel Barkalow, (Wed Apr 16, 8:42 am)