Re: [PATCH 1/2] Add strbuf_initf()

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Mike Hommey

Subject: Re: [PATCH 1/2] Add strbuf_initf()

Date: Thursday, March 6, 2008 - 12:10 pm

On Thu, Mar 06, 2008 at 07:26:50PM +0100, Johannes Schindelin wrote:
quoted text> Hi,
> 
> On Thu, 6 Mar 2008, Kristian Høgsberg wrote:
> 
> > On Thu, 2008-03-06 at 11:55 +0100, Johannes Schindelin wrote:
> >
> > > So your suggestion is out, unless you suggest to implement the whole 
> > > printf mechanism... which I hope you're not.
> > 
> > It's not a terrible idea, honestly.
> 
> Heh.  Yeah, I actually posted a start...
> 
> > There are several mature vsnprintf implementations out there under 
> > friendly licenses.  We could just stick it in compat/.  It's the only 
> > way to do reliable, cross platform vsnprintf, in my experience.  And the 
> > issue with %I64u vs %llu could be handle by implementing both, as Wayne 
> > Davison suggests.
> 
> Sure, we could always copy from somewhere else.  My rationale was that I 
> had fun writing it, and that we do not really need a full printf() 
> implementation.

And vsnprintf is a mess accross systems, returning -1 when not expected.
I even had the surprise to get an interesting bug in liferea/libxml2 due
to glibc's vsnprintf returning -1 in some obscure cases.

Mike
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/40] MinGW port, Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 01/40] Add compat/regex.[ch] and compat/fnmatch.[ch]., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 02/40] Compile some programs only conditionally., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 04/40] Windows: Use the Windows style PATH separato ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 05/40] Windows: Strip ".exe" from the program name., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 06/40] Windows: Implement a wrapper of the open() f ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 07/40] Windows: A minimal implemention of getpwuid()., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 08/40] Windows: always chmod(, 0666) before unlink()., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 09/40] Windows: Work around misbehaved rename()., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 10/40] Windows: Treat Windows style path names., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 11/40] Windows: Handle absolute paths in safe_creat ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 12/40] Windows: Implement gettimeofday()., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 13/40] Windows: Fix PRIuMAX definition., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 14/40] Windows: Implement setitimer() and sigaction()., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 15/40] Windows: A work-around for a misbehaved vsnp ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 16/40] Windows: Wrap execve so that shell scripts c ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 17/40] Windows: A pipe() replacement whose ends are ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 18/40] Windows: Implement start_command()., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 19/40] Windows: Change the name of hook scripts to ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 20/40] Windows: A rudimentary poll() emulation., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 21/40] Windows: Disambiguate DOS style paths from S ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 22/40] Windows: Implement asynchronous functions as ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 23/40] Windows: Local clone must use the drive lett ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 24/40] Windows: Work around incompatible sort and find., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 25/40] Windows: Implement a cpio emulation in git-c ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 26/40] Windows: Implement wrappers for gethostbynam ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 27/40] Windows: Implement a custom spawnve()., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 28/40] Windows: Add a new lstat and fstat implement ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 29/40] Windows: Use a customized struct stat that a ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 30/40] Turn builtin_exec_path into a function., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 31/40] Compute the ultimate fallback for exec_path ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 32/40] Windows: Use a relative default template_dir ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 33/40] When installing, be prepared that template_d ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 34/40] Windows: Make the pager work., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 35/40] Windows: Work around an oddity when a pipe w ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 36/40] Avoid the "dup dance" in wt_status_print_ver ..., Johannes Sixt, (Wed Feb 27, 11:54 am)

[PATCH 37/40] Windows: Make 'git help -a' work., Johannes Sixt, (Wed Feb 27, 11:55 am)

[PATCH 38/40] Windows: TMP and TEMP environment variables ..., Johannes Sixt, (Wed Feb 27, 11:55 am)

[PATCH 39/40] Windows: Fix ntohl() related warnings about ..., Johannes Sixt, (Wed Feb 27, 11:55 am)

[PATCH 40/40] compat/pread.c: Add foward decl to fix warning, Johannes Sixt, (Wed Feb 27, 11:55 am)

Re: [PATCH 00/40] MinGW port, Marius Storm-Olsen, (Wed Feb 27, 3:01 pm)

Re: [PATCH 00/40] MinGW port, Martin Langhoff, (Wed Feb 27, 4:34 pm)

Re: [PATCH 01/40] Add compat/regex.[ch] and compat/fnmatch ..., Johannes Schindelin, (Wed Feb 27, 4:43 pm)

Re: [PATCH 00/40] MinGW port, Johannes Schindelin, (Wed Feb 27, 4:58 pm)

Re: [PATCH 00/40] MinGW port, Nguyen Thai Ngoc Duy, (Wed Feb 27, 8:38 pm)

Re: [PATCH 04/40] Windows: Use the Windows style PATH sepa ..., Paolo Bonzini, (Thu Feb 28, 2:25 am)

Re: [PATCH 20/40] Windows: A rudimentary poll() emulation., Paolo Bonzini, (Thu Feb 28, 2:36 am)

Re: [PATCH 33/40] When installing, be prepared that templa ..., Paolo Bonzini, (Thu Feb 28, 2:49 am)

Re: [PATCH 37/40] Windows: Make 'git help -a' work., Paolo Bonzini, (Thu Feb 28, 2:52 am)

Re: [PATCH 02/40] Compile some programs only conditionally., Johannes Schindelin, (Thu Feb 28, 4:57 am)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Thu Feb 28, 5:05 am)

Re: [PATCH 08/40] Windows: always chmod(, 0666) before unl ..., Johannes Schindelin, (Thu Feb 28, 5:09 am)

Re: [PATCH 10/40] Windows: Treat Windows style path names., Johannes Schindelin, (Thu Feb 28, 5:18 am)

Re: [PATCH 13/40] Windows: Fix PRIuMAX definition., Johannes Schindelin, (Thu Feb 28, 5:21 am)

Re: [PATCH 03/40] Add target architecture MinGW., Paolo Bonzini, (Thu Feb 28, 5:57 am)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Thu Feb 28, 7:56 am)

Re: [PATCH 19/40] Windows: Change the name of hook scripts ..., Johannes Schindelin, (Thu Feb 28, 8:20 am)

Re: [PATCH 21/40] Windows: Disambiguate DOS style paths fr ..., Johannes Schindelin, (Thu Feb 28, 8:22 am)

Re: [PATCH 22/40] Windows: Implement asynchronous function ..., Johannes Schindelin, (Thu Feb 28, 8:28 am)

Re: [PATCH 23/40] Windows: Local clone must use the drive ..., Johannes Schindelin, (Thu Feb 28, 8:31 am)

Re: [PATCH 27/40] Windows: Implement a custom spawnve()., Johannes Schindelin, (Thu Feb 28, 8:36 am)

Re: [PATCH 33/40] When installing, be prepared that templa ..., Johannes Schindelin, (Thu Feb 28, 8:45 am)

Re: [PATCH 36/40] Avoid the "dup dance" in wt_status_print ..., Johannes Schindelin, (Thu Feb 28, 8:48 am)

Re: [PATCH 40/40] compat/pread.c: Add foward decl to fix w ..., Johannes Schindelin, (Thu Feb 28, 8:51 am)

Re: [PATCH 33/40] When installing, be prepared that templa ..., Paolo Bonzini, (Thu Feb 28, 8:57 am)

Re: [PATCH 22/40] Windows: Implement asynchronous function ..., Paul Franz, (Thu Feb 28, 10:48 am)

Re: [PATCH 02/40] Compile some programs only conditionally., Johannes Sixt, (Thu Feb 28, 1:30 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Thu Feb 28, 1:40 pm)

Re: [PATCH 04/40] Windows: Use the Windows style PATH sepa ..., Johannes Sixt, (Thu Feb 28, 1:43 pm)

Re: [PATCH 13/40] Windows: Fix PRIuMAX definition., Johannes Sixt, (Thu Feb 28, 1:45 pm)

Re: [PATCH 19/40] Windows: Change the name of hook scripts ..., Johannes Sixt, (Thu Feb 28, 1:48 pm)

Re: [PATCH 20/40] Windows: A rudimentary poll() emulation., Johannes Sixt, (Thu Feb 28, 1:49 pm)

Re: [PATCH 21/40] Windows: Disambiguate DOS style paths fr ..., Johannes Sixt, (Thu Feb 28, 1:51 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous function ..., Johannes Sixt, (Thu Feb 28, 2:01 pm)

Re: [PATCH 27/40] Windows: Implement a custom spawnve()., Johannes Sixt, (Thu Feb 28, 2:04 pm)

Re: [PATCH 33/40] When installing, be prepared that templa ..., Johannes Sixt, (Thu Feb 28, 2:12 pm)

Re: [PATCH 02/40] Compile some programs only conditionally., Johannes Schindelin, (Thu Feb 28, 5:47 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Thu Feb 28, 6:07 pm)

Re: [PATCH 04/40] Windows: Use the Windows style PATH sepa ..., Johannes Schindelin, (Thu Feb 28, 6:09 pm)

Re: [PATCH 19/40] Windows: Change the name of hook scripts ..., Johannes Schindelin, (Thu Feb 28, 6:11 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous function ..., Johannes Schindelin, (Thu Feb 28, 6:17 pm)

Re: [PATCH 27/40] Windows: Implement a custom spawnve()., Johannes Schindelin, (Thu Feb 28, 6:18 pm)

Re: [PATCH 33/40] When installing, be prepared that templa ..., Johannes Schindelin, (Thu Feb 28, 6:21 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous function ..., Johannes Schindelin, (Thu Feb 28, 6:27 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous function ..., Paul Franz, (Thu Feb 28, 6:46 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous function ..., Johannes Schindelin, (Thu Feb 28, 6:54 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous function ..., Paul Franz, (Thu Feb 28, 8:08 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous function ..., Junio C Hamano, (Fri Feb 29, 12:51 am)

Re: [PATCH 04/40] Windows: Use the Windows style PATH sepa ..., Paolo Bonzini, (Fri Feb 29, 12:57 am)

Re: [PATCH 22/40] Windows: Implement asynchronous function ..., Johannes Schindelin, (Fri Feb 29, 3:26 am)

Re: [PATCH 22/40] Windows: Implement asynchronous function ..., Paul Franz, (Fri Feb 29, 4:45 am)

Re: [PATCH 04/40] Windows: Use the Windows style PATH sepa ..., Johannes Schindelin, (Fri Feb 29, 5:19 am)

Re: [PATCH 04/40] Windows: Use the Windows style PATH sepa ..., Paolo Bonzini, (Fri Feb 29, 5:45 am)

Re: [PATCH 04/40] Windows: Use the Windows style PATH sepa ..., Johannes Schindelin, (Fri Feb 29, 5:59 am)

Re: [PATCH 02/40] Compile some programs only conditionally., Johannes Sixt, (Fri Feb 29, 1:58 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Fri Feb 29, 2:03 pm)

Re: [PATCH 02/40] Compile some programs only conditionally., Johannes Schindelin, (Fri Feb 29, 2:53 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Fri Feb 29, 2:54 pm)

Re: [PATCH 20/40] Windows: A rudimentary poll() emulation., Robin Rosenberg, (Sat Mar 1, 8:48 am)

Re: [PATCH 20/40] Windows: A rudimentary poll() emulation., Johannes Sixt, (Sat Mar 1, 12:24 pm)

Re: [PATCH 00/40] MinGW port, Johannes Sixt, (Sun Mar 2, 2:20 pm)

Re: [PATCH 00/40] MinGW port, Johannes Schindelin, (Sun Mar 2, 3:07 pm)

Re: [PATCH 00/40] MinGW port, Johannes Sixt, (Mon Mar 3, 11:34 am)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Wed Mar 5, 2:21 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Wed Mar 5, 3:18 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Junio C Hamano, (Wed Mar 5, 3:22 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Wed Mar 5, 3:28 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Junio C Hamano, (Wed Mar 5, 3:51 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Wed Mar 5, 5:11 pm)

[PATCH 1/2] Add strbuf_initf(), Johannes Schindelin, (Wed Mar 5, 6:14 pm)

[PATCH 2/2] format-patch: add --reviewed-by=<ident>, Johannes Schindelin, (Wed Mar 5, 6:15 pm)

Re: [PATCH 2/2] format-patch: add --reviewed-by=<ident>, Junio C Hamano, (Wed Mar 5, 7:40 pm)

Re: [PATCH 1/2] Add strbuf_initf(), Mike Hommey, (Wed Mar 5, 11:33 pm)

Re: [PATCH 1/2] Add strbuf_initf(), Reece Dunn, (Thu Mar 6, 2:03 am)

Re: [PATCH 2/2] format-patch: add --reviewed-by=<ident>, Johannes Schindelin, (Thu Mar 6, 3:40 am)

Re: [PATCH 1/2] Add strbuf_initf(), Johannes Schindelin, (Thu Mar 6, 3:53 am)

Re: [PATCH 1/2] Add strbuf_initf(), Johannes Schindelin, (Thu Mar 6, 3:55 am)

Re: [PATCH 1/2] Add strbuf_initf(), Reece Dunn, (Thu Mar 6, 4:53 am)

Re: [PATCH 1/2] Add strbuf_initf(), Jeff King, (Thu Mar 6, 5:09 am)

Re: [PATCH 1/2] Add strbuf_initf(), Johannes Schindelin, (Thu Mar 6, 5:52 am)

[PATCH 1/2 v2] Add strbuf_vaddf(), use it in strbuf_addf() ..., Johannes Schindelin, (Thu Mar 6, 9:29 am)

Re: [PATCH 1/2 v2] Add strbuf_vaddf(), use it in strbuf_ad ..., Johannes Sixt, (Thu Mar 6, 9:38 am)

Re: [PATCH 1/2 v2] Add strbuf_vaddf(), use it in strbuf_ad ..., Johannes Sixt, (Thu Mar 6, 9:47 am)

Re: [PATCH 1/2 v2] Add strbuf_vaddf(), use it in strbuf_ad ..., Johannes Schindelin, (Thu Mar 6, 9:59 am)

Re: [PATCH 1/2] Add strbuf_initf(), Kristian , (Thu Mar 6, 11:18 am)

Re: [PATCH 1/2] Add strbuf_initf(), Johannes Schindelin, (Thu Mar 6, 11:26 am)

Re: [PATCH 1/2] Add strbuf_initf(), Kristian , (Thu Mar 6, 11:35 am)

Re: [PATCH 1/2] Add strbuf_initf(), Mike Hommey, (Thu Mar 6, 12:10 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Thu Mar 6, 1:38 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Tue Mar 11, 2:30 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Tue Mar 11, 4:28 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Wed Mar 12, 3:59 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Wed Mar 12, 4:06 pm)

Navigation

Popular discussions


linux-kernel:
Greg KH	Og dreams of kernels
Jens Axboe	[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann	Re: finding your own dead "CONFIG_" variables
Mark Brown	[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds	[LGUEST] Look in object dir for .config
git:
Brian Downing	Re: Git in a Nutshell guide
John Benes	Re: master has some toys
Matthias Lederhofer	[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian	[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano	Re: Rss produced by git is not valid xml?
git-commits-head:
Linux Kernel Mailing List	iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List	ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List	ixgbe: fix several counter register errata
Linux Kernel Mailing List	b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List	9p: block-based virtio client
linux-netdev:
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
David Daney	[PATCH 5/7] Staging: Octeon Ethernet: Convert to NAPI.
Wolfgang Grandegger	[PATCH net-next v4 1/3] can: mscan: fix improper return if dlc < 8 in start_xmi...
Amit Kumar Salecha	[PATCHv3 NEXT 2/2] NET: Add Qlogic ethernet driver for CNA devices
openbsd-misc:
Theo de Raadt	Re: Old IPSEC bug
Tomáš Bodžár	Problem with vpnc connection - check group password !
Insan Praja SW	Mandoc Compiling Error
Carl Roberso	Re: Cannot change MTU of carp interface?
Richard Daemon	Re: booting openbsd on eee without cd-rom

Colocation donated by:

Syndicate