Re: [PATCH 1/2] Add strbuf_initf()

view
thread

Score:

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Mike Hommey <mh@...>

To: Johannes Schindelin <Johannes.Schindelin@...>

Cc: Junio C Hamano <gitster@...>, Johannes Sixt <johannes.sixt@...>, <git@...>

Subject: Re: [PATCH 1/2] Add strbuf_initf()

Date: Thursday, March 6, 2008 - 2:33 am

On Thu, Mar 06, 2008 at 02:14:43AM +0100, Johannes Schindelin wrote:
quoted text> 
> The most common use of addf() was to init a strbuf and addf() right away.
> Since it is so common, it makes sense to have a function strbuf_initf()
> to wrap both calls into one.
> 
> Unfortunately, C (and cpp) has no way to make this easy without code
> duplication, as we need to va_init() in strbuf_addf() possibly a few
> times.  So the code for addf() is copied.  Fortunately, the code is
> pretty short, so not too much had to be copied as-is.

The problem with code duplication is not about code size, but more about
not forgetting to fix bugs in all incarnations of the duplicated code.

Is it so ugly to use a macro ?

Mike
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/40] MinGW port, Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 00/40] MinGW port, Johannes Schindelin, (Wed Feb 27, 7:58 pm)

Re: [PATCH 00/40] MinGW port, Marius Storm-Olsen, (Wed Feb 27, 6:01 pm)

Re: [PATCH 00/40] MinGW port, Martin Langhoff, (Wed Feb 27, 7:34 pm)

Re: [PATCH 00/40] MinGW port, Nguyen Thai Ngoc Duy, (Wed Feb 27, 11:38 pm)

Re: [PATCH 00/40] MinGW port, Johannes Sixt, (Sun Mar 2, 5:20 pm)

Re: [PATCH 00/40] MinGW port, Johannes Schindelin, (Sun Mar 2, 6:07 pm)

Re: [PATCH 00/40] MinGW port, Johannes Sixt, (Mon Mar 3, 2:34 pm)

[PATCH 08/40] Windows: always chmod(, 0666) before unlink()., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 08/40] Windows: always chmod(, 0666) before unlin..., Johannes Schindelin, (Thu Feb 28, 8:09 am)

[PATCH 07/40] Windows: A minimal implemention of getpwuid()., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 06/40] Windows: Implement a wrapper of the open() fun..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 05/40] Windows: Strip ".exe" from the program name., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 04/40] Windows: Use the Windows style PATH separator ..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 04/40] Windows: Use the Windows style PATH separa..., Paolo Bonzini, (Thu Feb 28, 5:25 am)

Re: [PATCH 04/40] Windows: Use the Windows style PATH separa..., Johannes Sixt, (Thu Feb 28, 4:43 pm)

Re: [PATCH 04/40] Windows: Use the Windows style PATH separa..., Johannes Schindelin, (Thu Feb 28, 9:09 pm)

Re: [PATCH 04/40] Windows: Use the Windows style PATH separa..., Paolo Bonzini, (Fri Feb 29, 3:57 am)

Re: [PATCH 04/40] Windows: Use the Windows style PATH separa..., Johannes Schindelin, (Fri Feb 29, 8:19 am)

Re: [PATCH 04/40] Windows: Use the Windows style PATH separa..., Paolo Bonzini, (Fri Feb 29, 8:45 am)

Re: [PATCH 04/40] Windows: Use the Windows style PATH separa..., Johannes Schindelin, (Fri Feb 29, 8:59 am)

[PATCH 40/40] compat/pread.c: Add foward decl to fix warning, Johannes Sixt, (Wed Feb 27, 2:55 pm)

Re: [PATCH 40/40] compat/pread.c: Add foward decl to fix war..., Johannes Schindelin, (Thu Feb 28, 11:51 am)

[PATCH 39/40] Windows: Fix ntohl() related warnings about pr..., Johannes Sixt, (Wed Feb 27, 2:55 pm)

[PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Thu Feb 28, 8:05 am)

Re: [PATCH 03/40] Add target architecture MinGW., Paolo Bonzini, (Thu Feb 28, 8:57 am)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Thu Feb 28, 10:56 am)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Wed Mar 5, 5:21 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Tue Mar 11, 5:30 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Tue Mar 11, 7:28 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Wed Mar 12, 6:59 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Wed Mar 12, 7:06 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Wed Mar 5, 6:18 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Thu Mar 6, 4:38 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Junio C Hamano, (Wed Mar 5, 6:22 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Wed Mar 5, 6:28 pm)

[PATCH 2/2] format-patch: add --reviewed-by=<ident>, Johannes Schindelin, (Wed Mar 5, 9:15 pm)

Re: [PATCH 2/2] format-patch: add --reviewed-by=<ident>, Junio C Hamano, (Wed Mar 5, 10:40 pm)

Re: [PATCH 2/2] format-patch: add --reviewed-by=<ident>, Johannes Schindelin, (Thu Mar 6, 6:40 am)

[PATCH 1/2] Add strbuf_initf(), Johannes Schindelin, (Wed Mar 5, 9:14 pm)

Re: [PATCH 1/2] Add strbuf_initf(), Mike Hommey, (Thu Mar 6, 2:33 am)

Re: [PATCH 1/2] Add strbuf_initf(), Johannes Schindelin, (Thu Mar 6, 6:53 am)

Re: [PATCH 1/2] Add strbuf_initf(), Jeff King, (Thu Mar 6, 8:09 am)

Re: [PATCH 1/2] Add strbuf_initf(), Reece Dunn, (Thu Mar 6, 5:03 am)

Re: [PATCH 1/2] Add strbuf_initf(), Johannes Schindelin, (Thu Mar 6, 6:55 am)

Re: [PATCH 1/2] Add strbuf_initf(), Reece Dunn, (Thu Mar 6, 7:53 am)

Re: [PATCH 1/2] Add strbuf_initf(), Johannes Schindelin, (Thu Mar 6, 8:52 am)

[PATCH 1/2 v2] Add strbuf_vaddf(), use it in strbuf_addf(), ..., Johannes Schindelin, (Thu Mar 6, 12:29 pm)

Re: [PATCH 1/2 v2] Add strbuf_vaddf(), use it in strbuf_addf..., Johannes Sixt, (Thu Mar 6, 12:38 pm)

Re: [PATCH 1/2 v2] Add strbuf_vaddf(), use it in strbuf_addf..., Johannes Sixt, (Thu Mar 6, 12:47 pm)

Re: [PATCH 1/2 v2] Add strbuf_vaddf(), use it in strbuf_addf..., Johannes Schindelin, (Thu Mar 6, 12:59 pm)

Re: [PATCH 1/2] Add strbuf_initf(), Kristian , (Thu Mar 6, 2:18 pm)

Re: [PATCH 1/2] Add strbuf_initf(), Johannes Schindelin, (Thu Mar 6, 2:26 pm)

Re: [PATCH 1/2] Add strbuf_initf(), Mike Hommey, (Thu Mar 6, 3:10 pm)

Re: [PATCH 1/2] Add strbuf_initf(), Kristian , (Thu Mar 6, 2:35 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Junio C Hamano, (Wed Mar 5, 6:51 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Wed Mar 5, 8:11 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Thu Feb 28, 4:40 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Thu Feb 28, 9:07 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Sixt, (Fri Feb 29, 5:03 pm)

Re: [PATCH 03/40] Add target architecture MinGW., Johannes Schindelin, (Fri Feb 29, 5:54 pm)

[PATCH 38/40] Windows: TMP and TEMP environment variables sp..., Johannes Sixt, (Wed Feb 27, 2:55 pm)

[PATCH 37/40] Windows: Make 'git help -a' work., Johannes Sixt, (Wed Feb 27, 2:55 pm)

Re: [PATCH 37/40] Windows: Make 'git help -a' work., Paolo Bonzini, (Thu Feb 28, 5:52 am)

[PATCH 36/40] Avoid the "dup dance" in wt_status_print_verbo..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 36/40] Avoid the "dup dance" in wt_status_print_v..., Johannes Schindelin, (Thu Feb 28, 11:48 am)

[PATCH 35/40] Windows: Work around an oddity when a pipe wit..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 34/40] Windows: Make the pager work., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 33/40] When installing, be prepared that template_dir..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 33/40] When installing, be prepared that template..., Johannes Schindelin, (Thu Feb 28, 11:45 am)

Re: [PATCH 33/40] When installing, be prepared that template..., Paolo Bonzini, (Thu Feb 28, 11:57 am)

Re: [PATCH 33/40] When installing, be prepared that template..., Johannes Sixt, (Thu Feb 28, 5:12 pm)

Re: [PATCH 33/40] When installing, be prepared that template..., Johannes Schindelin, (Thu Feb 28, 9:21 pm)

Re: [PATCH 33/40] When installing, be prepared that template..., Paolo Bonzini, (Thu Feb 28, 5:49 am)

[PATCH 32/40] Windows: Use a relative default template_dir a..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 31/40] Compute the ultimate fallback for exec_path fr..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 30/40] Turn builtin_exec_path into a function., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 29/40] Windows: Use a customized struct stat that als..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 02/40] Compile some programs only conditionally., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 02/40] Compile some programs only conditionally., Johannes Schindelin, (Thu Feb 28, 7:57 am)

Re: [PATCH 02/40] Compile some programs only conditionally., Johannes Sixt, (Thu Feb 28, 4:30 pm)

Re: [PATCH 02/40] Compile some programs only conditionally., Johannes Schindelin, (Thu Feb 28, 8:47 pm)

Re: [PATCH 02/40] Compile some programs only conditionally., Johannes Sixt, (Fri Feb 29, 4:58 pm)

Re: [PATCH 02/40] Compile some programs only conditionally., Johannes Schindelin, (Fri Feb 29, 5:53 pm)

[PATCH 28/40] Windows: Add a new lstat and fstat implementat..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 27/40] Windows: Implement a custom spawnve()., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 27/40] Windows: Implement a custom spawnve()., Johannes Schindelin, (Thu Feb 28, 11:36 am)

Re: [PATCH 27/40] Windows: Implement a custom spawnve()., Johannes Sixt, (Thu Feb 28, 5:04 pm)

Re: [PATCH 27/40] Windows: Implement a custom spawnve()., Johannes Schindelin, (Thu Feb 28, 9:18 pm)

[PATCH 26/40] Windows: Implement wrappers for gethostbyname(..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 25/40] Windows: Implement a cpio emulation in git-clo..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 24/40] Windows: Work around incompatible sort and find., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 23/40] Windows: Local clone must use the drive letter..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 23/40] Windows: Local clone must use the drive le..., Johannes Schindelin, (Thu Feb 28, 11:31 am)

[PATCH 22/40] Windows: Implement asynchronous functions as t..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous functions ..., Johannes Schindelin, (Thu Feb 28, 11:28 am)

Re: [PATCH 22/40] Windows: Implement asynchronous functions ..., Paul Franz, (Thu Feb 28, 1:48 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous functions ..., Johannes Schindelin, (Thu Feb 28, 9:27 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous functions ..., Paul Franz, (Thu Feb 28, 9:46 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous functions ..., Johannes Schindelin, (Thu Feb 28, 9:54 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous functions ..., Paul Franz, (Thu Feb 28, 11:08 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous functions ..., Johannes Schindelin, (Fri Feb 29, 6:26 am)

Re: [PATCH 22/40] Windows: Implement asynchronous functions ..., Junio C Hamano, (Fri Feb 29, 3:51 am)

Re: [PATCH 22/40] Windows: Implement asynchronous functions ..., Paul Franz, (Fri Feb 29, 7:45 am)

Re: [PATCH 22/40] Windows: Implement asynchronous functions ..., Johannes Sixt, (Thu Feb 28, 5:01 pm)

Re: [PATCH 22/40] Windows: Implement asynchronous functions ..., Johannes Schindelin, (Thu Feb 28, 9:17 pm)

[PATCH 21/40] Windows: Disambiguate DOS style paths from SSH..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 21/40] Windows: Disambiguate DOS style paths from..., Johannes Schindelin, (Thu Feb 28, 11:22 am)

Re: [PATCH 21/40] Windows: Disambiguate DOS style paths from..., Johannes Sixt, (Thu Feb 28, 4:51 pm)

[PATCH 20/40] Windows: A rudimentary poll() emulation., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 20/40] Windows: A rudimentary poll() emulation., Paolo Bonzini, (Thu Feb 28, 5:36 am)

Re: [PATCH 20/40] Windows: A rudimentary poll() emulation., Johannes Sixt, (Thu Feb 28, 4:49 pm)

Re: [PATCH 20/40] Windows: A rudimentary poll() emulation., Robin Rosenberg, (Sat Mar 1, 11:48 am)

Re: [PATCH 20/40] Windows: A rudimentary poll() emulation., Johannes Sixt, (Sat Mar 1, 3:24 pm)

[PATCH 19/40] Windows: Change the name of hook scripts to ma..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 19/40] Windows: Change the name of hook scripts t..., Johannes Schindelin, (Thu Feb 28, 11:20 am)

Re: [PATCH 19/40] Windows: Change the name of hook scripts t..., Johannes Sixt, (Thu Feb 28, 4:48 pm)

Re: [PATCH 19/40] Windows: Change the name of hook scripts t..., Johannes Schindelin, (Thu Feb 28, 9:11 pm)

[PATCH 01/40] Add compat/regex.[ch] and compat/fnmatch.[ch]., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 01/40] Add compat/regex.[ch] and compat/fnmatch.[..., Johannes Schindelin, (Wed Feb 27, 7:43 pm)

[PATCH 18/40] Windows: Implement start_command()., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 17/40] Windows: A pipe() replacement whose ends are n..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 16/40] Windows: Wrap execve so that shell scripts can..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 15/40] Windows: A work-around for a misbehaved vsnpri..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 14/40] Windows: Implement setitimer() and sigaction()., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 13/40] Windows: Fix PRIuMAX definition., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 13/40] Windows: Fix PRIuMAX definition., Johannes Schindelin, (Thu Feb 28, 8:21 am)

Re: [PATCH 13/40] Windows: Fix PRIuMAX definition., Johannes Sixt, (Thu Feb 28, 4:45 pm)

[PATCH 12/40] Windows: Implement gettimeofday()., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 11/40] Windows: Handle absolute paths in safe_create_..., Johannes Sixt, (Wed Feb 27, 2:54 pm)

[PATCH 10/40] Windows: Treat Windows style path names., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Re: [PATCH 10/40] Windows: Treat Windows style path names., Johannes Schindelin, (Thu Feb 28, 8:18 am)

[PATCH 09/40] Windows: Work around misbehaved rename()., Johannes Sixt, (Wed Feb 27, 2:54 pm)

Navigation

Mail archive search

Popular discussions


linux-kernel:
Alan Cox	[PATCH 01/76] drivers/serial/crisv10.c: add missing put_tty_driver
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Adrian Bunk	Re: Linux 2.6.21
David Miller	Slow DOWN, please!!!
git:
Jon Smirl	Re: VCS comparison table
Junio C Hamano	[RFD] On deprecating "git-foo" for builtins
Eric Wong	[PATCH] archimport improvements
Johannes Schindelin	Re: [FAQ?] Rationale for git's way to manage the index
openbsd-misc:
Richard Stallman	Real men don't attack straw men
GVG GVG	ssh_exchange_identification: Connection closed by remote host
Leon Dippenaar	New tcp stack attack
Henning Brauer	Re: About Xen: maybe a reiterative question but ..
linux-netdev:
David Miller	[GIT]: Networking
Mark Lord	Re: 2.6.25-rc8: FTP transfer errors
Alexey Dobriyan	[PATCH 01/33] nf_conntrack_sip: de-static helper pointers
Evgeniy Polyakov	Re: [BUG] New Kernel Bugs

Latest forum posts


high memory	1 day ago	Linux kernel
semaphore access speed	1 day ago	Applications and Utilities
the kernel how to power off the machine	1 day ago	Linux kernel
Easter Eggs in windows XP	1 day ago	Windows
Shared swap partition	1 day ago	Linux general
Root password	1 day ago	Linux general
Where/when DNOTIFY is used?	1 day ago	Linux kernel
How to convert Linux Kernel built-in module into a loadable module	2 days ago	Linux kernel
Linux 2.6.24 and I/O schedulers	2 days ago	Linux kernel
USB Driver -- Interrupt Polling -- A Little Help Please	2 days ago	Linux general

Show all forums...

Recent Tags

-rc8 Linus Torvalds Linux -rc quote 2.6.27 2.6.27-rc8 bugs Intel

more tags

Colocation donated by:

Online users

Syndicate