Hi,

On Wed, 5 Mar 2008, Junio C Hamano wrote:

quoted text
> Recently, I ended up wasting two nights because I was not careful enough 
> earlier, when I was short of time and apparent backlog was beginning to 
> get larger and larger.
> 
> I queued some patches from the backlog to 'next' saying "ah, they look 
> good enough, people will notice breakages anyway," but the breakage was 
> not caught until 'master' got broken.
> 
> Not good.  And the list is not to blame.

Ah, but I think that you are too harsh onto yourself.  Recently, there was 
a surge of patches, mainly because 1.5.4 was held of -- but for a good 
reason: 1.5.4 was not ready before the point in time where you decided to 
release it.

If at all, the list is to blame, for just sending patches, but not 
reviewing them.

Now, personally I know that I am not half as good a reviewer as you are, 
since you catch way more bugs than me, just by looking at the patch.

But still, "many eyes make bugs shallow" is a principle to be heeded 
_everywhere_.

So I'd say: if you think that you are short of time, and patches have not 
been reviewed properly, do not assume it _your sole_ responsibility to 
review the patches.  Make it known that other people have to step in (even 
if it is a mediocre reviewer like me).  Do not overload yourself.

So my comment about the "blame" was really tongue-in-cheek.  Please do not 
take it for anything but a joke.

And when I say that I think you are a kick-ass maintainer, I _mean_ it.

'nuff said,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html