Home » Mailing list archives » git » 2008 » March » 4

Re: Commit f5bbc322 to git broke pre-commit hooks which read stdin

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: David Bremner
Subject: Re: Commit f5bbc322 to git broke pre-commit hooks which read stdin
Date: Tuesday, March 4, 2008 - 3:15 pm

>>>>> "Johannes" == Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

    >> Tue, 4 Mar 2008, David Bremner wrote:
    >> 
    >> Yeah, I should have been more explicit. The problem is a line
    >> 
    >> read -N1 VAR

    Johannes> Can you be even more explicit?  IOW why does this have
    Johannes> to be a pre-commit hook, and cannot be done before
    Johannes> calling git-commit itself?

I have this feeling I don't really understand the question.  Yes, in
principle, whatever I am doing in a pre-commit hook could be done by
hand first.  I guess it is primarily a user interface issue.  The goal
is modify the behaviour of git-commit in a particular repository;
isn't this the purpose of pre-commit hooks?  

All the best,

David

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Commit f5bbc322 to git broke pre-commit hooks which read stdin, David Bremner, (Tue Mar 4, 1:38 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Johannes Schindelin, (Tue Mar 4, 3:45 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Junio C Hamano, (Tue Mar 4, 4:12 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Johannes Sixt, (Tue Mar 4, 4:48 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., David Bremner, (Tue Mar 4, 4:48 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Jakub Narebski, (Tue Mar 4, 4:51 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Johannes Schindelin, (Tue Mar 4, 5:03 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Johannes Schindelin, (Tue Mar 4, 5:04 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Junio C Hamano, (Tue Mar 4, 5:17 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Joey Hess, (Tue Mar 4, 11:16 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., David Bremner, (Tue Mar 4, 3:15 pm)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Shawn O. Pearce, (Tue Mar 4, 10:12 pm)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Junio C Hamano, (Tue Mar 4, 10:36 pm)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Shawn O. Pearce, (Tue Mar 4, 10:46 pm)