Home » Mailing list archives » git » 2008 » March » 4

Commit f5bbc322 to git broke pre-commit hooks which read stdin

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: David Bremner
Subject: Commit f5bbc322 to git broke pre-commit hooks which read stdin
Date: Tuesday, March 4, 2008 - 1:38 am

It looks like line 435 of builtin-commit.c disables stdin for hooks
(with the disclaimer that I first looked at the git source ten minutes
ago).

	   hook.no_stdin = 1

I'm not sure if this was by design, but just so you know, this breaks
people's hooks.  In particular the default metastore pre-commit hook
no longer works.  I didn't find anything relevant in the docs [1].

David

[1]: http://www.kernel.org/pub/software/scm/git/docs/hooks.html

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Commit f5bbc322 to git broke pre-commit hooks which read stdin, David Bremner, (Tue Mar 4, 1:38 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Johannes Schindelin, (Tue Mar 4, 3:45 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Junio C Hamano, (Tue Mar 4, 4:12 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Johannes Sixt, (Tue Mar 4, 4:48 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., David Bremner, (Tue Mar 4, 4:48 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Jakub Narebski, (Tue Mar 4, 4:51 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Johannes Schindelin, (Tue Mar 4, 5:03 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Johannes Schindelin, (Tue Mar 4, 5:04 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Junio C Hamano, (Tue Mar 4, 5:17 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Joey Hess, (Tue Mar 4, 11:16 am)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., David Bremner, (Tue Mar 4, 3:15 pm)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Shawn O. Pearce, (Tue Mar 4, 10:12 pm)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Junio C Hamano, (Tue Mar 4, 10:36 pm)
Re: Commit f5bbc322 to git broke pre-commit hooks which re ..., Shawn O. Pearce, (Tue Mar 4, 10:46 pm)