Home » Mailing list archives » git » 2008 » March » 31

Re: [PATCH] git gc --auto: defer on battery

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Junio C Hamano <gitster@...>
To: Linus Torvalds <torvalds@...>
Cc: Bj?rn Steinbrink <B.Steinbrink@...>, Miklos Vajna <vmiklos@...>, <git@...>
Subject: Re: [PATCH] git gc --auto: defer on battery
Date: Sunday, March 30, 2008 - 10:06 pm

Linus Torvalds <torvalds@linux-foundation.org> writes:


That would be a sensible approach.

We also would need to make sure that Porcelain that call "gc --auto" does
not have an assumption that auto is ultra-cheap, however, as we are
talking about potentially two fork-exec in the usual "noop" case with such
a change, but we need to do that regardless.

 * git-svn has "every 1000 commits and one at the end" which should be
   Ok.

 * git-cvsimport does "repack -a -d" every 1k commits and once more at the
   end if there are many remaining loose objects.

 * "git-rebase -i" does one at the end, which should be Ok.

 * "git commit" used to have one at the end in the scripted version, but
   seems to have lost it in C rewrite.

So I think we are Ok with an additional hook.

By the way, Linus, is your MUA UTF-8 challenged?  I see Björn's name on
the To: header mangled.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] git gc --auto: defer on battery, Miklos Vajna, (Sun Mar 30, 7:14 pm)
Re: [PATCH] git gc --auto: defer on battery, Brandon Casey, (Mon Mar 31, 12:24 pm)
Re: [PATCH] git gc --auto: defer on battery, Miklos Vajna, (Mon Mar 31, 1:38 pm)
Re: [PATCH] git gc --auto: defer on battery, Brandon Casey, (Mon Mar 31, 2:31 pm)
Re: [PATCH] git gc --auto: defer on battery, Johannes Schindelin, (Sun Mar 30, 7:41 pm)
Re: [PATCH] git gc --auto: defer on battery, Miklos Vajna, (Sun Mar 30, 7:53 pm)
Re: [PATCH] git gc --auto: defer on battery, Björn, (Sun Mar 30, 7:26 pm)
Re: [PATCH] git gc --auto: defer on battery, Linus Torvalds, (Sun Mar 30, 7:46 pm)
Re: [PATCH] git gc --auto: defer on battery, Joey Hess, (Mon Mar 31, 2:08 pm)
[PATCH 4/4] templates: add an example pre-auto-gc hook, Miklos Vajna, (Mon Mar 31, 5:37 am)
Re: [PATCH 4/4] templates: add an example pre-auto-gc hook, Brian Gernhardt, (Mon Mar 31, 2:30 pm)
[PATCH 3/4] Documentation/hooks: add pre-auto-gc hook, Miklos Vajna, (Mon Mar 31, 5:36 am)
[PATCH 2/4] git-gc: add a --no-verify option to bypass the p..., Miklos Vajna, (Mon Mar 31, 5:36 am)
[PATCH 1/4] git-gc --auto: add pre-auto-gc hook, Miklos Vajna, (Mon Mar 31, 5:35 am)
[PATCH 0/4] add pre-auto-gc hook for git-gc --auto, Miklos Vajna, (Mon Mar 31, 5:35 am)
Re: [PATCH] git gc --auto: defer on battery, Junio C Hamano, (Sun Mar 30, 10:06 pm)
[PATCH] commit: resurrect "gc --auto" at the end, Johannes Schindelin, (Wed Apr 2, 9:40 am)
Re: [PATCH] commit: resurrect "gc --auto" at the end, Johannes Schindelin, (Wed May 14, 11:07 am)
Re: [PATCH] commit: resurrect "gc --auto" at the end, Junio C Hamano, (Wed May 14, 2:13 pm)
Re: [PATCH] commit: resurrect "gc --auto" at the end, Holger Schurig, (Thu May 15, 2:44 am)
Re: [PATCH] commit: resurrect "gc --auto" at the end, Johannes Schindelin, (Wed May 14, 2:40 pm)
Re: [PATCH] git gc --auto: defer on battery, Linus Torvalds, (Mon Mar 31, 11:02 am)
Re: [PATCH] git gc --auto: defer on battery, Björn, (Mon Mar 31, 12:43 pm)
fetchmail (Re: [PATCH] git gc --auto: defer on battery), Linus Torvalds, (Mon Mar 31, 1:00 pm)
Re: [PATCH] git gc --auto: defer on battery, Björn, (Sun Mar 30, 8:00 pm)
[PATCH] git gc --auto: defer on battery, Miklos Vajna, (Sun Mar 30, 7:39 pm)
Re: [PATCH] git gc --auto: defer on battery, Björn, (Sun Mar 30, 7:55 pm)