git mailing list

FromSubjectsort iconDate
Michael Gebetsroither
[bug] git-add won't add foo/.git/bar
hi, % git-add -f foo/.git/bar fatal: unable to add foo/.git/bar to index How do i add such a file to a git repository? thx && cu, michael -- It's already too late! --
Mar 24, 4:55 pm 2008
Damien Diederen
[PATCH 7/7] cvsserver: Use the user part of the email in ...
Generate the CVS author names by taking the first eight characters of the user part of the email address. The resulting names are more likely to make sense (or at least reduce ambiguities) in "corporate" environments. Signed-off-by: Damien Diederen <dash@foobox.net> --- git-cvsserver.perl | 18 ++++++++++++++---- 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/git-cvsserver.perl b/git-cvsserver.perl index 3c97226..9d845c8 100755 --- a/git-cvsserver.perl +++ ...
Mar 24, 3:50 pm 2008
Damien Diederen
[PATCH 1/7] cvsserver: Respond to the 'editors' command
"Cvs editors" lists the users currently working on watched (locked) files. This trivial implementation always returns an empty response, since git-cvsserver does not implement file locking. Without this, TkCVS hangs at startup, waiting forever for a response. Signed-off-by: Damien Diederen <dash@foobox.net> --- git-cvsserver.perl | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/git-cvsserver.perl b/git-cvsserver.perl index 7f632af..33d30c5 100755 --- ...
Mar 24, 3:48 pm 2008
Damien Diederen
[PATCH 2/7] cvsserver: Only print the file part of the f ...
The "File:" header of CVS status output only includes the basename of the file, even when generating a recursive listing; do the same. Signed-off-by: Damien Diederen <dash@foobox.net> --- git-cvsserver.perl | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/git-cvsserver.perl b/git-cvsserver.perl index 33d30c5..9101eef 100755 --- a/git-cvsserver.perl +++ b/git-cvsserver.perl @@ -1466,8 +1466,10 @@ sub req_status $status ||= "Unknown"; + my ...
Mar 24, 3:49 pm 2008
Damien Diederen
[PATCH 3/7] cvsserver: Do not include status output for ...
This effectively implements the -l switch by pruning the entries whose filenames contain a path separator. It was previously ignored. Without this, TkCVS includes strange "ghost" entries in its directory listings. Signed-off-by: Damien Diederen <dash@foobox.net> --- git-cvsserver.perl | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/git-cvsserver.perl b/git-cvsserver.perl index 9101eef..073a426 100755 --- a/git-cvsserver.perl +++ b/git-cvsserver.perl @@ ...
Mar 24, 3:49 pm 2008
Damien Diederen
[PATCH 0/7] Enhance TkCVS interoperability
This series was developed to improve interoperability between git-cvsserver and TkCVS, a CVS client that is fairly popular at least in some corporate environments. Patches 1-6 are "obvious" improvements, implementing missing features or fixing incorrect behaviour. 7 is more questionable, but likely to result in more intelligible log output in a majority of cases. Bear in mind that my perl-fu is not very high when reviewing this series; suggestions are more than welcome! ...
Mar 24, 3:48 pm 2008
Damien Diederen
[PATCH 6/7] cvsserver: Added test for update -p
Signed-off-by: Damien Diederen <dash@foobox.net> --- t/t9400-git-cvsserver-server.sh | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh index 6168324..166b43f 100755 --- a/t/t9400-git-cvsserver-server.sh +++ b/t/t9400-git-cvsserver-server.sh @@ -420,6 +420,24 @@ test_expect_success 'cvs update (merge no-op)' \ GIT_CONFIG="$git_config" cvs -Q update && diff -q merge ...
Mar 24, 3:50 pm 2008
Damien Diederen
[PATCH 5/7] cvsserver: Implemented update -p (print to stdout)
Cvs update -p -r <rev> <path> is the documented way to retrieve a specific revision of a file (similar to git show <rev>:<path>). Without this patch, the -p flag is ignored and status output is produced, causing clients to interpret it as the contents of the file. TkCVS uses update -p as a basis for implementing its various "View" and "Diff" commands. Signed-off-by: Damien Diederen <dash@foobox.net> --- git-cvsserver.perl | 36 ++++++++++++++++++++++++++++-------- 1 files changed, 28 ...
Mar 24, 3:50 pm 2008
Damien Diederen
[PATCH 4/7] cvsserver: Add a few tests for 'status' command
Signed-off-by: Damien Diederen <dash@foobox.net> --- t/t9400-git-cvsserver-server.sh | 32 ++++++++++++++++++++++++++++++++ 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh index b91b151..6168324 100755 --- a/t/t9400-git-cvsserver-server.sh +++ b/t/t9400-git-cvsserver-server.sh @@ -420,4 +420,36 @@ test_expect_success 'cvs update (merge no-op)' \ GIT_CONFIG="$git_config" cvs -Q update && diff -q ...
Mar 24, 3:50 pm 2008
Timothy Schaeffer
Symbolic links create dirty state from git.
Hello, I cloned a repo from another with symbolic links. Now the symbolic links appear as modified files, and nor resetting, nor committing, nor ignoring, nor `rm --cache`ing will take them out of their dirty state. If I try to commit them, I get error: readlink("lib/systems/asdf-system-connections.asd"): Invalid argument fatal: unable to index file lib/systems/asdf-system-connections.asd The link, however, is fine: it points to a valid, existing file, which I can read through the ...
Mar 24, 2:28 pm 2008
Deepak Saxena
git-rebase: "Patch is empty. Was it split wrong?"
I'm getting the above message when doing a git-rebase and wondering is is due to user error in how I am using rebase or b/c of something else. My situation is that a I have a main branch "dev", against which others have developed some branches and I merge into my local version of dev. After merging these I want to rebase to remove the merge itself from the history (I need to linearize the history, long story, don't ask why): $ git-checkout -b f2.6.24_dev f2.6.24/dev Branch f2.6.24_dev set ...
Mar 24, 1:11 pm 2008
Junio C Hamano
Re: [ANNOUNCE] Stacked GIT 0.14.2
Not my mumbling, but I am quite open to slurp in guilt as a subdirectory in git.git at some point in the future just like we bundle git-gui and gitk if asked by the maintainer. The same applies to StGIT for that matter, although I somehow feel that is much less likely to happen, because it lived long enough as a standalone project with enough following to achieve sustainable momentum by itself. --
Mar 24, 1:43 pm 2008
Catalin Marinas
Re: [ANNOUNCE] Stacked GIT 0.14.2
There was a thread last year: http://kerneltrap.org/mailarchive/git/2007/6/14/249310 I don't follow the guilt development to be able to comment. They are pretty similar regarding patch management but it's probably best to try both and see which tool you like. StGIT might have a few more features as it was around for longer (e-mail templates, patch synchronisation between branches etc.) but guilt seems actively developed as well. I might be wrong here but I'm not sure whether guilt uses ...
Mar 24, 4:24 pm 2008
Jan Engelhardt
Re: [ANNOUNCE] Stacked GIT 0.14.2
I always wondered what the difference between stgit and guilt is. Does anyone have a comparison up? --
Mar 24, 1:15 pm 2008
Rene Herman
Re: [ANNOUNCE] Stacked GIT 0.14.2
And I remember some mumblings about git growing quilt-like functionality itself. Anything on that? Rene. --
Mar 24, 1:33 pm 2008
Catalin Marinas Mar 24, 3:50 pm 2008
Catalin Marinas
[ANNOUNCE] Stacked GIT 0.14.2
Stacked GIT 0.14.2 release is available from http://www.procode.org/stgit/. StGIT is a Python application providing similar functionality to Quilt (i.e. pushing/popping patches to/from a stack) on top of GIT. These operations are performed using GIT commands and the patches are stored as GIT commit objects, allowing easy merging of the StGIT patches into other repositories using standard GIT functionality. This is a maintenance release including bug-fixes and a few user interface ...
Mar 24, 12:59 pm 2008
Josef Sipek
Re: [ANNOUNCE] Stacked GIT 0.14.2
Junio, That'd be great! Is there anything special you want me to do? Well, I want to finish up a merge I've been working on first. Josef 'Jeff' Sipek. -- Once you have their hardware. Never give it back. (The First Rule of Hardware Acquisition) --
Mar 24, 4:55 pm 2008
Rene Herman
Re: [ANNOUNCE] Stacked GIT 0.14.2
Probably read it on linux-kernel but yes, that was the one, thanks much. Stored it as an interesting something -- used to use quilt and although I didn't much care for its linear nature when managing an entire tree, it probably works out well for private topic branches. Not overly sure of added practical value over git rebase, but I did like the simple nature of shuffling things around by just editing a series file back when I was using quilt. Keeps one on top of things, so to speak (<-- ...
Mar 24, 4:23 pm 2008
Catalin Marinas
Re: [ANNOUNCE] Stacked GIT 0.14.2
Git rebasing is useful but using a patch management tool is much easier, especially when you need to post a series of patches multiple times while implementing others' comments. And this is not only for private branches but public ones that are meant for upstream merging. The problem with these tools is that they rewrite the history of the repository but they are OK if you aren't in a position where people need to base their work on your tree. I would much prefer to simply commit the ...
Mar 24, 4:40 pm 2008
Catalin Marinas
Re: [ANNOUNCE] Stacked GIT 0.14.2
Indeed, StGIT has grown quite a lot (it now has ~45 commands) and it probably feels better as a tool on its own. However, I think it would be good for git to get such functionality (and it could even share some ideas StGIT and guilt). If this functionality will get fully integrated in git, StGIT could use it directly rather than the low-level git commands. An example of additional functionality that might stay outside of git (at least for a while): since basic patch management support is ...
Mar 24, 4:55 pm 2008
Josef Sipek
Re: [ANNOUNCE] Stacked GIT 0.14.2
It's still using two-way diff apply, but I'd like to implement a three-way merge as a fallback. Josef 'Jeff' Sipek. -- The box said "Windows XP or better required". So I installed Linux. --
Mar 24, 4:39 pm 2008
Rene Herman
Re: [ANNOUNCE] Stacked GIT 0.14.2
Believe it was Linus. Seem to remember him saying something about possibly adding a native queues-like interface not too long ago but it's proving Rene. --
Mar 24, 3:31 pm 2008
Bill Lear
Limiting git log to skip commits with large number of diffs
I would like to tell git log "Do not list, or list in very abbreviated form, commits with greater than N diffs". The man page does not seem to indicate that this could be done. Is there a way to do this? Bill --
Mar 24, 12:53 pm 2008
Yoann Padioleau
Re: merging git repositories history for full history of linux
Thanks, I'll try that. Also the Dave jones commits have the wrong date. All the 1040 commits are set to December 2007. I can get all the dates for the different versions of Linux but is there an easy way then to change the date for those 1040 commitid ? and also author ? The reasons for this is I want to use 'git annotate' on the full history of Linux to do some statistics about the evolution of Linux so I need the good date for each commit. Also, why the diff produce by git log -p can not ...
Mar 24, 2:10 pm 2008
Yoann Padioleau
merging git repositories history for full history of linux
Hi, I would like to merge the 3 git repositories of the history of linux, the one by Dave Jones from linux 0.01 to linux 2.4.0, the one by tglx from 2.4.0 to 2.6.12 and the one from 2.6.12 by torvalds until the last version of Linux. Right now there are 3 repos and I would like only one. I made some scripts to create a fresh repo, and incorporate each commit from the 3 repositories mentionned above (getting the changelog, setting the date), but it takes lots of time because for instance ...
Mar 24, 11:56 am 2008
Junio C Hamano
Re: merging git repositories history for full history of linux
I think you can install two grafts (one that says the root in tglx history has one parent that is tip of Dave Jones history, another that says that the 2.6.12-rc2 commit which is the root in Linus history has one parent that is near the tip of tglx history), and if you want the result to use locally then you are done. Otherwise you can run filter-branch on the result, but the future commits from Linus tree will all be different. --
Mar 24, 12:51 pm 2008
"Kyrre Nygård"
Where to rent the best dedicated servers?
Sorry, I really don't know where else to ask. I've been using Staminus for a while now and I've had it with the downtime. Basically I want a place to host my Ruby on Rails / Git projects, an IRC server as well as an internet radio channel. Simple website / control panel design is ofcourse a plus. None of that cpanel bullshit though, I prefer to meddle around with simple text files the way it's meant to be done. So, layeredtech.com? rackspace.com? And is there a place that reviews ...
Mar 24, 11:09 am 2008
Bill Moran Mar 24, 11:44 am 2008
Gilles Chehade
Re: Where to rent the best dedicated servers?
If asked a couple weeks ago I would have suggested layeredtech, but I'd tend to discourage it now as I ran into a succession of issues that they took too many time to fix (ip addresses not routed to my box, almost 72h of downtime) Actually, if you aren't running a very critical service that you rely on, it is a pretty good service. It's just that when they fuck up, they fuck up big time :) Gilles -- Gilles Chehade --
Mar 24, 1:35 pm 2008
Daniel Barkalow
Re: [PATCH 2/2] git-init: set receive.guardCurrentBranch ...
The use cases I've seen for pushing into a non-bare repository seem to be cases in which "refs/heads/" isn't really local; it's only updated by push from elsewhere, and it's named "refs/heads/" because that's where public branches are served from. This suggests we could have: core.noLocalBranches: true with the implications: - it's definitely okay to push to refs/heads/ - HEAD is always detached. That seems to me to accurately describe a repository used to hold branches for ...
Mar 24, 3:08 pm 2008
Johannes Schindelin
Re: [PATCH 2/2] git-init: set receive.guardCurrentBranch ...
Hi, Funny. I thought bare repositories were meant for public consumption. And for testing, you still can have a (non-public) repository with a work-tree. I'd rather not try to tell users that it is okay to mix the two. Ciao, Dscho --
Mar 24, 3:31 pm 2008
Junio C Hamano
Re: [PATCH 2/2] git-init: set receive.guardCurrentBranch ...
I am afraid that the above is irrelevant. (1) You can push the temporary into anywhere outside refs/heads/ if that becomes the problem; (2) Your change to forbid current branch already "breaks" another workflow (which I happen to use everyday) anyway: # machine A (primary development repository) $ git push k.org ;# master->master, next->next, ... # machine B (build test repository) $ git reset --hard $ for b in master maint next pu ...
Mar 24, 9:50 am 2008
Johannes Schindelin
Re: [PATCH 2/2] git-init: set receive.guardCurrentBranch ...
Hi, It would not, because it is not activated by default. Only newly Okay, I am starting to see the light. How about receive.localBranches = (refuse | allow) with a default "allow"? Then we could add more rope later with the "update" option, which would run "git read-tree -u -m HEAD" if the current branch is updated, and simply allow all other branches being updated. Hmm? Ciao, Dscho --
Mar 24, 10:10 am 2008
Junio C Hamano
Re: [PATCH] Documentation/git-checkout: Update summary t ...
Hmm. The glossary may be a good place to define what the verb "checkout" means. I think using that defined word without adding "/update/refresh" to muddy its meaning would be more appropriate, after we establish what "checkout" means in the glossary. So how about saying "Check out a whole branch, or paths to the work tree" or something like that? --
Mar 24, 9:49 am 2008
Julian Phillips
[PATCH] Documentation/git-checkout: Update summary to re ...
For a while now, git-checkout has been more powerful than the man-page summary would suggest (the main text does describe the new features), so update the summary to hopefully better reflect the current functionality. Also update the glossary description of the word checkout. Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk> --- Ok, so more like this? I've updated the glossary entry for checkout too, though I'm thinking that there ought to be a clearer way to explain it ... ...
Mar 23, 8:06 pm 2008
Santiago Gala
BUG:git-log --follow <path> should never trim output WRT ...
I tried this on today's git.git repository, as a suggestion for following moves: $ git log -M -C -C --color --stat --follow -- gitk-git/po/de.po | wc -l 0 sgala@marlow ~/newcode/git/git (master)$ git log -M -C -C --color --stat -- gitk-git/po/de.po | wc -l 31 $ git --version git version 1.5.4.4 I find very strange that --follow makes git log to stop outputting the first entries. Regards Santiago --
Mar 24, 9:19 am 2008
Carlos Rica
Re: [PATCH] Documentation/git-tag.txt: Clarify tagging o ...
Note that you need to change also the corresponding string inside builtin-tag.c , the lines printed when you run "git tag -h". -- Carlos --
Mar 24, 11:16 am 2008
Pieter de Bie
[PATCH] Documentation/git-tag.txt: Clarify tagging of objects
Change the synopsis and description of git-tag to reflect that any object can be tagged, not just a committish. --- This surprised me, so I guess the documentation deserves some attention. I'm only able to build the HTML documentation, so I hope this looks correct in manpages too. - Pieter Documentation/git-tag.txt | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt index b62a3d1..9702f2f 100644 --- ...
Mar 24, 8:11 am 2008
Jeff King
[PATCH] Documentation: git-tag '-m' implies '-a'
From: Dirk Süsserott <newsletter@dirk.my1.cc> Described that '-a' is implied when '-m' or '-F' is present. --- Oh, I see you already took my suggestion before I made it. :) The text looks good to me, but the patch would not apply here. I think there are some wrapping issues, and it looks like some tabs have been mangled to spaces. Also, it is generally a good idea to: - at least cc Junio on patch submissions to make sure he sees it - sign off your patch (either with commit -s or ...
Mar 24, 12:43 pm 2008
Dirk Süsserott
[PATCH] Documentation: git-tag '-m' implies '-a'
Described that '-a' is implied when '-m' or '-F' is present. --- Documentation/git-tag.txt | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt index b62a3d1..c22fb71 100644 --- a/Documentation/git-tag.txt +++ b/Documentation/git-tag.txt @@ -26,6 +26,9 @@ creates a 'tag' object, and requires the tag message. Unless `-m <msg>` or `-F <file>` is given, an editor is started for the user to type in the tag ...
Mar 24, 7:41 am 2008
Junio C Hamano
Re: [PATCH] Documentation: git-tag '-m' implies '-a'
Heh, and you did not sign it off when you forwarded? ;-) --
Mar 24, 1:07 pm 2008
Jeremy Maitin-Shepard
Re: Yet another "emacs-git" mode on emacs
One thing that stood out in your guided tour is the "Commit with an automatically generated log message" if there are files not "up to date" (which I guess means index does not match HEAD, OR working dir does not match index). It seems that this is almost certainly a bad feature to have. More generally, it seems that your package does not have the right conceptual organization with respect to the index. (The lack of the word index in the guided tour document provides strong evidence ...
Mar 24, 10:05 am 2008
Junichi Uekawa
Re: Yet another "emacs-git" mode on emacs
hmm... Sounds great! where's your git repos :) regards, junichi -- dancer@{debian.org,netfort.gr.jp} Debian Project --
Mar 24, 7:50 am 2008
tsgatesv
Yet another "emacs-git" mode on emacs
Hi! I has written yet another git mode on Emacs in order to contribute to the git organization. I expected the below 1. Understanding git 2. Use friend and powerful mode for emacs 3. Introduce myself to you :-) Actually, I followed the suggestion listed on the soc 2008 ideas. ---------------------------------------------------------------------- Better Emacs integration Make git mode for Emacs full featured git GUI, and not only commit tool, following ideas of PCL-CVS... and its ...
Mar 24, 5:55 am 2008
Thomas Arcila
[PATCH] gitk : External diff viewer.
Right click on patched file list view gives "External diff" popup menu entry, launching selected external diff tool. The diff tool is configurable through Edit/Preference/External diff tool. Signed-off-by: Thomas Arcila <thomas.arcila@gmail.com> --- Hi, Here is a patch to gitk that allows to run an external diff viewer. It can be configured in Edit/Preferences/External diff tool. To see the diff between two files: - select revisions to diff - right click on a file in the patched files ...
Mar 24, 4:55 am 2008
Wincent Colaiuta
Re: [PATCH] Spanish translation of gitk.
I think that's better. The first person form really stands out like a sore thumb because basically _all_ of the output from the computer is in an impersonal form, and all of a sudden the computer starts telling you "_I_ couldn't process this!" as though it were a person. If you really care about length, you _might_ consider saving 3 more chars with: "Error al leer la salida de git log" But that's arguably starting to drift further away from the original English meaning (parse ...
Mar 24, 4:08 am 2008
Carlos Rica
Re: [PATCH] Spanish translation of gitk.
Ups, sorry, Wincent, not Vincent. --
Mar 24, 8:35 am 2008
Carlos Rica
Re: [PATCH] Spanish translation of gitk.
I can also review the translation to enhance it. To start, it is a very good job! I also think that to choose between two options we can compare with translations in other programs, since often they already have been had this discussion. This requires more analysis, I'm seeing many things that could be changed, but also some suggestions from Vincent that need to be addressed, for example the "hijo" and "hija" use, because in this case it adopts the gender of the thing being qualified as ...
Mar 24, 6:43 am 2008
Santiago Gala
Re: [PATCH] Spanish translation of gitk.
Well, "no se puede" has 3 more characters than "no puedo", this was the primary reason why I switched to the first person form. Spanish is way more verbose than English. what about "Error analizando la salida de git log:"? it is impersonal and shorter than the original one. done. This is not a good thing, as it means that I lost changes with my poor git abilities :( I actually translated those lines, but the last changes got lost I think I have taken care of most/all of the ...
Mar 24, 3:07 am 2008
Jean-Baptiste Quenot
Re: [PATCH] git-cherry-pick -x works with conflicting commits
When I'm using "git commit -c <id>" as suggested by git-cherry-pick upon conflict, I do not get the mention "(cherry picked from commit <id>)", at least with version 1.5.4.1. How did you get it? Cheers, -- Jean-Baptiste Quenot http://caraldi.com/jbq/blog/ --
Mar 24, 6:55 am 2008
Rafael Garcia-Suarez
Re: [PATCH] git-cherry-pick -x works with conflicting commits
I use the most recent git from master, and simply do git-add and git-commit without arguments after having resolving the conflict. The commit message in MERGE_MSG, that I checked, does have the "cherry picked from commit <id>" mention (before the conflict list). --
Mar 24, 7:52 am 2008
Jean-Baptiste Quenot
Re: [PATCH] git-cherry-pick -x works with conflicting commits
All right, I see. The conflict error message was confusing me: ------------------------------------------------------------------------ fatal: Entry 'azerty' would be overwritten by merge. Cannot merge. Automatic cherry-pick failed. After resolving the conflicts, mark the corrected paths with 'git add <paths>' or 'git rm <paths>' and commit the result. When commiting, use the option '-c c17532f' to retain authorship and ...
Mar 24, 11:32 am 2008
Rafael Garcia-Suarez
[PATCH] git-cherry-pick -x works with conflicting commits
So this patch fixes the docs to reflect that. Signed-off-by: Rafael Garcia-Suarez <rgarciasuarez@gmail.com> --- Documentation/git-cherry-pick.txt | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/Documentation/git-cherry-pick.txt b/Documentation/git-cherry-pick.txt index f0beb41..475e168 100644 --- a/Documentation/git-cherry-pick.txt +++ b/Documentation/git-cherry-pick.txt @@ -29,8 +29,7 @@ OPTIONS -x:: When recording the commit, append to the original commit ...
Mar 24, 3:41 am 2008
Roger C. Soares
Re: faster egit history page and a pure java "gitk"
Hi Shawn. This is awesome, I can't wait to see this integrated in the main repo :) I don't spend much time working on egit so I usually take a while to make small things, but I can certainly merge my patches on top of yours. Robin, how should I proceed, resend all my patches from the weekend on top of Shawn's tree? []s, Roger. --
Mar 24, 6:33 am 2008
Shawn O. Pearce
faster egit history page and a pure java "gitk"
OK, so I decided a few weeks back that the history page was not fast enough. I think I've spent the past 3 weeks writing true revision machinary for jgit, and now connecting it up to a UI visualizer. git://repo.or.cz/egit/spearce.git plotter The history page has been completely replaced. I saw Roger has some patches against the current history page. :-| There are huge benefits to this infrastructure: * Fast as snot. We are literally just 10-20 ms slower than C Git on the same ...
Mar 24, 2:27 am 2008
Robin Rosenberg Mar 24, 7:10 am 2008
Robin Rosenberg
Re: faster egit history page and a pure java "gitk" so
Did you lose compare? Ok, found it, but it only shows one file in the compare editor, so I cannot walk through all changes in the commit with Ctrl-. and Ctrl-, -- robin --
Mar 24, 7:31 am 2008
Robin Rosenberg
Re: faster egit history page and a pure java "gitk"
The page was very messy. It was my first attempt at anything ui in On what repo is that measured? As for Java speed, it is some two to three times slower than C on array intensive stuff. On just about anything else the difference is less. The "Micro-optimize pack index v2 findOffset routine" commit suprises me a little. The rearranged ObjectId layout does not. Could we do even better gitk has to talk to externa processess and parse things so I'm not surprised This probably is related to ...
Mar 24, 7:06 am 2008
sgala
[PATCH] gitk: One \t missing in the help file (for <Return>)
Add it in the source and the Italian translation, the German translation does not have the string. The Spanish translation already contains it. Without it the formatting of the help page is not right here. Signed-off-by: Santiago Gala &lt;sgala@apache.org&gt; --- gitk-git/gitk | 2 +- gitk-git/po/it.po | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gitk-git/gitk b/gitk-git/gitk index 84ab02e..6fe454b 100644 --- a/gitk-git/gitk +++ b/gitk-git/gitk @@ -1370,7 ...
Mar 24, 1:16 am 2008
Logan Kennelly
Effects of alias not changing the directory
At the request of some of my coworkers, I created a wrapper script that allows them to use a graphical diff tool when they wish. I effectively add a new command through the use of an alias: [alias] exdiff = &quot;!GIT_EXTERNAL_DIFF=git_exdiff.sh GIT_PAGER=cat git diff&quot; This command works extremely well when run by itself (`git exdiff`) but fails when run from a subdirectory and given a relative path because the alias machinery changes the current directory as demonstrated here: ...
Mar 23, 10:27 pm 2008
James Sadler
Committer authentication in git-send-pack/git-receive-pack
A while ago, there was some discussion about authenticating commits using gnupg signatures. (see http://kerneltrap.org/mailarchive/git/2008/1/29/634209). I have searched through all of the branches in the main git repo and I can't see any commits relating to this functionality, so I was wondering if the work had stalled or perhaps not even been started. If that's the case, I'm willing to give it a shot and would welcome some discussion on how to get started. The posts in the aforementioned ...
Mar 23, 9:01 pm 2008
Roger C. Soares
Re: [EGIT PATCH 4/4] Show only commits in the current branch.
Yep, I did it some time ago and haven't gone back to understand the getHistoryFor code. It will be a lot better now, thanks, will do it. :) []s, Roger. --
Mar 24, 6:18 am 2008
Robin Rosenberg
Re: [EGIT PATCH 4/4] Show only commits in the current branch.
Good ui, but I don't like the filter (seem you didn't either from your comment) so I suggest inserting this patch before the 4/4 patch of yours. Then in your patch drop the filter and fix the call to getHistory. This will improve performance since the &quot;current branch only&quot; will be the view I (and probably most other people) will use the most. @@ -868,39 +865,10 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable, .getHistoryFor(startingPoint, -1, ...
Mar 24, 2:47 am 2008
Roger C. Soares
[EGIT PATCH 4/4] Show only commits in the current branch.
This is a quick hack to have the functionality. It filters the commits returned by GitFileHistory.getHistoryFor. Signed-off-by: Roger C. Soares &lt;rogersoares@intelinet.com.br&gt; --- org.spearce.egit.ui/icons/elcl16/cbcommits.gif | Bin 0 -&gt; 354 bytes .../src/org/spearce/egit/ui/GitHistoryPage.java | 80 ++++++++++++++++++++ .../egit/ui/PluginPreferenceInitializer.java | 1 + .../src/org/spearce/egit/ui/UIIcons.java | 3 + ...
Mar 23, 7:58 pm 2008
Roger C. Soares
[EGIT PATCH 3/4] Add "find in references" to the find toolbar.
Signed-off-by: Roger C. Soares &lt;rogersoares@intelinet.com.br&gt; --- org.spearce.egit.ui/icons/elcl16/refs.gif | Bin 0 -&gt; 340 bytes .../src/org/spearce/egit/ui/FindToolbar.java | 55 ++++++++++++++++++- .../src/org/spearce/egit/ui/FindToolbarThread.java | 58 ++++++++++++++++++-- .../src/org/spearce/egit/ui/GitHistoryPage.java | 2 +- .../src/org/spearce/egit/ui/UIIcons.java | 3 + .../src/org/spearce/egit/ui/UIText.java | 2 + ...
Mar 23, 7:57 pm 2008
Roger C. Soares
[EGIT PATCH 2/4] Change the find toolbar find-in prefs i ...
The find toolbar now searches only in one field at a time and the user can change the find-in field by clicking on the button. The button shows an icon so the user knows at all times what field is selected. We don't have the option to find in all fields at the same time anymore, but from day to day usage I noticed that I usually only want to search in one field at a time. It feels a lot better to me and also makes it more like gitk. Signed-off-by: Roger C. Soares ...
Mar 23, 7:57 pm 2008
Roger C. Soares
[EGIT PATCH 1/4] Add private modifier for private variab ...
I overlooked this when doing the find toolbar. Fixing now. Signed-off-by: Roger C. Soares &lt;rogersoares@intelinet.com.br&gt; --- Hi Robin, Here goes some more patches for your review. Currently they are on top of the last patches I sent you. Patch 4/4 is the one that shows only the commits in the current branch. I don't see me going through Shawn's new machinery soon, so I'm just sending what I have today as a starting point for the feature. []s, Roger. ...
Mar 23, 7:57 pm 2008
Chiyuan Zhang
Re: [GSoC2008]What's wrong with last years Gittorrent?
OK! Thanks for this information. I think I should double check that I'm legal to work on this before trying to apply this. :p --
Mar 24, 12:34 am 2008
Shawn O. Pearce
Re: [GSoC2008]What's wrong with last years Gittorrent?
Last year's GitTorrent implementation never got off the ground. The student who we accepted was unable to actually participate due to legal problems, and we did not find out about it until too late in the program to select a replacement student. So in short, there's nothing wrong with last year's GitTorrent, as there was no last year's GitTorrent. Hence it is on the list again for this year. :) -- Shawn. --
Mar 24, 12:24 am 2008
Chiyuan Zhang
[GSoC2008]What's wrong with last years Gittorrent?
Hi, I'm planning to apply Google Summer of Code this year. I noticed on the git project page there's a gittorrent implementation. I'm interested in this. But later I found there was also a similar project (accepted) in last year's SoC: GitTorrent Server and Peer, written in Python. Unfortunately, the two links on that page aren't available any more. So I'm wondering what's the status of last year's GitTorrent? Is there something wrong with that? If any, what caused the problem and what's the ...
Mar 23, 6:14 pm 2008
Wincent Colaiuta
"Select bg" in gitk preferencias
In reviewing the patch just sent in by Santiago Gala (message-id: &lt;1206316703-15481-1-git-send-email-sgala@apache.org &gt;) I noticed the following little problem in the English version of the gitk preferences dialog: What do you think about changing &quot;Select bg&quot; to &quot;Selection bg&quot; (or even &quot;Selection background&quot;) in the English version to avoid this kind of misunderstanding in the future? Cheers, Wincent --
Mar 24, 2:15 am 2008
Wincent Colaiuta
Re: [PATCH] gitk: Changes in Spanish translation after r ...
Yep, I agree with everything that Carlos has said. If you can incorporate his feedback I think the translation will be in pretty good shape. Saludos, Wincent --
Mar 24, 3:35 pm 2008
sgala
[PATCH] gitk: Changes in Spanish translation after revie ...
Changes to Spanish translation after comments by Wincent Colaiuta in the git list, see http://thread.gmane.org/gmane.comp.version-control.git/77983/focus=78011 Signed-off-by: Santiago Gala &lt;sgala@apache.org&gt; --- gitk-git/po/es.po | 110 ++++++++++++++++++++++++++-------------------------- 1 files changed, 55 insertions(+), 55 deletions(-) diff --git a/gitk-git/po/es.po b/gitk-git/po/es.po index 1e28f11..8a60931 100644 --- a/gitk-git/po/es.po +++ b/gitk-git/po/es.po @@ -30,7 +30,7 @@ ...
Mar 24, 9:37 am 2008
Carlos Rica
Re: [PATCH] gitk: Changes in Spanish translation after r ...
I'm tracking all those changes. There are some issues still missing, this night (here) I will report them if Wincent don't review them first. Just a little more and we will be this new translation done. -- Carlos --
Mar 24, 11:49 am 2008
Carlos Rica
Re: [PATCH] gitk: Changes in Spanish translation after r ...
Hi Santiago, this is my list of the missing things: Also, this should be &quot;ruta&quot; instead of &quot;path&quot;. Below, you also wrote the message: &quot;Limita las diferencias a los path seleccionados&quot;, that it will be better written as I also think that this should be better &quot;Cambiar a esta rama&quot; This is mine: I think here you can write something more to the point to avoid repetition, just something like &quot;...o volver a empezar&quot; or &quot;...o reiniciar la búsqueda&quot;. How about translating &quot;To&quot; with ...
Mar 24, 2:00 pm 2008
Wincent Colaiuta
Re: [PATCH] Spanish translation of gitk.
Great job on the translation! Some feedback follows: Wouldn't it be normal to use an impersonal form there? ie. &quot;No se Consistency: you've capitalized &quot;Nueva&quot; but not &quot;antigua&quot;. I think both should be uncapitalized. Here you've translated &quot;Check out&quot; as &quot;activate&quot;, but I wonder if it might be better to instead pick a term like &quot;switch to&quot; (ie. &quot;Cambiar The official translations of the GNU GPL refer to it as &quot;Licencia Pública General de GNU (GNU GPL)&quot;. (See ...
Mar 24, 2:00 am 2008
Johannes Schindelin
Re: [PATCH 2/2] git-init: set receive.guardCurrentBranch ...
Hi, That would break this work flow: # machine A $ git push B master:refs/heads/tmp # machine B $ git merge tmp $ git branch -d tmp Besides, there is a _vital_ difference between the current branch, and any other local branch: pushing into other local branches cannot make your working tree stale. Ciao, Dscho --
Mar 24, 4:00 am 2008
Junio C Hamano
Re: [PATCH 2/2] git-init: set receive.guardCurrentBranch ...
As I described in my other message, I suspect that treating the current branch specially like this is a wrong approach. The configuration might be a good idea, but shouldn't it prevent any local branch from getting updated? Push into non-bare repository is simply a fetch run in reverse direction. --
Mar 23, 5:24 pm 2008
Johannes Schindelin Mar 24, 4:08 am 2008
Junio C Hamano
Re: git-merge adds test to a message -- bug?
Ok, it helped. So it was &quot;my suspicion that people who would want to pass -m would want it to behave this way&quot;. I do not care deeply either way myself, as I never have found use for -m to the merge command, but I think it could have been argued either way. &quot;If you want to include the standard message, you can do so yourself by running the fmt-merge-msg yourself&quot; would have been a valid argument too, even though it would make it a lot more cumbersome if many people wanted the standard ...
Mar 24, 9:45 am 2008
Junio C Hamano
Re: git-merge adds test to a message -- bug?
Interesting. The following patch will change the bahaviour to what your test script expects, but by looking at the original code, you can tell that it is indeed the intended behaviour of &quot;-M' to _allow_ you to _prepend_ your own message to the standardized &quot;Merge these&quot; message, not _replace_ with it. I unfortunately do not recall why _prepend_, and not _replace_, had to be the right behaviour. Unless somebody can point out there was a valid reason but that reason is not relevant anymore, ...
Mar 23, 10:17 pm 2008
Jörg
Re: [PATCH 4/4] git-rebase -i: New option to support reb ...
Hi Johannes, Me too, but I think it's not possible to do what I want with -p. -p misses a definition of the (new) parent of a commit. It tries to preserve all commits from all branches. But going through the _list_ of commands couldn't preserve this structure. o--A--B \ \ C--D--M--E How should the graph look like after these commands: pick A pick C squash E # pick D pick B pick M Should pick A pick B pick C pick D pick M pick E give a same graph like pick ...
Mar 24, 4:14 am 2008
Johannes Schindelin Mar 24, 6:08 am 2008
Jörg
Re: [PATCH 4/4] git-rebase -i: New option to support reb ...
Hallo Johannes, Thanks for answering my question. You are really cooperatively. Bye, J=F6rg. --=20 IRC: Der [Prof. Andreas Pfitzmann, TU Dresden] hat gerade vorgeschlagen, sie sollen doch statt Trojanern die elektromagnetische Abstrahlung nutzen. Das sei nicht massenf=E4hig, ginge ohne Eingriff ins System, sei zielgerichte= t, und, der Hammer, das funktioniere ja bei Wahlcomputern schon sehr gut.
Mar 24, 4:40 pm 2008
Junio C Hamano
Re: [PATCH 4/4] git-rebase -i: New option to support reb ...
I'll extend this topic a bit for the last time, but first a word of caution. What I am going to draw is probably not what the current -p implementation does. They illustrate what I think should happen. Again, starting from this topology: o---o---o---o---o---Z / X---Y---A---B \ \ C---D---M---E and the goal is to rebase your development leading to E on top of the updated mainline Z. The earlier example was when you want to end up with this ...
Mar 24, 4:30 pm 2008
Junio C Hamano
Re: [PATCH 4/4] git-rebase -i: New option to support reb ...
I am beginning to suspect that the root cause of this is that the todo language is not expressive enough to reproduce a merge _and_ allow end user editing. Let's step back a bit. If you have this history: o---o---o---o---o---Z / X---Y---A---B \ \ C---D---M---E and you want to transplant the history between X..E on top of Z, from the command line you would say: $ git rebase --interactive -p --onto Z X E First let's think what you would ...
Mar 24, 11:35 am 2008
Junio C Hamano
Re: [PATCH 3/2] parse-options.c: introduce OPT_DATE
Doesn't approxidate return ulong, not uint? --
Mar 24, 1:10 pm 2008
Johannes Schindelin
Re: [PATCH 2/2] builtin-prune.c: fix object parsing and ...
Hi, And maybe a #define OPT_DATE(s, l, v, h) { OPTION_CALLBACK, (s), (l), (v), &quot;time&quot;, (h), 0, parse_opt_approxidate_cb } Hmm? Ciao, Dscho --
Mar 24, 6:13 am 2008
Johannes Schindelin Mar 24, 6:59 am 2008
Johannes Schindelin Mar 24, 1:03 pm 2008
Michele Ballabio
Re: [PATCH 3/2] parse-options.c: introduce OPT_DATE
Ooops. To be consistent, these should be OPT__DATE (with two underscores) instead (and in the commit message, too). --
Mar 24, 9:25 am 2008
Michele Ballabio Mar 24, 2:18 pm 2008
Michele Ballabio
[PATCH 3/2] parse-options.c: introduce OPT_DATE
There are quite a few places that will need to call approxidate(), when they'll adopt the parse-options system, so this patch adds the function parse_opt_approxidate_cb(), used by OPT_DATE, and converts the only user so far. Signed-off-by: Michele Ballabio &lt;barra_cuda@katamail.com&gt; --- Oh, right. Somehow I thought it was simpler not to do this. Thank you for your review and suggestions. This is on top of [PATCH 2/2] builtin-prune.c: fix object parsing and use parse_options() ...
Mar 24, 7:02 am 2008
Michele Ballabio
Re: [PATCH 2/2] builtin-prune.c: fix object parsing and ...
Ok, but the usage string is quite short anyway... and other commands show a similar quite detailed usage string. Not that I care strongly Thank you. -- &gt;8 -- parse-options.c: introduce callback function for approxidate() There are quite a few places that will need to call approxidate(), when they'll adopt the parse-options system, so this patch adds the function parse_opt_approxidate_cb(), to be used within OPT_CALLBACK, and converts the only user so far. Signed-off-by: Michele ...
Mar 24, 5:31 am 2008
Jay Soffian
Re: A script that keeps track of your favorite Git/SVN p ...
T24gU3VuLCBNYXIgMjMsIDIwMDggYXQgNDo1NiBQTSwgIkt5cnJlIE55Z8OlcmQiIDxreXJyZW55 QGJyb2FkcGFyay5ubz4gd3JvdGU6Cj4gSGkgdGhlcmUsCj4gIEhhc2FueWJvZHkgZXZlciB3cml0 dGVuIGEgc2NyaXB0IHRoYXQga2VlcHMgdHJhY2sgb2YgeW91ciBmYXZvcml0ZSBHaXQoYW5kIFNW TikgcHJvamVjdHM/IEUuZy4gc2VuZHMgeW91IGFuIGUtbWFpbCBldmVyeSB0aW1lIGEgcmV2aXNp b24gaGFzYmVlbiBtYWRlLCB3aXRoIGRldGFpbHMgbGlrZSB0aGUgc3VtbWFyeSwgdGltZSBhbmQg ZGF0ZSwgYXV0aG9yIGFuZGNvZGUgZGlmZmVyZW5jZXMuCgpNYXliZSBodHRwOi8va2l0ZW5ldC5u ZXQvfmpvZXkvY29kZS9tci8gPwoKai4K --
Mar 24, 7:59 am 2008
Asheesh Laroia Mar 23, 9:04 pm 2008
Avery Pennarun
Re: A script that keeps track of your favorite Git/SVN p ...
Why not subscribe to the gitweb of each one via your RSS reader? Avery --
Mar 23, 9:47 pm 2008
Johannes Schindelin
Re: [PATCH 1/2] Introduce receive.guardCurrentBranch
Hi, As I wrote earlier, you can do that with a hook. I do not want any official support for this, since I think it is an absolutely horrible idea. I think I said that earlier, too. Ciao, Dscho --
Mar 24, 4:01 am 2008
Miklos Vajna
Re: [PATCH 1/2] Introduce receive.guardCurrentBranch
probably i want too much, but it would be really nice if receive-pack could just make HEAD detached. so that the user later can do a 'git checkout -m master' to resolve possible conflicts.
Mar 23, 6:21 pm 2008
Miklos Vajna
Re: [PATCH 1/2] Introduce receive.guardCurrentBranch
On Mon, Mar 24, 2008 at 12:01:33PM +0100, Johannes Schindelin &lt;Johannes.Sch= hm that makes sense. thanks for mentioning that it's possible via hooks, in the &quot;i know what i'm doing&quot; case :)
Mar 24, 7:10 am 2008
Theodore Tso
Re: What I miss from Cogito...
Yeah, it's not at all intuitive. I've been using git for quite some time and had *absolutely* *no* *idea* that &quot;git checkout &lt;treeish&gt; -- path&quot; did what &quot;bk revert&quot; and &quot;hg revert&quot; does. In fact, I'm pretty sure I remember asking for this functionality a while back, and being told the right answer was &quot;git show HEAD:pathname &gt; pathname&quot;, and I kept on typing it until I got sick and tired of it, and so I created my short-hand shell script. And the fact that Peter was using &quot;git reset ...
Mar 23, 5:16 pm 2008
Junio C Hamano
Re: What I miss from Cogito...
It's not &quot;wee bit misleading&quot; but it just is outright stale. Back then, before people realized the operation &quot;to check out the path out of index or tree-ish&quot; belongs naturally to a command whose name is &quot;checkout&quot;, &quot;to check out the named branch or a commit&quot; was the only thing that you could do with the command. The one-line description you quoted above reflects that history. Patches very much welcome; I did not notice it was kept stale. --
Mar 23, 7:53 pm 2008
Julian Phillips
[PATCH] Documentation/git-checkout: Update summary to re ...
For a while now, git-checkout has been more powerful than the man-page summary would suggest (the main text does describe the new features), so update the summary to hopefully better reflect the current functionality. Signed-off-by: Julian Phillips &lt;julian@quantumfyre.co.uk&gt; --- Something like this perhaps? Documentation/git-checkout.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/git-checkout.txt b/Documentation/git-checkout.txt index ...
Mar 23, 8:06 pm 2008
Theodore Tso
Re: What I miss from Cogito...
That's why I said &quot;git revert-file&quot; as being different from &quot;git revert&quot;. If you want to revert the entire tree in the sense of If that's true, why is the one-line summary in the git-checkout man page and in the git top-level man page read as follows? git-checkout - Checkout and switch to a branch At the very least, will you admit that the summary in the man page is perhaps just a wee bit misleading? - Ted --
Mar 23, 7:14 pm 2008
Björn
Re: What I miss from Cogito...
There is a difference between &quot;checkout HEAD -- $file&quot; and &quot;show HEAD:$file &gt; $file&quot;. The former will also update the index, while the latter does not. Maybe you asked for not updating the index back then? Maybe it's just a misunderstanding on my side, but to me &quot;checkout&quot; means as much as &quot;get me something out of the repo&quot;. And git checkout does exactly that. It can get you a branch (naturally switching your HEAD to it), or it can get you trees or blobs. The latter can come from either the ...
Mar 23, 6:40 pm 2008
Björn
Re: What I miss from Cogito...
But that still leaves out e.g. &quot;git checkout HEAD -- some_directory/&quot;. Passing a directory to git revert-file seems plain broken, but you can do that with checkout, so you would also need a git revert-tree (or come up with a better name ;-)). And IMHO the difference between git revert and the suggested revert-file has too much potential for confusion I won't disagree on that one ;-) But I probably won't come up with something better either. My brain stops somewhere at &quot;Checkout stuff&quot;, and ...
Mar 23, 7:57 pm 2008
Guanqun Lu
[PATCH] Fix the wrong output of `git-show v1.3.0~155^2~4 ...
Texts between ~ and ~ will be subscripted during the asciidoc translation. Signed-off-by: Guanqun Lu &lt;Guanqun.Lu@Gmail.com&gt; --- Documentation/user-manual.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt index 40b0de0..565aeb9 100644 --- a/Documentation/user-manual.txt +++ b/Documentation/user-manual.txt @@ -4144,7 +4144,7 @@ commits one by one with the function `get_revision()`. If you are ...
Mar 24, 12:27 am 2008
Jay Soffian
Re: git-config: aliases with parameter expansion ($1 and such)
Lost to the mists of time. But I think for consistency with other aliases where I was checking $#. Maybe. j. --
Mar 24, 7:54 am 2008
Jeff King
Re: git-config: aliases with parameter expansion ($1 and such)
I hadn't thought of that when I gave (1) as an example. I think (2) is Yes, see builtin-tag:430-433 (it is also implied by -F). Care to submit a documentation patch? -Peff --
Mar 24, 12:29 pm 2008
Jay Soffian
Re: git-config: aliases with parameter expansion ($1 and such)
All my shell aliases therefor look like: h = &quot;!sh -c 'git alias \&quot;$1\&quot; || git help \&quot;$1\&quot;' -&quot; (Notice the trailing '-'.) j. --
Mar 23, 6:54 pm 2008
Dirk Süsserott
Re: git-config: aliases with parameter expansion ($1 and such)
Thanks for the help. Both (1) atag = !sh -c 'git tag -a -m &quot;$0&quot; &quot;$0&quot;' and (2) atag = !sh -c 'git tag -a -m &quot;$1&quot; &quot;$1&quot;' - work, but in the latter case the '-' is indeed crucial. If not given, $1 is not set and git tag complains badly. When called without any args, (1) sets a tag called &quot;sh&quot; whereas (2) complains about the missing value for the -m option. So I decided to use the second form. Shells are funny things. ;-) BTW: Is it true that &quot;-a&quot; is implicitely added to &quot;git tag&quot; when ...
Mar 24, 6:15 am 2008
Junio C Hamano Mar 23, 7:47 pm 2008
Johannes Schindelin
Re: Working copy revision and push pain
Hi, I think I sent out a sensible patch, which does not change the behaviour in existing repositories. This should be safer (read: nicer) for Git old-timers. Ciao, Dscho --
Mar 24, 8:22 am 2008
Johan Herland
Re: Working copy revision and push pain
Yes, I'm following the discussion between you and Junio with great interest. Will post if I have anything worthwhile to contribute. So far you both make a lot of sense. Thanks a lot for the patch. Have fun! :) ...Johan -- Johan Herland, &lt;johan@herland.net&gt; www.herland.net --
Mar 24, 11:00 am 2008
Junio C Hamano
Re: What's cooking in git.git (topics)
I had an impression that that change would break the existing output that somebody other than you are depending on. I personally think it is plausible that everybody wants the new behaviour your patch propose, but that kind of change is not appropriate for 1.5.5 cycle (might be Ok for 1.6.0 after we see agreements on the list), and definitely not something we would want to apply after -rc0. --
Mar 23, 8:01 pm 2008
Johannes Schindelin
[PATCH] init: show &quot;Reinit&quot; message even in an (existing ...
Earlier, git-init tested for a valid HEAD ref, but if the repository was empty, there was none. Instead, test for the existence of the file $GIT_DIR/HEAD. Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt; --- I realised this while testing the core.initHook patch. builtin-init-db.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/builtin-init-db.c b/builtin-init-db.c index 1975910..ceb4727 100644 --- a/builtin-init-db.c +++ ...
Mar 24, 8:14 am 2008
Junio C Hamano
Re: [PATCH v2] Introduce core.initHook
Sorry, I may have been unclear but I was wondering more about the case the hook script errored out silently. --
Mar 24, 3:40 pm 2008
Dmitry Potapov
Re: [msysGit] Re: Store autocrlf during init-db (was [ms ...
I am sorry I missed this discussion. In this case, I believe that the idea of templates should be extended, so any user may have his/her own templates in $HOME/.gittemplates. IMHO, it makes much more sense than making an exception for autocrlf in builtin-init-db.c and breaking existing repositories... Dmitry --
Mar 23, 5:23 pm 2008
Dmitry Potapov
Re: [PATCH] init-db: Store current value of autocrlf
NAK While I agree that preserving autocrlf may be a good idea, I don't like that the idea of making an exception for autocrlf and treating the global settings for it differently than for other variables -- as something that should be copied on init. We have templates for that, so autocrlf should be placed into templates/config and then it will be automatically copied when a new repository is created. I have tested that now, and it works. Dmitry --
Mar 23, 5:16 pm 2008
Johannes Schindelin
Re: [msysGit] Re: Store autocrlf during init-db (was [ms ...
Hi, I thought we discussed that already? And the consensus was that this does not allow for per-user overriding. Ciao, Dscho --
Mar 23, 5:01 pm 2008
Johannes Schindelin
Re: [msysGit] Re: Store autocrlf during init-db (was [ms ...
Hi, I think I actually suggested something like that. But that gets only even more complicated: if you have a template for .git/config in $HOME/.gittemplates/, then the global template will be _disregarded_, even if the administrator puts something vital in there. Maybe the best idea would be an &quot;init&quot; hook, settable from the config, after all. Ciao, Dscho --
Mar 24, 3:57 am 2008
Johannes Schindelin
[PATCH v3] Introduce core.initHook
This variable, if set, specifies the path of a hook which is executed after every git-init. It can be used to override settings in the templates per-user. In case of a re-initialization, the hook gets called with the argument &quot;reinit&quot;. Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt; --- Ooops. You're right. This is the interdiff: diff --git a/builtin-init-db.c b/builtin-init-db.c index e1a54b5..cdeb1d7 100644 --- a/builtin-init-db.c +++ b/builtin-init-db.c @@ ...
Mar 24, 4:21 pm 2008
Johannes Schindelin
[PATCH v2] Introduce core.initHook
This variable, if set, specifies the path of a hook which is executed after every git-init. It can be used to override settings in the templates per-user. In case of a re-initialization, the hook gets called with the argument &quot;reinit&quot;. Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt; --- On Mon, 24 Mar 2008, Junio C Hamano wrote: &gt; Johannes Schindelin &lt;Johannes.Schindelin@gmx.de&gt; writes: &gt; &gt; &gt; If you want to run a specific script everytime git-init was &gt; &gt; ...
Mar 24, 2:40 pm 2008
Johannes Schindelin
[PATCH] Introduce core.initHook
This variable, if set, specifies the path of a hook which is executed after every git-init. It can be used to override settings in the templates per-user. For example, when the adminstrator set core.autoCRLF=true in the templates, but you want to avoid that explicitely. Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt; --- On Mon, 24 Mar 2008, Dmitry Potapov wrote: &gt; On Mon, Mar 24, 2008 at 11:57:19AM +0100, Johannes Schindelin &gt; wrote: &gt; &gt; &gt; &gt; Maybe the best ...
Mar 24, 8:12 am 2008
Dmitry Potapov
Re: [msysGit] Re: Store autocrlf during init-db (was [ms ...
Maybe, because I cannot imagine what so vital the administrator can put in it, I really do not see that as a problem. I believe that any good administrator should notify all users about any vital changes anyway, because if these changes are vital, it may be necessary not only change templates in $HOME/.gittemplates/ (which very few users will probably I agree that seems to be the best solution as it is more flexible than having $HOME/.gittemplates/. Dmitry --
Mar 24, 5:21 am 2008
Junio C Hamano
Re: [PATCH] Introduce core.initHook
... in your $HOME/.gitconfig, naturally ;-) I like the general idea, but with a few nits. The hook might want to differentiate its behaviour based on how git-init was invoked, don't you think? E.g. was it because the end user wanted to create a new repo? Re-init? Clone, cvsimport or some other higher level commands invoked git-init on the user's behalf?). The higher level ones could communicate it via environment so we do not have to worry about them too much (except perhaps in the ...
Mar 24, 1:25 pm 2008
Anton Gladkov
Re: [PATCH] [RFC] add Message-ID field to log on git-am ...
I've got your idea! Thank you :) -- Best regards, anton mailto:agladkov@sw.ru --
Mar 23, 11:43 pm 2008
Joe Fiorini
Re: Switching branches without committing changes
Can you send me a link to the official wiki? If I have access to it, I will see about updating it today. -Joe --
Mar 24, 7:46 am 2008
Jeff King Mar 24, 12:07 pm 2008
Brandon Casey
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ...
Maybe that should be qualified. I think your statement is similar to my example and so &quot;not explicitly asking for tags&quot; (by your definition) since neither explicitly named the tags to be rewritten on the command line. In both cases, tag objects would currently be replaced by lightweight tags when --tag-name-filter is used. -brandon --
Mar 24, 9:45 am 2008
Eyvind Bernhardsen
filter-branch --all?
On 24. mars. 2008, at 16.10, Johannes Schindelin wrote: Sorry to hijack the thread. I've seen you mention using &quot;--all&quot; to filter-branch everything before, but I can't get it to work: % git filter-branch --all Usage: /usr/local/bin/git-filter-branch [--env-filter &lt;command&gt;] [-- tree-filter &lt;command&gt;] [--index-filter &lt;command&gt;] [--parent-filter &lt;command&gt;] [--msg-filter &lt;command&gt;] [--commit-filter &lt;command&gt;] [--tag- name-filter &lt;command&gt;] [--subdirectory-filter &lt;directory&gt;] ...
Mar 24, 2:22 pm 2008
Brandon Casey
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ...
Then what is the intended behavior for --tag-name-filter? -brandon --
Mar 24, 10:06 am 2008
Brandon Casey
Re: filter-branch --all?
Try git filter-branch -- --all It is actually an option to rev-parse. -brandon --
Mar 24, 2:33 pm 2008
Johannes Schindelin
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ...
Hi, That is unintended. My understanding of a tag was always that it is something immutable. I mean, _really_ immutable. If you released a certain version, then that is tagged. You must not rewrite the tag. Ever. Ciao, Dscho --
Mar 24, 9:46 am 2008
Johannes Schindelin
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ...
Hi, The thing is: signed tags cannot be rewritten. As simple as that. They could be recreated if the committer happens to be the original tagger, but even then, it is a rewrite of _tags_, which are _not_ supposed to be moving targets. So it was very much on purpose to disallow rewriting them by default. Ciao, Dscho --
Mar 24, 3:53 am 2008
Brandon Casey
Re: [PATCH] filter-branch.sh: support nearly proper tag ...
I probably should have called this v2. Sorry. -brandon --
Mar 24, 3:14 pm 2008
Johannes Schindelin
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ...
Hi, To be honest, I wanted to rip that part out before posting the initial filter-branch patches, and forgot/was too lazy. IMO there should be clean semantics first, and a default mode that does _not_ rewrite tags at all first. Maybe something as in fast-export. Ciao, Dscho --
Mar 24, 10:14 am 2008
Junio C Hamano
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ...
I know that, and you know I know that if you read what you responded again ;-) And I think stripping of gpg signature part is a reasonable best effort for the command, _when_ the user told a signed tag to be rewritten. --
Mar 24, 7:49 am 2008
Eyvind Bernhardsen
Re: filter-branch --all?
That works! Thanks. I managed to figure out that &quot;--all&quot; is a rev-parse option, but it never occurred to me to protect it with a &quot;--&quot;. -- Eyvind Bernhardsen --
Mar 24, 2:44 pm 2008
Brandon Casey
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ...
That sounds like saying that specifying &quot;HEAD&quot; as the revision (_and_ using --tag-name-filter) is not explicitly asking for tags to be rewritten. ? Aside from that, wouldn't the signed tag currently be rewritten? With current git, if I have a signed tag named &quot;my_signed_release&quot;, and I can verify its authenticity using 'git tag -v my_signed_release', and then I run filter-branch with '--tag-name-filter cat', my previously signed tag is replaced with a light weight tag and of course 'git tag ...
Mar 24, 9:34 am 2008
Brandon Casey
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ...
This tag format is described in the documentation for git-mktag as follows: Tag Format ---------- A tag signature file has a very simple fixed format: four lines of object &lt;sha1&gt; type &lt;typename&gt; tag &lt;tagname&gt; tagger &lt;tagger&gt; followed by some 'optional' free-form message (some tags created [...] So, as long as git-cat-file succeeds, shouldn't we get this format piped to sed? The type is hard coded to &quot;commit&quot;, since $new_ref will always be a commit ...
Mar 24, 12:02 pm 2008
Junio C Hamano
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ...
It is a different story if the fix is a good one, or has room for improvement. For example, the sed script that knows what is on the first and second line and relies on that knowledge to use 1c...2c... looked very fragile to me. However, at least to me, this looked like an attempt for a pure &quot;fix&quot;. If you tell filter-branch to filter a branch A and a tag T, as the command is advertised to rewrite positive refs that were given from the command line, isn't it natural to expect that the ...
Mar 23, 10:49 pm 2008
Brandon Casey
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ...
There isn't really a &quot;default&quot; mode for --tag-name-filter, a script must always be supplied. The name of the option (--tag- _name_ -filter) implies that it is intended for changing the names of tags. If the user decides not to change the name, then I think the user would expect the old tag to be replaced. So the user could choose to: Rewrite tag ref: --tag-name-filter cat or Give new tags a new name: --tag-name-filter 'sed -e s/$/.new/' ...
Mar 24, 11:37 am 2008
Brandon Casey
[PATCH] filter-branch.sh: support nearly proper tag name ...
Add support for creating a new tag object and retaining the tag message, author, and date when rewriting tags. The gpg signature, if one exists, will be stripped. This adds nearly proper tag name filtering to filter-branch. Proper tag name filtering would include the ability to change the tagger, tag date, tag message, and _not_ strip a gpg signature if the tag did not change. Signed-off-by: Brandon Casey &lt;casey@nrlssc.navy.mil&gt; --- I learned that the 'Q' command to sed is not portable, ...
Mar 24, 3:09 pm 2008
Johannes Schindelin
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ...
Hi, Yes. BUT. You can say &quot;--all&quot;, and I actually expect quite a few people to do exactly that. And then you cannot really say &quot;the user explicitely asked to have that signed tag rewritten&quot;. Ciao, Dscho --
Mar 24, 8:10 am 2008
Karl
Re: [StGit PATCH 0/6] Two bugfixes
There are three possible values of &quot;keepiness&quot;: 1. Make sure there are _no_ local changes. (Default for old infrastructure.) 2. Make sure there are no local changes in the files we need to touch. (Default for new infrastructure.) 3. Bring along local changes by means of a merge. (What the --keep option does.) git defaults to doing (2), and optionally does (3). (1) is significantly slower than (2); I don't know how slow (3) is. There are two questions: what ...
Mar 24, 11:12 am 2008
Catalin Marinas
Re: [StGit PATCH 0/6] Two bugfixes
I'll try to release 0.14.2 today or tomorrow as I'll be on holiday afterwards for 2.5 weeks. BTW, on the master branch, I noticed that StackTransaction.push_patch() checks whether the patch is empty before pushing it. The behaviour on stable is that it reports whether it's empty after push (just like &quot;modified&quot;, so that you know that a patch no longer has data as a result of the merge). On the merging side during push, we have to add the plain patch applying first followed by a three-way ...
Mar 24, 2:16 am 2008
Karl
Re: [StGit PATCH 0/6] Two bugfixes
Absolutely. I think it would be worthwhile to treat &quot;stable&quot; much like Junio handles his &quot;maint&quot; -- apply minor and/or important fixes there, and release minor releases from it somewhat frequently. And merge it to master often, so that master always has everything stable has. -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle --
Mar 24, 1:35 am 2008
Bryan Donlan
Re: thread-safe libgit.a as a GSoC project, was Re: [SoC ...
On Sat, Mar 22, 2008 at 7:35 AM, Johannes Schindelin All right. If I do end up having to recreate (thread-safe, multiple-git-dir-safe) logic for my project, I'll try to keep in mind --
Mar 24, 12:50 pm 2008
Karl
Re: StGit: kha/safe and kha/experimental updated
It's not entirely clear (to me at least) exactly what undo and redo should do. Something like this maybe: undo: If the log begins with k &quot;undo&quot; entries (k &gt;= 0), reset to log~(2k+1). redo: Find the most recent &quot;undo&quot; entry that hasn't been cancelled out by a &quot;redo&quot;. If this is the most recent log entry (except the cancelled-out ones), reset to it; otherwise, complain that the last command was not an undo or redo. I _think_ this does what one naively ...
Mar 24, 11:26 am 2008
Miklos Vajna
Re: RFC: Use TranslationProject.org for git, gitk, git-gui
i think when we want a good translation, we want somebody, who: 1) understands how git works (as a user), so he/she won't misunderstand the messages to translate 2) is a good translator. i think it's hard to find someone who is good in both. probably the current translations are 1)-like, and TranslationProject.org provides a 2)-like one. not sure which one is better.
Mar 23, 6:43 pm 2008
previous daytodaynext day
March 23, 2008March 24, 2008March 25, 2008