Re: [PATCH 2/2] filter-branch.sh: support nearly proper tag name filtering

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Sunday, March 23, 2008 - 10:49 pm

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:


It is a different story if the fix is a good one, or has room for
improvement.  For example, the sed script that knows what is on the first
and second line and relies on that knowledge to use 1c...2c... looked very
fragile to me.

However, at least to me, this looked like an attempt for a pure "fix".

If you tell filter-branch to filter a branch A and a tag T, as the command
is advertised to rewrite positive refs that were given from the command
line, isn't it natural to expect that the command would attempt its best
effort to rewrite such a tag object?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ta ..., Johannes Schindelin, (Thu Mar 20, 10:14 am)
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ta ..., Junio C Hamano, (Sun Mar 23, 10:49 pm)
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ta ..., Johannes Schindelin, (Mon Mar 24, 3:53 am)
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ta ..., Johannes Schindelin, (Mon Mar 24, 8:10 am)
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ta ..., Johannes Schindelin, (Mon Mar 24, 9:46 am)
Re: [PATCH 2/2] filter-branch.sh: support nearly proper ta ..., Johannes Schindelin, (Mon Mar 24, 10:14 am)
filter-branch --all?, Eyvind Bernhardsen, (Mon Mar 24, 2:22 pm)
Re: filter-branch --all?, Brandon Casey, (Mon Mar 24, 2:33 pm)
Re: filter-branch --all?, Eyvind Bernhardsen, (Mon Mar 24, 2:44 pm)