[PATCH] Simplify MSGFMT setting in Makefile

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Tuesday, March 11, 2008 - 10:29 pm

To prepare msg files for Tcl scripts, the command that is set to MSGFMT
make variable needs to be able to grok "--tcl -l <lang> -d <here>" options
correctly.  This patch simplifies the tests done in git-gui's Makefile to
directly test this condition.  If the test run does not exit properly with
zero status (either because you do not have "msgfmt" itself, or your
"msgfmt" is too old to grok --tcl option --- the reason does not matter),
have it fall back to po/po2msg.sh

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

 * I am planning to close 'master' for -rc1 by the end of this week, so
   please plan to tell me to pull if you have accumulated changes,
   thanks.

 Makefile |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index 4e32174..95e99f2 100644
--- a/Makefile
+++ b/Makefile
@@ -221,14 +221,9 @@ ifdef NO_MSGFMT
 	MSGFMT ?= $(TCL_PATH) po/po2msg.sh
 else
 	MSGFMT ?= msgfmt
-	ifeq ($(shell $(MSGFMT) >/dev/null 2>&1 || echo $$?),127)
+	ifneq ($(shell $(MSGFMT) --tcl -l C -d . /dev/null 2>/dev/null; echo $?),0)
 		MSGFMT := $(TCL_PATH) po/po2msg.sh
 	endif
-	ifeq (msgfmt,$(MSGFMT))
-	ifeq ($(shell $(MSGFMT) --tcl -l C -d . /dev/null 2>/dev/null || echo $?),1)
-		MSGFMT := $(TCL_PATH) po/po2msg.sh
-	endif
-	endif
 endif
 
 msgsdir     = $(gg_libdir)/msgs
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
msgmft segfaulting on tiger, Martin Langhoff, (Thu Feb 21, 4:53 pm)
Re: msgmft segfaulting on tiger, Martin Langhoff, (Thu Feb 21, 4:59 pm)
Re: msgmft segfaulting on tiger, Shawn O. Pearce, (Thu Feb 21, 11:58 pm)
Re: msgmft segfaulting on tiger, Martin Langhoff, (Fri Feb 22, 10:57 am)
Re: msgmft segfaulting on tiger, Gabriel Saldaña, (Wed Feb 27, 11:18 am)
Re: msgmft segfaulting on tiger, Johannes Schindelin, (Wed Feb 27, 11:26 am)
Re: msgmft segfaulting on tiger, Gabriel Saldaña, (Wed Feb 27, 11:42 am)
Re: msgmft segfaulting on tiger, Johannes Schindelin, (Wed Feb 27, 3:04 pm)
Re: msgmft segfaulting on tiger, Junio C Hamano, (Wed Feb 27, 3:14 pm)
Re: msgmft segfaulting on tiger, Shawn O. Pearce, (Wed Feb 27, 5:32 pm)
Re: msgmft segfaulting on tiger, Gabriel Saldaña, (Thu Feb 28, 11:40 am)
msgmft segfaulting on ubuntu gutsy (clean), Gabriel Saldaña, (Tue Mar 4, 12:02 am)
Re: msgmft segfaulting on ubuntu gutsy (clean), Shawn O. Pearce, (Tue Mar 4, 12:07 am)
Re: msgmft segfaulting on tiger, Shawn O. Pearce, (Wed Mar 5, 12:19 am)
Re: msgmft segfaulting on tiger, Junio C Hamano, (Thu Mar 6, 1:40 am)
[PATCH] Simplify MSGFMT setting in Makefile, Junio C Hamano, (Tue Mar 11, 10:29 pm)
Re: [PATCH] Simplify MSGFMT setting in Makefile, Shawn O. Pearce, (Tue Mar 11, 10:51 pm)
Re: [PATCH] Simplify MSGFMT setting in Makefile, Charles Bailey, (Wed Mar 12, 3:19 am)
Re: [PATCH] Simplify MSGFMT setting in Makefile, Paul Mackerras, (Thu Mar 13, 9:44 pm)
Re: [PATCH] Simplify MSGFMT setting in Makefile, Junio C Hamano, (Thu Mar 13, 9:50 pm)
Re: [PATCH] Simplify MSGFMT setting in Makefile, Andreas Ericsson, (Fri Mar 14, 6:07 am)