git mailing list

FromSubjectsort iconDate
Junio C Hamano
Re: [PATCH 2/3] fsck_commit: remove duplicate tests
As I believe in belt-and-suspenders when it comes to validation, I am somewhat uneasy with this change. If it ever turns out that we would need to make parse_commit_buffer() more lenient during the normal operation, some of this would need to be reverted (for example, you may not need to have a valid "tree" to salvage the log messages from a corrupt history by running "git log"), and forgetting to do so will result in fsck that does not validate enough. The validation done by parse_commit_buffe...
Feb 3, 7:58 pm 2008
Jari Aalto
Re: [PATCH] Documentation/git-reset.txt: Use HEAD~N syntax e...
* Sun 2008-02-03 Dmitry Potapov <dpotapov@gmail.com> Only if you're grown with git. Everywhere else the concept of HEAD or TIP is more natural, thus progression: HEAD, HEAD~1, HEAD~2 Jari -- Welcome to FOSS revolution: we fix and modify until it shines -
Feb 3, 7:48 pm 2008
Jari Aalto
[PATCH] git-rebase.sh: Update USAGE string (No. 1)
Present the options in -s|--long (short, long) order. Mention merge and new whitespace option. ed-off-by: Jari Aalto <jari.aalto AT cante.net> --- *********************************************************************** Reworked patch (No. 1) [Jakub Narebski] > or break synopsis into lines 80-column lines max. *********************************************************************** git-rebase.sh | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/git...
Feb 3, 7:33 pm 2008
Jakub Narebski
Re: [PATCH] git-rebase.sh: Update USAGE string (No. 1)
What's with the "(No. 1)" here? If you want to add some comment that should *not* be part of commit message, put it in brackets beside PATCH, for example "[PATCH/RFC]", "[PATCH (resend)]", I guess that it is copy'n'paste error, and it should be I would say "[--whitespace=<option>]" or "[--whitespace=<action>]" instead of introducing yet not agreed upon notation (this has the advantage of shortening synopisis, which should be short IMHO). Besides here the mutually exclusive option...
Feb 3, 7:52 pm 2008
Johannes Schindelin
Re: [PATCH] git-rebase.sh: Update USAGE string (No. 1)
Hi, what's this "(No. 1)" business? /me grins Ciao, Dscho -
Feb 3, 7:41 pm 2008
Junio C Hamano
Re: [PATCH 06/11] Better error handling in compress_all()
This is meant to be an improvement for [01/11] and I think should be done from the beginning by squashing into it. Haven't looked at the decompression side yet. Help in reviewing this series from others are appreciated. -
Feb 3, 6:54 pm 2008
Junio C Hamano
Re: [PATCH 02/11] Use new compress helpers in git files
This used to leave *compressed_size untouched upon deflate failure but now it sets it to zero. Is this change in behaviour safe? -
Feb 3, 6:54 pm 2008
Junio C Hamano
Re: [PATCH 04/11] Use new compress helpers in http-push.c
Although the original does not bother to, the return value from compress_next() should be checked in later rounds. -
Feb 3, 6:53 pm 2008
Junio C Hamano
Re: [PATCH 03/11] Use new compress helpers in fast-import
I'll let Shawn comment on this. The realloc() does not seem to be using the contents in the buffer from the previous round, so I suspect that a free() followed by an independent alloc() would be an improvement when the later call uses much larger buffer than the previous one, but would be a waste if the later one needs smaller buffer. -
Feb 3, 6:53 pm 2008
Junio C Hamano
Re: [PATCH 01/11] Introduce stream compress helpers
(Cosmetic) Your log message lines are wrapped a bit too short, while some (Naming) This returns Z_OK unconditionally and most callers do not even bother checking the return value. Shouldn't this be of type void? Especially the use of this in if() conditional, after [06/11] Eventually, this should check errors from deflateEnd() and propagate that to the caller. -
Feb 3, 6:53 pm 2008
Junio C Hamano
Re: [PATCH v6] safecrlf: Add mechanism to warn about irrever...
I agree that warning is needed if the setting says "warn". Of course, it could become part of an irreversible action if you did this: $ git commit ;# or whatever. Now there is no local mods $ git apply <patch-1 $ edit ;# to fix things up $ git apply <patch-2 and if you get the warning from patch-2. But the safecrlf warning is primarily about a misdetection of binaryness, so I do not think this sequence is not something we would even want to worry about. -
Feb 3, 6:53 pm 2008
Martin Koegler
[PATCH 1/3] git-fsck: report missing author/commit line in a...
A zero commit date could be caused by: * a missing author line * a missing commiter line * a malformed email address in the commiter line * a malformed commit date Simply reporting it as zero commit date is missleading. Additionally, it upgrades the message to an error (instead of an printf). Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at> --- builtin-fsck.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/builtin-fsck.c b/builtin-fsck.c inde...
Feb 3, 5:22 pm 2008
Martin Koegler
[PATCH 2/3] fsck_commit: remove duplicate tests
All tests on the commit buffer in fsck_cmd are ready done by parse_commit_buffer. This patch rips out all redundant tests. It still leaves the check for author, as this is can be used as starting point for validation the author/committer information. Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at> --- builtin-fsck.c | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/builtin-fsck.c b/builtin-fsck.c index cc7524b..ba785ec 100644 --- a/builtin...
Feb 3, 5:22 pm 2008
Martin Koegler
[PATCH 3/3] parse_object_buffer: don't ignore errors from th...
In the case of an malformed object, the object specific parsing functions would return an error, which is currently ignored. The object can be partial initialized in this case. This patch make parse_object_buffer propagate such errors. Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at> --- object.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/object.c b/object.c index 5a5ebe2..4e7f27a 100644 --- a/object.c +++ b/object.c @@ -140,7 +140,8...
Feb 3, 5:22 pm 2008
Jari Aalto
[PATCH] git-rebase.sh: Update USAGE string
Present the options in -s|--long (short, long) order. Mention merge and new whitespace option. Signed-off-by: Jari Aalto <jari.aalto AT cante.net> --- git-rebase.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-rebase.sh b/git-rebase.sh index bdcea0e..9c8cf90 100755 --- a/git-rebase.sh +++ b/git-rebase.sh @@ -3,7 +3,7 @@ # Copyright (c) 2005 Junio C Hamano. # -USAGE='[--interactive | -i] [-v] [--onto <newbase>] <upstream> [<branch&gt...
Feb 3, 4:19 pm 2008
Jakub Narebski
Re: [PATCH] git-rebase.sh: Update USAGE string
This is a good change (but might not make sense without the following ...and this is not; usage string is now too long. Please either use placeholder ([<whitespace>]), or enumerate only short version of commands ([-i] [-v] [-m]) in synopsis, -- Jakub Narebski Poland ShadeHawk on #git -
Feb 3, 5:14 pm 2008
Francis Moreau
What about git cp ?
Hello, I'm looking for a something which could be done by a git-cp command. I'd like to copy a file with its history to a new file but want to keep the old one, Thanks -- Francis -
Feb 3, 2:23 pm 2008
Remi Vanicat
Re: What about git cp ?
Git don't attach history to a file, but to a content. Just do a: cp foo bar git add bar git commit -m "copying foo to bar" And it will be done, and when needed, git will be able to know that this was a copy. -- Rémi Vanicat -
Feb 3, 2:55 pm 2008
Matthieu Moy
Re: What about git cp ?
Git doesn't _record_ copies and renames, but detects them after-the-fact (either by default, or explicitly like "git blame -C" or so). So, just "cp + git add" and you're done. That's what a "git cp" command would do if it existed. -- Matthieu -
Feb 3, 2:46 pm 2008
Jakub Narebski
Re: What about git cp ?
You can just put git-cp shell script doing this in PATH (or GIT_EXEC_PATH if they are different) for "git cp" to just work. Or you can write builtin-cp.c, following builtin-mv.c -- Jakub Narebski Poland ShadeHawk on #git -
Feb 3, 3:07 pm 2008
Mark Levedahl
[PATCH 0 of 7] [resend] - Improve handling remotes, origin, ...
(sigh, someday I'll get this command line email addressing stuff sorted out - resending as I mangled Junio's email) This patch series was inspired by several issues dealing with multiple remotes and submodules. The tests added as the last patch demonstrate the specific use pattern to be supported, and that does not work currently. 1 - user A creates a project on server "frotz" with a submodule. 2 - user B clones the project, forks it, adds a submodule, and publishes the fork on server "fork" ...
Feb 3, 1:31 pm 2008
Johannes Schindelin
Re: [PATCH 0 of 7] [resend] - Improve handling remotes, orig...
Hi, It seems that everytime you send a new patch series, it gets longer/more complicated/affects more and more of git. As far as I understood, your problem was _purely_ a submodule issue. I find it utterly unnerving that you keep trying to sneak in _anything_ unrelated to submodules. Such as the origin issue. I am getting pretty angry that you keep trying to complicating things in that area! origin is origin is origin. It is the default remote. It is what you can change to fetch ...
Feb 3, 6:43 pm 2008
Mark Levedahl
[PATCH 1/7] Teach remote machinery about core.origin config ...
This introduces a new configuration variable, core.origin, that defines the name of the default remote to be used. Traditionally, this is "origin", and could be overridden for a given branch. This change introduces a way to redefine the default as desired and have that honored regardless of the currently checked out head (e.g., core.origin is used when on a detached head or any other non-tracking branch). Signed-off-by: Mark Levedahl <mlevedahl@gmail.com> --- Documentation/config.txt | 6...
Feb 3, 1:31 pm 2008
Mark Levedahl
[PATCH 2/7] git-remote - Unset core.origin when deleting the...
Signed-off-by: Mark Levedahl <mlevedahl@gmail.com> --- git-remote.perl | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/git-remote.perl b/git-remote.perl index d13e4c1..75d2371 100755 --- a/git-remote.perl +++ b/git-remote.perl @@ -328,6 +328,11 @@ sub rm_remote { $git->command('config', '--remove-section', "remote.$name"); + my $defremote = $git->config("core.origin"); + if (defined $defremote && $defremote eq $name) { + $git->...
Feb 3, 1:31 pm 2008
Mark Levedahl
[PATCH 3/7] git-clone - Set remotes.origin config variable
This records the users choice of default remote name (by default "origin") as given by the -o option. Signed-off-by: Mark Levedahl <mlevedahl@gmail.com> --- Documentation/git-clone.txt | 3 ++- git-clone.sh | 1 + 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt index 2341881..f15aecd 100644 --- a/Documentation/git-clone.txt +++ b/Documentation/git-clone.txt @@ -103,7 +103,8 @@ OPTIONS --origi...
Feb 3, 1:31 pm 2008
Mark Levedahl
[PATCH 4/7] git-submodule - Possibly inherit parent's defaul...
For submodules defined relative to their parent, it is likely that the parent's defined default remote is correct for the child as well. This allows use of remote names other than "origin", important as managed submodules are typically checked out on a detached head and therefore submodule-update invokes git-fetch using the default remote. Without this change, submodules effectively had to have a default remote of "origin." Signed-off-by: Mark Levedahl <mlevedahl@gmail.com> --- Documentatio...
Feb 3, 1:31 pm 2008
Mark Levedahl
[PATCH 5/7] Teach git-submodule to use top-level remote when...
Modules that are defined using relative urls to the master project are assumed to be completely owned by the project. When running "submodule update" from the top level, it is reasonable that the entire project exists at the remote given by top-level branch.<name>.remote. Using the remote machinery, this remote can be different for each branch and can be different than the current defaults in each submodule. This teaches submodule to: 1) Possibly define the current master's remote in each s...
Feb 3, 1:31 pm 2008
Mark Levedahl
[PATCH 6/7] git-submodule - Allow adding a submodule in-place
When working in top-level directory, it is natural to create a new submodule in a subdirectory, then add that submodule to top-level in place. This allows "git submodule add <intended url> subdir" to add the existing subdir to the current project. The presumption is the user will later push / clone the subdir to the <intended url> so that future submodule init / updates will work. Absent this patch, "git submodule add" insists upon cloning the subdir from the remote, which is fine for a...
Feb 3, 1:31 pm 2008
Mark Levedahl
[PATCH 7/7] Add t/t7401 - test submodule interaction with re...
This adds a sequence of tests to assure that the following two sequences work: git clone -o frotz <someurl> foo cd foo git submodule init git submodule update This should result in the master and subproject having "frotz" as the name of the default remote (and origin undefined). Then, in the same working directory git remote add fork <some url> git fetch fork git checkout --track -b fork fork/<somebranch> git submodule init git submodule update will retrive n...
Feb 3, 1:31 pm 2008
Mark Levedahl
[PATCH 0 of 7] - Improve handling remotes, origin, and submo...
This patch series was inspired by several issues dealing with multiple remotes and submodules. The tests added as the last patch demonstrate the specific use pattern to be supported, and that does not work currently. 1 - user A creates a project on server "frotz" with a submodule. 2 - user B clones the project, forks it, adds a submodule, and publishes the fork on server "fork" user A adds the fork to his working tree, via git remote add + git fetch. The desire is that: 1 - git submodule init +...
Feb 3, 1:20 pm 2008
Mark Levedahl
[PATCH 1/7] Teach remote machinery about core.origin config ...
This introduces a new configuration variable, core.origin, that defines the name of the default remote to be used. Traditionally, this is "origin", and could be overridden for a given branch. This change introduces a way to redefine the default as desired and have that honored regardless of the currently checked out head (e.g., core.origin is used when on a detached head or any other non-tracking branch). Signed-off-by: Mark Levedahl <mlevedahl@gmail.com> --- Documentation/config.txt | 6...
Feb 3, 1:20 pm 2008
Mark Levedahl
[PATCH 2/7] git-remote - Unset core.origin when deleting the...
Signed-off-by: Mark Levedahl <mlevedahl@gmail.com> --- git-remote.perl | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/git-remote.perl b/git-remote.perl index d13e4c1..75d2371 100755 --- a/git-remote.perl +++ b/git-remote.perl @@ -328,6 +328,11 @@ sub rm_remote { $git->command('config', '--remove-section', "remote.$name"); + my $defremote = $git->config("core.origin"); + if (defined $defremote && $defremote eq $name) { + $git->...
Feb 3, 1:20 pm 2008
Mark Levedahl
[PATCH 3/7] git-clone - Set remotes.origin config variable
This records the users choice of default remote name (by default "origin") as given by the -o option. Signed-off-by: Mark Levedahl <mlevedahl@gmail.com> --- Documentation/git-clone.txt | 3 ++- git-clone.sh | 1 + 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt index 2341881..f15aecd 100644 --- a/Documentation/git-clone.txt +++ b/Documentation/git-clone.txt @@ -103,7 +103,8 @@ OPTIONS --origi...
Feb 3, 1:20 pm 2008
Mark Levedahl
[PATCH 4/7] git-submodule - Possibly inherit parent's defaul...
For submodules defined relative to their parent, it is likely that the parent's defined default remote is correct for the child as well. This allows use of remote names other than "origin", important as managed submodules are typically checked out on a detached head and therefore submodule-update invokes git-fetch using the default remote. Without this change, submodules effectively had to have a default remote of "origin." Signed-off-by: Mark Levedahl <mlevedahl@gmail.com> --- Documentatio...
Feb 3, 1:20 pm 2008
Mark Levedahl
[PATCH 5/7] Teach git-submodule to use top-level remote when...
Modules that are defined using relative urls to the master project are assumed to be completely owned by the project. When running "submodule update" from the top level, it is reasonable that the entire project exists at the remote given by top-level branch.<name>.remote. Using the remote machinery, this remote can be different for each branch and can be different than the current defaults in each submodule. This teaches submodule to: 1) Possibly define the current master's remote in each s...
Feb 3, 1:20 pm 2008
Mark Levedahl
[PATCH 6/7] git-submodule - Allow adding a submodule in-place
When working in top-level directory, it is natural to create a new submodule in a subdirectory, then add that submodule to top-level in place. This allows "git submodule add <intended url> subdir" to add the existing subdir to the current project. The presumption is the user will later push / clone the subdir to the <intended url> so that future submodule init / updates will work. Absent this patch, "git submodule add" insists upon cloning the subdir from the remote, which is fine for a...
Feb 3, 1:20 pm 2008
Mark Levedahl
[PATCH 7/7] Add t/t7401 - test submodule interaction with re...
This adds a sequence of tests to assure that the following two sequences work: git clone -o frotz <someurl> foo cd foo git submodule init git submodule update This should result in the master and subproject having "frotz" as the name of the default remote (and origin undefined). Then, in the same working directory git remote add fork <some url> git fetch fork git checkout --track -b fork fork/<somebranch> git submodule init git submodule update will retrive n...
Feb 3, 1:20 pm 2008
Jakub Narebski
Re: [ANNOUNCE] GIT 1.5.4 (git popularity)
And Ohloh stack count gives yet another idea. Both Debian popularity counter and number of Ohloh stacks are mentioned in GitSurvey2007[*1*], around question about used SCMs. Google Trends above not yet, and perhaps will not because it is even more skewed than mentioned results, perhaps even more than result of Git _User's_ Survey 2007. [*1*] http://git.or.cz/gitwiki/GitSurvey2007#head-4ed59e7615e2dc4f4baa8fa0beccde52c93789f8 -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Feb 3, 11:34 am 2008
Jean-Luc Herren
git cvsimport fails noisily if cvs has no server support
Hello list! cvs (1.12.12) can be compiled with --disable-server to omit support for cvs servers. Although this is not ./configure's default, it was the default on my distro (gentoo). git-cvsimport fails loudly as pasted below (note that this command is part of the test t9600-cvsimport.sh). Nicer behavior would of course be to detect the situation and inform the user that server support is missing (and to skip the test). jlh $ git-cvsimport -a -z 0 -C module-git module Unknown command: `se...
Feb 3, 11:28 am 2008
Robin Rosenberg
Re: git cvsimport fails noisily if cvs has no server support
I'm guessing now, but try -Z '--cvs-direct'. -- robin -
Feb 3, 2:08 pm 2008
Guilhem Bonnefille
Tips for different workflows/use cases
Hi, <my_life> Up to recently, I used Git as a frontend to many SVN repo. The workflow is simple: a central SVN and a single "client" desktop. Now, I started to use Git at office. So I "discover" new problems and my actual experience is not enougth. </my_life> Actually, I discovered two(/three) use cases for which I'm looking the best (recommended) workflows. My idea is to identify the best practices to avoid (as possible) complex situations. 1- The same developer uses two repo on t...
Feb 3, 11:08 am 2008
Dmitry Potapov
Re: Tips for different workflows/use cases
If both computers are always online and you can connect at will then "pull" is the simplest solution. The problem with "push" is that pushing to the local branch of another that has the working directory attached to it will give you not exactly what you want. The default refspec for "push" is only suitable for pushing into a "bare" repository from where anyone can pull. However, if you do not want to have a separate bare repository for synchronization, you can avoid by providing suitable refspec fo...
Feb 3, 5:49 pm 2008
Alan Smith
MKCOL fails, 403 error
Hello everyone, I am assisting the admin of dsource.org to get git working on their server. I have had problems but those were resolved by my upgrading to the most recent version of git (who'd have thought Ubuntu would not have a version newer than 1.5.2.5?) Let me give you the terminal output, the best explanation I have of my problem: $ git push upload --force --all -v Pushing to http://git.dsource.org/projects/pineapple/ Getting pack list Fetching remote heads... refs/ refs/heads/ ...
Feb 3, 9:39 am 2008
Mike Hommey
Re: MKCOL fails, 403 error
Do you have access to the apache error_log ? Mike -
Feb 3, 10:31 am 2008
Alan Smith
Re: MKCOL fails, 403 error
Mike, I do have access to the log at /var/logs/apache2/error_log. What should I be looking for? Thanks, Alan -- My blog: lifelover.blogetery.com My old blog: cocoalatte.info // Things I've said ------------------------- "Maturity resides in the mind." "Silence is the Universe's greatest gift." "When the World realizes that personal beliefs are not something to argue or fight over, it shall evolve." -
Feb 3, 11:32 am 2008
Mike Hommey
Re: MKCOL fails, 403 error
For whatever error message shows up at the time corresponding to when the MKCOL request was done. You can grep MKCOL in the access_log to find out. That might help you understand why the MKCOL fails. Mike -
Feb 3, 11:35 am 2008
Jakub Narebski
[PATCH/RFC] gitweb: Make feed entries point to commitdiff view
From: Florian La Roche <laroche@redhat.com> Change feeds entries (feeds items) from pointing (linking) to 'commit' view to pointing to 'commitdiff' view. First, feed entries have whatchanged-like list of files which were modified in a commit, so 'commitdiff' view more naturally reflects feed entry (in more naturally alternate / extended version of a feed item). Second, this way the patches are shown directly and code review is done more easily via watching feeds. [jn: Rewritten commit me...
Feb 3, 7:38 am 2008
Junio C Hamano
What's cooking in git.git (topics)
Here are the topics that have been kept out of 'master'. Commits prefixed with '-' are only in 'pu' while commits prefixed with '+' are in 'next'. The topics list the commits in reverse chronological order. I'd like to get post-release fixes to 'maint' first, tag 1.5.4.1 and merge that to 'master', and then start merging things from 'next' to 'master'. My wish is to have small but short release cycle for 1.5.5 and leave bigger ones cooking for 1.6.0. ----------------------------------------...
Feb 3, 6:59 am 2008
Johannes Schindelin
Re: What's cooking in git.git (topics)
Hi, You said that the test suit fails on one of your machines, and I looked at it with valgrind. There was an odd problem accessing free()d memory, and I decided to come back to it after 1.5.4. Personally, I do not think the current form merits any change. Ciao, Dscho -
Feb 3, 5:43 pm 2008
Jakub Narebski
Re: [PATCH] Unify the name of the second option in the text
Err... that is incorrect without further surgery. <refspec> is either <ref>:<ref>, <ref> or some other exotic case; in the form <ref>:<ref> it can include globbing. The fragment above talks about situation where <refspec> is <ref>, and does not contain colon. -- Jakub Narebski Poland ShadeHawk on #git -
Feb 3, 8:04 am 2008
previous daytodaynext day
February 2, 2008February 3, 2008February 4, 2008