Re: [PATCH] compat: Add simplified merge sort implementation from glibc

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Johannes Schindelin <Johannes.Schindelin@...>
Cc: Brian Downing <bdowning@...>, Steffen Prohaska <prohaska@...>, <git@...>, <msysgit@...>
Date: Sunday, February 3, 2008 - 2:22 am

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:


I do not think we want to spend arguing over the last few
percent to get anything ultra-fast.  The aim for compat/ is to
have a replacement for unusable platform-supplied stuff.

The patch looked fine, thanks.

If I may add a bikeshed comment, I probably would have modelled
the make variable, not after ssl-with-crypto and libiconv, but
after {arm,mozilla,ppc}-sha1, if I were naming it.  This is not
like an absolute must-to-have: "on this platform, libc is not
enough and we NEED to explicitly ask for -liconv".  It is more
like a choose-to-use: "we could use openssl sha1 implementation,
but I choose to use Mozilla one".
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] compat: Add simplified merge sort implementation..., Johannes Schindelin, (Sat Feb 2, 10:37 pm)
Re: [PATCH] compat: Add simplified merge sort implementation..., Junio C Hamano, (Sun Feb 3, 2:22 am)
Re: [PATCH] compat: Add simplified merge sort implementation..., Johannes Schindelin, (Sun Feb 3, 5:09 pm)