Hi,

On Wed, 27 Feb 2008, Johannes Sixt wrote:

quoted text
> In upload-pack we must explicitly close the output channel of rev-list. 
> (On Unix, the channel is closed automatically because process that runs 
> rev-list terminates.)

When I read this patch, my impression was that it litters the source code 
with #ifdef's.  IMO this makes the code less readable, and as a 
consequence easer to fsck up.

Unfortunately, I have no idea how to help that, other than implementing 
compat/thread.[ch], abstracting the thread functions, and introducing a 
NO_FORK Makefile variable and preprocessor constant.

Hmpf.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html